finapps 5.0.13 → 5.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e76401d8f5d3d2c4850fb765e007d70808dcb8a7886bb238f6d7ef2f7cb1be24
-  data.tar.gz: e0030ef2a516c409b9f2afa21f1971275a6fc25a45dd724bb3c81e1b3f6b6d81
+  metadata.gz: c88358c623ea2ab28b48c290cea3245bee6896aa105ef411e881ca01c80b31c9
+  data.tar.gz: c40ecae6c8ba2a5472b2b80325cf4ebf912a06cdedb6d75e05fe77a3994f272d
 SHA512:
-  metadata.gz: 82635ddd557d64752c0778067b80405001bd1a11b123fc7805221422cb51f5e0587dd1dad266882e6d108d973406ab9493da23cdc9064ebc66a2eb22c0934d05
-  data.tar.gz: 81ef62a5c19146479a42afaac2c51ca6f6f2aabef48b81c77eecd44421568d8df7575f969f1fc58c424a8ae9b6323d26c7a761d3325f4db05fc00582c9640a4a
+  metadata.gz: e2ac883b52219e1fa3dc5acda80bfa37268e4c04b61bc6d604320357ed46b8b35665931a85769eb7b6d4ce7473db7957eff19d58622564106c28ba2c9fab5acf
+  data.tar.gz: 1c85b4ae3ea37cfe915efa193248c094c385efbe099f860efd639cc8760b299aa541665e7c7a8d30892d63ea51ed89600e36dd2b2f0ad21a63105f9729ec97ed

data/lib/finapps/rest/orders.rb

@@ -33,25 +33,18 @@ module FinApps
         super build_query_path(end_point, params)
       end
 
-      def update(id, params, path = nil)
-        return super nil, path if path
-
+      def update(id)
         not_blank(id, :id)
-        not_blank(params, :params)
-        # Params array need matching Institution ids & Account ids
-        # Validations to check each Institution id has at least one account id
-        # Validations to check at least 1 Institution id or 1 account "params.length >= 1"
-
         path = "#{end_point}/#{ERB::Util.url_encode(id)}"
 
-        super params, path
+        super nil, path
       end
 
       def destroy(id)
         not_blank(id, :id)
-
         path = "#{end_point}/#{ERB::Util.url_encode(id)}/cancel"
-        update nil, nil, path
+
+        send_request path, :put
       end
 
       private

data/lib/finapps/rest/plaid/plaid_account_permissions.rb

@@ -4,11 +4,11 @@ module FinApps
   module REST
     class PlaidAccountPermissions < PlaidResources # :nodoc:
       def create(id)
-        send_request 'p/accounts/permissions', :put, ids: [id]
+        send_request 'p/accounts/permissions', :put, [id]
       end
 
       def destroy(id)
-        send_request 'p/accounts/permissions', :delete, ids: [id]
+        send_request 'p/accounts/permissions', :delete, [id]
       end
     end
   end

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '5.0.13'
+  VERSION = '5.0.14'
 end

data/spec/rest/orders_spec.rb

@@ -151,21 +151,14 @@ RSpec.describe FinApps::REST::Orders do
     subject(:orders) { FinApps::REST::Orders.new(client) }
 
     context 'when missing id' do
-      let(:update) { subject.update(nil, :params) }
+      let(:update) { subject.update(nil) }
       it('returns missing argument error') do
         expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
       end
     end
 
-    context 'when missing params' do
-      let(:update) { subject.update(:id, nil) }
-      it('returns missing argument error') do
-        expect { update }.to raise_error(FinAppsCore::MissingArgumentsError)
-      end
-    end
-
-    context 'when valid id and params are provided' do
-      let(:update) { subject.update('valid_id', accounts: 'valid_account') } # how to stub params
+    context 'when valid id is provided' do
+      let(:update) { subject.update('valid_id') } # how to stub params
       let(:results) { update[RESULTS] }
       let(:error_messages) { update[ERROR_MESSAGES] }
 
@@ -175,7 +168,7 @@ RSpec.describe FinApps::REST::Orders do
     end
 
     context 'when invalid id is provided' do
-      let(:update) { subject.update('invalid_id', :params) }
+      let(:update) { subject.update('invalid_id') }
       let(:results) { update[RESULTS] }
       let(:error_messages) { update[ERROR_MESSAGES] }
 
@@ -185,18 +178,6 @@ RSpec.describe FinApps::REST::Orders do
         expect(error_messages.first.downcase).to eq('resource not found')
       end
     end
-
-    context 'when invalid params are provided' do
-      let(:update) { subject.update('valid_id', accounts: 'invalid_account') }
-      let(:results) { update[RESULTS] }
-      let(:error_messages) { update[ERROR_MESSAGES] }
-
-      it { expect { update }.not_to raise_error }
-      it('results is nil') { expect(results).to be_nil }
-      it('error messages array is populated') do
-        expect(error_messages.first.downcase).to eq('invalid request body')
-      end
-    end
   end
 
   describe '#destroy' do

data/spec/support/fake_api.rb

@@ -59,7 +59,7 @@ class FakeApi < Sinatra::Base
   put("/#{version}/p/accounts/permissions") do
     request.body.rewind
     request_payload = JSON.parse request.body.read
-    if request_payload.respond_to?(:key?) && request_payload.key?('ids')
+    if request_payload.is_a? Array
       status 204
     else
       json_response 400, 'invalid_request_body.json'
@@ -68,7 +68,7 @@ class FakeApi < Sinatra::Base
   delete("/#{version}/p/accounts/permissions") do
     request.body.rewind
     request_payload = JSON.parse request.body.read
-    if request_payload.respond_to?(:key?) && request_payload.key?('ids')
+    if request_payload.is_a? Array
       status 204
     else
       json_response 400, 'invalid_request_body.json'
@@ -142,15 +142,7 @@ class FakeApi < Sinatra::Base
   put("/#{version}/orders/invalid_id") do
     json_response 404, 'resource_not_found.json'
   end
-  put("/#{version}/orders/valid_id") do
-    request.body.rewind
-    request_payload = JSON.parse request.body.read
-    if request_payload['accounts'] == 'valid_account'
-      status 204
-    else
-      json_response 400, 'invalid_request_body.json'
-    end
-  end
+  put("/#{version}/orders/valid_id") { status 204 }
   post("/#{version}/orders") do
     request.body.rewind
     request_payload = JSON.parse request.body.read

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 5.0.13
+  version: 5.0.14
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-28 00:00:00.000000000 Z
+date: 2019-09-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -442,38 +442,38 @@ signing_key:
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/rest/portfolios_consumers_spec.rb
-- spec/rest/consumers_portfolios_spec.rb
-- spec/rest/operators_password_resets_spec.rb
-- spec/rest/portfolios_available_consumers_spec.rb
-- spec/rest/products_spec.rb
-- spec/rest/statements_spec.rb
+- spec/rest/portfolios_alerts_spec.rb
 - spec/rest/alert_definitions_spec.rb
-- spec/rest/version_spec.rb
-- spec/rest/consumers_spec.rb
-- spec/rest/orders_spec.rb
-- spec/rest/order_tokens_spec.rb
+- spec/rest/portfolios_consumers_spec.rb
+- spec/rest/plaid/plaid_accounts_spec.rb
+- spec/rest/plaid/plaid_webhooks_spec.rb
+- spec/rest/plaid/plaid_account_permissions_spec.rb
+- spec/rest/plaid/plaid_consumer_institutions_spec.rb
+- spec/rest/order_assignments_spec.rb
+- spec/rest/tenant_settings_spec.rb
 - spec/rest/tenant_app_settings_spec.rb
-- spec/rest/operators_spec.rb
 - spec/rest/client_spec.rb
-- spec/rest/tenant_settings_spec.rb
-- spec/rest/api_request.rb
-- spec/rest/alert_occurrences_spec.rb
+- spec/rest/portfolio_reports_spec.rb
+- spec/rest/version_spec.rb
 - spec/rest/password_resets_spec.rb
+- spec/rest/operators_spec.rb
+- spec/rest/order_statuses_spec.rb
+- spec/rest/alert_occurrences_spec.rb
 - spec/rest/order_reports_spec.rb
+- spec/rest/portfolios_available_consumers_spec.rb
+- spec/rest/consumers_spec.rb
+- spec/rest/sessions_spec.rb
+- spec/rest/orders_spec.rb
+- spec/rest/operators_password_resets_spec.rb
 - spec/rest/portfolios_spec.rb
-- spec/rest/order_statuses_spec.rb
-- spec/rest/plaid/plaid_accounts_spec.rb
-- spec/rest/plaid/plaid_account_permissions_spec.rb
-- spec/rest/plaid/plaid_webhooks_spec.rb
-- spec/rest/plaid/plaid_consumer_institutions_spec.rb
 - spec/rest/order_refreshes_spec.rb
 - spec/rest/order_notifications_spec.rb
-- spec/rest/portfolios_alerts_spec.rb
-- spec/rest/order_assignments_spec.rb
-- spec/rest/sessions_spec.rb
-- spec/rest/portfolio_reports_spec.rb
-- spec/support/fake_api.rb
+- spec/rest/statements_spec.rb
+- spec/rest/api_request.rb
+- spec/rest/order_tokens_spec.rb
+- spec/rest/consumers_portfolios_spec.rb
+- spec/rest/products_spec.rb
 - spec/utils/query_builder_spec.rb
-- spec/spec_helpers/client.rb
+- spec/support/fake_api.rb
 - spec/spec_helper.rb
+- spec/spec_helpers/client.rb