finapps 4.0.5 → 4.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: a05f192b629e85e689d080fac49dc2b6a117a823
-  data.tar.gz: d19ae194b2dbb8d7fd518b1cfec0e71a5bce6088
+SHA256:
+  metadata.gz: e1e6ff1a8379127a67c120835e11aa5d02b4a250341583e6bb31d340b9eb6527
+  data.tar.gz: a0599c41a38248aaa2180a005cc6020666280e1b92137744d3143691fa39c1e9
 SHA512:
-  metadata.gz: 94eeac31a8838ab0c8a43aff2f2f5514dae8684a3f1b18ddde480500205010eb41746fdd8ea0cc7ff30096fcb8f8bfa86a86d9fa1fd9e48cacd7e5de60717b5d
-  data.tar.gz: 431604c2f7dc6ba3b96c004000176dcf959ed1cb4147aacbe8c9d6b9a3c6954deddfd6540a9d814654740b0f4e8666b02ce6a6500b1b32187069f96e0960e061
+  metadata.gz: a728f579cc44d56586cb0fd05e4949c38305791687dd6e9e231021477809cab9f5896f2e67974c82a6460f6d9f66b7a6b5ab5c235980a0a0c8fb4a6c0828ea95
+  data.tar.gz: 6a4721575df2270662974814db05af130ed69038ce6acfcccbd9841b47bbbba787d05b5d15ec603277e3adf81614a8b89939e8e4a7388aa772dcfe52e5443458

data/finapps.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.test_files = Dir['spec/**/*.rb']
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency     'finapps_core',               '~> 4.0',   '>= 4.0.4'
+  spec.add_runtime_dependency     'finapps_core',               '~> 4.0',   '>= 4.0.5'
 
   spec.add_development_dependency 'bundler',                    '~> 1.16',  '>= 1.16.6'
   spec.add_development_dependency 'codeclimate-test-reporter',  '~> 1.0',   '>= 1.0.9'

data/lib/finapps/rest/sessions.rb

@@ -3,15 +3,20 @@
 module FinApps
   module REST
     class Sessions < FinAppsCore::REST::Resources # :nodoc:
+      CONSUMER_LOGIN = 'login'
       LOGOUT = 'logout'
 
       def create(params, path = nil)
         return super nil, path if path == LOGOUT
         raise FinAppsCore::InvalidArgumentsError, 'Invalid argument: params.' unless validates params
 
-        path ||= 'login'
+        path ||= CONSUMER_LOGIN
 
-        super params, path
+        begin
+          super params, path
+        rescue FinAppsCore::ApiUnauthenticatedError
+          return [nil, ["Invalid #{path == CONSUMER_LOGIN ? 'Consumer' : 'Operator'} Identifier or Credentials"]]
+        end
       end
 
       def destroy

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '4.0.5'
+  VERSION = '4.0.7'
 end

data/spec/rest/order_tokens_spec.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require 'spec_helpers/client'
+
 RSpec.describe FinApps::REST::OrderTokens, 'initialized with valid FinApps::Client object' do
   include SpecHelpers::Client
 

data/spec/rest/sessions_spec.rb

@@ -28,7 +28,7 @@ RSpec.describe FinApps::REST::Sessions, 'initialized with valid FinApps::Client
 
       it { expect { create }.not_to raise_error }
       it('results is nil') { expect(results).to be_nil }
-      error_message = 'Invalid User Identifier or Credentials'
+      error_message = 'Invalid Consumer Identifier or Credentials'
       it('error_messages are populated') { expect(error_messages.first).to eq(error_message) }
     end
 

data/spec/spec_helper.rb

@@ -37,7 +37,7 @@ RSpec.configure do |config|
 end
 
 VALID_CREDENTIALS = { identifier: '49fb918d-7e71-44dd-7378-58f19606df2a',
-                      token:      'hohoho=' }.freeze
+                      token: 'hohoho=' }.freeze
 
 RESULTS = 0
 ERROR_MESSAGES = 1

data/spec/support/fake_api.rb

@@ -20,7 +20,7 @@ class FakeApi < Sinatra::Base
     request.body.rewind
     request_payload = JSON.parse request.body.read
     if request_payload['bad_params']
-      json_response 401, 'resource_not_found.json'
+      json_response 404, 'resource_not_found.json'
     else
       status 204
     end
@@ -32,7 +32,7 @@ class FakeApi < Sinatra::Base
     if request_payload['pdf_statement_months']
       status 204
     else
-      json_response 401, 'resource_not_found.json'
+      json_response 404, 'resource_not_found.json'
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 4.0.5
+  version: 4.0.6
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-10-15 00:00:00.000000000 Z
+date: 2018-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -19,7 +19,7 @@ dependencies:
         version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.4
+        version: 4.0.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '4.0'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.4
+        version: 4.0.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -348,36 +348,36 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/rest/operators_password_resets_spec.rb
-- spec/rest/products_spec.rb
-- spec/rest/statements_spec.rb
-- spec/rest/version_spec.rb
-- spec/rest/user_institutions_forms_spec.rb
-- spec/rest/consumers_spec.rb
-- spec/rest/orders_spec.rb
-- spec/rest/order_tokens_spec.rb
-- spec/rest/institutions_forms_spec.rb
+- spec/rest/institutions_spec.rb
+- spec/rest/consumer_institution_refreshes_spec.rb
+- spec/rest/order_assignments_spec.rb
+- spec/rest/tenant_settings_spec.rb
 - spec/rest/tenant_app_settings_spec.rb
-- spec/rest/operators_spec.rb
-- spec/rest/user_institutions_statuses_spec.rb
+- spec/rest/user_institutions_forms_spec.rb
 - spec/rest/client_spec.rb
-- spec/rest/tenant_settings_spec.rb
-- spec/rest/user_institutions_spec.rb
-- spec/rest/consumer_institution_refreshes_spec.rb
+- spec/rest/version_spec.rb
 - spec/rest/password_resets_spec.rb
-- spec/rest/order_reports_spec.rb
-- spec/rest/institutions_spec.rb
+- spec/rest/operators_spec.rb
 - spec/rest/order_statuses_spec.rb
+- spec/rest/order_reports_spec.rb
+- spec/rest/consumers_spec.rb
+- spec/rest/sessions_spec.rb
+- spec/rest/user_institutions_statuses_spec.rb
+- spec/rest/orders_spec.rb
+- spec/rest/operators_password_resets_spec.rb
+- spec/rest/institutions_forms_spec.rb
 - spec/rest/order_refreshes_spec.rb
 - spec/rest/order_notifications_spec.rb
-- spec/rest/order_assignments_spec.rb
-- spec/rest/sessions_spec.rb
-- spec/support/fake_api.rb
+- spec/rest/statements_spec.rb
+- spec/rest/order_tokens_spec.rb
+- spec/rest/user_institutions_spec.rb
+- spec/rest/products_spec.rb
 - spec/utils/query_builder_spec.rb
-- spec/spec_helpers/client.rb
+- spec/support/fake_api.rb
 - spec/spec_helper.rb
+- spec/spec_helpers/client.rb