finapps 4.0.12 → 4.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 7c7e01a0cc069279baa7d0c6c6ad4de1de8e19a77bac754f0d091a9b18721574
-  data.tar.gz: b9b5441629770d07bd85c65360c8a87e8b41df3b13b1a9ca71fce4cf7dd484d9
+SHA1:
+  metadata.gz: 94a52c110da7d02d0eb59601e720692df36794fc
+  data.tar.gz: f32cd05b296b9356cb898d9ee19bf3a41cc6a520
 SHA512:
-  metadata.gz: cb60857be1798390f6b5b76c68fdb9d7cbc4b9dbdf273080794a1abe698c99bf2e6aa9b42f492ff2ebe6e911e28db3e8063574f76fe7d062bde97c1d759aa728
-  data.tar.gz: 928d032593ed3b44e5bacacc5a925d4142dabf3a8bfcc964d8f25f9dc28a14ff7a7f4e7ae925952cbab53279443fa18cc8a616ff789a323982804162d2da2803
+  metadata.gz: 99af45710dc67b478e5596c5840b9d613f2c48de382b5d0344924bad10cb7a5fceed42689a64e09dad87f735635cb97da0840862abd380a51b69edc8359e3581
+  data.tar.gz: b51d3dff34e0f7a226abebd9915fc4dd1902e0886edd2ead8636330efe9a1637ec2ed47f35f22c7d291bf551f9a84411e4d97510c57a2555925444da18e0bc9e

data/lib/finapps/utils/query_builder.rb

@@ -16,7 +16,7 @@ module FinApps
 
       def query_join(root_url, params_array)
         query_string = params_array.compact.join('&')
-        !query_string.empty? ? [root_url, query_string].join('?') : nil
+        [root_url, query_string].reject(&:empty?).join('?')
       end
 
       def build_filter(_params)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '4.0.13'
+  VERSION = '4.0.14'
 end

data/spec/utils/query_builder_spec.rb

@@ -24,10 +24,10 @@ RSpec.describe FinApps::Utils::QueryBuilder do
 
     context 'with no params' do
       let(:params) { {} }
-      it 'returns returns' do
+      it 'returns root' do
         allow(subject).to receive(:build_filter) { {} }
         expect(subject).to receive(:build_filter).with(params)
-        expect(subject.build_query_path(end_point, params)).to be_nil
+        expect(subject.build_query_path(end_point, params)).to eq(end_point)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 4.0.12
+  version: 4.0.14
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-12 00:00:00.000000000 Z
+date: 2019-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: finapps_core
@@ -382,45 +382,45 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/rest/portfolios_consumers_spec.rb
-- spec/rest/consumers_portfolios_spec.rb
-- spec/rest/operators_password_resets_spec.rb
-- spec/rest/portfolios_available_consumers_spec.rb
-- spec/rest/products_spec.rb
-- spec/rest/statements_spec.rb
+- spec/rest/institutions_spec.rb
+- spec/rest/consumer_institution_refreshes_spec.rb
+- spec/rest/portfolios_alerts_spec.rb
 - spec/rest/alert_definitions_spec.rb
-- spec/rest/version_spec.rb
-- spec/rest/user_institutions_forms_spec.rb
-- spec/rest/consumers_spec.rb
-- spec/rest/orders_spec.rb
-- spec/rest/order_tokens_spec.rb
-- spec/rest/institutions_forms_spec.rb
+- spec/rest/portfolios_consumers_spec.rb
+- spec/rest/consumer_institution_refresh_spec.rb
+- spec/rest/order_assignments_spec.rb
+- spec/rest/tenant_settings_spec.rb
 - spec/rest/tenant_app_settings_spec.rb
-- spec/rest/operators_spec.rb
-- spec/rest/user_institutions_statuses_spec.rb
+- spec/rest/user_institutions_forms_spec.rb
 - spec/rest/client_spec.rb
-- spec/rest/tenant_settings_spec.rb
-- spec/rest/user_institutions_spec.rb
-- spec/rest/alert_occurrences_spec.rb
-- spec/rest/consumer_institution_refreshes_spec.rb
+- spec/rest/portfolio_reports_spec.rb
+- spec/rest/version_spec.rb
 - spec/rest/password_resets_spec.rb
+- spec/rest/operators_spec.rb
+- spec/rest/order_statuses_spec.rb
+- spec/rest/alert_occurrences_spec.rb
 - spec/rest/order_reports_spec.rb
+- spec/rest/portfolios_available_consumers_spec.rb
+- spec/rest/consumers_spec.rb
+- spec/rest/sessions_spec.rb
+- spec/rest/user_institutions_statuses_spec.rb
+- spec/rest/orders_spec.rb
+- spec/rest/operators_password_resets_spec.rb
+- spec/rest/institutions_forms_spec.rb
 - spec/rest/portfolios_spec.rb
-- spec/rest/institutions_spec.rb
-- spec/rest/order_statuses_spec.rb
 - spec/rest/order_refreshes_spec.rb
 - spec/rest/order_notifications_spec.rb
-- spec/rest/portfolios_alerts_spec.rb
-- spec/rest/consumer_institution_refresh_spec.rb
-- spec/rest/order_assignments_spec.rb
-- spec/rest/sessions_spec.rb
-- spec/rest/portfolio_reports_spec.rb
-- spec/support/fake_api.rb
+- spec/rest/statements_spec.rb
+- spec/rest/order_tokens_spec.rb
+- spec/rest/user_institutions_spec.rb
+- spec/rest/consumers_portfolios_spec.rb
+- spec/rest/products_spec.rb
 - spec/utils/query_builder_spec.rb
-- spec/spec_helpers/client.rb
+- spec/support/fake_api.rb
 - spec/spec_helper.rb
+- spec/spec_helpers/client.rb