finapps 2.3.6 → 2.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6193020d474b6c3868abc58a633736652f2bface
-  data.tar.gz: 8fec9d538fc88e8706a27f6a6eb009a45e0d2368
+  metadata.gz: fa46e2d5c4400f8118bfa2bfec92330574fd96f0
+  data.tar.gz: f7d566d14145e831f36f9ae7c2d698044902322e
 SHA512:
-  metadata.gz: f39b661759572f31166f54ca5839eef3260b0b426ab0db32422f310632508b65ed57e35a247397dc0bc7307601cf88cae72be7d1b36b0f6467299420cf454c2d
-  data.tar.gz: 785951c200e8749f45c42a91754849d7cc5533d6b6598a70823fcf18d6dcb5ea7c8b272f091c6ae75d8ee404dac668c039781938637ed98d6236a433c83ecefc
+  metadata.gz: ef5a6691ff97b23e0bdb7dfdfd1104110f89ca88bd21a536cb54ed4c2651d212961464a152273dfd4057fd30d0fb4ec6213f6cff572b07bf4161668cfcc2d65f
+  data.tar.gz: 42560e6de9ff8e43146e5f8f9d9a40ff5d816336f6ed14a2fcd6cd321ecc9cff0fdec15c2ce9e764d4614a44ab42ceefd2913ad7b2deb4183e595025710b1c26

data/lib/finapps/rest/orders.rb

@@ -55,7 +55,7 @@ module FinApps
         filter = {}
         filter.merge!(search_query(params[:searchTerm])) if params[:searchTerm]
         filter.merge!(status_query(params[:status])) if params[:status]
-        filter.merge!(assignment_query(params[:assignment])) if params.key?(:assignment) # assignment can be nil
+        filter.merge!(assignment_query(params[:assignment])) if params[:assignment] # assignment can be ""
         filter.merge!(relation_query(params[:relation])) if !params[:searchTerm] && !nil_or_empty?(params[:relation])
         filter
       end
@@ -91,7 +91,7 @@ module FinApps
       end
 
       def assignment_query(assignment)
-        {"assignment.operator_id": assignment}
+        {"assignment.operator_id": assignment.empty? ? nil : assignment} # translate "" to null assignment
       end
 
       def relation_query(relation)

data/lib/finapps/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module FinApps
-  VERSION = '2.3.6'
+  VERSION = '2.3.7'
 end

data/spec/rest/orders_spec.rb

@@ -105,6 +105,12 @@ RSpec.describe FinApps::REST::Orders do
               '%5D%7D%7D%5D%7D&page=2&requested=25&sort=status'
         expect(WebMock).to have_requested(:get, url)
       end
+      it 'builds null assignment query properly when supplied w/ empty string' do
+        FinApps::REST::Orders.new(client).list(assignment: '')
+
+        url = "#{FinAppsCore::REST::Defaults::DEFAULTS[:host]}/v2/orders?filter=%7B%22assignment.operator_id%22:null%7D"
+        expect(WebMock).to have_requested(:get, url)
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.3.6
+  version: 2.3.7
 platform: ruby
 authors:
 - Erich Quintero