finapps 2.0.23 → 2.0.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5be4f8c24c61d16ba7c0faabfd7a8447457fbc9a
-  data.tar.gz: 260a063e09e7d8e7a23bfb9cf4e69b1d74dea3e0
+  metadata.gz: 459e76ea87b8115a6832116c5fa5244f5074694c
+  data.tar.gz: 0ebb05734404029ce95eb67a6ce7b893c2b7435d
 SHA512:
-  metadata.gz: 71a91753140914e0a7e01caceedcc11b3b5eb25997c8a46160c97706d23f511fa5dc5707de9762372ed52450ca10a94181c1788115092a7b8a4ea9a2ba372981
-  data.tar.gz: 6a1347b053c179e48f16b70c8785ccc8dfb5911371c40714ef2d963e4ad504d3ab14a0ebd5366742c7eb2648c2e8f4bf3d0a4989847af0d5fbd0ed92bdcea186
+  metadata.gz: 56509e050cfa3f90fd8575bd28c2dd758d7beded369f8f272fd4f181c55cabfcba09a58fe767ff0ac73e3cb5ec6de2ce44e747749e9ecbfd1914917dcef41962
+  data.tar.gz: 49b53717825e7c597409f7609f050e6430f10d9ff6bdcda025212409d3afba9f957ed339055915e2c9a2c4a3acd3bf15820c989b140c927bf1155043c598077c

data/lib/finapps/rest/institutions.rb

@@ -5,15 +5,6 @@ module FinApps
       using ObjectExtensions
       using StringExtensions
 
-      def create(site_id, params)
-        raise MissingArgumentsError.new 'Missing argument: site_id.' if site_id.blank?
-        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
-
-        path = "#{end_point}/site/#{ERB::Util.url_encode(site_id)}/add"
-
-        super params, path
-      end
-
       def list(search_term)
         raise MissingArgumentsError.new 'Missing argument: search_term' if search_term.blank?
         # API errors when search_term is blank, maybe it shouldn't

data/lib/finapps/rest/user_institutions.rb

@@ -12,6 +12,15 @@ module FinApps
         super path
       end
 
+      def create(site_id, params)
+        raise MissingArgumentsError.new 'Missing argument: site_id.' if site_id.blank?
+        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
+
+        path = "institutions/site/#{ERB::Util.url_encode(site_id)}/add"
+
+        super params, path
+      end
+
       def show(id)
         raise MissingArgumentsError.new 'Missing Argument: id.' if id.blank?
 

data/lib/finapps/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module FinApps
-  VERSION = '2.0.23'
+  VERSION = '2.0.24'
 end

data/spec/rest/institutions_spec.rb

@@ -1,29 +1,6 @@
 # frozen_string_literal: true
 RSpec.describe FinApps::REST::Institutions do
   let(:client) { FinApps::REST::Client.new(:company_identifier, :company_token) }
-  describe '#create' do
-    subject(:institutions) { FinApps::REST::Institutions.new(client) }
-
-    context 'when missing site_id' do
-      let(:create) { subject.create(nil, :params) }
-      it { expect { create }.to raise_error(FinApps::MissingArgumentsError) }
-    end
-
-    context 'when missing params' do
-      let(:create) { subject.create(:site_id, nil) }
-      it { expect { create }.to raise_error(FinApps::MissingArgumentsError) }
-    end
-
-    context 'when valid site_id and params are provided' do
-      let(:create) { subject.create('valid_site_id', :params) }
-
-      it { expect { create }.not_to raise_error }
-      it('performs a post and returns the response') { expect(create[0]).to respond_to(:user_institution) }
-      it('returns no error messages') { expect(create[1]).to be_empty }
-    end
-
-    # No tests for invalid site_id/params because of API/Yodlee flow
-  end
 
   describe '#list' do
     subject(:institutions) { FinApps::REST::Institutions.new(client) }

data/spec/rest/user_institutions_spec.rb

@@ -11,6 +11,30 @@ RSpec.describe FinApps::REST::UserInstitutions do
     end
   end
 
+  describe '#create' do
+    subject(:institutions) { FinApps::REST::UserInstitutions.new(client) }
+
+    context 'when missing site_id' do
+      let(:create) { subject.create(nil, :params) }
+      it { expect { create }.to raise_error(FinApps::MissingArgumentsError) }
+    end
+
+    context 'when missing params' do
+      let(:create) { subject.create(:site_id, nil) }
+      it { expect { create }.to raise_error(FinApps::MissingArgumentsError) }
+    end
+
+    context 'when valid site_id and params are provided' do
+      let(:create) { subject.create('valid_site_id', :params) }
+
+      it { expect { create }.not_to raise_error }
+      it('performs a post and returns the response') { expect(create[0]).to respond_to(:user_institution) }
+      it('returns no error messages') { expect(create[1]).to be_empty }
+    end
+
+    # No tests for invalid site_id/params because of API/Yodlee flow
+  end
+
   describe '#show' do
     context 'when missing id' do
       subject { FinApps::REST::UserInstitutions.new(client).show(nil) }

data/spec/support/fake_api.rb

@@ -30,7 +30,6 @@ class FakeApi < Sinatra::Base
   get('/v2/institutions/site/valid_site_id/form') { json_response 200, 'institution_login_form.json' }
   get('/v2/institutions/site/invalid_site_id/form') { json_response 400, 'invalid_institution_id.json' }
   post('/v2/institutions/site/valid_site_id/add') { json_response 200, 'institution_add.json' }
-  post('/v2/institutions/site/invalid_site_id/add') { json_response 400, 'invalid_institution_id.json' }
   get('/v2/institutions/search/:search_term') { json_response 200, 'institutions_search_list.json' }
 
   # user institutions

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 2.0.23
+  version: 2.0.24
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-22 00:00:00.000000000 Z
+date: 2016-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday