finapps 0.22.2.pre → 0.22.3.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9ca6b380d56d4a5bc2c2e27149d6fee6f8d78da0
-  data.tar.gz: a6ebbbd6d7725d5370450d8cbe4282e38fe3dd27
+  metadata.gz: 43ea47ac9694d4dba3fab923139344ee89b46780
+  data.tar.gz: f9aa6c0f7a25bd48d9af43ceecd311c0db19b2ab
 SHA512:
-  metadata.gz: ac33f9808003c4579c57b6074e2fddd695b0925f23dc4b33c02931dd5b8c574e987f4d0e764f464dfe402a28879b445b9eb30ecc6ff26b0e4b49e5b40a9e0f9b
-  data.tar.gz: de1b4e6a5205ab7ff48cfb9c26665fd90f46c829a3be642209a7a929567eba209cb5043cde6d306a7d5160ee1d29654933a761e784f0db0577dbbf11581d554f
+  metadata.gz: 8dec3552f184098e53af7da7170ff01838b898422c8a4b53f8e94040ab0db12a8d8eac63cb5d8c01b5292dac7f6435fd6ad630fb839c3cde2cfe44bd6d683b7a
+  data.tar.gz: 5ed925c293033c7de685ff0077c64603a5deb1d8b168feab3ac3e4a1c1b530339a0301fd5820f344e477284cc9863beb0150500484f19b9904bfd144da133d3a

data/.gitignore

@@ -1,6 +1,4 @@
 *.gem
-*.rbc
-.bundle
 .config
 .yardoc
 Gemfile.lock
@@ -11,12 +9,34 @@ doc/
 lib/bundler/man
 pkg
 rdoc
-spec/reports
-test/tmp
-test/version_tmp
-tmp
 *.bundle
 *.so
 *.o
 *.a
 mkmf.log
+
+# Ignore bundler config.
+/.bundle
+/vendor/bundle/
+/vendor/ruby/
+
+# Ignore all log files and tempfiles.
+/log/*
+!/log/.keep
+/tmp
+
+# various artifacts
+**.war
+*.rbc
+*.sassc
+.project
+.secret
+.rspec
+.idea/
+/spec/tmp/*
+/cache
+
+*.BACKUP.*
+*.BASE.*
+*.LOCAL.*
+*.REMOTE.*

data/README.md

@@ -5,7 +5,7 @@ FinApps Ruby-Client
 
 [![Gem Version](http://img.shields.io/gem/v/finapps.svg)][gem]
 
-![Build Status](http://teamciti.powerwallet.com/app/rest/builds/buildType:(id:FaRuby_BuildMaster)/statusIcon)
+[![Build Status](http://teamciti.powerwallet.com/app/rest/builds/buildType:(id:FaRuby_BuildMaster)/statusIcon)][build_status]
 
 
 Ruby client for [FinApps][financialapps].
@@ -73,3 +73,4 @@ Please check the [FinApps wiki][wiki] for extended documentation.
 [bundler]: http://bundler.io
 [rubygems]: http://rubygems.org
 [gem]: https://rubygems.org/gems/finapps
+[build_status]: http://teamciti.powerwallet.com/viewType.html?buildTypeId=FaRuby_BuildMaster&guest=1

data/lib/finapps/rest/alert.rb

@@ -8,7 +8,6 @@ module FinApps
 
       # @return [Hash, Array<String>]
       def list(page = 1, requested=100, sort='date', asc=false, read='all')
-        logger.debug "##{__method__.to_s} => Started"
 
         end_point = Defaults::END_POINTS[:alert_list]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
@@ -22,16 +21,14 @@ module FinApps
 
         result, error_messages = @client.send(path, :get)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return result, error_messages
       end
 
       # @return [Hash, Array<String>]
       def update(alert_id, read=true)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: alert_id.' if alert_id.blank?
         logger.debug "##{__method__.to_s} => alert_id: #{alert_id.inspect}"
+
         raise MissingArgumentsError.new 'Missing argument: read.' if read.blank?
         logger.debug "##{__method__.to_s} => read: #{read.inspect}"
 
@@ -44,14 +41,11 @@ module FinApps
 
         _, error_messages = @client.send(path, :put)
 
-        logger.debug "##{__method__.to_s} => Completed"
         error_messages
       end
 
       # @return [Hash, Array<String>]
       def delete(alert_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: alert_id.' if alert_id.blank?
         logger.debug "##{__method__.to_s} => alert_id: #{alert_id.inspect}"
 
@@ -63,7 +57,6 @@ module FinApps
 
         _, error_messages = @client.send(path, :delete)
 
-        logger.debug "##{__method__.to_s} => Completed"
         error_messages
       end
 

data/lib/finapps/rest/alert_definition.rb

@@ -8,8 +8,6 @@ module FinApps
 
       # @return [Hash, Array<String>]
       def list
-        logger.debug "##{__method__.to_s} => Started"
-
         end_point = Defaults::END_POINTS[:alert_definition_list]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
@@ -17,15 +15,11 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         result, error_messages = @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return result, error_messages
       end
 
       # @return [Hash, Array<String>]
       def show(alert_name)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: alert_name.' if alert_name.blank?
         logger.debug "##{__method__.to_s} => alert_name: #{alert_name}"
 
@@ -36,8 +30,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         result, error_messages = @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return result, error_messages
       end
 

data/lib/finapps/rest/alert_preferences.rb

@@ -8,8 +8,6 @@ module FinApps
 
       # @return [Hash, Array<String>]
       def show
-        logger.debug "##{__method__.to_s} => Started"
-
         end_point = Defaults::END_POINTS[:alert_preferences_show]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
@@ -17,15 +15,11 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         result, error_messages = @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return result, error_messages
       end
 
       # @return [Hash, Array<String>]
       def update(params)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{params.inspect}"
 
@@ -36,8 +30,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         _, error_messages = @client.send(path, :put, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
         error_messages
       end
 

data/lib/finapps/rest/alert_settings.rb

@@ -8,8 +8,6 @@ module FinApps
 
       # @return [Hash, Array<String>]
       def show
-        logger.debug "##{__method__.to_s} => Started"
-
         end_point = Defaults::END_POINTS[:alert_settings_show]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
@@ -17,15 +15,11 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         result, error_messages = @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return result, error_messages
       end
 
       # @return [Hash, Array<String>]
       def update(params)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{params.inspect}"
 
@@ -36,8 +30,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         _, error_messages = @client.send(path, :put, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
         error_messages
       end
 

data/lib/finapps/rest/budget_calculation.rb

@@ -10,10 +10,9 @@ module FinApps
       # @param [Number] income
       # @return [Array<Hash>, Array<String>]
       def create(budget_model_id, income)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: budget_model_id.' if budget_model_id.blank?
         logger.debug "##{__method__.to_s} => budget_model: #{budget_model_id}"
+
         raise MissingArgumentsError.new 'Missing argument: income.' if income.blank?
         logger.debug "##{__method__.to_s} => income: #{income}"
 
@@ -24,15 +23,11 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         budget_calculation, error_messages = @client.send(path, :get)
-        logger.debug "##{__method__.to_s} => Completed"
-
         return budget_calculation, error_messages
       end
 
       # @return [Array<Hash>, Array<String>]
       def show
-        logger.debug "##{__method__.to_s} => Started"
-
         end_point = Defaults::END_POINTS[:budget_calculation_show]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
@@ -40,8 +35,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         budget_calculation, error_messages = @client.send(path, :get)
-        logger.debug "##{__method__.to_s} => Completed"
-
         return budget_calculation, error_messages
       end
 

data/lib/finapps/rest/budget_models.rb

@@ -8,21 +8,15 @@ module FinApps
 
       # @return [Array<Hash>, Array<String>]
       def list
-        logger.debug "##{__method__.to_s} => Started"
-
         path = Defaults::END_POINTS[:budget_models_list]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         budget_models, error_messages = @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return budget_models, error_messages
       end
 
       # @param [Integer] budget_model_id
       def show(budget_model_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: budget_model_id.' if budget_model_id.blank?
         logger.debug "##{__method__.to_s} => budget_model_id: #{budget_model_id}"
 
@@ -33,8 +27,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         budget_model, error_messages = @client.send(path, :get) { |r| BudgetModel.new(r.body) }
-
-        logger.debug "##{__method__.to_s} => Completed"
         return budget_model, error_messages
       end
 

data/lib/finapps/rest/budgets.rb

@@ -10,10 +10,9 @@ module FinApps
       # @param [Date] end_date
       # @return [Hash, Array<String>]
       def show(start_date, end_date)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: start_date.' if start_date.blank?
         logger.debug "##{__method__.to_s} => start_date: #{start_date}"
+
         raise MissingArgumentsError.new 'Missing argument: end_date.' if end_date.blank?
         logger.debug "##{__method__.to_s} => end_date: #{end_date}"
 
@@ -34,23 +33,18 @@ module FinApps
           categories.each { |category| budget.details << result_category_to_budget_detail(category, transactions) }
         end
 
-        logger.debug "##{__method__.to_s} => Completed"
         return budget, error_messages
       end
 
       # @param [Hash] params
       # @return [Array<Hash>, Array<String>]
       def update(params={})
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
 
         end_point = Defaults::END_POINTS[:budget_update]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
         budget, error_messages = @client.send(end_point, :put, params)
-        logger.debug "##{__method__.to_s} => Completed"
-
         return budget, error_messages
       end
 

data/lib/finapps/rest/cashflows.rb

@@ -10,10 +10,9 @@ module FinApps
       # @param [Date] end_date
       # @return [Hash, Array<String>]
       def show(start_date, end_date)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: start_date.' if start_date.blank?
         logger.debug "##{__method__.to_s} => start_date: #{start_date}"
+
         raise MissingArgumentsError.new 'Missing argument: end_date.' if end_date.blank?
         logger.debug "##{__method__.to_s} => end_date: #{end_date}"
 
@@ -52,7 +51,6 @@ module FinApps
           categories.each { |category| cashflow.details << result_category_to_cashflow_detail(category) }
         end
 
-        logger.debug "##{__method__.to_s} => Completed"
         return cashflow, error_messages
       end
 

data/lib/finapps/rest/categories.rb

@@ -5,8 +5,6 @@ module FinApps
 
       # @return [Array<Hash>, Array<String>]
       def list
-        logger.debug "##{__method__.to_s} => Started"
-
         end_point = Defaults::END_POINTS[:categories_list]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
@@ -14,8 +12,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         categories, error_messages = @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return categories, error_messages
       end
 

data/lib/finapps/rest/client.rb

@@ -16,8 +16,6 @@ module FinApps
       # @param [Hash] options
       # @return [FinApps::REST::Client]
       def initialize(company_identifier, company_token, options = {})
-        logger.debug "##{__method__.to_s} => Started"
-
         @config = DEFAULTS.merge! options
         if @config[:logger_tag].present?
           Logging.tag= @config[:logger_tag]
@@ -34,8 +32,6 @@ module FinApps
 
         set_up_resources
         logger.debug "##{__method__.to_s} => All resources initialized"
-
-        logger.debug "##{__method__.to_s} => Completed"
       end
 
       # Performs HTTP GET, POST, UPDATE and DELETE requests.
@@ -47,7 +43,6 @@ module FinApps
       # @param [Proc] proc
       # @return [Hash,Array<String>]
       def send(path, method, params = {}, &proc)
-        logger.debug "##{__method__.to_s} => Started"
         raise MissingArgumentsError.new 'Missing argument: method.' if method.blank?
         result, error_messages = nil, nil
 
@@ -84,18 +79,14 @@ module FinApps
           logger.fatal "##{__method__.to_s} => Exception, #{error.to_s}"
           logger.fatal error
         ensure
-          logger.error "##{__method__.to_s} => Failed, error_messages: #{error_messages.pretty_inspect}" if error_messages.present?
+          logger.debug "##{__method__.to_s} => Failed, error_messages: #{error_messages.pretty_inspect}" if error_messages.present?
         end
-
-        logger.debug "##{__method__.to_s} => Completed"
         return result, error_messages
       end
 
       # @param [String] user_identifier
       # @param [String] user_token
       def user_credentials!(user_identifier, user_token)
-        logger.debug "##{__method__.to_s} => Started"
-
         {:user_identifier => user_identifier, :user_token => user_token}.validate_required_strings!
         logger.debug "##{__method__.to_s} => Credentials passed validation. Attempting to set user credentials on current connection."
 
@@ -103,8 +94,6 @@ module FinApps
         @config[:user_identifier] = user_identifier
         @config[:user_token] = user_token
         @connection = set_up_connection(@company_credentials, @config)
-
-        logger.debug "##{__method__.to_s} => Completed"
       end
 
       private
@@ -116,16 +105,10 @@ module FinApps
       # @param [String] path
       # @return [Hash,Array<String>]
       def get(path)
-        logger.debug "##{__method__.to_s} => Started"
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => GET path:#{path}"
-        response = @connection.get do |req|
-          req.url path
-        end
-
-        logger.debug "##{__method__.to_s} => Completed"
-        response
+        @connection.get { |req| req.url path }
       end
 
       # Performs an HTTP POST request.
@@ -136,17 +119,13 @@ module FinApps
       # @param [Hash] params
       # @return [Hash,Array<String>]
       def post(path, params = {})
-        logger.debug "##{__method__.to_s} => Started"
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => POST path:#{path} params:#{skip_sensitive_data params }"
-        response = @connection.post do |req|
+        @connection.post do |req|
           req.url path
           req.body = params
         end
-
-        logger.debug "##{__method__.to_s} => Completed"
-        response
       end
 
       # Performs an HTTP PUT request.
@@ -157,17 +136,13 @@ module FinApps
       # @param [Hash] params
       # @return [Hash,Array<String>]
       def put(path, params = {})
-        logger.debug "##{__method__.to_s} => Started"
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => PUT path:#{path} params:#{skip_sensitive_data(params)}"
-        response = @connection.put do |req|
+        @connection.put do |req|
           req.url path
           req.body = params
         end
-
-        logger.debug "##{__method__.to_s} => Completed"
-        response
       end
 
       # Performs an HTTP DELETE request.
@@ -178,19 +153,17 @@ module FinApps
       # @param [Hash] params
       # @return [Hash,Array<String>]
       def delete(path, params = {})
-        logger.debug "##{__method__.to_s} => Started"
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
 
         logger.debug "##{__method__.to_s} => DELETE path:#{path} params:#{skip_sensitive_data(params)}"
-        response = @connection.delete do |req|
+        @connection.delete do |req|
           req.url path
           req.body = params
         end
-
-        logger.debug "##{__method__.to_s} => Completed"
-        response
       end
 
+      # Initialize resources.
+      #
       def set_up_resources
         @users ||= FinApps::REST::Users.new self
         @institutions ||= FinApps::REST::Institutions.new self

data/lib/finapps/rest/connection.rb

@@ -9,10 +9,8 @@ module FinApps
       # @param [Hash] config
       # @return [Faraday::Connection]
       def set_up_connection(company_credentials, config)
-        logger.debug "##{__method__.to_s} => Started"
-
         company_credentials.validate_required_strings!
-        logger.debug "##{__method__.to_s} => company_credentials passed validation."
+        logger.debug "##{__method__.to_s} => company_credentials were provided."
 
         host = config[:host]
         validate_host_url! host
@@ -23,48 +21,48 @@ module FinApps
         timeout = config[:timeout].blank? ? DEFAULTS[:timeout] : config[:timeout]
         logger.debug " timeout: #{timeout}"
 
-        user_identifier = config[:user_identifier]
-        logger.debug " user_identifier: #{user_identifier}" if user_identifier.present?
-
-        user_token = config[:user_token]
-        logger.debug ' user_token: [REDACTED]' if user_token.present?
-
-        connection = Faraday.new(:url => base_url,
-                                 :request => {
-                                     :open_timeout => timeout,
-                                     :timeout => timeout},
-                                 :headers => {
-                                     :accept => HEADERS[:accept],
-                                     :user_agent => HEADERS[:user_agent]}) do |conn|
+        Faraday.new(:url => base_url,
+                    :request => {
+                        :open_timeout => timeout,
+                        :timeout => timeout},
+                    :headers => {
+                        :accept => HEADERS[:accept],
+                        :user_agent => HEADERS[:user_agent]}) do |conn|
 
-          # Request Middleware
-          conn.use FinApps::Middleware::ApiToken, company_credentials
-          conn.request :json
-          conn.request :retry
-          conn.request :multipart
-          conn.request :url_encoded
-          if user_identifier.blank? || user_token.blank?
-            logger.debug "##{__method__.to_s} => User credentials were not provided. Authentication header not set."
-          else
-            conn.request :basic_auth, user_identifier, user_token
-            logger.debug "##{__method__.to_s} => Basic Authentication header set for provided user credentials."
-          end
-
-          # Response Middleware
-          conn.use FinApps::Middleware::RaiseHttpExceptions
-          conn.response :rashify
-          conn.response :json, :content_type => /\bjson$/
-          conn.use FinApps::Middleware::ResponseLogger
+          set_request_middleware(conn, company_credentials)
+          set_basic_authentication(conn, config)
+          set_response_middleware(conn)
 
           # Adapter (ensure that the adapter is always last.)
           conn.adapter :typhoeus
         end
-
-        logger.debug "##{__method__.to_s} => Completed"
-        connection
       end
 
       private
+      def set_response_middleware(conn)
+        conn.use FinApps::Middleware::RaiseHttpExceptions
+        conn.response :rashify
+        conn.response :json, :content_type => /\bjson$/
+        conn.use FinApps::Middleware::ResponseLogger
+      end
+
+      def set_request_middleware(conn, company_credentials)
+        conn.use FinApps::Middleware::ApiToken, company_credentials
+        conn.request :json
+        conn.request :retry
+        conn.request :multipart
+        conn.request :url_encoded
+      end
+
+      def set_basic_authentication(conn, config)
+        if config[:user_identifier].blank? || config[:user_token].blank?
+          logger.debug "##{__method__.to_s} => User credentials were not provided. Authentication header not set."
+        else
+          conn.request :basic_auth, config[:user_identifier], config[:user_token]
+          logger.debug "##{__method__.to_s} => Basic Authentication header set for provided user credentials."
+        end
+      end
+
       def validate_host_url!(host_url)
         raise MissingArgumentsError.new 'Missing argument: host_url.' if host_url.blank?
         raise InvalidArgumentsError.new 'Invalid argument: host_url does not specify a valid protocol (http/https).' unless host_url.start_with?('http://', 'https://')

data/lib/finapps/rest/institutions.rb

@@ -9,8 +9,6 @@ module FinApps
       # @param [String] term
       # @return [Array<FinApps::REST::Institution>, Array<String>]
       def search(term)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: term.' if term.blank?
         logger.debug "##{__method__.to_s} => term: #{term}"
 
@@ -21,15 +19,11 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         institutions, error_messages = @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return institutions, error_messages
       end
 
       # @param [Integer] site_id
       def form(site_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: site_id.' if site_id.blank?
         logger.debug "##{__method__.to_s} => site_id: #{site_id}"
 
@@ -40,8 +34,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         institution, error_messages = @client.send(path, :get) { |r| Institution.new(r.body) }
-
-        logger.debug "##{__method__.to_s} => Completed"
         return institution, error_messages
       end
 

data/lib/finapps/rest/relevance/rulesets.rb

@@ -7,7 +7,7 @@ module FinApps
       class Rulesets < FinApps::REST::Resources
 
         def list
-          logger.debug "##{__method__.to_s} => Started"
+
 
           end_point = Defaults::END_POINTS[:relevance_rulesets_list]
           logger.debug "##{__method__.to_s} => end_point: #{end_point}"
@@ -17,12 +17,12 @@ module FinApps
 
           results, error_messages = @client.send(path, :get)
 
-          logger.debug "##{__method__.to_s} => Completed"
+
           return results, error_messages
         end
 
         def show(ruleset_name)
-          logger.debug "##{__method__.to_s} => Started"
+
 
           raise MissingArgumentsError.new 'Missing argument: ruleset_name.' if ruleset_name.blank?
           logger.debug "##{__method__.to_s} => ruleset_name: #{ruleset_name}"
@@ -35,12 +35,12 @@ module FinApps
 
           results, error_messages = @client.send(path, :get)
 
-          logger.debug "##{__method__.to_s} => Completed"
+
           return results, error_messages
         end
 
         def run(params = {})
-          logger.debug "##{__method__.to_s} => Started"
+
 
           raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
           logger.debug "##{__method__.to_s} => params: #{params.inspect}"
@@ -53,7 +53,7 @@ module FinApps
 
           results, error_messages = @client.send(path, :post, params)
 
-          logger.debug "##{__method__.to_s} => Completed"
+
           return results, error_messages
         end
 

data/lib/finapps/rest/transactions.rb

@@ -7,45 +7,33 @@ module FinApps
       # @transaction_id [String]
       # # @return [Hash, Array<String>]
       def show(transaction_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         end_point = Defaults::END_POINTS[:transactions_show]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
         path = end_point.sub ':transaction_id', ERB::Util.url_encode(transaction_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        transaction, error_messages =  @client.send(path, :get)
-
-        logger.debug "##{__method__.to_s} => Completed"
+        transaction, error_messages = @client.send(path, :get)
         return transaction, error_messages
       end
 
       # @param [Hash] params
       # @return [Array<Hash>, Array<String>]
       def search(params={})
-        logger.debug "##{__method__.to_s} => Started"
-
         path = Defaults::END_POINTS[:transactions_list]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         transactions, error_messages = @client.send(path, :post, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
         return transactions, error_messages
       end
 
       # @param [Hash] params
       # @return [Array<Hash>, Array<String>]
       def update(params={})
-        logger.debug "##{__method__.to_s} => Started"
-
         path = Defaults::END_POINTS[:transactions_update]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         _, error_messages = @client.send(path, :put, params.compact)
-
-        logger.debug "##{__method__.to_s} => Completed"
         error_messages
       end
 

data/lib/finapps/rest/user_institutions.rb

@@ -7,19 +7,15 @@ module FinApps
       include FinApps::REST::Defaults
 
       def list
-        logger.debug "##{__method__.to_s} => Started"
-
         path = Defaults::END_POINTS[:user_institutions_list]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         user_institutions, error_messages = @client.send(path, :get)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institutions, error_messages
       end
 
       def add(site_id, parameters)
-        logger.debug "##{__method__.to_s} => Started"
 
         raise MissingArgumentsError.new 'Missing argument: site_id.' if site_id.blank?
         logger.debug "##{__method__.to_s} => site_id: #{site_id}"
@@ -35,12 +31,10 @@ module FinApps
 
         user_institution, error_messages = @client.send(path, :post, :parameters => parameters)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institution, error_messages
       end
 
       def show(user_institution_id)
-        logger.debug "##{__method__.to_s} => Started"
 
         raise MissingArgumentsError.new 'Missing argument: user_institution_id.' if user_institution_id.blank?
         logger.debug "##{__method__.to_s} => user_institution_id: #{user_institution_id}"
@@ -53,13 +47,10 @@ module FinApps
 
         user_institution, error_messages = @client.send(path, :get)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institution, error_messages
       end
 
       def form(user_institution_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: user_institution_id.' if user_institution_id.blank?
         logger.debug "##{__method__.to_s} => user_institution_id: #{user_institution_id}"
 
@@ -71,13 +62,10 @@ module FinApps
 
         user_institution, error_messages = @client.send(path, :get)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institution, error_messages
       end
 
       def status(user_institution_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: user_institution_id.' if user_institution_id.blank?
         logger.debug "##{__method__.to_s} => user_institution_id: #{user_institution_id}"
 
@@ -89,13 +77,10 @@ module FinApps
 
         user_institution, error_messages = @client.send(path, :get)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institution, error_messages
       end
 
       def mfa(user_institution_id, parameters)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: user_institution_id.' if user_institution_id.blank?
         logger.debug "##{__method__.to_s} => user_institution_id: #{user_institution_id}"
 
@@ -110,13 +95,10 @@ module FinApps
 
         user_institution, error_messages = @client.send(path, :put, :parameters => parameters)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institution, error_messages
       end
 
       def update(user_institution_id, parameters)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: user_institution_id.' if user_institution_id.blank?
         logger.debug "##{__method__.to_s} => user_institution_id: #{user_institution_id}"
 
@@ -131,26 +113,20 @@ module FinApps
 
         user_institution, error_messages = @client.send(path, :put, :parameters => parameters)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institution, error_messages
       end
 
       def refresh
-        logger.debug "##{__method__.to_s} => Started"
-
         path = Defaults::END_POINTS[:user_institutions_refresh]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         user_institutions, error_messages = @client.send(path, :get)
 
-        logger.debug "##{__method__.to_s} => Completed"
         return user_institutions, error_messages
       end
 
       # @return [Hash, Array<String>]
       def delete(user_institution_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: user_institution_id.' if user_institution_id.blank?
         logger.debug "##{__method__.to_s} => user_institution_id: #{user_institution_id.inspect}"
 
@@ -162,7 +138,6 @@ module FinApps
 
         _, error_messages = @client.send(path, :delete)
 
-        logger.debug "##{__method__.to_s} => Completed"
         error_messages
       end
 

data/lib/finapps/rest/users.rb

@@ -10,8 +10,6 @@ module FinApps
       # @param [Hash] params
       # @return [FinApps::REST::User, Array<String>]
       def create(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
@@ -19,14 +17,12 @@ module FinApps
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
         user, error_messages = @client.send(end_point, :post, params) { |r| User.new(r.body) }
-        logger.debug "##{__method__.to_s} => Completed"
 
         return user, error_messages
       end
 
       def update(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
+        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
         path = Defaults::END_POINTS[:users_update]
@@ -34,20 +30,17 @@ module FinApps
 
         _, error_messages = @client.send(path, :put, params.compact)
 
-        logger.debug "##{__method__.to_s} => Completed"
         error_messages
       end
 
       def update_password(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
+        raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
         path = Defaults::END_POINTS[:users_update_password]
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         user, error_messages = @client.send(path, :put, params.compact) { |r| User.new(r.body) }
-        logger.debug "##{__method__.to_s} => Completed"
 
         return user, error_messages
       end
@@ -55,8 +48,6 @@ module FinApps
       # @param [Hash] params
       # @return [FinApps::REST::User, Array<String>]
       def login(params = {})
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: params.' if params.blank?
         logger.debug "##{__method__.to_s} => params: #{skip_sensitive_data params}"
 
@@ -64,7 +55,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
         user, error_messages = @client.send(end_point, :post, params) { |r| User.new(r.body) }
-        logger.debug "##{__method__.to_s} => Completed"
 
         return user, error_messages
       end
@@ -72,8 +62,6 @@ module FinApps
       # @param [String] public_id
       # @return [Array<String>]
       def delete(public_id)
-        logger.debug "##{__method__.to_s} => Started"
-
         raise MissingArgumentsError.new 'Missing argument: public_id.' if public_id.blank?
         logger.debug "##{__method__.to_s} => public_id: #{public_id}"
 
@@ -84,7 +72,6 @@ module FinApps
         logger.debug "##{__method__.to_s} => path: #{path}"
 
         _, error_messages = @client.send(path, :delete)
-        logger.debug "##{__method__.to_s} => Completed"
 
         error_messages
       end

data/lib/finapps/utils/logging.rb

@@ -34,9 +34,9 @@ module FinApps
     end
 
     def set_up_logger_level(logger_level)
-      unless logger_level.blank? || @logger.level == logger_level
-        @logger.info "##{__method__.to_s} => Setting logger level to #{SEVERITY_LABEL[logger_level]}"
-        @logger.level = logger_level
+      unless logger_level.blank? || logger.level == logger_level
+        logger.info "##{__method__.to_s} => Setting logger level to #{SEVERITY_LABEL[logger_level]}"
+        logger.level = logger_level
       end
     end
 

data/lib/finapps/version.rb

@@ -1,3 +1,3 @@
 module FinApps
-  VERSION = '0.22.2.pre'
+  VERSION = '0.22.3.pre'
 end

data/spec/rest/client_spec.rb

@@ -17,8 +17,6 @@ module FinApps
       expect(@client).to respond_to(:user_credentials!)
     end
 
-
-
     it 'responds to public api methods' do
       [:alert, :alert_definition, :alert_settings, :alert_preferences,
        :budgets, :budget_calculation, :budget_models, :cashflows,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 0.22.2.pre
+  version: 0.22.3.pre
 platform: ruby
 authors:
 - Erich Quintero
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-11 00:00:00.000000000 Z
+date: 2016-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -257,6 +257,6 @@ signing_key:
 specification_version: 4
 summary: FinApps REST API ruby client.
 test_files:
-- spec/rest/client_spec.rb
 - spec/spec_helper.rb
 - spec/utils/logging_spec.rb
+- spec/rest/client_spec.rb