finapps 0.21.4.pre → 0.21.5.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f72d59941b3f324b751f393548af22a421d546c1
-  data.tar.gz: 2980215ae44453154d5c360bd781e672999bc8a8
+  metadata.gz: e0b9ce07fca3ac0bc03a102c38f367b75bb311bf
+  data.tar.gz: a95cc221e07224f71a78b9c2651d7f87f613cea2
 SHA512:
-  metadata.gz: b6818c7caf9cd4b0018919523139fad1c6c82719c5e3c6ba5650cbc3fc36ce5ed1447112f4db8278c49263dcf5fd82132d64d8972d266c7d723517fa58381fe4
-  data.tar.gz: 7d611924d13c99794ab34113af68a56f55fed2dab9d54c56869bbe955bd772b298dd3454693ec0b4e712a6a6f11fcd35bf2632975f56b94e8e939cd1da31a455
+  metadata.gz: 04b7aaa69a8684e3be3c2606e9a0067b11fe0a566d26bad9eafecf6c9cd127556b98ade4c38af344b2fb49572a2c94442d366680e7bfab3c03017f47856932c8
+  data.tar.gz: e85ec56cc4b776e9e138a2b8f6b55a5f1969974e3366dcb18c6f50729a18c3ff4e8a2c7a7c99dada8e180cb466a771853efd46c5a6d3616bba5edc9c2e3d9776

data/.rspec

@@ -1,3 +1,4 @@
 --color
+--format documentation
 --warnings
 --require spec_helper

data/lib/finapps/utils/logging.rb

@@ -55,7 +55,17 @@ module FinApps
     def skip_sensitive_data(hash)
       if hash.is_a? Hash
         filtered_hash = hash.clone
-        filtered_hash.update(filtered_hash) { |key, v1| filter_sensitive_values(key, v1) }
+        filtered_hash.each do |key, value|
+          if PROTECTED_KEYS.include? key.to_s.downcase
+            filtered_hash[key] = '[REDACTED]'
+          elsif value.is_a?(Hash)
+            filtered_hash[key] = self.skip_sensitive_data(value)
+          elsif value.is_a?(Array)
+            filtered_hash[key] = value.map { |v| v.is_a?(Hash) ? self.skip_sensitive_data(v) : v }
+          end
+        end
+
+        filtered_hash
       else
         hash
       end
@@ -66,10 +76,6 @@ module FinApps
       time.strftime('%Y-%m-%dT%H:%M:%S.') << '%06d ' % time.usec
     end
 
-    def filter_sensitive_values(key, v1)
-      (PROTECTED_KEYS.include? key.to_s.downcase) ? '[REDACTED]' : v1
-    end
-
     def msg2str(msg)
       case msg
         when ::String
@@ -86,4 +92,4 @@ module FinApps
     end
 
   end
-end
+end

data/lib/finapps/version.rb

@@ -1,3 +1,3 @@
 module FinApps
-  VERSION = '0.21.4.pre'
+  VERSION = '0.21.5.pre'
 end

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
-require 'finapps'
+require 'bundler/setup'
+Bundler.setup
 
+require 'finapps'
 # This file was generated by the `rspec --init` command. Conventionally, all
 # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
 # The generated `.rspec` file contains `--require spec_helper` which will cause this

data/spec/utils/logging_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+RSpec.describe FinApps::Logging do
+
+  let(:dummy_class) { Class.new { extend FinApps::Logging } }
+  let(:simple_hash) { {:login => 'login', :password => 'secret'} }
+  let(:deep_hash) { {:parameters => {:login => 'login', :password => 'secret'}} }
+  let(:array_of_hashes) { {:parameters => [{:login => 'login', :password => 'secret'},
+                                           {:login => 'login', :password => 'secret'}]} }
+
+  it 'should redact protected keys on a simple Hash' do
+    redacted = dummy_class.skip_sensitive_data simple_hash
+    expect(redacted[:password]).to eq('[REDACTED]')
+  end
+
+  it 'should redact protected keys on a deep Hash' do
+    redacted = dummy_class.skip_sensitive_data deep_hash
+    expect(redacted[:parameters][:password]).to eq('[REDACTED]')
+  end
+
+  it 'should redact protected keys on an array of Hashes' do
+    redacted = dummy_class.skip_sensitive_data array_of_hashes
+    expect(redacted[:parameters][0][:password]).to eq('[REDACTED]')
+    expect(redacted[:parameters][1][:password]).to eq('[REDACTED]')
+  end
+end
+
+
+=begin
+params : {:parameters => {"LOGIN1" => "MoneyMatch.site16441.1", "PASSWORD1" => "site16441.1"}}
+params : {:email => "erich@example.com", :password => "[REDACTED]"}
+=end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 0.21.4.pre
+  version: 0.21.5.pre
 platform: ruby
 authors:
 - Erich Quintero
@@ -225,6 +225,7 @@ files:
 - lib/finapps/version.rb
 - spec/rest/client_spec.rb
 - spec/spec_helper.rb
+- spec/utils/logging_spec.rb
 homepage: http://github.com/finapps/finapps-ruby
 licenses:
 - MIT
@@ -258,3 +259,4 @@ summary: FinApps REST API ruby client.
 test_files:
 - spec/rest/client_spec.rb
 - spec/spec_helper.rb
+- spec/utils/logging_spec.rb