finapps 0.1.8.pre → 0.1.10.pre

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 30876b25f377f6c13e4ad4e8c343d5c4c31a11af
-  data.tar.gz: b4bb089beffd2bd95adaacbae50aa08e2d72aa1a
+  metadata.gz: f9bb9c1f912e72afc9a3b0b8c72e1f8285df32a7
+  data.tar.gz: 7047152f6c890bd120dc1e0cd1ef4ce76f393e09
 SHA512:
-  metadata.gz: f743583ba7756bf02c5026cdf381ba1a3260d0e4383972a801365d37174e0c518e36132635e9ede84b78a0ed5f0d89e9aad369a4f1f4c1d0a56624910decc32d
-  data.tar.gz: fd428d18e09e732e0c03f20002f44f1e8e2ad19f79e47cb674e297f4ca091228ae7c27dfd46f48e3e35f7a3ad7b948559bbb2c13cd5f42f74adeab87d74c2705
+  metadata.gz: 1739253c2b1d1c9420ceb99c486ea5d30f64763552d221fc41c015649a7a45c6b219d36159ef4906294044f73258c23e196cf3e2f3e205c2c7ef6c76f271897e
+  data.tar.gz: 445c302fe03d7727540fbd58e7bab99d4b6e3a5408adfe2a91ae5233f66d910f38808c59a77f9520aa1ab3ec35ba51b0c81431d6b4073ee10f66f52980c3ec77

data/lib/finapps/rest/client.rb

@@ -45,6 +45,7 @@ module FinApps
       # @return [Hash,Array<String>]
       def send(path, method, params = {}, &proc)
         logger.debug "##{__method__.to_s} => Started"
+        raise MissingArgumentsError.new 'Missing argument: method.' if method.blank?
         result, error_messages = nil, nil
 
         begin
@@ -88,20 +89,15 @@ module FinApps
       def get(path, &proc)
         logger.debug "##{__method__.to_s} => Started"
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
-        response, result, error_messages = nil, nil, nil
+        result, error_messages = nil, nil
 
-        begin
-          logger.debug "##{__method__.to_s} => GET path:#{path}"
-          response = @connection.get do |req|
-            req.url path
-          end
-          if response.present? && block_given?
-            result = proc.call(response)
-            logger.debug "##{__method__.to_s} => parsed result: #{result.pretty_inspect}" if result.present?
-          end
-        rescue FinApps::REST::Error => error
-          error_messages = error.error_messages
-          logger.debug "##{__method__.to_s} => Failed, error_messages: #{error_messages.pretty_inspect}" if error_messages.present?
+        logger.debug "##{__method__.to_s} => GET path:#{path}"
+        response = @connection.get do |req|
+          req.url path
+        end
+        if response.present? && block_given?
+          result = proc.call(response)
+          logger.debug "##{__method__.to_s} => parsed result: #{result.pretty_inspect}" if result.present?
         end
 
         logger.debug "##{__method__.to_s} => Completed"
@@ -119,7 +115,7 @@ module FinApps
       def post(path, params = {}, &proc)
         logger.debug "##{__method__.to_s} => Started"
         raise MissingArgumentsError.new 'Missing argument: path.' if path.blank?
-        result, error_messages = nil, nil, nil
+        result, error_messages = nil, nil
 
         logger.debug "##{__method__.to_s} => POST path:#{path} params:#{skip_sensitive_data(params)}"
         response = @connection.post do |req|

data/lib/finapps/rest/institutions.rb

@@ -20,7 +20,7 @@ module FinApps
         path = end_point.sub ':search_term', ERB::Util.url_encode(term)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        institutions, error_messages = @client.get(path) do |r|
+        institutions, error_messages = @client.post(path, :post) do |r|
           r.body.each { |i| Institution.new(i) }
         end
 
@@ -41,7 +41,7 @@ module FinApps
         path = end_point.sub ':site_id', ERB::Util.url_encode(site_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        institution, error_messages = @client.get(path) { |r| Institution.new(r.body) }
+        institution, error_messages = @client.send(path, :get) { |r| Institution.new(r.body) }
 
         logger.debug "##{__method__.to_s} => Completed"
         return institution, error_messages

data/lib/finapps/rest/users.rb

@@ -15,7 +15,7 @@ module FinApps
         end_point = Defaults::END_POINTS[:users_create]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
-        user, error_messages = @client.post(end_point, params) { |r| User.new(r.body) }
+        user, error_messages = @client.send(end_point, :post, params) { |r| User.new(r.body) }
         logger.debug "##{__method__.to_s} => Completed"
 
         return user, error_messages
@@ -31,7 +31,7 @@ module FinApps
         end_point = Defaults::END_POINTS[:users_login]
         logger.debug "##{__method__.to_s} => end_point: #{end_point}"
 
-        user, error_messages = @client.post(end_point, params) { |r| User.new(r.body) }
+        user, error_messages = @client.send(end_point, :post, params) { |r| User.new(r.body) }
         logger.debug "##{__method__.to_s} => Completed"
 
         return user, error_messages
@@ -51,7 +51,7 @@ module FinApps
         path = end_point.sub ':public_id', ERB::Util.url_encode(public_id)
         logger.debug "##{__method__.to_s} => path: #{path}"
 
-        _, error_messages = @client.delete(path)
+        _, error_messages = @client.send(path, :delete)
         logger.debug "##{__method__.to_s} => Completed"
 
         error_messages

data/lib/finapps/version.rb

@@ -1,3 +1,3 @@
 module FinApps
-  VERSION = '0.1.8.pre'
+  VERSION = '0.1.10.pre'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: finapps
 version: !ruby/object:Gem::Version
-  version: 0.1.8.pre
+  version: 0.1.10.pre
 platform: ruby
 authors:
 - Erich Quintero