filmaffinity 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52aaf0ced3b0eb4e2eec8f40a956a9491045e073
-  data.tar.gz: 11d38853476bce00f143ac5e3213970029dd34ec
+  metadata.gz: 29ef0361d9518662bb80c94ec7935ec0706b3874
+  data.tar.gz: 17684ee3bf5f24ed46766a0e8539cbfde0812316
 SHA512:
-  metadata.gz: aa6e4c80f074223966f37466bcb6e315e33fb4a9c4cefef7cb8c550f15f23fadd112d8f2a7c43c3a9f11e094167272bc3d4d3dc353836d9ab11e14db358160fc
-  data.tar.gz: 41d399c3bdc3e920b78cd5314f621e2c67ba785b25face9d9e87f7e4d45ffde85fb1437fb6c3183881395cdb4c4971d7d8dc47dce471df02b643a57fa2c4919d
+  metadata.gz: 61606a76a4d418ffe81b087504df61332423de8759ca12fbf5b580bc1f70fdb98a1b952e1d98b687e5d7f92072cd1414152cc0587032c693eb9621307be5a86b
+  data.tar.gz: d4a64c23d3c57b8982ed609931ed9f939c063dfdfac6c388fa9441317ee45c7cd37272b4858560e83855c6f73aa23375cfcb072a1122032e9caa65c4a4315f58

data/.rubocop.yml

@@ -0,0 +1,4 @@
+# inherit_from: .rubocop_todo.yml 
+
+# Style/FileName:
+#   Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,227 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2016-04-19 12:48:01 +0200 using RuboCop version 0.39.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AlignWith, SupportedStyles.
+# SupportedStyles: either, start_of_block, start_of_line
+Lint/BlockAlignment:
+  Exclude:
+  
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks.
+Lint/UnusedBlockArgument:
+  Exclude:
+    # - 'lib/filmaffinity/top.rb'
+
+# Offense count: 35
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 134
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/MethodLength:
+  Max: 50
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Performance/StringReplacement:
+  Exclude:
+    # - 'lib/filmaffinity/movie.rb'
+
+# Offense count: 8
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Style/AlignHash:
+  Exclude:
+
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
+# SupportedStyles: line_count_based, semantic, braces_for_chaining
+# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
+# FunctionalMethods: let, let!, subject, watch
+# IgnoredMethods: lambda, proc, it
+Style/BlockDelimiters:
+  Exclude:
+
+
+# Offense count: 9
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/constants/constants.rb'
+    - 'lib/filmaffinity.rb'
+    - 'lib/filmaffinity/configuration.rb'
+    - 'lib/filmaffinity/json-movie-parser.rb'
+    - 'lib/filmaffinity/json-movies-parser.rb'
+    - 'lib/filmaffinity/movie.rb'
+    - 'lib/filmaffinity/poster-manager.rb'
+    - 'lib/filmaffinity/search.rb'
+    - 'lib/filmaffinity/top.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAdjacentOneLineDefs.
+Style/EmptyLineBetweenDefs:
+  Exclude:
+    # - 'lib/filmaffinity/json-movie-parser.rb'
+    # - 'lib/filmaffinity/json-movies-parser.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/EmptyLines:
+  Exclude:
+
+
+# Offense count: 13
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundBlockBody:
+  Exclude:
+
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundClassBody:
+  Exclude:
+
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/EmptyLinesAroundMethodBody:
+  Exclude:
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: empty_lines, no_empty_lines
+Style/EmptyLinesAroundModuleBody:
+  Exclude:
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/EmptyLiteral:
+  Exclude:
+  
+
+# Offense count: 6
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts.
+Style/FileName:
+  Exclude:
+    #CAREFUL FileName Bug!
+    - 'lib/filmaffinity/json-movie-parser.rb'
+    - 'lib/filmaffinity/json-movies-parser.rb'
+    - 'lib/filmaffinity/poster-manager.rb'
+    - 'spec/filmaffinity/json-movie-parser_spec.rb'
+    - 'spec/filmaffinity/json-movies-parser_spec.rb'
+    - 'spec/filmaffinity/matchers/include-movie.rb'
+
+# Offense count: 59
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
+# SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
+Style/HashSyntax:
+  Enabled: enable
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: normal, rails
+Style/IndentationConsistency:
+  Exclude:
+    # - 'lib/filmaffinity/top.rb'
+    # - 'spec/filmaffinity/movie_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/LeadingCommentSpace:
+  Exclude:
+    # - 'spec/filmaffinity/search_spec.rb'
+
+# Offense count: 11
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles.
+# SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
+Style/MethodDefParentheses:
+  Enabled: true
+
+# Offense count: 29
+# Cop supports --auto-correct.
+Style/NumericLiterals:
+  Enabled: true
+
+# Offense count: 3
+# Cop supports --auto-correct.
+Style/RedundantParentheses:
+  Exclude:
+ 
+
+# Offense count: 6
+# Cop supports --auto-correct.
+Style/RedundantSelf:
+  Exclude:
+
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/SpaceAfterColon:
+  Exclude:
+
+
+# Offense count: 9
+# Cop supports --auto-correct.
+Style/SpaceAfterComma:
+  Exclude:
+
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowForAlignment.
+Style/SpaceAroundOperators:
+  Exclude:
+ 
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
+# SupportedStyles: space, no_space
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+# Offense count: 209
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
+# SupportedStyles: single_quotes, double_quotes
+Style/StringLiterals:
+  Enabled: false
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
+# SupportedStyles: comma, consistent_comma, no_comma
+Style/TrailingCommaInLiteral:
+  Exclude:
+    - 'lib/constants/constants.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: SupportedStyles, MinSize, WordRegex.
+# SupportedStyles: percent, brackets
+Style/WordArray:
+  EnforcedStyle: brackets

data/README.md

@@ -30,6 +30,15 @@ Or install it yourself as:
 
 ## Documentation
 
+##### FilmAffinity configuration
+FilmAffinity has some configuration options, which you can configure globally before your requests. Could include an ```imgur_id``` to upload the posters on Imgur and avoid forbidden hotlinking from filmaffinity. Also you can change the ```language```, english by default. 
+```
+FilmAffinity.configure do |config|
+  config.imgur_id = "Your-imgur-client-id"
+  config.language = "ES"
+end
+```
+
 ##### FilmAffinity::Search
 Return an array of FilmAffinity::Movie, just containing preload ID and title.
 

data/filmaffinity.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name        = 'filmaffinity'
-  s.version     = '0.3.0'
-  s.date        = '2016-04-18'
+  s.version     = '0.3.1'
+  s.date        = '2016-04-19'
   s.summary     = "filmaffinity"
   s.description = "Easily use Ruby or the command line to find information on Filmaffinity.com"
   s.authors     = ["David Santos", "Oriol Bellido"]
@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.license       = 'MIT'
   s.add_dependency 'nokogiri', ' ~> 1.6'
   s.add_dependency 'json', ' ~> 1.8'
-  s.add_dependency 'imgur-api','~> 0'
+  s.add_dependency 'imgur-api', '~> 0'
   s.add_development_dependency 'rake', '~> 10.0'
   s.add_development_dependency 'rspec', '~> 3.3'
 end

data/lib/constants/constants.rb

@@ -1,89 +1,88 @@
 module Constants
-
   def self.query_params
     {
-      :genre => "genre=%s&",
-      :country => "country=%s&",
-      :from_year => "fromyear=%i&",
-      :to_year => "toyear=%i&",
-      :no_doc => "nodoc&",
-      :no_tv => "notvse&",
+      genre: 'genre=%s&',
+      country: 'country=%s&',
+      from_year: 'fromyear=%i&',
+      to_year: 'toyear=%i&',
+      no_doc: 'nodoc&',
+      no_tv: 'notvse&',
     }
   end
 
   def self.urls
     {
-      :top => "http://www.filmaffinity.com/#{self.lang}/topgen.php%s",
-      :search_by_title => "http://www.filmaffinity.com/#{self.lang}/search.php?stext=%s&stype=title",
-      :movie => "http://www.filmaffinity.com/#{self.lang}/film%i.html"
+      top: "http://www.filmaffinity.com/#{lang}/topgen.php%s",
+      search_by_title: "http://www.filmaffinity.com/#{lang}/search.php?stext=%s&stype=title",
+      movie: "http://www.filmaffinity.com/#{lang}/film%i.html"
     }
   end
 
   def self.tags
     {
 
-      :title => { :EN => '#main-title span',
-                  :ES => '#main-title span'
+      title: { EN: '#main-title span',
+               ES: '#main-title span'
       },
 
-      :year => { :EN => 'dd[itemprop="datePublished"]',
-                  :ES => 'dd[itemprop="datePublished"]'
+      year: { EN: 'dd[itemprop="datePublished"]',
+              ES: 'dd[itemprop="datePublished"]'
       },
 
-      :duration => { :EN => 'dd[itemprop="duration"]',
-                      :ES => 'dd[itemprop="duration"]'
+      duration: { EN: 'dd[itemprop="duration"]',
+                  ES: 'dd[itemprop="duration"]'
       },
 
-      :country => { :EN => '#country-img',
-                    :ES => '#country-img'
+      country: { EN: '#country-img',
+                 ES: '#country-img'
       },
 
-      :director => { :EN => 'a[itemprop="url"]',
-                      :ES => 'a[itemprop="url"]'
+      director: { EN: 'a[itemprop="url"]',
+                  ES: 'a[itemprop="url"]'
       },
 
-      :music => { :EN => 'dt:contains("Music")',
-                  :ES => 'dt:contains("Música")'
+      music: { EN: 'dt:contains("Music")',
+               ES: 'dt:contains("Música")'
       },
 
-      :company => { :EN => 'dt:contains("Producer")',
-                    :ES => 'dt:contains("Productora")'
+      company: { EN: 'dt:contains("Producer")',
+                 ES: 'dt:contains("Productora")'
       },
 
-      :script => {:EN => 'dt:contains("Screenwriter")',
-                  :ES => 'dt:contains("Guión")'
+      script: { EN: 'dt:contains("Screenwriter")',
+                ES: 'dt:contains("Guión")'
       },
 
-      :photography => { :EN => 'dt:contains("Cinematography")',
-                        :ES => 'dt:contains("Fotografía")'
+      photography: { EN: 'dt:contains("Cinematography")',
+                     ES: 'dt:contains("Fotografía")'
       },
 
-      :cast => { :EN => 'span[itemprop="actor"]',
-                  :ES => 'span[itemprop="actor"]'
+      cast: { EN: 'span[itemprop="actor"]',
+              ES: 'span[itemprop="actor"]'
       },
 
-      :cast_each => { :EN => 'span[itemprop="name"]',
-                      :ES => 'span[itemprop="name"]'
+      cast_each: { EN: 'span[itemprop="name"]',
+                   ES: 'span[itemprop="name"]'
       },
 
-      :genre => { :EN => 'dt:contains("Genre")',
-                  :ES => 'dt:contains("Género")'
+      genre: { EN: 'dt:contains("Genre")',
+               ES: 'dt:contains("Género")'
       },
 
-      :sinopsis => { :EN => 'dd[itemprop="description"]',
-                      :ES => 'dd[itemprop="description"]'
+      sinopsis: { EN: 'dd[itemprop="description"]',
+                  ES: 'dd[itemprop="description"]'
       },
 
-      :rating => { :EN => 'div[itemprop="ratingValue"]',
-                  :ES => 'div[itemprop="ratingValue"]'
+      rating: { EN: 'div[itemprop="ratingValue"]',
+                ES: 'div[itemprop="ratingValue"]'
       },
 
-      :poster => { :EN => 'img[itemprop="image"]',
-                    :ES => 'img[itemprop="image"]'
+      poster: { EN: 'img[itemprop="image"]',
+                ES: 'img[itemprop="image"]'
       },
 
-      :poster_big => { :EN => 'a[class="lightbox"]',
-                        :ES => 'a[class="lightbox"]'
+      poster_big: { EN: 'a[class="lightbox"]',
+                    ES: 'a[class="lightbox"]'
       }
 
     }
@@ -97,5 +96,4 @@ module Constants
   def self.lang
     FilmAffinity.configuration.language.downcase
   end
-
 end

data/lib/filmaffinity/json-movie-parser.rb

@@ -1,8 +1,7 @@
 require "json"
 
 class JsonMovieParser
-
-  def to_hash movie
+  def to_hash(movie)
     {
       "title" => movie.title,
       "rating" => movie.rating,
@@ -15,7 +14,8 @@ class JsonMovieParser
       "sinopsis" => movie.sinopsis
     }
   end
-  def to_json movie
+
+  def to_json(movie)
     hash = to_hash movie
     hash.to_json
   end

data/lib/filmaffinity/json-movies-parser.rb

@@ -1,6 +1,5 @@
 class JsonMoviesParser
-
-  def to_hashes movies
+  def to_hashes(movies)
     hashes = []
     movies.each do |movie|
       hash = {
@@ -11,9 +10,9 @@ class JsonMoviesParser
     end
     hashes
   end
-  def to_json movies
+
+  def to_json(movies)
     hashes = to_hashes movies
     hashes.to_json
   end
-
 end

data/lib/filmaffinity/movie.rb

@@ -1,8 +1,7 @@
-
 module FilmAffinity
   class Movie
     attr_reader :id, :title
-    def initialize id, title = nil
+    def initialize(id, title = nil)
       @id = id
       @title = title if title
       @json_parser = JsonMovieParser.new
@@ -10,7 +9,7 @@ module FilmAffinity
     end
 
     def document_html
-      @document_html ||= Nokogiri::HTML(self.generate_html)
+      @document_html ||= Nokogiri::HTML(generate_html)
     end
 
     def generate_html
@@ -18,85 +17,79 @@ module FilmAffinity
     end
 
     def title
-      @title ||= document_html.at(Constants.tag(:title)).content.strip
+      @title ||= document_html.at(Constants.tag(:title)).content.strip rescue nil
     end
 
     def year
-      document_html.at(Constants.tag(:year)).content[/\d+/].to_i
+      document_html.at(Constants.tag(:year)).content[/\d+/].to_i rescue nil
     end
 
     def duration
-      document_html.at(Constants.tag(:duration)).content[/\d+/].to_i
+      document_html.at(Constants.tag(:duration)).content[/\d+/].to_i rescue nil
     end
 
     def country
-      raw_country = document_html.at(Constants.tag(:country)).next_sibling.content
-      raw_country.gsub(/\A[[:space:]]+|[[:space:]]+\z/, '')
+      raw_country = document_html.at(Constants.tag(:country)).next_sibling.content rescue nil
+      raw_country.gsub(/\A[[:space:]]+|[[:space:]]+\z/, '') if raw_country
     end
 
     def director
-      raw_director = document_html.at(Constants.tag(:director)).content
-      raw_director.strip
+      raw_director = document_html.at(Constants.tag(:director)).content rescue nil
+      raw_director.strip if raw_director
     end
 
     def music
-      document_html.at(Constants.tag(:music)).next_sibling.next_sibling.content
+      document_html.at(Constants.tag(:music)).next_sibling.next_sibling.content rescue nil
     end
 
     def company
-      document_html.at(Constants.tag(:company)).next_sibling.next_sibling.content
+      document_html.at(Constants.tag(:company)).next_sibling.next_sibling.content rescue nil
     end
 
     def script
-      document_html.at(Constants.tag(:script)).next_sibling.next_sibling.content
+      document_html.at(Constants.tag(:script)).next_sibling.next_sibling.content rescue nil
     end
 
     def photography
-      document_html.at((Constants.tag(:photography))).next_sibling.next_sibling.content
+      document_html.at(Constants.tag(:photography)).next_sibling.next_sibling.content rescue nil
     end
 
     def cast
       actors = []
-      node = document_html.search((Constants.tag(:cast)))
+      node = document_html.search(Constants.tag(:cast)) rescue []
       node.each do |actor|
-        actors << actor.at((Constants.tag(:cast_each))).content.strip
+        actors << actor.at(Constants.tag(:cast_each)).content.strip
       end
       actors
     end
 
     def genres
       genres = []
-      node = document_html.at(Constants.tag(:genre)).next_sibling.next_sibling
+      node = document_html.at(Constants.tag(:genre)).next_sibling.next_sibling rescue []
       raw_genres = node.search("a")
       raw_genres.each do |raw_genre|
         genres << raw_genre.content.strip
       end
       genres
-
     end
 
     def sinopsis
-      document_html.at(Constants.tag(:sinopsis)).content
-    end
-
-
-    def prizes
-
+      document_html.at(Constants.tag(:sinopsis)).content rescue nil
     end
 
     def rating
-      raw_rating = document_html.at(Constants.tag(:rating)).content.strip
-      raw_rating.gsub(",",".").to_f
+      raw_rating = document_html.at(Constants.tag(:rating)).content.strip rescue nil
+      raw_rating.tr(",", ".").to_f if raw_rating
     end
 
     def poster
-      poster_url = document_html.at(Constants.tag(:poster))["src"]
-      @poster_manager.load_poster(poster_url)
+      poster_url = document_html.at(Constants.tag(:poster))["src"] rescue nil
+      @poster_manager.load_poster(poster_url) if poster_url
     end
 
     def poster_big
-      poster_url = document_html.at(Constants.tag(:poster_big))["href"]
-      @poster_manager.load_poster(poster_url)
+      poster_url = document_html.at(Constants.tag(:poster_big))["href"] rescue nil
+      @poster_manager.load_poster(poster_url) if poster_url
     end
 
     def to_json

data/lib/filmaffinity/poster-manager.rb

@@ -1,7 +1,6 @@
 require "open-uri"
 require "imgur"
 
-
 class PosterManager
   def load_poster(posterurl)
     return posterurl unless FilmAffinity.configuration.imgur_id
@@ -19,11 +18,11 @@ class PosterManager
   end
 
   def save_img_locally(posterurl)
-    open(posterurl) {|f|
-      File.open(@dir,"wb") do |file|
+    open(posterurl) do |f|
+      File.open(@dir, "wb") do |file|
         file.puts f.read
       end
-    }
+    end
   end
 
   def construct_name

data/lib/filmaffinity/search.rb

@@ -2,7 +2,7 @@ require "cgi"
 
 module FilmAffinity
   class Search
-    def initialize query
+    def initialize(query)
       @query = query
       @json_parser = JsonMoviesParser.new
     end
@@ -16,7 +16,7 @@ module FilmAffinity
     end
 
     def document_html
-      @document_html ||= Nokogiri::HTML(self.generate_html)
+      @document_html ||= Nokogiri::HTML(generate_html)
     end
 
     def generate_html
@@ -26,7 +26,7 @@ module FilmAffinity
     def parse_movie
       id    = document_html.at('meta[property="og:url"]')['content'][/\d+/].to_i
       title = document_html.at('meta[property="og:title"]')['content']
-      [FilmAffinity::Movie.new(id,title)]
+      [FilmAffinity::Movie.new(id, title)]
     end
 
     def parse_movies
@@ -43,6 +43,5 @@ module FilmAffinity
     def to_json
       @json_parser.to_json movies
     end
-
   end
 end

data/lib/filmaffinity/top.rb

@@ -1,8 +1,6 @@
-
-require "pry"
 module FilmAffinity
   class Top
-    def initialize options: {}, limit: 30
+    def initialize(options: {}, limit: 30)
       @options = options
       @limit = limit
       @json_parser = JsonMoviesParser.new
@@ -12,11 +10,11 @@ module FilmAffinity
       @movies = movies_with_limit
     end
 
-    def document_html from
-      @document_html = Nokogiri::HTML(self.generate_html(from))
+    def document_html(from)
+      @document_html = Nokogiri::HTML(generate_html(from))
     end
 
-    def generate_html from
+    def generate_html(from)
       params = {'from' => from}
       url = URI.parse(Constants.urls[:top] % query_options)
       data = Net::HTTP.post_form(url, params)
@@ -24,12 +22,12 @@ module FilmAffinity
     end
 
     def query_options
-      query_options = String.new
-        query_options += "?"
-        @options.each do |key,value|
-          query_options += Constants.query_params[key] % value
-        end
-      query_options.gsub(/\&$/,"")
+      query_options = ''
+      query_options += "?"
+      @options.each do |key, value|
+        query_options += Constants.query_params[key] % value
+      end
+      query_options.gsub(/\&$/, "")
     end
 
     def movies_with_limit
@@ -39,16 +37,16 @@ module FilmAffinity
       end
     end
 
-    def collect_from collection = [], from = 0, &block
+    def collect_from(collection = [], from = 0, &block)
       response = yield(from)
       collection += response
       last_position = collection.size
-      response.empty? || last_position >= @limit ? collection.flatten[0..@limit-1] : collect_from(collection,last_position,&block)
+      response.empty? || last_position >= @limit ? collection.flatten[0..@limit - 1] : collect_from(collection, last_position, &block)
     end
 
-    def parse_movies document_html
+    def parse_movies(document_html)
       movies = []
-      document_html.search(".movie-card.movie-card-1").each_with_index do |movie_card,index|
+      document_html.search(".movie-card.movie-card-1").each_with_index do |movie_card, _index|
         id = movie_card["data-movie-id"].to_i
         title = movie_card.search(".mc-title a").first.content.strip
         movie = FilmAffinity::Movie.new id, title
@@ -60,6 +58,5 @@ module FilmAffinity
     def to_json
       @json_parser.to_json movies
     end
-
   end
 end

data/spec/filmaffinity/json-movie-parser_spec.rb

@@ -1,15 +1,11 @@
 require_relative "../spec_helper"
 
 describe "JsonMovieParser" do
-
   describe "#to_hash" do
     subject { JsonMovieParser.new }
-
     it "return the right director for the given movie" do
-      hash = subject.to_hash FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)")
+      hash = subject.to_hash FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)")
       expect(hash["director"]).to eq("Peter Weir")
     end
-
   end
-
 end

data/spec/filmaffinity/json-movies-parser_spec.rb

@@ -1,15 +1,11 @@
-require_relative "../spec_helper"
+require_relative '../spec_helper'
 
-describe "JsonMoviesParser" do
-
-  describe "#to_hashes" do
+describe 'JsonMoviesParser' do
+  describe '#to_hashes' do
     subject { JsonMoviesParser.new }
-
-    it "return some valid ids for a given search" do
-      hashes = subject.to_hashes FilmAffinity::Search.new("truman").movies
-      expect(hashes.map {|hash| hash["id"]}).to include(193232, 504889)
+    it 'return some valid ids for a given search' do
+      hashes = subject.to_hashes FilmAffinity::Search.new('truman').movies
+      expect(hashes.map { |hash| hash['id'] }).to include(193_232, 504_889)
     end
-
   end
-
 end

data/spec/filmaffinity/movie_spec.rb

@@ -3,21 +3,21 @@ require_relative "../spec_helper"
 describe "FilmAffinity::Movie" do
   context "english version" do
     describe "#title" do
-      subject(:movie) { FilmAffinity::Movie.new(504889) }
+      subject(:movie) { FilmAffinity::Movie.new(504_889) }
       it "should return an valid title when initializes with no title" do
         expect(movie.title).to eq("The Truman Show")
       end
     end
 
     describe "#rating" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Float" do
         expect(movie.rating).to be_a(Float)
       end
     end
 
     describe "#year" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Fixnum" do
         expect(movie.year).to be_an(Fixnum)
       end
@@ -27,7 +27,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#duration" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Fixnum" do
         expect(movie.duration).to be_a(Fixnum)
       end
@@ -37,7 +37,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#country" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.country).to be_a(String)
       end
@@ -47,7 +47,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#director" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.director).to be_a(String)
       end
@@ -57,7 +57,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#script" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.script).to be_a(String)
       end
@@ -67,7 +67,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#cast" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Array" do
         expect(movie.cast).to be_an(Array)
       end
@@ -83,7 +83,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#company" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.company).to be_a(String)
       end
@@ -93,7 +93,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#genres" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Array" do
         expect(movie.genres).to be_an(Array)
       end
@@ -108,7 +108,7 @@ describe "FilmAffinity::Movie" do
     end
 
     describe "#poster" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.poster).to be_a(String)
       end
@@ -118,7 +118,7 @@ describe "FilmAffinity::Movie" do
     end
   end
 
-context "spanish version" do
+  context "spanish version" do
     before :all do
       FilmAffinity.configure do |config|
         config.language = "ES"
@@ -126,21 +126,21 @@ context "spanish version" do
     end
 
     describe "#title" do
-      subject(:movie) { FilmAffinity::Movie.new(504889) }
+      subject(:movie) { FilmAffinity::Movie.new(504_889) }
       it "should return an valid title when initializes with no title" do
         expect(movie.title).to eq("El show de Truman (Una vida en directo)")
       end
     end
 
     describe "#rating" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Float" do
         expect(movie.rating).to be_a(Float)
       end
     end
 
     describe "#year" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Fixnum" do
         expect(movie.year).to be_an(Fixnum)
       end
@@ -150,7 +150,7 @@ context "spanish version" do
     end
 
     describe "#duration" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Fixnum" do
         expect(movie.duration).to be_a(Fixnum)
       end
@@ -160,7 +160,7 @@ context "spanish version" do
     end
 
     describe "#country" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.country).to be_a(String)
       end
@@ -170,7 +170,7 @@ context "spanish version" do
     end
 
     describe "#director" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.director).to be_a(String)
       end
@@ -180,7 +180,7 @@ context "spanish version" do
     end
 
     describe "#script" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.script).to be_a(String)
       end
@@ -190,7 +190,7 @@ context "spanish version" do
     end
 
     describe "#cast" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Array" do
         expect(movie.cast).to be_an(Array)
       end
@@ -206,7 +206,7 @@ context "spanish version" do
     end
 
     describe "#company" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.company).to be_a(String)
       end
@@ -216,7 +216,7 @@ context "spanish version" do
     end
 
     describe "#genres" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return an Array" do
         expect(movie.genres).to be_an(Array)
       end
@@ -231,7 +231,7 @@ context "spanish version" do
     end
 
     describe "#poster" do
-      subject(:movie) { FilmAffinity::Movie.new(504889, "El show de Truman (Una vida en directo)") }
+      subject(:movie) { FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)") }
       it "should return a String" do
         expect(movie.poster).to be_a(String)
       end

data/spec/filmaffinity/search_spec.rb

@@ -1,9 +1,7 @@
 require_relative "../spec_helper"
 require_relative "matchers/include-movie"
 
-
 describe "FilmAffinity::Search" do
-
   describe "#create_document_html" do
     subject(:search) { FilmAffinity::Search.new("truman") }
 
@@ -11,7 +9,6 @@ describe "FilmAffinity::Search" do
       document_html = search.document_html
       expect(document_html).to be_an(Nokogiri::HTML::Document)
     end
-
   end
 
   describe "#movies" do
@@ -27,17 +24,17 @@ describe "FilmAffinity::Search" do
     end
     it "should include 'Truman Show'" do
       movies = search.movies
-      truman_movie = FilmAffinity::Movie.new 504889, "El show de Truman (Una vida en directo)"
+      truman_movie = FilmAffinity::Movie.new(504_889, "El show de Truman (Una vida en directo)")
       expect(movies).to include_movie(truman_movie)
     end
   end
 
   describe "#parse_movie" do
-    #Get a direct result from a specific searchs
+    # Get a direct result from a specific searchs
     subject(:search) { FilmAffinity::Search.new("truman show") }
 
     it "should parse id" do
-      id = 504889
+      id = 504_889
       expect(id).to eq(search.movies.first.id)
     end
 
@@ -45,6 +42,5 @@ describe "FilmAffinity::Search" do
       title = "El show de Truman (Una vida en directo)  (1998)"
       expect(title).to eq(search.movies.first.title)
     end
-
   end
 end

data/spec/filmaffinity/top_spec.rb

@@ -2,7 +2,6 @@ require_relative "../spec_helper"
 require "pry"
 
 describe "FilmAffinity::Top" do
-
   describe "#create_document_html" do
     subject(:top) { FilmAffinity::Top.new }
 
@@ -10,85 +9,82 @@ describe "FilmAffinity::Top" do
       document_html = top.document_html 0
       expect(document_html).to respond_to(:search)
     end
-
   end
 
   describe "#movies" do
-      context "no options" do
-        subject(:top) { FilmAffinity::Top.new }
-        it "should return an array" do
-          movies = top.movies
-          expect(movies).to be_an(Array)
-        end
-        it "should return just FilmAffinity::Movie objects only" do
-          movies = top.movies
-          movies.each { |movie| expect(movie).to be_an(FilmAffinity::Movie) }
-        end
-        it "should include 'El Padrino'" do
-          movies = top.movies
-          el_padrino_movie = FilmAffinity::Movie.new 809297, "El padrino"
-          expect(movies).to include_movie(el_padrino_movie)
-        end
-        it "should return 30 movies" do
-          movies = top.movies
-          expect(movies.size).to eq(30)
-        end
+    context "no options" do
+      subject(:top) { FilmAffinity::Top.new }
+      it "should return an array" do
+        movies = top.movies
+        expect(movies).to be_an(Array)
       end
-      context "with options" do
-        options = {
-          :genre => "BE",
-          :country => "DE"
-        }
-        subject(:top) { FilmAffinity::Top.new options:options }
-        it "should return an array" do
-          movies = top.movies
-          expect(movies).to be_an(Array)
-        end
-        it "should return just FilmAffinity::Movie objects only" do
-          movies = top.movies
-          movies.each { |movie| expect(movie).to be_an(FilmAffinity::Movie) }
-        end
-        it "should include 'Hijos del Tercer Reich (TV)'" do
-          movies = top.movies
-          hijos_del_tercer_reich_movie = FilmAffinity::Movie.new 831118, "Hijos del Tercer Reich (TV)"
-          expect(movies).to include_movie(hijos_del_tercer_reich_movie)
-        end
-
+      it "should return just FilmAffinity::Movie objects only" do
+        movies = top.movies
+        movies.each { |movie| expect(movie).to be_an(FilmAffinity::Movie) }
+      end
+      it "should include 'El Padrino'" do
+        movies = top.movies
+        el_padrino_movie = FilmAffinity::Movie.new(809_297, "El padrino")
+        expect(movies).to include_movie(el_padrino_movie)
       end
-      context "with limit 60" do
-        limit = 60
-        subject(:top) { FilmAffinity::Top.new limit:limit }
-        it "should include 'American History X'" do
-          movies = top.movies
-          american_history_x = FilmAffinity::Movie.new 261972, "American History X"
-          expect(movies).to include_movie(american_history_x)
-        end
-        it "should NOT include 'Con la muerte en los talones'" do
-          movies = top.movies
-          con_la_muerte_en_los_talones = FilmAffinity::Movie.new 351704, "Con la muerte en los talones"
-          expect(movies).not_to include_movie(con_la_muerte_en_los_talones)
-        end
-        it "should return 60 movies" do
-          movies = top.movies
-          expect(movies.size).to eq(60)
-        end
+      it "should return 30 movies" do
+        movies = top.movies
+        expect(movies.size).to eq(30)
       end
-      context "with limit 132" do
-        limit = 132
-        subject(:top) { FilmAffinity::Top.new limit:limit }
-        it "should return 132 movies" do
-          movies = top.movies
-          expect(movies.size).to eq(132)
-        end
+    end
+    context "with options" do
+      options = {
+        genre: "BE",
+        country: "DE"
+      }
+      subject(:top) { FilmAffinity::Top.new options: options }
+      it "should return an array" do
+        movies = top.movies
+        expect(movies).to be_an(Array)
+      end
+      it "should return just FilmAffinity::Movie objects only" do
+        movies = top.movies
+        movies.each { |movie| expect(movie).to be_an(FilmAffinity::Movie) }
       end
-      context "with limit 10" do
-        limit = 10
-        subject(:top) { FilmAffinity::Top.new limit:limit }
-        it "should return 10 movies" do
-          movies = top.movies
-          expect(movies.size).to eq(10)
-        end
+      it "should include 'Hijos del Tercer Reich (TV)'" do
+        movies = top.movies
+        hijos_del_tercer_reich_movie = FilmAffinity::Movie.new(831_118, "Hijos del Tercer Reich (TV)")
+        expect(movies).to include_movie(hijos_del_tercer_reich_movie)
       end
     end
-
+    context "with limit 60" do
+      limit = 60
+      subject(:top) { FilmAffinity::Top.new limit: limit }
+      it "should include 'American History X'" do
+        movies = top.movies
+        american_history_x = FilmAffinity::Movie.new(261_972, "American History X")
+        expect(movies).to include_movie(american_history_x)
+      end
+      it "should NOT include 'Con la muerte en los talones'" do
+        movies = top.movies
+        con_la_muerte_en_los_talones = FilmAffinity::Movie.new(351_704, "Con la muerte en los talones")
+        expect(movies).not_to include_movie(con_la_muerte_en_los_talones)
+      end
+      it "should return 60 movies" do
+        movies = top.movies
+        expect(movies.size).to eq(60)
+      end
+    end
+    context "with limit 132" do
+      limit = 132
+      subject(:top) { FilmAffinity::Top.new limit: limit }
+      it "should return 132 movies" do
+        movies = top.movies
+        expect(movies.size).to eq(132)
+      end
+    end
+    context "with limit 10" do
+      limit = 10
+      subject(:top) { FilmAffinity::Top.new limit: limit }
+      it "should return 10 movies" do
+        movies = top.movies
+        expect(movies.size).to eq(10)
+      end
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: filmaffinity
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - David Santos
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-04-18 00:00:00.000000000 Z
+date: 2016-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -88,6 +88,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - Gemfile
 - Gemfile.lock
 - README.md