film_snob 0.6.5 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8cf290744ac7770ce7b8d8f0ebdde751b4428557
-  data.tar.gz: 0df2231616cbd058bea30b5480708f1c795e1d83
+  metadata.gz: f456c757ffe9c535c907220ae5774ddbd4506bba
+  data.tar.gz: 6f91fc2d8849c61775aea6259aafa36e2c01d28b
 SHA512:
-  metadata.gz: 56540292bb66647af0749970dd8a9e28b6a09de560e3b1f7d8365f68c3ae613e48aa95d8fcf6b0bda984a5c0de7c7464ae7aa2faec3451e81a155324480498fe
-  data.tar.gz: 5d132d9626ea0fe6852938748ba813539fdbd5626e5513f13d24d0e2a7dac1d4cc7b6b30868d75be63da772468a180bc1eed76ba6b8b3770a7efe14fbfbf0ad8
+  metadata.gz: f034c43b8fd9e49fd3d923e60085d8b502f17ad30178999bfdf66fb4ed63da9570a29209c5b252d17964d0bcf938a87516b98cada9055a8132fd3a75fe0841a3
+  data.tar.gz: aaec57f2af26a92fb192969cee667b4eb4a42c0666b9b860dc4847a7832174f160296dfc01450fdc7078725a1e60adab2997d2889453a4caaf3bf2ca9de70b5c

data/.rspec

@@ -1,2 +1,3 @@
 --color
 --require spec_helper
+--format documentation

data/.travis.yml

@@ -1,6 +1,7 @@
+sudo: false
+cache: bundler
 language: ruby
 rvm:
-  - 1.9.3
   - 2.0.0
   - 2.1.0
   - 2.1.1
@@ -8,11 +9,23 @@ rvm:
   - 2.1.3
   - 2.1.4
   - 2.1.5
+  - 2.1.6
+  - 2.1.7
   - 2.2.0
   - 2.2.1
   - 2.2.2
-before_install: "gem install bundler -v 1.10"
+  - 2.2.3
+  - ruby-head
+  - jruby-19mode
+  - jruby-9.0.1.0
+  - rbx-2
+matrix:
+  fast_finish: true
+  allow_failures:
+    - rvm: ruby-head
+    - rvm: jruby-19mode
+    - rvm: jruby-9.0.1.0
+    - rvm: rbx-2
+before_install: 'gem install bundler -v 1.10.6'
 script:
   - bundle exec rake ci
-sudo: false
-cache: bundler

data/CHANGELOG.md

@@ -0,0 +1,19 @@
+# Change log
+
+## 1.0.0 (2015-11-14)
+
+### New features
+
+* support for Rdio Urls
+
+### changes
+
+* dropped support for Ruby 1.9.3
+* removed the `FilmSnob#watchable?` method in favor of `embeddable?`
+* renamed a bunch of internal things that were all about videos, to reflect that
+  some of the sites like soundcloud and isntagram aren't really about videos
+* no longer rescuing all errors when making the request
+
+## Earlier
+
+Added a bunch of stuff!

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,13 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, or religion.
+
+Examples of unacceptable behavior by participants include the use of sexual language or imagery, derogatory comments or personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. Project maintainers who do not follow the Code of Conduct may be removed from the project team.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
+
+This Code of Conduct is adapted from the [Contributor Covenant](http://contributor-covenant.org), version 1.0.0, available at [http://contributor-covenant.org/version/1/0/0/](http://contributor-covenant.org/version/1/0/0/)

data/Gemfile

@@ -1,4 +1,19 @@
 source "https://rubygems.org"
 
+gem "rake", "~> 10.4"
+
+gem "pry", "~> 0.10"
+gem "rubocop", "~> 0.35"
+gem "todo_lint", "~> 0.2"
+gem "rspec", "~> 3.4"
+gem "webmock", "~> 1.22"
+gem "vcr", "~> 2.9"
+gem "codeclimate-test-reporter", "~> 0.4"
+
+# TDD workflow
+gem "guard"
+gem "guard-rspec"
+gem "guard-rubocop"
+
 # Specify your gem's dependencies in film_snob.gemspec
 gemspec

data/Guardfile

@@ -0,0 +1,13 @@
+# This group allows to skip running RuboCop when RSpec failed.
+group :red_green_refactor, :halt_on_fail => true do
+  guard :rspec, :cmd => "bundle exec rspec --fail-fast" do
+    # run a spec when editing it
+    watch(%r{^spec/.+_spec\.rb$})
+
+    watch(%r{^lib/(.+)\.rb$}) { |m| "spec/#{m[1]}_spec.rb" }
+  end
+  guard :rubocop, :all_on_start => false do
+    watch(/.+\.rb$/)
+    watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
+  end
+end

data/README.md

@@ -5,7 +5,8 @@
 [![Code Climate](https://codeclimate.com/github/maxjacobson/film_snob.png)](https://codeclimate.com/github/maxjacobson/film_snob)
 [![Test Coverage](https://codeclimate.com/github/maxjacobson/film_snob/badges/coverage.svg)](https://codeclimate.com/github/maxjacobson/film_snob)
 
-Helps parse URLs of web videos.
+Lookup things like titles and HTML embed codes for web media like videos,
+pictures, and songs.
 
 ## Installation
 
@@ -40,7 +41,28 @@ film.title #=> "Garann Means - Bacon is bad for you"
 film.html  #=> "<iframe src=\"//player.vimeo.com/video/64683454\" width=\"720\" height=\"405\" frameborder=\"0\" title=\"Garann Means - Bacon is bad for you\" webkitallowfullscreen mozallowfullscreen allowfullscreen></iframe>"
 ```
 
-film_snob uses the oembed protocol to get html for embed codes. These options assume some knowledge of the endpoint's API. The above vimeo example works because they [have an extensively documented API](http://developer.vimeo.com/apis/oembed) which allows tons of configuration. The other two don't seem to have any documentation or configuration at all.
+film_snob uses the oembed protocol to get html for embed codes. These options
+assume some knowledge of the endpoint's API. The above vimeo example works
+because they [have an extensively documented API][vimeo] which allows tons of
+configuration. The other two don't seem to have any documentation or
+configuration at all.
+
+[vimeo]: http://developer.vimeo.com/apis/oembed
+
+### Performance
+
+The interface described above is nice for unknown URLs because you can use
+film_snob to check if a URL should be embeddable, and then if it should be, you
+can ask it for the HTML.
+
+If you know for sure that a URL ought to be a YouTube video, it will be faster
+to use an interface like this one:
+
+```ruby
+film = FilmSnob::YouTube.new("https://www.youtube.com/watch?v=st21dIMaGMs")
+film.title #=> "Key & Peele - Continental Breakfast"
+film.html #=> "<iframe width=\"480\" height=\"270\" src=\"https://www.youtube.com/embed/st21dIMaGMs?feature=oembed\" frameborder=\"0\" allowfullscreen></iframe>"
+```
 
 ## Supported Sites
 
@@ -54,32 +76,49 @@ film_snob uses the oembed protocol to get html for embed codes. These options as
 * Vine
 * Rutube
 * Soundcloud
+* Rdio
 
 The same methods work with all of these providers.
 
 ## Testing
 
-Run `rake spec` to run all of the tests.
+Run `bundle exec rake spec` to run all of the tests.
+
+If you like TDD, you might want to run `bundle exec guard` instead, which will
+listen for your changes and auto-run your tests when you save them or the
+related files.
 
 ## Code Style
 
-Run `rake style` to confirm the codebase is looking stylish.
+Run `bundle exec rake style` to confirm the codebase is looking stylish.
 
 ## Continous Integration
 
-Run `rake ci` to run both the tests and the style checks, which will be run on Travis; both should pass to have a green build.
+Run `bundle exec rake ci` to run both the tests and the style checks, which
+will be run on Travis; both should pass to have a green build.
 
 ## Questions?
 
 [![Gitter](https://badges.gitter.im/Join Chat.svg)](https://gitter.im/maxjacobson/film_snob?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
-Ping me in [the Gitter chat room](https://gitter.im/maxjacobson/film_snob) or [create a GitHub issue](https://github.com/maxjacobson/film_snob/issues/new)
+Ping me in [the Gitter chat room](https://gitter.im/maxjacobson/film_snob) or
+[create a GitHub issue](https://github.com/maxjacobson/film_snob/issues/new)
 
 ## Contributing
 
-1. Fork it ( https://github.com/maxjacobson/film_snob/fork )
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am "Add some feature"`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create a new Pull Request
+Bug reports and pull requests are welcome on GitHub at
+<https://github.com/maxjacobson/smashcut>. This project is intended to be a
+safe, welcoming space for collaboration, and contributors are expected to
+adhere to the [Contributor Covenant](http://contributor-covenant.org) code of
+conduct.
+
+## Releasing a new version
+
+* change the version in `version.rb`.
+* describe what changed in `CHANGELOG.md`
+* commit the change
+* run `bundle exec rake release` to create a git tag, push the code to github,
+  and push the release to rubygems
+* describe the release on [the releases page][]
 
+[the releases page]: https://github.com/maxjacobson/film_snob/releases

data/Rakefile

@@ -1,16 +1,13 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 require "rubocop/rake_task"
+require "todo_lint"
 
 RSpec::Core::RakeTask.new(:spec)
 RuboCop::RakeTask.new(:style)
 
 task :todos do
-  # This tool requires keyword arguments
-  if RUBY_VERSION >= "2.0.0"
-    require "todo_lint"
-    TodoLint::Cli.new([]).run!
-  end
+  TodoLint::Cli.new([]).run!
 end
 
 task :ci => [:spec, :style, :todos]

data/film_snob.gemspec

@@ -4,29 +4,21 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "film_snob/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = "film_snob"
-  spec.version       = FilmSnob::VERSION
-  spec.authors       = ["Max Jacobson"]
-  spec.email         = ["max@hardscrabble.net"]
-  spec.summary       = "Fetch embed codes for videos"
-  spec.description   = "Find information about URLs from video sites, " \
-                       "such as the title and embed code of the video"
-  spec.homepage      = "https://github.com/maxjacobson/film_snob"
-  spec.license       = "MIT"
+  spec.name = "film_snob"
+  spec.version = FilmSnob::VERSION
+  spec.authors = ["Max Jacobson"]
+  spec.email = ["max@hardscrabble.net"]
+  spec.summary = "Fetch data from oEmbed APIs"
+  spec.description = "Lookup things like titles and HTML embed codes for web " \
+                     "media like videos, pictures, and songs."
+  spec.homepage = "https://github.com/maxjacobson/film_snob"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
+  spec.files = `git ls-files -z`.split("\x0")
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler",  "~> 1.10"
-  spec.add_development_dependency "rake",     "~> 10.4"
-  spec.add_development_dependency "rspec",    "~> 3.3"
-  spec.add_development_dependency "webmock",  "~> 1.21"
-  spec.add_development_dependency "vcr",      "~> 2.9"
-  spec.add_development_dependency "pry",      "~> 0.10"
-  spec.add_development_dependency "rubocop",  "~> 0.32.1"
-  spec.add_development_dependency "todo_lint", "~> 0.2"
-  spec.add_development_dependency "codeclimate-test-reporter", "~> 0.4"
-  spec.required_ruby_version = ">= 1.9.3"
+  spec.add_development_dependency "bundler", "~> 1.10"
+  spec.required_ruby_version = ">= 2.0.0"
 end

data/lib/film_snob.rb

@@ -1,35 +1,31 @@
 require "forwardable"
 require "film_snob/version"
-require "film_snob/url_to_video"
+require "film_snob/url_to_oembed_provider"
 require "film_snob/exceptions"
-require "film_snob/deprecated"
 
 class FilmSnob
-  extend Deprecated, Forwardable
+  extend Forwardable
 
-  VIDEO_METHODS = [:site, :id, :clean_url, :title, :html]
+  MEDIA_METHODS = [:site, :id, :clean_url, :title, :html]
 
-  def_delegators :video, *VIDEO_METHODS
-
-  # TODO(2015-11-15): actually remove this method
-  deprecated_alias :watchable?, :embeddable?, :removed_in => "v1.0.0"
+  def_delegators :media, *MEDIA_METHODS
 
   attr_reader :url
 
   def initialize(url, options = {})
     @url = url
-    @video = UrlToVideo.new(url, options).video
+    @media = UrlToOembedProvider.new(url, options).media
   end
 
   def embeddable?
-    !@video.nil?
+    !@media.nil?
   end
 
   private
 
-  def video
+  def media
     if embeddable?
-      @video
+      @media
     else
       raise NotSupportedURLError, "#{url} is not a supported URL"
     end

data/lib/film_snob/exceptions.rb

@@ -1,4 +1,7 @@
 class FilmSnob
-  class NotSupportedURLError < StandardError; end
-  class NotEmbeddableError < StandardError; end
+  # all FilmSnob errors can be rescued in one go by rescuing this one
+  class FilmSnobError < StandardError; end
+
+  class NotSupportedURLError < FilmSnobError; end
+  class NotEmbeddableError < FilmSnobError; end
 end

data/lib/film_snob/{video_site.rb → oembed_provider.rb}

@@ -2,13 +2,13 @@ require "net/http"
 require "json"
 
 class FilmSnob
-  # TODO(2015-11-15): rename to something more general
-  # we're using this for things like Instagram
-  class VideoSite
+  class OembedProvider
     attr_reader :url, :options
+
     def initialize(url, options = {})
       @url = url
-      @options = options
+      @options = friendly_options(options)
+      ensure_match unless options.delete(:matched)
     end
 
     def id
@@ -69,19 +69,23 @@ class FilmSnob
     end
 
     def matching_pattern
-      self.class.valid_url_patterns.find do |pattern|
+      @matching_pattern ||= self.class.valid_url_patterns.find do |pattern|
         pattern.match(url)
       end
     end
 
     def oembed
-      @oembed ||= JSON.parse response.body
-    rescue
-      @oembed = {}
+      @oembed ||= begin
+                    if response.code.start_with?("2")
+                      JSON.parse(response.body)
+                    else
+                      {}
+                    end
+                  end
     end
 
     def response
-      self.class.http.request get
+      @response ||= self.class.http.request get
     end
 
     def get
@@ -93,5 +97,17 @@ class FilmSnob
         uri.query = URI.encode_www_form({ :url => clean_url }.merge(options))
       end
     end
+
+    def ensure_match
+      return unless matching_pattern.nil?
+      raise NotSupportedURLError, "#{self.class} can not handle #{url.inspect}"
+    end
+
+    # a subclass can override this one to define some aliases to paper over some
+    # quirks in a specific oembed provider's API, e.g. mapping "width" to
+    # "maxwidth"
+    def friendly_options(options)
+      options
+    end
   end
 end

data/lib/film_snob/{video_sites → oembed_providers}/coub.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Coub < VideoSite
+  class Coub < OembedProvider
     def self.valid_url_patterns
       [
         %r{https?://coub.com/view/(\w*)}

data/lib/film_snob/{video_sites → oembed_providers}/dailymotion.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Dailymotion < VideoSite
+  class Dailymotion < OembedProvider
     def self.valid_url_patterns
       [
         %r{https?://www.dailymotion.com/video/([\w\d\-_]+)},

data/lib/film_snob/{video_sites → oembed_providers}/funny_or_die.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class FunnyOrDie < VideoSite
+  class FunnyOrDie < OembedProvider
     def self.valid_url_patterns
       [
         %r{http://www.funnyordie.com/videos/([\w\d]+)}

data/lib/film_snob/{video_sites → oembed_providers}/hulu.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Hulu < VideoSite
+  class Hulu < OembedProvider
     def self.valid_url_patterns
       [
         %r{https?://(?:(?:www).)?hulu.com/watch/(\d+)}

data/lib/film_snob/{video_sites → oembed_providers}/instagram.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Instagram < VideoSite
+  class Instagram < OembedProvider
     def self.valid_url_patterns
       [
         %r{https?://(?:(?:www).)?instagram.com/p/(\w+)},

data/lib/film_snob/oembed_providers/rdio.rb

@@ -0,0 +1,20 @@
+require "film_snob/oembed_provider"
+
+class FilmSnob
+  class Rdio < OembedProvider
+    def self.valid_url_patterns
+      [
+        %r{http?://www.rdio.com/artist/(?:[\w\d\-_]+/album/)}
+      ]
+    end
+
+    # in this case, we're trusting Rdio to clean up the URL
+    def clean_url
+      @clean_url = url
+    end
+
+    def self.oembed_endpoint
+      "http://www.rdio.com/api/oembed/"
+    end
+  end
+end

data/lib/film_snob/{video_sites → oembed_providers}/rutube.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Rutube < VideoSite
+  class Rutube < OembedProvider
     def initialize(url, options = {})
       super(url, options.merge(:format => :json))
     end

data/lib/film_snob/{video_sites → oembed_providers}/soundcloud.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Soundcloud < VideoSite
+  class Soundcloud < OembedProvider
     def initialize(url, options = {})
       super(url, options.merge(:format => :json))
     end

data/lib/film_snob/{video_sites → oembed_providers}/vimeo.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Vimeo < VideoSite
+  class Vimeo < OembedProvider
     def self.valid_url_patterns
       [
         %r{https?://vimeo.com/(\d{1,})},

data/lib/film_snob/{video_sites → oembed_providers}/vine.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class Vine < VideoSite
+  class Vine < OembedProvider
     def self.valid_url_patterns
       [
         %r{https://vine.co/v/(\w+)}

data/lib/film_snob/{video_sites → oembed_providers}/youtube.rb

@@ -1,7 +1,7 @@
-require "film_snob/video_site"
+require "film_snob/oembed_provider"
 
 class FilmSnob
-  class YouTube < VideoSite
+  class YouTube < OembedProvider
     def self.valid_url_patterns
       [
         %r{
@@ -20,5 +20,14 @@ class FilmSnob
     def clean_url
       @clean_url ||= "https://www.youtube.com/watch?v=#{id}"
     end
+
+    private
+
+    def friendly_options(options)
+      if (width = options.delete(:width) || options.delete("width"))
+        options[:maxwidth] = width
+      end
+      options
+    end
   end
 end

data/lib/film_snob/{url_to_video.rb → url_to_oembed_provider.rb}

@@ -1,9 +1,10 @@
-Dir[File.join(File.dirname(__FILE__), "video_sites", "*.rb")].each do |file|
-  require file
+path_to_providers = File.join(File.dirname(__FILE__), "oembed_providers")
+Dir.entries(path_to_providers).each do |file|
+  require "film_snob/oembed_providers/#{file}" unless [".", ".."].include?(file)
 end
 
 class FilmSnob
-  class UrlToVideo
+  class UrlToOembedProvider
     attr_reader :url, :options
 
     def initialize(url, options)
@@ -11,14 +12,14 @@ class FilmSnob
       @options = options
     end
 
-    def video
+    def media
       site.nil? ? nil : site.new(url, options)
     end
 
     private
 
     def site
-      @site ||= VideoSite.subclasses.find do |site|
+      @site ||= OembedProvider.subclasses.find do |site|
         site.valid_url_patterns.any? do |pattern|
           pattern.match(url)
         end

data/lib/film_snob/version.rb

@@ -1,3 +1,3 @@
 class FilmSnob
-  VERSION = "0.6.5"
+  VERSION = "1.0.0"
 end

data/spec/film_snob/oembed_provider_spec.rb

@@ -0,0 +1,27 @@
+# this is a generic parent class for sharing code
+describe FilmSnob::OembedProvider do
+  describe "initialization" do
+    let(:film) { FilmSnob::YouTube.new(url, options) }
+
+    context "when you assure it the URL is a good match" do
+      let(:url) { "https://www.youtube.com/watch?v=st21dIMaGMs" }
+      let(:options) { { :matched => true } }
+
+      it "can look up the title, but the URL better be related to this site" do
+        VCR.use_cassette "youtube/continental breakfast" do
+          expect(film.title).to include "Continental Breakfast"
+        end
+      end
+    end
+
+    context "when you do not assure it the URL is a good match" do
+      let(:url) { "this just is not a YouTube URL" }
+      let(:options) { {} }
+
+      it "will yell at you" do
+        expect { film.title }.to raise_error(FilmSnob::NotSupportedURLError,
+                                             /can not handle/)
+      end
+    end
+  end
+end

data/spec/film_snob/oembed_providers/rdio_spec.rb

@@ -0,0 +1,38 @@
+describe FilmSnob::Rdio do
+  describe "rdio URLs" do
+    let(:url) { "http://www.rdio.com/#{path}" }
+
+    context "when the URL is an album" do
+      let(:path) { "artist/Sam_Smith/album/In_The_Lonely_Hour/" }
+
+      it "should parse" do
+        snob = FilmSnob.new(url)
+        expect(snob).to be_embeddable
+        expect(snob.site).to eq :rdio
+        VCR.use_cassette("rdio/in the lonely hour") do
+          expect(snob.title).to eq "In The Lonely Hour"
+          expect(snob.html).to include "iframe"
+        end
+      end
+    end
+
+    context "a song" do
+      let(:path) do
+        "artist/Sam_Smith/album/In_The_Lonely_Hour/track/Stay_With_Me"
+      end
+      it "should parse normal track rdio URLs" do
+        snob = FilmSnob.new(url)
+        expect(snob).to be_embeddable
+        expect(snob.site).to eq :rdio
+        VCR.use_cassette("rdio/stay with me") do
+          expect(snob.title).to eq "Stay With Me"
+        end
+      end
+    end
+
+    it "should not allow weak matches for rdio urls" do
+      snob = FilmSnob.new("google.com/q=rdio")
+      expect(snob).to_not be_embeddable
+    end
+  end
+end

data/spec/film_snob/{video_sites → oembed_providers}/youtube_spec.rb

@@ -85,4 +85,22 @@ describe FilmSnob::YouTube do
     expect(snob.site).to eq :youtube
     expect(snob.clean_url).to eq "https://www.youtube.com/watch?v=sLSFOCyNC8Q"
   end
+
+  it "should allow specifying the width of the video" do
+    film = FilmSnob.new("https://www.youtube.com/watch?v=ky9Ro9pP2gc",
+                        :maxwidth => 350)
+    VCR.use_cassette "youtube/joanna1" do
+      expect(film.title).to include "Joanna"
+      expect(film.html).to include "350"
+    end
+  end
+
+  it "should allow specifying the width of the video via width option" do
+    film = FilmSnob.new("https://www.youtube.com/watch?v=ky9Ro9pP2gc",
+                        :width => 350)
+    VCR.use_cassette "youtube/joanna2" do
+      expect(film.title).to include "Joanna"
+      expect(film.html).to include "350"
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -13,8 +13,6 @@ VCR.configure do |c|
 end
 
 RSpec.configure do |config|
-  config.default_formatter = "doc" if config.files_to_run.one?
-
   config.order = :random
 
   config.expect_with :rspec do |expectations|
@@ -26,4 +24,8 @@ RSpec.configure do |config|
   config.mock_with :rspec do |mocks|
     mocks.verify_partial_doubles = true
   end
+
+  # allow to focus on one thing at a time if you like, by adding the focus tag
+  config.filter_run_including :focus => true
+  config.run_all_when_everything_filtered = true
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: film_snob
 version: !ruby/object:Gem::Version
-  version: 0.6.5
+  version: 1.0.0
 platform: ruby
 authors:
 - Max Jacobson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-14 00:00:00.000000000 Z
+date: 2015-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -24,120 +24,8 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.4'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.3'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.21'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.21'
-- !ruby/object:Gem::Dependency
-  name: vcr
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.9'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.9'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.10'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.32.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.32.1
-- !ruby/object:Gem::Dependency
-  name: todo_lint
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-- !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-description: Find information about URLs from video sites, such as the title and embed
-  code of the video
+description: Lookup things like titles and HTML embed codes for web media like videos,
+  pictures, and songs.
 email:
 - max@hardscrabble.net
 executables: []
@@ -149,39 +37,43 @@ files:
 - ".rubocop.yml"
 - ".todo_lint.yml"
 - ".travis.yml"
+- CHANGELOG.md
+- CODE_OF_CONDUCT.md
 - Gemfile
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - film_snob.gemspec
 - lib/film_snob.rb
-- lib/film_snob/deprecated.rb
 - lib/film_snob/exceptions.rb
-- lib/film_snob/url_to_video.rb
+- lib/film_snob/oembed_provider.rb
+- lib/film_snob/oembed_providers/coub.rb
+- lib/film_snob/oembed_providers/dailymotion.rb
+- lib/film_snob/oembed_providers/funny_or_die.rb
+- lib/film_snob/oembed_providers/hulu.rb
+- lib/film_snob/oembed_providers/instagram.rb
+- lib/film_snob/oembed_providers/rdio.rb
+- lib/film_snob/oembed_providers/rutube.rb
+- lib/film_snob/oembed_providers/soundcloud.rb
+- lib/film_snob/oembed_providers/vimeo.rb
+- lib/film_snob/oembed_providers/vine.rb
+- lib/film_snob/oembed_providers/youtube.rb
+- lib/film_snob/url_to_oembed_provider.rb
 - lib/film_snob/version.rb
-- lib/film_snob/video_site.rb
-- lib/film_snob/video_sites/coub.rb
-- lib/film_snob/video_sites/dailymotion.rb
-- lib/film_snob/video_sites/funny_or_die.rb
-- lib/film_snob/video_sites/hulu.rb
-- lib/film_snob/video_sites/instagram.rb
-- lib/film_snob/video_sites/rutube.rb
-- lib/film_snob/video_sites/soundcloud.rb
-- lib/film_snob/video_sites/vimeo.rb
-- lib/film_snob/video_sites/vine.rb
-- lib/film_snob/video_sites/youtube.rb
 - spec/cassettes/README.md
-- spec/deprecated_spec.rb
-- spec/film_snob/video_sites/coub_spec.rb
-- spec/film_snob/video_sites/dailymotion_spec.rb
-- spec/film_snob/video_sites/funny_or_die_spec.rb
-- spec/film_snob/video_sites/hulu_spec.rb
-- spec/film_snob/video_sites/instagram_spec.rb
-- spec/film_snob/video_sites/rutube_spec.rb
-- spec/film_snob/video_sites/soundcloud_spec.rb
-- spec/film_snob/video_sites/vimeo_spec.rb
-- spec/film_snob/video_sites/vine_spec.rb
-- spec/film_snob/video_sites/youtube_spec.rb
+- spec/film_snob/oembed_provider_spec.rb
+- spec/film_snob/oembed_providers/coub_spec.rb
+- spec/film_snob/oembed_providers/dailymotion_spec.rb
+- spec/film_snob/oembed_providers/funny_or_die_spec.rb
+- spec/film_snob/oembed_providers/hulu_spec.rb
+- spec/film_snob/oembed_providers/instagram_spec.rb
+- spec/film_snob/oembed_providers/rdio_spec.rb
+- spec/film_snob/oembed_providers/rutube_spec.rb
+- spec/film_snob/oembed_providers/soundcloud_spec.rb
+- spec/film_snob/oembed_providers/vimeo_spec.rb
+- spec/film_snob/oembed_providers/vine_spec.rb
+- spec/film_snob/oembed_providers/youtube_spec.rb
 - spec/film_snob_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/maxjacobson/film_snob
@@ -196,7 +88,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 1.9.3
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -204,22 +96,23 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.0
 signing_key: 
 specification_version: 4
-summary: Fetch embed codes for videos
+summary: Fetch data from oEmbed APIs
 test_files:
 - spec/cassettes/README.md
-- spec/deprecated_spec.rb
-- spec/film_snob/video_sites/coub_spec.rb
-- spec/film_snob/video_sites/dailymotion_spec.rb
-- spec/film_snob/video_sites/funny_or_die_spec.rb
-- spec/film_snob/video_sites/hulu_spec.rb
-- spec/film_snob/video_sites/instagram_spec.rb
-- spec/film_snob/video_sites/rutube_spec.rb
-- spec/film_snob/video_sites/soundcloud_spec.rb
-- spec/film_snob/video_sites/vimeo_spec.rb
-- spec/film_snob/video_sites/vine_spec.rb
-- spec/film_snob/video_sites/youtube_spec.rb
+- spec/film_snob/oembed_provider_spec.rb
+- spec/film_snob/oembed_providers/coub_spec.rb
+- spec/film_snob/oembed_providers/dailymotion_spec.rb
+- spec/film_snob/oembed_providers/funny_or_die_spec.rb
+- spec/film_snob/oembed_providers/hulu_spec.rb
+- spec/film_snob/oembed_providers/instagram_spec.rb
+- spec/film_snob/oembed_providers/rdio_spec.rb
+- spec/film_snob/oembed_providers/rutube_spec.rb
+- spec/film_snob/oembed_providers/soundcloud_spec.rb
+- spec/film_snob/oembed_providers/vimeo_spec.rb
+- spec/film_snob/oembed_providers/vine_spec.rb
+- spec/film_snob/oembed_providers/youtube_spec.rb
 - spec/film_snob_spec.rb
 - spec/spec_helper.rb

data/lib/film_snob/deprecated.rb

@@ -1,12 +0,0 @@
-class FilmSnob
-  module Deprecated
-    def deprecated_alias(previous, replacement, options)
-      define_method(previous) do |*args, &block|
-        Kernel.warn "WARNING: ##{previous} is deprecated and " \
-                    "will be removed in #{options[:removed_in]}. " \
-                    "Please use ##{replacement} instead."
-        send(replacement, *args, &block)
-      end
-    end
-  end
-end

data/spec/deprecated_spec.rb

@@ -1,28 +0,0 @@
-class FilmSnob
-  describe Deprecated do
-    class Dog
-      extend Deprecated
-
-      deprecated_alias :woof, :bark, :removed_in => "v4.0.0"
-
-      def bark
-        "bark"
-      end
-    end
-
-    let(:milo) { Dog.new }
-
-    describe "deprecated_alias" do
-      it "does not interfere with the current method" do
-        expect(Kernel).to_not receive(:warn)
-        milo.bark
-      end
-
-      it "creates an alias" do
-        expect(milo).to respond_to :woof
-        expect(Kernel).to receive(:warn)
-        expect(milo.woof).to eq "bark"
-      end
-    end
-  end
-end