film_snob 0.6.4 → 0.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a601ca38e0d932d9f1a0cbda09684e20a8521698
-  data.tar.gz: 04e76c9a32a8bc4b71fae81f0c3dade1a5cbbbdb
+  metadata.gz: 8cf290744ac7770ce7b8d8f0ebdde751b4428557
+  data.tar.gz: 0df2231616cbd058bea30b5480708f1c795e1d83
 SHA512:
-  metadata.gz: 930341d43662884815073ed285f42221e54dc39cdda500554a0f45643e3e8546df173dae8aba8fc6e0ae70df91131869c1c19aba01121664597b478fe8b19da5
-  data.tar.gz: 731d530bd8341888c122fa977acf1cf513eec8e775962abf8567d771849584a6d1993f85c916a288612e5588a8fb92fd832e2dd326b0cd82a0ba5aa4e29781b9
+  metadata.gz: 56540292bb66647af0749970dd8a9e28b6a09de560e3b1f7d8365f68c3ae613e48aa95d8fcf6b0bda984a5c0de7c7464ae7aa2faec3451e81a155324480498fe
+  data.tar.gz: 5d132d9626ea0fe6852938748ba813539fdbd5626e5513f13d24d0e2a7dac1d4cc7b6b30868d75be63da772468a180bc1eed76ba6b8b3770a7efe14fbfbf0ad8

data/.rubocop.yml

@@ -1,60 +1,15 @@
-Style/CollectionMethods:
-  # Mapping from undesired method to desired_method
-  # e.g. to use `detect` over `find`:
-  #
-  # CollectionMethods:
-  #   PreferredMethods:
-  #     find: detect
-  PreferredMethods:
-    collect: 'map'
-    collect!: 'map!'
-    reduce: 'inject'
-    detect: 'find'
-    select: 'find_all'
-
-# Disabling this because I don't love using the return keyword
-# and sometimes lines get long and difficult to read that way
-Style/GuardClause:
-  Description: "Check for conditionals that can be replaced with guard clauses"
-  StyleGuide: "https://github.com/bbatsov/ruby-style-guide#no-nested-conditionals"
-  Enabled: false
-
 # I don't want to write documentation for every class
 Style/Documentation:
-  Description: "Document classes and non-namespace modules."
   Enabled: false
 
-# I will use the %r syntax even if there's only one slash
-Style/RegexpLiteral:
-  Description: >-
-                 Use %r for regular expressions matching more than
-                 `MaxSlashes` "/" characters.
-  StyleGuide: "https://github.com/bbatsov/ruby-style-guide#percent-r"
-  Enabled: true
-
-# I prefer raise to fail, so I'm disabling this one
+# I prefer raise to fail
 Style/SignalException:
-  Description: "Checks for proper usage of fail and raise."
-  StyleGuide: "https://github.com/bbatsov/ruby-style-guide#fail-method"
-  Enabled: false
+  EnforcedStyle: only_raise
 
 # I prefer double quotes
 Style/StringLiterals:
-  Description: "Checks if uses of quotes match the configured preference."
-  StyleGuide: "https://github.com/bbatsov/ruby-style-guide#consistent-string-literals"
-  Enabled: true
   EnforcedStyle: double_quotes
 
-# Expect a final blank line
-Style/TrailingBlankLines:
-  Description: "Checks trailing blank lines and final newline."
-  StyleGuide: "https://github.com/bbatsov/ruby-style-guide#newline-eof"
-  Enabled: true
-  EnforcedStyle: final_blank_line
-
-# I like to use assignment in conditions
-Lint/AssignmentInCondition:
-  Description: "Don't use assignment in conditions."
-  StyleGuide: "https://github.com/bbatsov/ruby-style-guide#safe-assignment-in-condition"
-  Enabled: false
-
+# I prefer hash rockets
+Style/HashSyntax:
+  EnforcedStyle: hash_rockets

data/.travis.yml

@@ -9,9 +9,10 @@ rvm:
   - 2.1.4
   - 2.1.5
   - 2.2.0
+  - 2.2.1
+  - 2.2.2
 before_install: "gem install bundler -v 1.10"
 script:
   - bundle exec rake ci
 sudo: false
 cache: bundler
-

data/Gemfile

@@ -2,4 +2,3 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in film_snob.gemspec
 gemspec
-

data/Rakefile

@@ -13,6 +13,5 @@ task :todos do
   end
 end
 
-task ci: [:spec, :style, :todos]
-task default: :ci
-
+task :ci => [:spec, :style, :todos]
+task :default => :ci

data/film_snob.gemspec

@@ -30,4 +30,3 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "codeclimate-test-reporter", "~> 0.4"
   spec.required_ruby_version = ">= 1.9.3"
 end
-

data/lib/film_snob.rb

@@ -11,8 +11,8 @@ class FilmSnob
 
   def_delegators :video, *VIDEO_METHODS
 
-  # TODO(2015-08-01): actually deprecate this method
-  deprecated_alias :watchable?, :embeddable?, removed_in: "v1.0.0"
+  # TODO(2015-11-15): actually remove this method
+  deprecated_alias :watchable?, :embeddable?, :removed_in => "v1.0.0"
 
   attr_reader :url
 
@@ -35,4 +35,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/deprecated.rb

@@ -10,4 +10,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/exceptions.rb

@@ -2,4 +2,3 @@ class FilmSnob
   class NotSupportedURLError < StandardError; end
   class NotEmbeddableError < StandardError; end
 end
-

data/lib/film_snob/url_to_video.rb

@@ -26,4 +26,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/version.rb

@@ -1,4 +1,3 @@
 class FilmSnob
-  VERSION = "0.6.4"
+  VERSION = "0.6.5"
 end
-

data/lib/film_snob/video_site.rb

@@ -2,7 +2,7 @@ require "net/http"
 require "json"
 
 class FilmSnob
-  # TODO(2015-08-01): rename to something more general
+  # TODO(2015-11-15): rename to something more general
   # we're using this for things like Instagram
   class VideoSite
     attr_reader :url, :options
@@ -90,9 +90,8 @@ class FilmSnob
 
     def uri
       URI(self.class.oembed_endpoint).tap do |uri|
-        uri.query = URI.encode_www_form({ url: clean_url }.merge(options))
+        uri.query = URI.encode_www_form({ :url => clean_url }.merge(options))
       end
     end
   end
 end
-

data/lib/film_snob/video_sites/coub.rb

@@ -17,4 +17,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/dailymotion.rb

@@ -18,4 +18,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/funny_or_die.rb

@@ -17,4 +17,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/hulu.rb

@@ -17,4 +17,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/instagram.rb

@@ -10,7 +10,7 @@ class FilmSnob
     end
 
     def self.oembed_endpoint
-      "http://api.instagram.com/publicapi/oembed/"
+      "http://instagram.com/publicapi/oembed/"
     end
 
     def clean_url
@@ -18,4 +18,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/rutube.rb

@@ -3,7 +3,7 @@ require "film_snob/video_site"
 class FilmSnob
   class Rutube < VideoSite
     def initialize(url, options = {})
-      super(url, options.merge(format: :json))
+      super(url, options.merge(:format => :json))
     end
 
     def self.valid_url_patterns
@@ -21,4 +21,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/soundcloud.rb

@@ -3,7 +3,7 @@ require "film_snob/video_site"
 class FilmSnob
   class Soundcloud < VideoSite
     def initialize(url, options = {})
-      super(url, options.merge(format: :json))
+      super(url, options.merge(:format => :json))
     end
 
     def self.valid_url_patterns
@@ -22,4 +22,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/vimeo.rb

@@ -20,4 +20,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/vine.rb

@@ -17,4 +17,3 @@ class FilmSnob
     end
   end
 end
-

data/lib/film_snob/video_sites/youtube.rb

@@ -22,4 +22,3 @@ class FilmSnob
     end
   end
 end
-

data/spec/deprecated_spec.rb

@@ -3,7 +3,7 @@ class FilmSnob
     class Dog
       extend Deprecated
 
-      deprecated_alias :woof, :bark, removed_in: "v4.0.0"
+      deprecated_alias :woof, :bark, :removed_in => "v4.0.0"
 
       def bark
         "bark"
@@ -26,4 +26,3 @@ class FilmSnob
     end
   end
 end
-

data/spec/film_snob/video_sites/coub_spec.rb

@@ -9,4 +9,3 @@ describe FilmSnob::Coub do
     end
   end
 end
-

data/spec/film_snob/video_sites/dailymotion_spec.rb

@@ -28,7 +28,7 @@ describe FilmSnob::Dailymotion do
   it "should allow oembed configuration" do
     snob = FilmSnob.new(
       "http://www.dailymotion.com/video/xf02xp_uffie-difficult_music",
-      maxwidth: 400
+      :maxwidth => 400
     )
     VCR.use_cassette("dailymotion/music1") do
       expect(snob.html).to match(/width="400"/)
@@ -36,11 +36,10 @@ describe FilmSnob::Dailymotion do
 
     snob2 = FilmSnob.new(
       "http://www.dailymotion.com/video/xf02xp_uffie-difficult_music",
-      maxwidth: 500
+      :maxwidth => 500
     )
     VCR.use_cassette("dailymotion/music500") do
       expect(snob2.html).to match(/width="500"/)
     end
   end
 end
-

data/spec/film_snob/video_sites/funny_or_die_spec.rb

@@ -10,4 +10,3 @@ describe FilmSnob::FunnyOrDie do
     end
   end
 end
-

data/spec/film_snob/video_sites/hulu_spec.rb

@@ -9,4 +9,3 @@ describe FilmSnob::Hulu do
     end
   end
 end
-

data/spec/film_snob/video_sites/instagram_spec.rb

@@ -34,4 +34,3 @@ describe FilmSnob::Instagram do
     end
   end
 end
-

data/spec/film_snob/video_sites/rutube_spec.rb

@@ -12,4 +12,3 @@ describe FilmSnob::Rutube do
     end
   end
 end
-

data/spec/film_snob/video_sites/soundcloud_spec.rb

@@ -52,7 +52,7 @@ describe FilmSnob::Soundcloud do
     it "should allow user to set the iframe width" do
       snob = FilmSnob.new(
         "https://soundcloud.com/theweeknd/the-weeknd-king-of-the-fall",
-        maxwidth: 500
+        :maxwidth => 500
       )
       VCR.use_cassette("soundcloud/maxwidth") do
         expect(snob.html).to match(/width="500"/)
@@ -62,7 +62,7 @@ describe FilmSnob::Soundcloud do
     it "should allow user to set autoplay" do
       snob = FilmSnob.new(
         "https://soundcloud.com/theweeknd/the-weeknd-king-of-the-fall",
-        auto_play: true
+        :auto_play => true
       )
       VCR.use_cassette("soundcloud/autoplay") do
         expect(snob.html).to match(/auto_play=true/)
@@ -70,4 +70,3 @@ describe FilmSnob::Soundcloud do
     end
   end
 end
-

data/spec/film_snob/video_sites/vimeo_spec.rb

@@ -46,15 +46,14 @@ describe FilmSnob::Vimeo do
   end
 
   it "should allow oembed configuration" do
-    snob = FilmSnob.new("http://vimeo.com/31158841", width: 400)
+    snob = FilmSnob.new("http://vimeo.com/31158841", :width => 400)
     VCR.use_cassette("vimeo/murmuration") do
       expect(snob.html).to match(/width="400"/)
     end
 
-    snob2 = FilmSnob.new("http://vimeo.com/31158841", width: 500)
+    snob2 = FilmSnob.new("http://vimeo.com/31158841", :width => 500)
     VCR.use_cassette("vimeo/murmuration2") do
       expect(snob2.html).to match(/width="500"/)
     end
   end
 end
-

data/spec/film_snob/video_sites/vine_spec.rb

@@ -9,4 +9,3 @@ describe FilmSnob::Vine do
     end
   end
 end
-

data/spec/film_snob/video_sites/youtube_spec.rb

@@ -86,4 +86,3 @@ describe FilmSnob::YouTube do
     expect(snob.clean_url).to eq "https://www.youtube.com/watch?v=sLSFOCyNC8Q"
   end
 end
-

data/spec/film_snob_spec.rb

@@ -12,4 +12,3 @@ describe FilmSnob do
     end
   end
 end
-

data/spec/spec_helper.rb

@@ -27,4 +27,3 @@ RSpec.configure do |config|
     mocks.verify_partial_doubles = true
   end
 end
-

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: film_snob
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.6.5
 platform: ruby
 authors:
 - Max Jacobson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-11 00:00:00.000000000 Z
+date: 2015-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -204,7 +204,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Fetch embed codes for videos