film_snob 0.3.8 → 0.3.9

data/film_snob.gemspec

@@ -25,7 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "vcr",      "~> 2.9"
   spec.add_development_dependency "pry",      "~> 0.9"
 
-  spec.add_runtime_dependency     "httparty", "~> 0.13"
-
   spec.required_ruby_version = '>= 1.9.3'
 end

data/lib/film_snob.rb

@@ -28,7 +28,7 @@ class FilmSnob
       if watchable?
         @video
       else
-        raise NotSupportedURLError.new("#{url} is not a supported URL")
+        raise NotSupportedURLError, "#{url} is not a supported URL"
       end
     end
 

data/lib/film_snob/coub.rb

@@ -16,5 +16,6 @@ class FilmSnob
     def self.oembed_endpoint
       'http://coub.com/api/oembed.json'
     end
+
   end
 end

data/lib/film_snob/version.rb

@@ -1,3 +1,3 @@
 class FilmSnob
-  VERSION = "0.3.8"
+  VERSION = "0.3.9"
 end

data/lib/film_snob/video_site.rb

@@ -1,8 +1,8 @@
-require 'httparty'
+require 'net/http'
+require 'json'
 
 class FilmSnob
   class VideoSite
-
     attr_reader :url, :options
 
     def initialize(url, options)
@@ -26,16 +26,38 @@ class FilmSnob
       ''
     end
 
+    def self.http
+      Net::HTTP.new(uri.host, uri.port).tap do |uri|
+        uri.use_ssl = use_ssl?
+      end
+    end
+
+    def self.use_ssl?
+      'https' == uri.scheme
+    end
+
     def title
-      oembed['title']
+      lookup :title
     end
 
     def html
-      oembed['html'] || (raise NotEmbeddableError.new("#{clean_url} is not embeddable"))
+      lookup :html
     end
 
     private
 
+      def not_embeddable!
+        raise NotEmbeddableError, "#{clean_url} is not embeddable"
+      end
+
+      def self.uri
+        URI.parse(oembed_endpoint)
+      end
+
+      def lookup(attribute)
+        oembed[attribute.to_s] || not_embeddable!
+      end
+
       def matching_pattern
         self.class.valid_url_patterns.find do |pattern|
           pattern.match(url)
@@ -43,10 +65,23 @@ class FilmSnob
       end
 
       def oembed
-        @oembed ||= HTTParty.get(
-          self.class.oembed_endpoint,
-          query: { url: clean_url }.merge(options)
-        )
+        @oembed ||= JSON.parse response.body
+      rescue
+        @oembed = {}
+      end
+
+      def response
+        self.class.http.request get
+      end
+
+      def get
+        Net::HTTP::Get.new uri.request_uri
+      end
+
+      def uri
+        URI(self.class.oembed_endpoint).tap do |uri|
+          uri.query = URI.encode_www_form({ url: clean_url }.merge(options))
+        end
       end
 
   end

data/spec/cassettes/bad_youtube_url.yml

@@ -6,36 +6,44 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - www.youtube.com
   response:
     status:
       code: 404
       message: Not Found
     headers:
       Date:
-      - Tue, 15 Apr 2014 02:52:18 GMT
+      - Fri, 06 Jun 2014 03:02:54 GMT
       Server:
       - gwiseguy/2.0
-      X-Content-Type-Options:
-      - nosniff
       P3p:
       - CP="This is not a P3P policy! See http://support.google.com/accounts/bin/answer.py?answer=151657&hl=en
         for more info."
+      Content-Type:
+      - text/html; charset=utf-8
+      Cache-Control:
+      - no-cache
       X-Frame-Options:
       - ALLOWALL
       Expires:
       - Tue, 27 Apr 1971 19:44:06 EST
       X-Xss-Protection:
       - 1; mode=block; report=https://www.google.com/appserve/security-bugs/log/youtube
-      Cache-Control:
-      - no-cache
-      Content-Type:
-      - text/html; charset=utf-8
+      X-Content-Type-Options:
+      - nosniff
       Content-Length:
       - '9'
     body:
-      encoding: US-ASCII
+      encoding: UTF-8
       string: Not Found
     http_version: 
-  recorded_at: Tue, 15 Apr 2014 02:52:19 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 03:02:54 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/billy.yml

@@ -6,16 +6,26 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - www.youtube.com
   response:
     status:
       code: 200
       message: OK
     headers:
       Date:
-      - Tue, 15 Apr 2014 02:52:15 GMT
+      - Fri, 06 Jun 2014 02:59:55 GMT
       Server:
       - gwiseguy/2.0
+      Cache-Control:
+      - no-cache
       X-Frame-Options:
       - ALLOWALL
       X-Xss-Protection:
@@ -24,25 +34,23 @@ http_interactions:
       - Tue, 27 Apr 1971 19:44:06 EST
       X-Content-Type-Options:
       - nosniff
+      Content-Type:
+      - application/json
       P3p:
       - CP="This is not a P3P policy! See http://support.google.com/accounts/bin/answer.py?answer=151657&hl=en
         for more info."
-      Content-Type:
-      - application/json
-      Cache-Control:
-      - no-cache
       Transfer-Encoding:
       - chunked
     body:
-      encoding: US-ASCII
-      string: ! '{"type": "video", "provider_url": "http:\/\/www.youtube.com\/", "thumbnail_url":
-        "http:\/\/i1.ytimg.com\/vi\/7q5Ltr0qc8c\/hqdefault.jpg", "thumbnail_height":
-        360, "width": 480, "provider_name": "YouTube", "author_url": "http:\/\/www.youtube.com\/user\/billyonthestreettv",
-        "title": "Billy on the Street: Amateur Speed Sketching!", "thumbnail_width":
-        480, "version": "1.0", "html": "\u003ciframe width=\"480\" height=\"270\"
+      encoding: UTF-8
+      string: '{"thumbnail_height": 360, "html": "\u003ciframe width=\"480\" height=\"270\"
         src=\"http:\/\/www.youtube.com\/embed\/7q5Ltr0qc8c?feature=oembed\" frameborder=\"0\"
-        allowfullscreen\u003e\u003c\/iframe\u003e", "height": 270, "author_name":
-        "billyonthestreettv"}'
+        allowfullscreen\u003e\u003c\/iframe\u003e", "title": "Billy on the Street:
+        Amateur Speed Sketching!", "height": 270, "provider_name": "YouTube", "author_url":
+        "http:\/\/www.youtube.com\/user\/billyonthestreettv", "type": "video", "author_name":
+        "billyonthestreettv", "thumbnail_url": "http:\/\/i1.ytimg.com\/vi\/7q5Ltr0qc8c\/hqdefault.jpg",
+        "provider_url": "http:\/\/www.youtube.com\/", "thumbnail_width": 480, "version":
+        "1.0", "width": 480}'
     http_version: 
-  recorded_at: Tue, 15 Apr 2014 02:52:17 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 02:59:55 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/harmon.yml

@@ -6,7 +6,15 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - www.hulu.com
   response:
     status:
       code: 200
@@ -22,22 +30,20 @@ http_interactions:
       - 200 OK
       X-Ua-Compatible:
       - IE=EmulateIE9; IE=EmulateIE7
-      Accept-Ranges:
-      - bytes
       Cache-Control:
-      - max-age=3600
+      - max-age=1205
       Date:
-      - Tue, 15 Apr 2014 02:52:16 GMT
+      - Fri, 06 Jun 2014 02:59:56 GMT
       Connection:
       - keep-alive
     body:
-      encoding: US-ASCII
-      string: ! '{"cache_age":3600,"type":"video","large_thumbnail_url":"http://ib.huluim.com/video/50172061?size=512x288&caller=h1o&img=i","height":296,"html":"<iframe
+      encoding: UTF-8
+      string: '{"thumbnail_height":80,"thumbnail_url":"http://ib.huluim.com/video/50172061?size=145x80&caller=h1o&img=i","type":"video","cache_age":3600,"title":"Remedial
+        Chaos Theory (Community)","width":512,"large_thumbnail_url":"http://ib.huluim.com/video/50172061?size=512x288&caller=h1o&img=i","large_thumbnail_width":512,"height":296,"embed_url":"http://www.hulu.com/embed.html?eid=CbtnRM8PBJsCfZpUy2V3Yg","html":"<iframe
         width=\"512\" height=\"296\" src=\"http://www.hulu.com/embed.html?eid=CbtnRM8PBJsCfZpUy2V3Yg\"
         frameborder=\"0\" scrolling=\"no\" webkitAllowFullScreen mozallowfullscreen
-        allowfullscreen> </iframe>","large_thumbnail_width":512,"embed_url":"http://www.hulu.com/embed.html?eid=CbtnRM8PBJsCfZpUy2V3Yg","air_date":"Thu
-        Oct 13 00:00:00 UTC 2011","large_thumbnail_height":288,"thumbnail_url":"http://ib.huluim.com/video/50172061?size=145x80&caller=h1o&img=i","author_name":"NBC","provider_name":"Hulu","title":"Remedial
-        Chaos Theory (Community)","thumbnail_width":145,"provider_url":"http://www.hulu.com/","duration":1286.87,"version":"1.0","thumbnail_height":80,"width":512}'
+        allowfullscreen> </iframe>","version":"1.0","air_date":"Thu Oct 13 00:00:00
+        UTC 2011","large_thumbnail_height":288,"author_name":"NBC","provider_name":"Hulu","duration":1286.87,"thumbnail_width":145,"provider_url":"http://www.hulu.com/"}'
     http_version: 
-  recorded_at: Tue, 15 Apr 2014 02:52:18 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 02:59:56 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/missing_video.yml

@@ -0,0 +1,49 @@
+---
+http_interactions:
+- request:
+    method: get
+    uri: https://www.youtube.com/oembed?url=https://www.youtube.com/watch?v=malformedid
+    body:
+      encoding: US-ASCII
+      string: ''
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - www.youtube.com
+  response:
+    status:
+      code: 404
+      message: Not Found
+    headers:
+      Date:
+      - Fri, 06 Jun 2014 02:59:55 GMT
+      Server:
+      - gwiseguy/2.0
+      X-Xss-Protection:
+      - 1; mode=block; report=https://www.google.com/appserve/security-bugs/log/youtube
+      Expires:
+      - Tue, 27 Apr 1971 19:44:06 EST
+      X-Content-Type-Options:
+      - nosniff
+      X-Frame-Options:
+      - ALLOWALL
+      P3p:
+      - CP="This is not a P3P policy! See http://support.google.com/accounts/bin/answer.py?answer=151657&hl=en
+        for more info."
+      Cache-Control:
+      - no-cache
+      Content-Type:
+      - text/html; charset=utf-8
+      Content-Length:
+      - '9'
+    body:
+      encoding: UTF-8
+      string: Not Found
+    http_version: 
+  recorded_at: Fri, 06 Jun 2014 02:59:55 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/murmuration.yml

@@ -6,7 +6,15 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - vimeo.com
   response:
     status:
       code: 200
@@ -15,9 +23,9 @@ http_interactions:
       Age:
       - '1'
       Date:
-      - Tue, 15 Apr 2014 02:52:16 GMT
+      - Fri, 06 Jun 2014 02:59:55 GMT
       Expires:
-      - Tue, 15 Apr 2014 02:53:16 GMT
+      - Fri, 06 Jun 2014 03:00:55 GMT
       Content-Length:
       - '793'
       Connection:
@@ -26,30 +34,30 @@ http_interactions:
       - 1.1 varnish
       - dnet-dca
       Etag:
-      - ! '"e19e6eea37661a8e029d8f8e3b2116f3e97ea8f0"'
+      - '"5ffeebb02a34c4b0edaf908978ae3dc7a08a8994"'
       Server:
       - Apache
       Access-Control-Allow-Origin:
-      - ! '*'
+      - "*"
       Access-Control-Allow-Headers:
       - X-Requested-With
       Last-Modified:
-      - Tue, 15 Apr 2014 02:10:30 GMT
+      - Fri, 06 Jun 2014 02:09:21 GMT
       Vary:
       - Accept-Encoding
       Content-Type:
       - application/json
       X-Varnish:
-      - '1677378251'
+      - '1670035520'
       X-Varnish-Cache:
       - '0'
       Nncoection:
       - close
       X-Vserver:
-      - 10.90.128.197
+      - dfvimeowebproxy3
     body:
-      encoding: US-ASCII
-      string: ! '{"type":"video","version":"1.0","provider_name":"Vimeo","provider_url":"https:\/\/vimeo.com\/","title":"Murmuration","author_name":"Islands
+      encoding: UTF-8
+      string: '{"type":"video","version":"1.0","provider_name":"Vimeo","provider_url":"https:\/\/vimeo.com\/","title":"Murmuration","author_name":"Islands
         & Rivers","author_url":"http:\/\/vimeo.com\/islandsandrivers","is_plus":"1","html":"<iframe
         src=\"\/\/player.vimeo.com\/video\/31158841\" width=\"400\" height=\"300\"
         frameborder=\"0\" title=\"Murmuration\" webkitallowfullscreen mozallowfullscreen
@@ -57,5 +65,5 @@ http_interactions:
         Islands And Rivers\n\nFollow us @Islands_Rivers\n\nA chance encounter and
         shared moment with one of natures greatest and most fleeting phenomena.","thumbnail_url":"http:\/\/i.vimeocdn.com\/video\/448600816_295x166.jpg","thumbnail_width":295,"thumbnail_height":221,"video_id":31158841}'
     http_version: 
-  recorded_at: Tue, 15 Apr 2014 02:52:17 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 02:59:55 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/murmuration2.yml

@@ -6,7 +6,11 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept:
+      - ! '*/*'
+      User-Agent:
+      - Ruby
   response:
     status:
       code: 200
@@ -19,11 +23,11 @@ http_interactions:
       Access-Control-Allow-Headers:
       - X-Requested-With
       Expires:
-      - Tue, 15 Apr 2014 02:52:58 GMT
+      - Fri, 06 Jun 2014 03:05:51 GMT
       Last-Modified:
-      - Tue, 15 Apr 2014 02:10:30 GMT
+      - Fri, 06 Jun 2014 02:09:21 GMT
       Etag:
-      - ! '"e19e6eea37661a8e029d8f8e3b2116f3e97ea8f0"'
+      - ! '"5ffeebb02a34c4b0edaf908978ae3dc7a08a8994"'
       Vary:
       - Accept-Encoding
       Content-Type:
@@ -31,19 +35,19 @@ http_interactions:
       Transfer-Encoding:
       - chunked
       Date:
-      - Tue, 15 Apr 2014 02:52:16 GMT
+      - Fri, 06 Jun 2014 03:04:51 GMT
       X-Varnish:
-      - 2146795868 2146790599
+      - '1671233141'
       Age:
-      - '18'
+      - '0'
       Via:
       - 1.1 varnish
       X-Varnish-Cache:
-      - '1'
+      - '0'
       Nncoection:
       - close
       X-Vserver:
-      - 10.90.128.188
+      - dfvimeowebproxy3
     body:
       encoding: US-ASCII
       string: ! '{"type":"video","version":"1.0","provider_name":"Vimeo","provider_url":"https:\/\/vimeo.com\/","title":"Murmuration","author_name":"Islands
@@ -54,5 +58,5 @@ http_interactions:
         Islands And Rivers\n\nFollow us @Islands_Rivers\n\nA chance encounter and
         shared moment with one of natures greatest and most fleeting phenomena.","thumbnail_url":"http:\/\/i.vimeocdn.com\/video\/448600816_295x166.jpg","thumbnail_width":295,"thumbnail_height":221,"video_id":31158841}'
     http_version: 
-  recorded_at: Tue, 15 Apr 2014 02:52:17 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 03:04:51 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/space_jam.yml

@@ -6,7 +6,15 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - www.funnyordie.com
   response:
     status:
       code: 200
@@ -29,22 +37,24 @@ http_interactions:
       Etag:
       - '"bf2b27d19328373c12ec3f1c5a813b56"'
       X-Request-Id:
-      - 981b6969-3e49-462a-b4a8-37fd14702479
+      - 39767a34-cf4a-43e7-995a-ed12770d1dba
       X-Runtime:
-      - '0.025448'
+      - '0.021698'
       X-Varnish:
-      - '1732560026'
-      - '318926149'
+      - '472126988'
+      - '472126989'
       Served-By:
-      - prodweb2/prodweb1/278007-prodapp3
+      - prodweb1/prodweb1/278006-prodapp2
+      Vary:
+      - Accept-Encoding
       Expires:
-      - Sat, 19 Apr 2014 03:15:41 GMT
+      - Fri, 06 Jun 2014 02:59:56 GMT
       Cache-Control:
       - max-age=0, no-cache, no-store
       Pragma:
       - no-cache
       Date:
-      - Sat, 19 Apr 2014 03:15:41 GMT
+      - Fri, 06 Jun 2014 02:59:56 GMT
       Content-Length:
       - '1751'
       Connection:
@@ -54,5 +64,5 @@ http_interactions:
       string: |
         {"type":"video","version":"1.0","provider_name":"Funny or Die","provider_url":"http://www.funnyordie.com","author_name":"Seth Green","author_url":"http://www.funnyordie.com/seth_green","title":"The Live Read of Space Jam with Blake Griffin","html":"\u003Ciframe src=\"http://www.funnyordie.com/embed/8db066d2e0\" width=\"960\" height=\"580\" frameborder=\"0\" allowfullscreen webkitallowfullscreen mozallowfullscreen\u003E\u003C/iframe\u003E\u003Cdiv style=\"text-align:left;font-size:x-small;margin-top:0;width:960px;\"\u003E\u003Ca href=\"http://www.funnyordie.com/videos/8db066d2e0/the-live-read-of-space-jam-with-blake-griffin\" title=\"from Seth Green, Blake Griffin, DeAndre Jordan, Danielle Fishel, Paul Scheer, Nick Kroll, Ben Schwartz, Jerrod Carmichael, Noah Garfinkel, Brandon Johnson, Melissa Stetten, Shelby Fero, Jensen Karp, Ally Hord, Funny Or Die, Matt Sweeney, BoTown Sound, and Nate Maggio\"\u003EThe Live Read of Space Jam with Blake Griffin\u003C/a\u003E from \u003Ca href=\"http://www.funnyordie.com/seth_green\"\u003ESeth Green\u003C/a\u003E      \u003Ciframe src=\"http://www.facebook.com/plugins/like.php?app_id=138711277798\u0026amp;href=http%3A%2F%2Fwww.funnyordie.com%2Fvideos%2F8db066d2e0%2Fthe-live-read-of-space-jam-with-blake-griffin\u0026amp;send=false\u0026amp;layout=button_count\u0026amp;width=150\u0026amp;show_faces=false\u0026amp;action=like\u0026amp;height=21\" scrolling=\"no\" frameborder=\"0\" style=\"border:none; overflow:hidden; width:90px; height:21px; vertical-align:middle;\" allowTransparency=\"true\"\u003E\u003C/iframe\u003E\n\u003C/div\u003E","width":960,"height":580,"thumbnail_width":464,"thumbnail_height":348,"thumbnail_url":"http://t.fod4.com/t/8db066d2e0/c480x270_58.jpg","duration":584.817}
     http_version: 
-  recorded_at: Sat, 19 Apr 2014 03:15:41 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 02:59:56 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/stephen.yml

@@ -6,47 +6,60 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - vimeo.com
   response:
     status:
       code: 200
       message: OK
     headers:
+      Age:
+      - '1'
+      Date:
+      - Fri, 06 Jun 2014 02:59:55 GMT
+      Expires:
+      - Fri, 06 Jun 2014 03:00:55 GMT
+      Connection:
+      - Keep-Alive
+      Via:
+      - 1.1 varnish
+      - dnet-dca
+      Etag:
+      - '"3ee9abac968dd90ff3d61a6c3ed1e6aac5a93a7d"'
       Server:
       - Apache
       Access-Control-Allow-Origin:
-      - ! '*'
+      - "*"
       Access-Control-Allow-Headers:
       - X-Requested-With
-      Expires:
-      - Tue, 15 Apr 2014 02:53:16 GMT
       Last-Modified:
       - Sun, 13 Apr 2014 19:06:59 GMT
-      Etag:
-      - ! '"3ee9abac968dd90ff3d61a6c3ed1e6aac5a93a7d"'
       Vary:
       - Accept-Encoding
       Content-Type:
       - application/json
-      Transfer-Encoding:
-      - chunked
-      Date:
-      - Tue, 15 Apr 2014 02:52:16 GMT
+      Content-Length:
+      - '478'
+      Accept-Ranges:
+      - bytes
       X-Varnish:
-      - '273732503'
-      Age:
-      - '0'
-      Via:
-      - 1.1 varnish
+      - '1817515816'
       X-Varnish-Cache:
       - '0'
       Cneonction:
       - close
       X-Vserver:
-      - 10.90.128.147
+      - dfvimeowebproxy4
     body:
-      encoding: US-ASCII
-      string: ! '{"type":"video","version":"1.0","provider_name":"Vimeo","provider_url":"https:\/\/vimeo.com\/","title":"Days
+      encoding: UTF-8
+      string: '{"type":"video","version":"1.0","provider_name":"Vimeo","provider_url":"https:\/\/vimeo.com\/","title":"Days
         Like Today","author_name":"Stephen_Scott_Day","author_url":"http:\/\/vimeo.com\/stephenscottday","is_plus":"1","html":"<iframe
         src=\"\/\/player.vimeo.com\/video\/16010689\" width=\"1280\" height=\"720\"
         frameborder=\"0\" title=\"Days Like Today\" webkitallowfullscreen mozallowfullscreen
@@ -55,5 +68,5 @@ http_interactions:
         the whole thing, but if you do, lemme know. \n\nTuesday, October 19th, 2010.
         Somewhere between 3:40pm and 3:50pm. Alhambra, CA.","thumbnail_url":"http:\/\/i.vimeocdn.com\/video\/97388869_1280.jpg","thumbnail_width":1280,"thumbnail_height":720,"video_id":16010689}'
     http_version: 
-  recorded_at: Tue, 15 Apr 2014 02:52:17 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 02:59:55 GMT
+recorded_with: VCR 2.9.2

data/spec/cassettes/voodoo_people.yml

@@ -6,52 +6,50 @@ http_interactions:
     body:
       encoding: US-ASCII
       string: ''
-    headers: {}
+    headers:
+      Accept-Encoding:
+      - gzip;q=1.0,deflate;q=0.6,identity;q=0.3
+      Accept:
+      - "*/*"
+      User-Agent:
+      - Ruby
+      Host:
+      - coub.com
   response:
     status:
       code: 200
       message: OK
     headers:
       Server:
-      - Apache
-      Access-Control-Allow-Origin:
-      - ! '*'
-      Access-Control-Allow-Headers:
-      - X-Requested-With
-      Expires:
-      - Tue, 15 Apr 2014 02:53:16 GMT
-      Last-Modified:
-      - Sun, 13 Apr 2014 19:06:59 GMT
-      Etag:
-      - ! '"3ee9abac968dd90ff3d61a6c3ed1e6aac5a93a7d"'
-      Vary:
-      - Accept-Encoding
+      - nginx/1.4.4
+      Date:
+      - Fri, 06 Jun 2014 02:59:56 GMT
       Content-Type:
-      - application/json
+      - application/json; charset=utf-8
       Transfer-Encoding:
       - chunked
-      Date:
-      - Tue, 15 Apr 2014 02:52:16 GMT
-      X-Varnish:
-      - '273732503'
-      Age:
-      - '0'
-      Via:
-      - 1.1 varnish
-      X-Varnish-Cache:
-      - '0'
-      Cneonction:
-      - close
-      X-Vserver:
-      - 10.90.128.147
+      Connection:
+      - keep-alive
+      Vary:
+      - Accept-Encoding
+      Status:
+      - 200 OK
+      X-Ua-Compatible:
+      - IE=Edge,chrome=1
+      Cache-Control:
+      - max-age=0, private, must-revalidate
+      X-Request-Id:
+      - 271c6fd4f094ad88c161efa47990e5e1
+      X-Runtime:
+      - '0.011259'
+      X-Rack-Cache:
+      - miss
     body:
-      encoding: US-ASCII
-      string: |
-        {"type":"video","version":"1.0","width":942,"height":720,"title":"voodoo people","url":"http://coub.com/view/rcd14cm",
-        "thumbnail_url":"http://cdn1.akamai.coub.com/coub/simple/cw_image/8007107badd/a0f3e90c986074ac81f30/med_1374583486_00033.jpg",
-        "thumbnail_width":640,"thumbnail_height":488,"author_name":"Igor","author_url":"http://coub.com/coubcreator",
-        "provider_name":"Coub","provider_url":"http://coub.com/",
-        "html":"<iframesrc=\"http://coub.com/embed/rcd14cm\"allowfullscreen=\"true\"frameborder=\"0\"width=\"640\"height=\"489\"></iframe>"}
+      encoding: UTF-8
+      string: '{"type":"video","version":"1.0","width":"942","height":"720","title":"voodoo
+        people","url":"http://coub.com/view/rcd14cm","thumbnail_url":"http://cdn1.akamai.coub.com/coub/simple/cw_image/8007107badd/a0f3e90c986074ac81f30/med_1374583486_00033.jpg","thumbnail_width":"640","thumbnail_height":"488","author_name":"\u0418\u0433\u043e\u0440\u044c","author_url":"http://coub.com/coubcreator","provider_name":"Coub","provider_url":"http://coub.com/","html":"<iframe
+        src=\"http://coub.com/embed/rcd14cm\" allowfullscreen=\"true\" frameborder=\"0\"
+        width=\"640\" height=\"489\"></iframe>"}'
     http_version: 
-  recorded_at: Sun, 01 Jun 2014 02:52:17 GMT
-recorded_with: VCR 2.9.0
+  recorded_at: Fri, 06 Jun 2014 02:59:56 GMT
+recorded_with: VCR 2.9.2

data/spec/film_snob_spec.rb

@@ -1,9 +1,7 @@
 require_relative 'spec_helper'
 
 describe FilmSnob do
-
   describe 'not supported URLs' do
-
     it 'should handle non-supported URLs gracefully' do
       snob = FilmSnob.new("http://hardscrabble.net")
       expect(snob).to_not be_watchable
@@ -14,15 +12,13 @@ describe FilmSnob do
       expect(snob).to_not be_watchable
       expect{snob.id}.to raise_error(FilmSnob::NotSupportedURLError)
     end
-
   end
 
   describe 'YouTube URLs' do
-
     it 'should parse normal YouTube URLs' do
       snob = FilmSnob.new("https://www.youtube.com/watch?v=7q5Ltr0qc8c")
       expect(snob).to be_watchable
-      expect(snob.id).to eq "7q5Ltr0qc8c"
+      expect(snob.id).to eq '7q5Ltr0qc8c'
       expect(snob.site).to eq :youtube
       VCR.use_cassette('billy') do
         expect(snob.title).to eq 'Billy on the Street: Amateur Speed Sketching!'
@@ -32,7 +28,7 @@ describe FilmSnob do
     it 'should parse YouTube URLs with dashes' do
       snob = FilmSnob.new("https://www.youtube.com/watch?v=xa-KBqOFgDQ")
       expect(snob).to be_watchable
-      expect(snob.id).to eq "xa-KBqOFgDQ"
+      expect(snob.id).to eq 'xa-KBqOFgDQ'
       expect(snob.site).to eq :youtube
     end
 
@@ -40,30 +36,36 @@ describe FilmSnob do
       # first video I could find with an underscore
       snob = FilmSnob.new("https://www.youtube.com/watch?v=HPR3PB_VGVs")
       expect(snob).to be_watchable
-      expect(snob.id).to eq "HPR3PB_VGVs"
+      expect(snob.id).to eq 'HPR3PB_VGVs'
       expect(snob.site).to eq :youtube
     end
 
     it 'should parse mobile YouTube URLs' do
       snob = FilmSnob.new("https://m.youtube.com/watch?v=6dyeFalOjw0&feature=youtu.be")
-      expect(snob.id).to eq "6dyeFalOjw0"
+      expect(snob.id).to eq '6dyeFalOjw0'
       expect(snob.site).to eq :youtube
-      expect(snob.clean_url).to eq "https://www.youtube.com/watch?v=6dyeFalOjw0"
+      expect(snob.clean_url).to eq 'https://www.youtube.com/watch?v=6dyeFalOjw0'
     end
 
     it 'should parse short YouTube URLs' do
       snob = FilmSnob.new("http://youtu.be/1Ee4bfu_t3c")
-      expect(snob.id).to eq "1Ee4bfu_t3c"
+      expect(snob.id).to eq '1Ee4bfu_t3c'
       expect(snob.site).to eq :youtube
-      expect(snob.clean_url).to eq "https://www.youtube.com/watch?v=1Ee4bfu_t3c"
+      expect(snob.clean_url).to eq 'https://www.youtube.com/watch?v=1Ee4bfu_t3c'
     end
 
+    it 'should raise a not embeddable error for a missing video URL' do
+      VCR.use_cassette('missing video') do
+        snob = FilmSnob.new("https://youtube.com/watch?v=malformedid")
+        expect{snob.title}.to raise_error(FilmSnob::NotEmbeddableError)
+      end
+    end
   end
 
   describe 'vimeo URLs' do
     it 'should parse https vimeo URLs' do
       snob = FilmSnob.new("https://vimeo.com/16010689")
-      expect(snob.id).to eq "16010689"
+      expect(snob.id).to eq '16010689'
       expect(snob.site).to eq :vimeo
       VCR.use_cassette('stephen') do
         expect(snob.title).to eq 'Days Like Today'
@@ -72,40 +74,40 @@ describe FilmSnob do
 
     it 'should parse http vimeo URLs' do
       snob = FilmSnob.new("http://vimeo.com/16010689")
-      expect(snob.id).to eq "16010689"
+      expect(snob.id).to eq '16010689'
       expect(snob.site).to eq :vimeo
     end
 
     it 'should parse mobile vimeo URLs' do
       snob = FilmSnob.new("http://vimeo.com/m/16010689")
-      expect(snob.id).to eq "16010689"
+      expect(snob.id).to eq '16010689'
       expect(snob.site).to eq :vimeo
-      expect(snob.clean_url).to eq "https://vimeo.com/16010689"
+      expect(snob.clean_url).to eq 'https://vimeo.com/16010689'
     end
 
     it 'should parse couchmode vimeo URLs' do
       snob = FilmSnob.new("https://vimeo.com/couchmode/staffpicks/sort:date/91157088")
-      expect(snob.id).to eq "91157088"
+      expect(snob.id).to eq '91157088'
       expect(snob.site).to eq :vimeo
       expect(snob.clean_url).to eq 'https://vimeo.com/91157088'
 
-      snob2 = FilmSnob.new("https://vimeo.com/couchmode/watchlater/sort:date/51020067")
-      expect(snob2.id).to eq "51020067"
+      snob2 = FilmSnob.new('https://vimeo.com/couchmode/watchlater/sort:date/51020067')
+      expect(snob2.id).to eq '51020067'
       expect(snob2.site).to eq :vimeo
       expect(snob2.clean_url).to eq 'https://vimeo.com/51020067'
     end
 
     it 'should allow oembed configuration' do
       snob = FilmSnob.new("http://vimeo.com/31158841", width: 400)
-      VCR.use_cassette "murmuration" do
+      VCR.use_cassette 'murmuration' do
         expect(snob.html).to match %r{width="400"}
       end
-      snob2 = FilmSnob.new("http://vimeo.com/31158841", width: 500)
-      VCR.use_cassette "murmuration2" do
+
+      snob2 = FilmSnob.new('http://vimeo.com/31158841', width: 500)
+      VCR.use_cassette 'murmuration2' do
         expect(snob2.html).to match %r{width="500"}
       end
     end
-
   end
 
   describe 'hulu URLs' do
@@ -122,7 +124,7 @@ describe FilmSnob do
 
   describe 'funny or die URLs' do
     it 'should parse funny or die URLs' do
-      film = FilmSnob.new("http://www.funnyordie.com/videos/8db066d2e0/the-live-read-of-space-jam-with-blake-griffin")
+      film = FilmSnob.new('http://www.funnyordie.com/videos/8db066d2e0/the-live-read-of-space-jam-with-blake-griffin')
       expect(film.id).to eq '8db066d2e0'
       expect(film.site).to eq :funnyordie
       VCR.use_cassette 'space jam' do
@@ -134,7 +136,7 @@ describe FilmSnob do
 
   describe 'coub URLs' do
     it 'should parse coub URLs' do
-      film = FilmSnob.new("http://coub.com/view/rcd14cm")
+      film = FilmSnob.new('http://coub.com/view/rcd14cm')
       expect(film.id).to eq 'rcd14cm'
       expect(film.site).to eq :coub
       VCR.use_cassette 'voodoo_people' do

metadata

@@ -1,113 +1,112 @@
 --- !ruby/object:Gem::Specification
 name: film_snob
 version: !ruby/object:Gem::Version
-  version: 0.3.8
+  version: 0.3.9
+  prerelease: 
 platform: ruby
 authors:
 - Max Jacobson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-01 00:00:00.000000000 Z
+date: 2014-06-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0.rc1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 3.0.0.rc1
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.17'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '2.9'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '0.9'
-- !ruby/object:Gem::Dependency
-  name: httparty
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
 description: Find information about URLs from video sites, such as the title and embed
   code of the video
 email:
@@ -116,9 +115,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".travis.yml"
+- .gitignore
+- .rspec
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -138,6 +137,7 @@ files:
 - spec/cassettes/bad_youtube_url.yml
 - spec/cassettes/billy.yml
 - spec/cassettes/harmon.yml
+- spec/cassettes/missing_video.yml
 - spec/cassettes/murmuration.yml
 - spec/cassettes/murmuration2.yml
 - spec/cassettes/space_jam.yml
@@ -149,32 +149,34 @@ files:
 homepage: https://github.com/maxjacobson/film_snob
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - ">="
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 1.8.23.2
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Fetch embed codes for videos
 test_files:
 - spec/cassettes/.keep
 - spec/cassettes/bad_youtube_url.yml
 - spec/cassettes/billy.yml
 - spec/cassettes/harmon.yml
+- spec/cassettes/missing_video.yml
 - spec/cassettes/murmuration.yml
 - spec/cassettes/murmuration2.yml
 - spec/cassettes/space_jam.yml

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: 7c1fbeb96d100f09f8e9a752b96362afcbc735fd
-  data.tar.gz: 9171fdc77ef624937f52c47dc77281dd6ee3aa1b
-SHA512:
-  metadata.gz: 8161280ebf1c10ce0dd94d88570ab8b2d3afa0e974b9aa7aeac1dad4d37c6f6f8e9ed68c937401800664befea46b6a913da7ec818481270836a9c749203a627b
-  data.tar.gz: 2dae80380057c6bdeb2a68a7c1f2eb4e0cf44bc92a5f475431a08c440405201e01894ebe94028643e77dbf3716aaaed3ef87669e5d74bf4a7cf72e8bd7a91dbd