film_snob 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9fd64b2ca72b970aff20eeab6af18223b9766657
-  data.tar.gz: db0546c3172f484046936d0aa9517323ea0ca751
+  metadata.gz: 9ebbfb259fe060f9088fb498d7fc8dbeec0dd930
+  data.tar.gz: a4b673eb9ba569919fd025020a2b51633f407a2c
 SHA512:
-  metadata.gz: dc87b47e6871f1e8cd6b3d48d80428fc9b9d4cad5df9522e895fc62b647913a6762015adb5233d4103278d8c0fc3b55bbcd9bae9af547f49bacedfe7696054b8
-  data.tar.gz: 22832cf25386d2b01df764f2f206fe5b6ce5b0ee300e09403cdc016af664ce671ba8bfa229ec3f2ddb4ec96c0578a3494f6f6fe966553b341991894dc4d56930
+  metadata.gz: 7ecbd09bb577700444161f9bf32d11b43bf89438bdc8b376ddb7da1db7f5ae3dcbcccf819fa9b9d02ea1f467ce626dbc043219768b26d411df6bf5feaff2cf3a
+  data.tar.gz: bb0872003be0a82cb8773ff5c0a7a0000fca00d70a51b75735ace03a4b9606de66a8e46d191ca910848d2b4724a2d69e48eddbd6f86cd5504cc958f44b0382d0

data/.travis.yml

@@ -3,4 +3,5 @@ rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.1.1
 before_install: 'gem install bundler -v 1.6'

data/film_snob.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "webmock", "~> 1.17"
   spec.add_development_dependency "vcr",     "~> 2.9"
   spec.add_development_dependency "debugger"
+
   spec.add_runtime_dependency     "httparty","~> 0.13"
 
   spec.required_ruby_version = '>= 1.9.3'

data/lib/film_snob/version.rb

@@ -1,3 +1,3 @@
 class FilmSnob
-  VERSION = "0.3.4"
+  VERSION = "0.3.5"
 end

data/lib/film_snob.rb

@@ -3,7 +3,7 @@ require "film_snob/url_to_video"
 require "film_snob/exceptions"
 
 class FilmSnob
-  attr_reader :url, :video
+  attr_reader :url
 
   def initialize(url, options={})
     @url = url
@@ -11,12 +11,11 @@ class FilmSnob
   end
 
   def watchable?
-    !video.nil?
+    !@video.nil?
   end
 
   def method_missing(message)
     if delegated_video_methods.include?(message)
-      complain_about_bad_urls!(message)
       video.send(message)
     else
       super
@@ -24,13 +23,17 @@ class FilmSnob
   end
 
   private
-  
-    def delegated_video_methods
-      [:site, :id, :clean_url, :title, :html]
+
+    def video
+      if watchable?
+        @video
+      else
+        raise NotSupportedURLError.new("#{url} is not a supported URL")
+      end
     end
 
-    def complain_about_bad_urls!(method)
-      raise NotSupportedURLError.new("Can not call FilmSnob##{method} because #{url} is not a supported URL.") unless watchable?
+    def delegated_video_methods
+      [:site, :id, :clean_url, :title, :html]
     end
 
 end

data/spec/film_snob_spec.rb

@@ -6,7 +6,7 @@ describe FilmSnob do
 
     it 'should handle non-supported URLs gracefully' do
       snob = FilmSnob.new("http://hardscrabble.net")
-      expect(snob.video).to be_nil
+      expect(snob).to_not be_watchable
     end
 
     it 'should raise an exception if you push your luck' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: film_snob
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Max Jacobson