filepond-rails 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d4db40f90628c511fd73a636ce3c513fd01d9db16249bf99ceb5966ea9c4469
-  data.tar.gz: ff09c1019e75f8c9aaa002397e8b797f88848e94ea4ce4deee80eaa7f6125050
+  metadata.gz: 3371b4f31b36a228ececa27ed2d98c2a5a1db0464ef699ee04f8d33024fa6c66
+  data.tar.gz: cf05bcc5c842119fefa32ccb135fe04470182f141f7ea141c98d1e0fb6922188
 SHA512:
-  metadata.gz: b57aa9177e77918141ec1bfd2fc694f7d5ace8d37c00d7f46c6637d981f3280e6196b65447042d981f480ae825fa89323ee1fbe19b28d7e6a15804fcffec64bb
-  data.tar.gz: 135ff06a64a2c6135d524644e5597a68416f2bd3ba1a824d8e8e9ebcbf96f1d51ecf633d1c2d7f32d1ee2031d925692e7a1d40592fa766f00acdd4eab61d0677
+  metadata.gz: a147658ff35f3fdac1827daa0d7a25e9ca7d4a3186f8ef4a262a9b76e806fbebd1542ee8d3e2c0a42a7d5da58fd3b686af46276f4d91b60d0b916de618450c38
+  data.tar.gz: df0bfab28be9c3dbca0ae60c8099650bf598a03cdc6133ade8077929f1f7c6d56530b45ffaaedb057b4144f062eae5ba139c864b65b4b9e1fd667f953fc0f1cf

data/README.md

@@ -1,28 +1,26 @@
 # filepond-rails
 
+![example workflow](https://github.com/Code-With-Rails/filepond-rails/actions/workflows/ci.yml/badge.svg)
+
+
 This gem allows you to quickly integrate [FilePond](https://github.com/pqina/filepond) with your Ruby on Rails app.
 
 ## Requirements
 * Rails 7.0.x and above
-* Use of [importmap-rails](https://github.com/rails/importmap-rails) (optional)
+* Use of [importmap-rails](https://github.com/rails/importmap-rails)
 
 ## Installation
 Add this line to your application's Gemfile:
 
 ```ruby
-gem "filepond-rails"
+gem 'filepond-rails'
 ```
 
-And then execute:
+And then run:
 ```bash
 $ bundle
 ```
 
-Or install it yourself as:
-```bash
-$ gem install filepond-rails
-```
-
 Add the following to your `application.css`:
 ```css
 *= require 'filepond'
@@ -77,5 +75,33 @@ The gem's JavaScript provide two available exports:
 1. `FilePond` (which corresponds to the original FilePond library)
 2. `FilePondRails` (which is a convenience helper that integrates and sets up FilePond to work with our `FilePond::Rails::IngressController`
 
+## Development
+
+filepond-rails is configured with Docker to help developer-contributors be able to easily work on this gem locally.
+
+To get started:
+
+1. Fork this repository
+2. git clone it to your local machine and cd into it
+3. Run `docker compose build`
+
+To run the gem through the "dummy" app, run:
+
+```bash
+docker compose up
+```
+
+To enter the development environment where you can run `bin/rails g controller` and other commands:
+
+```bash
+docker compose run app bash
+```
+
+You should now be able to run tests locally within this bash container:
+
+```bash
+bin/rails test
+```
+
 ## License
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/app/assets/javascripts/filepond-rails.js

@@ -59,7 +59,7 @@ let FilePondRails = {
     FilePondRails.input = input
 
     // Initialize FilePond on our element
-    FilePond.create(input, FilePondRails.default_options)
+    return FilePond.create(input, FilePondRails.default_options)
   }
 }
 

data/app/controllers/filepond/rails/ingress_controller.rb

@@ -13,20 +13,24 @@ module Filepond
       # The alternative way would be to directly proxy the request to
       # the URL where the file is originally hosted.
       def fetch
-        # We explicitly declare this for clarity of what is in the
-        # raw_post value as sent by FilePond
-        uri = URI.parse(raw_post)
-        url = uri.to_s
-        blob = ActiveStorage::Blob.create_and_upload!(
-          io: URI.open(uri),
-          filename: URI.parse(url).path.parameterize
-        )
-        if blob.persisted?
+        begin
+          # We explicitly declare this for clarity of what is in the
+          # raw_post value as sent by FilePond
+          uri = URI.parse(raw_post)
+          url = uri.to_s
+
+          blob = ActiveStorage::Blob.create_and_upload!(
+            io: URI.open(uri),
+            filename: URI.parse(url).path.parameterize
+          )
+
           redirect_to ::Rails.application.routes.url_helpers.rails_service_blob_path(
             blob.signed_id,
             blob.filename
           )
-        else
+        # Why we casting such a wide net with StandardError (TL;DR: too many errors to catch):
+        # See https://stackoverflow.com/a/46979718/20551849
+        rescue StandardError
           head :unprocessable_entity
         end
       end
@@ -39,8 +43,7 @@ module Filepond
         signed_id = raw_post
 
         blob = ActiveStorage::Blob.find_signed(signed_id)
-        if blob
-          blob.purge
+        if blob && blob.purge
           head :ok
         else
           # If we cannot find the blob, then we'll just return 404

data/lib/filepond/rails/version.rb

@@ -2,6 +2,6 @@
 
 module Filepond
   module Rails
-    VERSION = '0.1.0'
+    VERSION = '1.0.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: filepond-rails
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Simon Chiu
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-12-26 00:00:00.000000000 Z
+date: 2022-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -30,6 +30,20 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '8'
+- !ruby/object:Gem::Dependency
+  name: puma
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -37,9 +51,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.1.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -47,9 +58,62 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.18'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.18'
+- !ruby/object:Gem::Dependency
+  name: capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: dropybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: selenium-webdriver
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.4
+        version: '0'
 description: Add FilePond server endpoints and form helpers for Rails
 email:
 - simon@furvur.com
@@ -66,11 +130,6 @@ files:
 - app/assets/stylesheets/filepond.min.css
 - app/controllers/filepond/rails/application_controller.rb
 - app/controllers/filepond/rails/ingress_controller.rb
-- app/helpers/filepond/rails/application_helper.rb
-- app/jobs/filepond/rails/application_job.rb
-- app/mailers/filepond/rails/application_mailer.rb
-- app/models/filepond/rails/application_record.rb
-- app/views/layouts/filepond/rails/application.html.erb
 - config/importmap.rb
 - config/routes.rb
 - lib/filepond/rails.rb
@@ -100,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.3
+rubygems_version: 3.4.1
 signing_key:
 specification_version: 4
 summary: FilePond integration for Rails

data/app/helpers/filepond/rails/application_helper.rb

@@ -1,6 +0,0 @@
-module Filepond
-  module Rails
-    module ApplicationHelper
-    end
-  end
-end

data/app/jobs/filepond/rails/application_job.rb

@@ -1,6 +0,0 @@
-module Filepond
-  module Rails
-    class ApplicationJob < ActiveJob::Base
-    end
-  end
-end

data/app/mailers/filepond/rails/application_mailer.rb

@@ -1,8 +0,0 @@
-module Filepond
-  module Rails
-    class ApplicationMailer < ActionMailer::Base
-      default from: "from@example.com"
-      layout "mailer"
-    end
-  end
-end

data/app/models/filepond/rails/application_record.rb

@@ -1,7 +0,0 @@
-module Filepond
-  module Rails
-    class ApplicationRecord < ActiveRecord::Base
-      self.abstract_class = true
-    end
-  end
-end

data/app/views/layouts/filepond/rails/application.html.erb

@@ -1,15 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-  <title>Filepond rails</title>
-  <%= csrf_meta_tags %>
-  <%= csp_meta_tag %>
-
-  <%= stylesheet_link_tag    "filepond/rails/application", media: "all" %>
-</head>
-<body>
-
-<%= yield %>
-
-</body>
-</html>