fileboost 0.1.1 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4b0218cd56f2e874e631b1d0bab51c86e8fb2b0b91bdcd2c2879877bf1b2a64f
-  data.tar.gz: 3bd21ff3ba8f05f640c99a6003f2ca3da29feeca59d642a3230870705c7f21ab
+  metadata.gz: c4fec62d9be1b012648ceccd75eaa24a75c64ce4d3ae2e4d3fa060e08960de70
+  data.tar.gz: 67fbe1d13e4ec43b47c9517b3acddff6fc7a35a930b670cd15be781474d4824f
 SHA512:
-  metadata.gz: 8d85be5931908aed5d46285b2bf8b27bc70031987b2c7c643989694a0bd688a1e5c8fa442aa7598092a5e6f8d197c91c1973d26d33b2b031933a98f23acba58d
-  data.tar.gz: 82a9468ba2967c5cbc6bba6edcbc1faecdc962f6f50f913f179babcd18b86f610135a74f8b99a523f102e5f2a0e920e030159c701fdf082a4287cbd0dbb74424
+  metadata.gz: add42effb51bb5a83eaf754365d703ab6c9161f2c8aa7b7297b1aee99194e02f8b706eae6cf04e2f9137683c13c52dc5aa57451a94a7d5dffaa7246b479508a9
+  data.tar.gz: 56ebbea598301c491c2cfef190c9cdb15716b9621874beb8e5f3a007c4da2ba9c27303cf1784cd89a35daed9039ec81f961849576f588bed975ccebfdd675a15

data/README.md

@@ -205,17 +205,6 @@ $ bundle exec rubocop
 6. Push to the branch (`git push origin my-new-feature`)
 7. Create new Pull Request
 
-## Fileboost.dev Service
-
-To use Fileboost, you'll need access to the Fileboost.dev image optimization service at `cdn.fileboost.dev`. The service:
-
-1. Receives requests at `https://cdn.fileboost.dev/{project_id}/path/to/activestorage/blob`
-2. Verifies HMAC signatures using your secret token
-3. Applies transformations based on query parameters
-4. Returns optimized images
-
-The service handles ActiveStorage blob URLs and applies image transformations on-the-fly.
-
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
@@ -224,4 +213,3 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 - [GitHub Issues](https://github.com/bilalbudhani/fileboost/issues)
 - [Documentation](https://github.com/bilalbudhani/fileboost/wiki)
-- [Cloudflare Worker Setup Guide](https://github.com/bilalbudhani/fileboost-worker)

data/Rakefile

@@ -1,8 +1,7 @@
 require "bundler/setup"
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
 
-APP_RAKEFILE = File.expand_path("test/dummy/Rakefile", __dir__)
-load "rails/tasks/engine.rake"
-
-load "rails/tasks/statistics.rake"
+RSpec::Core::RakeTask.new(:spec)
 
-require "bundler/gem_tasks"
+task default: :spec

data/lib/fileboost/config.rb

@@ -11,7 +11,7 @@ module Fileboost
     end
 
     def valid?
-      project_id.present? && token.present?
+      !project_id.empty? && !token.empty?
     end
 
     def base_url
@@ -26,4 +26,4 @@ module Fileboost
   def self.configure
     yield(config) if block_given?
   end
-end
+end

data/lib/fileboost/engine.rb

@@ -7,11 +7,5 @@ module Fileboost
         include Fileboost::Helpers
       end
     end
-
-    initializer "fileboost.active_storage" do
-      ActiveSupport.on_load :active_storage_blob do
-        # Extend ActiveStorage::Blob with fileboost-specific methods if needed
-      end
-    end
   end
 end

data/lib/fileboost/error_handler.rb

@@ -1,57 +1,7 @@
 module Fileboost
-  class ErrorHandler
-    class << self
-      def handle_with_fallback(error_context, &block)
-        begin
-          yield
-        rescue StandardError => e
-          log_error(error_context, e)
-          
-          if Fileboost.config.fallback_to_rails
-            yield_fallback if block_given?
-          else
-            nil
-          end
-        end
-      end
-
-      def handle_gracefully(error_context, default_value = nil, &block)
-        begin
-          yield
-        rescue StandardError => e
-          log_error(error_context, e)
-          default_value
-        end
-      end
-
-      private
-
-      def log_error(context, error)
-        return unless defined?(Rails) && Rails.logger
-
-        Rails.logger.warn(
-          "[Fileboost] Error in #{context}: #{error.class}: #{error.message}"
-        )
-        
-        # Log backtrace in development for debugging
-        if Rails.env.development?
-          Rails.logger.debug(
-            "[Fileboost] Backtrace:\n#{error.backtrace.take(5).join("\n")}"
-          )
-        end
-      end
-
-      def yield_fallback
-        # This would be implemented by the calling code
-        # The pattern is to pass a fallback block when needed
-        nil
-      end
-    end
-  end
-
   # Specific exception classes for better error handling
   class ConfigurationError < StandardError; end
   class SignatureGenerationError < StandardError; end
   class UrlBuildError < StandardError; end
   class AssetPathExtractionError < StandardError; end
-end
+end

data/lib/fileboost/helpers.rb

@@ -18,9 +18,6 @@ module Fileboost
       # Generate the optimized URL
       optimized_url = fileboost_url_for(asset, resize: resize_options)
 
-      # Return empty string if no URL could be generated
-      return "" if optimized_url.blank?
-
       # Use the optimized URL with Rails image_tag for consistency
       image_tag(optimized_url, **options)
     end
@@ -36,16 +33,10 @@ module Fileboost
     #   fileboost_url_for(user.avatar.blob, resize: { w: 1200, h: 400, q: 85 })
     def fileboost_url_for(asset, **options)
       # Validate that asset is an ActiveStorage object
-      unless valid_activestorage_asset?(asset)
-        Rails.logger.error("[Fileboost] Invalid asset type #{asset.class}. Only ActiveStorage objects are supported.") if defined?(Rails)
-        return nil
-      end
+      raise ArgumentError, "Invalid asset type #{asset.class}. Only ActiveStorage objects are supported." unless valid_activestorage_asset?(asset)
 
       # Validate configuration
-      unless Fileboost.config.valid?
-        log_configuration_warning
-        return nil
-      end
+      raise Fileboost::ConfigurationError, "Invalid Fileboost configuration" unless Fileboost.config.valid?
 
       # Build the optimized URL
       Fileboost::UrlBuilder.build_url(asset, **options)
@@ -71,10 +62,13 @@ module Fileboost
       sizes.each do |size_config|
         suffix = size_config[:suffix] || size_config["suffix"]
         size_options = size_config.except(:suffix, "suffix")
-        combined_options = base_options.merge(size_options)
+
+        # Merge size options into base resize options
+        merged_resize_options = (base_options[:resize] || {}).merge(size_options)
+        combined_options = base_options.merge(resize: merged_resize_options)
 
         url = fileboost_url_for(asset, **combined_options)
-        urls[suffix] = url if url.present?
+        urls[suffix] = url if !url.nil? && !url.empty?
       end
 
       urls
@@ -91,17 +85,5 @@ module Fileboost
 
       false
     end
-
-    # Log configuration warnings
-    def log_configuration_warning
-      missing_configs = []
-      missing_configs << "project_id" if Fileboost.config.project_id.blank?
-      missing_configs << "token" if Fileboost.config.token.blank?
-
-      Rails.logger.warn(
-        "[Fileboost] Configuration incomplete. Missing: #{missing_configs.join(', ')}. " \
-        "Set FILEBOOST_PROJECT_ID and FILEBOOST_TOKEN environment variables or configure them in your initializer."
-      ) if defined?(Rails)
-    end
   end
 end

data/lib/fileboost/signature_generator.rb

@@ -3,42 +3,17 @@ require "base64"
 
 module Fileboost
   class SignatureGenerator
-    def self.generate(project_id:, asset_path:, params: {})
-      return nil unless project_id.present? && asset_path.present? && Fileboost.config.token.present?
-
+    def self.generate(asset_path:, params: {})
       # Sort parameters for consistent signature generation
       sorted_params = params.sort.to_h
       query_string = sorted_params.map { |k, v| "#{k}=#{v}" }.join("&")
 
       # Create the signing string: project_id:asset_path:sorted_query_params
-      signing_string = [project_id, asset_path, query_string].join(":")
-      Rails.logger.debug("signature payload #{project_id}, #{asset_path}, #{query_string}, #{Fileboost.config.token}")
+      signing_string = [ Fileboost.config.project_id, asset_path, query_string ].join(":")
       # Generate HMAC-SHA256 signature for secure authentication with Fileboost.dev
       digest = OpenSSL::HMAC.digest("SHA256", Fileboost.config.token, signing_string)
       # Use URL-safe base64 encoding and remove padding for maximum URL compatibility
       Base64.urlsafe_encode64(digest, padding: false)
-    rescue StandardError => e
-      if defined?(Rails) && Rails.env.development?
-        raise e
-      else
-        Rails.logger.warn("[Fileboost] Failed to generate signature: #{e.message}") if defined?(Rails)
-        nil
-      end
-    end
-
-    def self.verify_signature(project_id:, asset_path:, params: {}, signature:)
-      expected_signature = generate(project_id: project_id, asset_path: asset_path, params: params)
-      return false if expected_signature.nil? || signature.nil?
-
-      # Use secure comparison to prevent timing attacks
-      ActiveSupport::SecurityUtils.secure_compare(signature, expected_signature)
-    rescue StandardError => e
-      if defined?(Rails) && Rails.env.development?
-        raise e
-      else
-        Rails.logger.warn("[Fileboost] Failed to verify signature: #{e.message}") if defined?(Rails)
-        false
-      end
     end
   end
 end

data/lib/fileboost/url_builder.rb

@@ -31,44 +31,36 @@ module Fileboost
     RESIZE_PARAMS = %w[w width h height q quality f format b blur br brightness c contrast r rotation fit].freeze
 
     def self.build_url(asset, **options)
-      return nil unless Fileboost.config.valid?
-      
+      raise ConfigurationError, "Invalid configuration" unless Fileboost.config.valid?
+
       asset_path = extract_asset_path(asset)
-      return nil unless asset_path.present?
+      raise AssetPathExtractionError, "Unable to extract asset path" unless !asset_path.nil? && !asset_path.empty?
 
       project_id = Fileboost.config.project_id
       base_url = Fileboost.config.base_url
-      
+
       # Build the full asset URL path for Fileboost.dev service
       full_path = "/#{project_id}#{asset_path}"
-      
+
       # Extract and normalize transformation parameters
       transformation_params = extract_transformation_params(options)
-      
+
       # Generate HMAC signature for secure authentication
       signature = Fileboost::SignatureGenerator.generate(
-        project_id: project_id,
         asset_path: asset_path,
         params: transformation_params
       )
-      
-      return nil unless signature
-      
+
+      raise SignatureGenerationError, "Failed to generate signature" unless signature
+
       # Add signature to parameters
       all_params = transformation_params.merge("sig" => signature)
-      
+
       # Build final URL
       uri = URI.join(base_url, full_path)
       uri.query = URI.encode_www_form(all_params) unless all_params.empty?
-      
+
       uri.to_s
-    rescue StandardError => e
-      if defined?(Rails) && Rails.env.development?
-        raise e
-      else
-        Rails.logger.warn("[Fileboost] Failed to build URL: #{e.message}") if defined?(Rails)
-        nil
-      end
     end
 
     private
@@ -78,57 +70,48 @@ module Fileboost
       when ActiveStorage::Blob
         # ActiveStorage Blob
         Rails.application.routes.url_helpers.rails_blob_path(asset, only_path: true)
-        
+
       when ActiveStorage::Attached
         # ActiveStorage Attachment (has_one_attached, has_many_attached)
-        if asset.respond_to?(:blob) && asset.blob.present?
+        if asset.respond_to?(:blob) && !asset.blob.nil?
           Rails.application.routes.url_helpers.rails_blob_path(asset.blob, only_path: true)
         else
-          Rails.logger.warn("[Fileboost] ActiveStorage attachment has no blob") if defined?(Rails)
-          nil
+          raise AssetPathExtractionError, "ActiveStorage attachment has no blob"
         end
-        
+
       when ActiveStorage::VariantWithRecord
         # ActiveStorage Variant - use blob URL to avoid triggering variant generation
         Rails.application.routes.url_helpers.rails_blob_path(asset.blob, only_path: true)
-        
+
       else
         # Only ActiveStorage objects are supported
-        Rails.logger.warn("[Fileboost] Unsupported asset type: #{asset.class}. Only ActiveStorage objects are supported.") if defined?(Rails)
-        nil
-      end
-    rescue StandardError => e
-      if defined?(Rails) && Rails.env.development?
-        raise e
-      else
-        Rails.logger.warn("[Fileboost] Failed to extract asset path: #{e.message}") if defined?(Rails)
-        nil
+        raise AssetPathExtractionError, "Unsupported asset type: #{asset.class}. Only ActiveStorage objects are supported."
       end
     end
 
     def self.extract_transformation_params(options)
       params = {}
-      
+
       # Only handle nested resize parameter
       if options[:resize].is_a?(Hash)
         resize_options = options[:resize]
         resize_options.each do |key, value|
           key_str = key.to_s
-          
+
           # Only process valid resize parameters
           next unless RESIZE_PARAMS.include?(key_str)
-          
+
           # Use alias if available
           param_key = PARAM_ALIASES[key_str] || key_str
-          
+
           # Convert value to string and validate
           param_value = normalize_param_value(param_key, value)
-          next if param_value.blank?
-          
+          next if param_value.nil? || param_value.empty?
+
           params[param_key] = param_value
         end
       end
-      
+
       params
     end
 
@@ -152,4 +135,4 @@ module Fileboost
       end
     end
   end
-end
+end

data/lib/fileboost/version.rb

@@ -1,3 +1,3 @@
 module Fileboost
-  VERSION = "0.1.1"
+  VERSION = "0.1.5"
 end

data/lib/generators/fileboost/install_generator.rb

@@ -4,7 +4,7 @@ module Fileboost
   module Generators
     class InstallGenerator < Rails::Generators::Base
       desc "Create Fileboost initializer file"
-      
+
       def self.source_root
         @source_root ||= File.expand_path("templates", __dir__)
       end
@@ -24,4 +24,4 @@ module Fileboost
       end
     end
   end
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fileboost
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.5
 platform: ruby
 authors:
 - bilal
@@ -29,28 +29,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2'
 - !ruby/object:Gem::Dependency
   name: combustion
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: '1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -79,6 +79,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 8.0.0
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '6.0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: Fileboost provides drop-in replacement Rails image helpers with automatic
   optimization through the Fileboost.dev service. Works exclusively with ActiveStorage
   objects, features HMAC authentication, and comprehensive transformation support.