fides 1.0.1 → 1.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: bb5348f0123dc29b821666959c3ac4df69314296
+  data.tar.gz: 5cdd818167dc6a69d60167ff8fc78845da405943
+SHA512:
+  metadata.gz: 254fcc01368c3c0ab6fc2b39b280bddf927698d39416e74cf829816e47572db6b957b0454cbe9d87a08972f51e6510bcb0bede27a14ec54fadf07cc73ec13d07
+  data.tar.gz: 1f3b421f03f3e8a0adb45e90b94ffb2bfa96c539f971b0a02f0eb306c5ddff30c521b38fa1b8c515987aa01f2cec0de74a0a915d343b36605b16a0cc40ecfa9b

data/README.md

@@ -66,6 +66,16 @@ If you're using Rails < version 3.1, then use Fides in your migration like this:
     
     end
 
+## Tests
+
+    rake test:unit
+    rake test:sqlite3
+
+To run the postgresql integration tests you must first copy test/config/database.yml.example to test/config/database.yml
+and customize the values for your local postgres installation.
+
+    rake test:postgresql
+
 ## Caveats
 
 Fides assumes the use of Rails conventions, so if you find a case for something that needs overriding, 

data/Rakefile

@@ -5,6 +5,8 @@ require 'rake/testtask'
 require 'pg'
 require 'yaml'
 require 'sqlite3'
+require 'pry'
+require_relative 'test/integration/db_test'
 
 SQLITE3_FILE_PATH = "test/db/fides_test.sqlite3"
 
@@ -35,21 +37,25 @@ def destroy_sqlite3_db
   File.delete(SQLITE3_FILE_PATH)
 end
 
-task :create_databases do
-  postgres_db(:create => true)
-  create_sqlite3_db
-end
+namespace :test do
 
-task :destroy_databases do
-  postgres_db(:create => false)
-  destroy_sqlite3_db
-end
+  Rake::TestTask.new do |t|
+    t.name = :unit
+    t.libs << 'lib/fides'
+    t.test_files = FileList['test/unit/*_test.rb']
+    t.verbose = true
+  end
 
-Rake::TestTask.new do |t|
-  t.name = :run_tests
-  t.libs << 'lib/fides'
-  t.test_files = FileList['test/unit/*_test.rb', 'test/integration/*_test.rb']
-  t.verbose = true
-end
+  task :postgresql do
+    postgres_db(:create => false)
+    postgres_db(:create => true)
+    Fides.run_common_tests("postgresql")
+  end
+
+  task :sqlite3 do
+    # destroy_sqlite3_db
+    create_sqlite3_db
+    Fides.run_common_tests("sqlite3")
+  end
 
-task :test =>  [:create_databases, :run_tests, :destroy_databases]
+end

data/fides.gemspec

@@ -28,4 +28,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "minitest", "~> 4.7.0"
   spec.add_development_dependency "pg"
   spec.add_development_dependency "sqlite3"
+  spec.add_development_dependency "pry"
 end

data/lib/fides.rb

@@ -44,7 +44,6 @@ module Fides
     return "Fides::#{db_adapter.capitalize}Writer".constantize
   end
 
-  # TODO: Is it safe to just grab the first polymorphic association?
   def interface_name(model_name)
     model_name.constantize.reflect_on_all_associations.select { |r| r if r.options[:polymorphic] }.first.name
   end
@@ -53,4 +52,4 @@ end
 
 class ActiveRecord::Migration
   include Fides
-end
+end

data/lib/fides/sqlite3_writer.rb

@@ -40,6 +40,15 @@ module Fides
             SELECT CASE 
         }
 
+      sql << 'WHEN ('
+
+      models.each do |model|  
+        sql << %{NEW.#{interface_name}_type != '#{model}' }
+        sql << 'AND ' unless model == models.last
+      end
+
+      sql << %{) THEN RAISE(ABORT, 'There is no model by that name.') }
+
       models.each do |model|
         sql << %{ 
           WHEN ((NEW.#{interface_name}_type = '#{model}') AND (SELECT id 
@@ -62,6 +71,15 @@ module Fides
             SELECT CASE 
         }
 
+      sql << 'WHEN ('
+
+      models.each do |model|  
+        sql << %{NEW.#{interface_name}_type != '#{model}' }
+        sql << 'AND ' unless model == models.last
+      end
+
+      sql << %{) THEN RAISE(ABORT, 'There is no model by that name.') }
+
       models.each do |model|
         sql << %{ 
           WHEN ((NEW.#{interface_name}_type = '#{model}') AND (SELECT id 

data/lib/fides/version.rb

@@ -1,3 +1,3 @@
 module Fides
-  VERSION = "1.0.1"
+  VERSION = "1.1.0"
 end

data/test/integration/db_test.rb

@@ -1,7 +1,12 @@
 require_relative '../test_helper'
 
 module Fides
-  def self.run_common_tests
+  def self.run_common_tests(adapter)
+    execute_migration(adapter) do
+      CreateTestTables.new.change
+      AddTriggers.new.up
+    end
+
     describe "PostgreSQL database interaction behaviour" do
       it "raises an exception inserting a polymorphic without a coresponding record" do
         clothing_article = ClothingArticle.new
@@ -24,6 +29,40 @@ module Fides
         clothing_article.save
 
         assert_raises(ActiveRecord::StatementInvalid) { Senior.find(senior.id).delete }
+        assert_raises(ActiveRecord::StatementInvalid) { Senior.find(senior.id).destroy }
+      end
+
+      it "doesn't get in the way of :dependent => :destroy" do
+        baby = Baby.new
+        baby.name = "Suze"
+        baby.save
+        baby.reload
+        
+        clothing_article = ClothingArticle.new
+        clothing_article.name = "Bloomers"
+        clothing_article.wearable_id = baby.id
+        clothing_article.wearable_type = "Baby"
+        clothing_article.save
+        before_destroy_count = ClothingArticle.count
+        baby.destroy
+
+        assert_equal (before_destroy_count - 1), ClothingArticle.count
+      end
+
+      it "does enfoce dependent destroy behaviour if delete is used instead of destroy" do
+        baby = Baby.new
+        baby.name = "Suze"
+        baby.save
+        baby.reload
+        
+        clothing_article = ClothingArticle.new
+        clothing_article.name = "Bloomers"
+        clothing_article.wearable_id = baby.id
+        clothing_article.wearable_type = "Baby"
+        clothing_article.save
+        before_destroy_count = ClothingArticle.count
+
+        assert_raises(ActiveRecord::StatementInvalid) { baby.delete }
       end
 
       it "allows an insert of a model type specified in #add_polymorphic_triggers" do
@@ -48,19 +87,62 @@ module Fides
         assert Teenager.find(teenager.id).delete
       end
 
-      it "allows an insert of a model type that wasn't specified in #add_polymorphic_triggers" do
+      it "allows a destroy of a record NOT referenced by the polymorphic table" do
+        teenager = Teenager.new
+        teenager.name = "Johnny"
+        teenager.save
+        teenager.reload
+
+        assert Teenager.find(teenager.id).destroy
+      end
+
+      it "does not allow an insert of a model type that wasn't specified in #add_polymorphic_triggers" do
         clothing_article = ClothingArticle.new
         clothing_article.name = "Nothing"
         clothing_article.wearable_id = 123
         clothing_article.wearable_type = "Zygote"
-        assert clothing_article.save
+        
+        assert_raises(ActiveRecord::StatementInvalid) { clothing_article.save }
+      end
+
+      it "does not allow an update to a model type that wasn't specified in #add_polymorphic_triggers" do
+        baby = Baby.new
+        baby.name = "JJ"
+        baby.save
+        baby.reload
+        
+        clothing_article = ClothingArticle.new
+        clothing_article.name = "Onesie"
+        clothing_article.wearable_id = baby.id
+        clothing_article.wearable_type = "Baby"
+        clothing_article.save
+        clothing_article.reload
+
+        clothing_article.wearable_type = "Zygote"
+        assert_raises(ActiveRecord::StatementInvalid) { clothing_article.save }
+      end
+
+      it "drops the trigger properly" do
+        begin
+          execute_migration(adapter) do
+            AddTriggers.new.down
+          end
+          clothing_article = ClothingArticle.new
+          clothing_article.name = "Nothing"
+          clothing_article.wearable_id = 123
+          clothing_article.wearable_type = "Zygote"
+          
+          assert clothing_article.save
+        rescue
+
+        ensure
+          execute_migration(adapter) do
+            AddTriggers.new.up
+          end
+        end
       end
     end # describe
   end # run_common_tests
 
-  connect_and_migrate_database("postgresql")
-  run_common_tests
 
-  connect_and_migrate_database("sqlite3")
-  run_common_tests
 end # Fides

data/test/integration/migrations/add_triggers.rb

@@ -0,0 +1,9 @@
+class AddTriggers < ActiveRecord::Migration
+  def up
+    add_polymorphic_triggers(:polymorphic_model => "ClothingArticle", :associated_models => ["Baby", "Senior", "Teenager"])
+  end
+
+  def down
+    remove_polymorphic_triggers(:polymorphic_model => "ClothingArticle")
+  end
+end

data/test/integration/migrations/create_test_tables.rb

@@ -21,7 +21,5 @@ class CreateTestTables < ActiveRecord::Migration
       t.string :name
       t.timestamps
     end
-
-    add_polymorphic_triggers(:polymorphic_model => "ClothingArticle", :associated_models => ["Baby", "Senior", "Teenager"])
   end
 end

data/test/integration/models/baby.rb

@@ -1,4 +1,4 @@
 class Baby < ActiveRecord::Base
   self.table_name = 'babies'
-  has_many :clothing_articles, :as => :wearable
+  has_many :clothing_articles, :as => :wearable, :dependent => :destroy
 end

data/test/test_helper.rb

@@ -3,23 +3,22 @@ require 'minitest/pride'
 require File.expand_path('../../lib/fides.rb', __FILE__)
 require 'pg'
 require_relative 'integration/migrations/create_test_tables'
+require_relative 'integration/migrations/add_triggers'
 require_relative 'integration/models/baby'
 require_relative 'integration/models/teenager'
 require_relative 'integration/models/senior'
 require_relative 'integration/models/clothing_article'
 
-
-def connect_and_migrate_database(adapter_name)
+def execute_migration(adapter_name)
   path = File.join(File.dirname(__FILE__), "config", "database.yml")      
   yaml = YAML.load_file(path)
   yaml["sqlite3"] = { :adapter => "sqlite3", :database => File.join(File.dirname(__FILE__), "db", "fides_test.sqlite3") }
   connection_config = yaml[adapter_name]
 
   ActiveRecord::Base.establish_connection(connection_config)
-
   Rails.stub :env, "test" do
     ActiveRecord::Base.stub :configurations, { "test" => { "adapter" => adapter_name } } do
-      CreateTestTables.new.change
+      yield
     end
   end
 end

data/test/unit/sqlite3_test.rb

@@ -36,6 +36,7 @@ describe Fides::Sqlite3Writer do
       BEFORE INSERT ON pictures
       BEGIN 
         SELECT CASE
+          WHEN (NEW.imageable_type != 'Product' AND NEW.imageable_type != 'Employee' ) THEN RAISE(ABORT, 'There is no model by that name.')
           WHEN ((NEW.imageable_type = 'Product') AND (SELECT id FROM products WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Product with that id.')
           WHEN ((NEW.imageable_type = 'Employee') AND (SELECT id FROM employees WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Employee with that id.')
         END;
@@ -87,6 +88,7 @@ describe Fides::Sqlite3Writer do
       BEFORE UPDATE ON pictures
       BEGIN 
         SELECT CASE
+          WHEN (NEW.imageable_type != 'Product' AND NEW.imageable_type != 'Employee' ) THEN RAISE(ABORT, 'There is no model by that name.')
           WHEN ((NEW.imageable_type = 'Product') AND (SELECT id FROM products WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Product with that id.')
           WHEN ((NEW.imageable_type = 'Employee') AND (SELECT id FROM employees WHERE id = NEW.imageable_id) ISNULL) THEN RAISE(ABORT, 'There is no Employee with that id.')
         END;

metadata

@@ -1,68 +1,60 @@
 --- !ruby/object:Gem::Specification
 name: fides
 version: !ruby/object:Gem::Version
-  version: 1.0.1
-  prerelease: 
+  version: 1.1.0
 platform: ruby
 authors:
 - Martin Kraft
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-13 00:00:00.000000000 Z
+date: 2013-04-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,23 +69,20 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -102,7 +90,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -110,33 +97,43 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Maintains referential integrity of Rails polymorphic associations.
@@ -162,6 +159,7 @@ files:
 - test/config/database.yml.example
 - test/db/.gitkeep
 - test/integration/db_test.rb
+- test/integration/migrations/add_triggers.rb
 - test/integration/migrations/create_test_tables.rb
 - test/integration/models/baby.rb
 - test/integration/models/clothing_article.rb
@@ -176,33 +174,33 @@ files:
 homepage: https://github.com/mkraft/fides
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Creates SQL triggers from Rails migrations to enforce the integrity of  polymorphic
   associations at the database level.
 test_files:
 - test/config/database.yml.example
 - test/db/.gitkeep
 - test/integration/db_test.rb
+- test/integration/migrations/add_triggers.rb
 - test/integration/migrations/create_test_tables.rb
 - test/integration/models/baby.rb
 - test/integration/models/clothing_article.rb