ffi-hunspell 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b29a3ff5f68640f1c8123c5895074ed2d986961a15fd3f8921baf1bd83769831
-  data.tar.gz: fcf088c5e73c7c6dd5ac23db60a8c14c9be58a4dea16e7aa2d0006ed5f019694
+  metadata.gz: 73c2a507e6fe1a6f34ff4a97f4db79c0518f5d352386c82cc69e6c35bfbe075a
+  data.tar.gz: dd5c8a8190a2cfa273f07a84fafea7c3422e1a3a4cdd4b6a1d629c465ced350e
 SHA512:
-  metadata.gz: ef1c370fd0471c1f50748a6c4775313090b5f676c25ed9976932749149905d80c1c02d574ae8dd553ff7d380ddd7f9b5825f30240ec9f17f45e28ff6e98f2007
-  data.tar.gz: 365cb6e3fb48e17f1303e76cbd0082e57b0d3d5814f8ff7a2c8c0415fcaa1c3287fedd96ad6c0d94fc2e844d459a07556df38bd5ccd64b6f470c8e75bc860236
+  metadata.gz: db867a438a0c6546d3175bf086ec999f905f27bbe663cc3a8758fd43516bb1968843f16800f6bf2f2322356005fd84e7c5915e2a964abb1b6cd8d7ce57f82d2b
+  data.tar.gz: 1af4a53d595bf279a43db1e1a3c5d8cdbe5439ef8853f4e829cc7b38115e1632a770c41af401645f427e5b85f7449257edc00f8434e205eee488d5c45cde7908

data/.github/workflows/ruby.yml

@@ -1,10 +1,6 @@
 name: CI
 
-on:
-  push:
-    branches: [ master ]
-  pull_request:
-    branches: ['**']
+on: [ push, pull_request ]
 
 jobs:
   tests:
@@ -17,6 +13,7 @@ jobs:
           - 2.5
           - 2.6
           - 2.7
+          - 3.0
           - jruby
     name: Ruby ${{ matrix.ruby }}
     steps:

data/ChangeLog.md

@@ -1,3 +1,13 @@
+### 0.6.1 / 2021-02-12
+
+* Fixed a possible memory leak in {FFI::Hunspell::Dictionary#stem} and 
+  {FFI::Hunspell::Dictionary#suggest}.
+* Prevent a possible memory leak if {FFI::Hunspell::Dictionary#close} is not
+  called, which deallocates the underlying libhunspell handler pointer,
+  before the dictionary is garbage collected. Note: if
+  {FFI::Hunspell::Dictionary.open} is called with a block, the dictionary object
+  will explicitly be closed once the block returns.
+
 ### 0.6.0 / 2020-11-28
 
 * Added {FFI::Hunspell::Dictionary#add_dic} which adds an extra dictionary

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2010-2020 Hal Brodigan
+Copyright (c) 2010-2021 Hal Brodigan
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -3,7 +3,6 @@
 * [Source](https://github.com/postmodern/ffi-hunspell)
 * [Issues](https://github.com/postmodern/ffi-hunspell/issues)
 * [Documentation](http://rubydoc.info/gems/ffi-hunspell/frames)
-* [Email](postmodern.mod3 at gmail.com)
 
 ## Description
 
@@ -64,11 +63,25 @@ dict.suggest('arbitrage')
 $ gem install ffi-hunspell
 ```
 
+### libhunspell
+
+* Debian / Ubuntu:
+
+      $ sudo apt install libhunspell-dev hunspell-en-us
+
+* RedHat / Fedora:
+
+      $ sudo dnf install hunspell-devel hunspell-en
+
+* macOS:
+
+      $ brew install hunspell
+
 ## License
 
-Copyright (c) 2010-2020 Hal Brodigan
+Copyright (c) 2010-2021 Hal Brodigan
 
 See {file:LICENSE.txt} for license information.
 
 [libhunspell]: http://hunspell.github.io/
-[ffi]: https://github.com/ffi/ffi
+[ffi]: https://github.com/ffi/ffi#readme

data/ffi-hunspell.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |gem|
   gem.authors     = Array(gemspec['authors'])
   gem.email       = gemspec['email']
   gem.homepage    = gemspec['homepage']
+  gem.metadata    = gemspec['metadata'] if gemspec['metadata']
 
   glob = lambda { |patterns| gem.files & Dir[*patterns] }
 

data/gemspec.yml

@@ -7,6 +7,12 @@ email: postmodern.mod3@gmail.com
 homepage: https://github.com/postmodern/ffi-hunspell#readme
 has_yard: true
 
+metadata:
+  documentation_uri: https://rubydoc.info/gems/ffi-hunspell
+  source_code_uri:   https://github.com/postmodern/ffi-hunspell
+  bug_tracker_uri:   https://github.com/postmodern/ffi-hunspell/issues
+  changelog_uri:     https://github.com/postmodern/ffi-hunspell/blob/master/ChangeLog.md
+
 requirements: libhunspell >= 1.2.0, <= 1.7.0
 
 required_ruby_version: ">= 1.9.1"

data/lib/ffi/hunspell/dictionary.rb

@@ -37,9 +37,11 @@ module FFI
           raise("invalid dic path #{dic_path.inspect}")
         end
 
-        @ptr = if key then Hunspell.Hunspell_create_key(affix_path,dic_path,key)
-               else        Hunspell.Hunspell_create(affix_path,dic_path)
-               end
+        ptr = if key then Hunspell.Hunspell_create_key(affix_path,dic_path,key)
+              else        Hunspell.Hunspell_create(affix_path,dic_path)
+              end
+
+        @ptr = FFI::AutoPointer.new(ptr,Hunspell.method(:Hunspell_destroy))
       end
 
       #
@@ -207,6 +209,8 @@ module FFI
 
           if count > 0
             stems = ptr.get_array_of_string(0,count)
+
+            Hunspell.Hunspell_free_list(self,output,count)
           end
         end
 
@@ -231,6 +235,8 @@ module FFI
 
           if count > 0
             suggestions = ptr.get_array_of_string(0,count)
+
+            Hunspell.Hunspell_free_list(self,output,count)
           end
         end
 
@@ -243,9 +249,11 @@ module FFI
       # @return [nil]
       #
       def close
-        Hunspell.Hunspell_destroy(self)
+        if @ptr
+          @ptr.free
+          @ptr = nil
+        end
 
-        @ptr = nil
         return nil
       end
 

data/lib/ffi/hunspell/version.rb

@@ -2,6 +2,6 @@ module FFI
   module Hunspell
     # ffi-hunspell versiont 
     # @since 0.5.0
-    VERSION = '0.6.0'
+    VERSION = '0.6.1'
   end
 end

data/spec/dictionary_spec.rb

@@ -58,7 +58,8 @@ describe Hunspell::Dictionary do
     end
 
     describe "#add_dic" do
-      let(:extra_dic) { File.join(File.dirname(__FILE__),'fixtures/extra.dic') }
+      let(:fixtures_dir) { File.expand_path('../fixtures',__FILE__) }
+      let(:extra_dic)    { File.join(fixtures_dir,'extra.dic')      }
 
       if FFI::Hunspell.respond_to?(:Hunspell_add_dic)
         context "when libhunspell supports add_dic" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ffi-hunspell
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Postmodern
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-28 00:00:00.000000000 Z
+date: 2021-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ffi
@@ -70,7 +70,11 @@ files:
 homepage: https://github.com/postmodern/ffi-hunspell#readme
 licenses:
 - MIT
-metadata: {}
+metadata:
+  documentation_uri: https://rubydoc.info/gems/ffi-hunspell
+  source_code_uri: https://github.com/postmodern/ffi-hunspell
+  bug_tracker_uri: https://github.com/postmodern/ffi-hunspell/issues
+  changelog_uri: https://github.com/postmodern/ffi-hunspell/blob/master/ChangeLog.md
 post_install_message: 
 rdoc_options: []
 require_paths: