fetching 0.5.0 → 0.6.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 17a2d47d0a5f371c2f183a86e4f0251f8b84d522
+  data.tar.gz: 78bd54db29bee8f7a3f86f8e168279e4ee00474e
+SHA512:
+  metadata.gz: 04933886fb1e0623087cea84a87da2a2af2c541af9d1a0ada4ad4ae4e4b685c7c0273f156f87483ca5f9cbcf7725a4255b34ef51f6d0d21b31008cd777cca1eb
+  data.tar.gz: 347ff59ef74c2076c0514b943d30c3b7a94f5d27b8e4777df5635629bf9e2809db3a9cc2c3d246e994dc628c3269e6e9cff71457a5697ce5d80b42c002ff7075

data/.rubocop.yml

@@ -0,0 +1,37 @@
+AllCops:
+  Include:
+    - Gemfile
+    - Rakefile
+
+Documentation:
+  Enabled: false
+
+Encoding:
+  Enabled: false
+
+EmptyLinesAroundBody:
+  Enabled: false
+
+LineLength:
+  Max: 100
+
+MethodDefParentheses:
+  Enabled: false
+
+NumericLiterals:
+  Enabled: false
+
+RegexpLiteral:
+  MaxSlashes: 0
+  Exclude:
+    - Guardfile
+
+SpecialGlobalVars:
+  Exclude:
+    - fetching.gemspec
+
+StringLiterals:
+  EnforcedStyle: double_quotes
+
+TrailingComma:
+  EnforcedStyleForMultiline: comma

data/Gemfile

@@ -1,4 +1,4 @@
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
 # Specify your gem's dependencies in fetching.gemspec
 gemspec

data/fetching.gemspec

@@ -1,14 +1,14 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'fetching/version'
+require "fetching/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "fetching"
   spec.version       = Fetching::VERSION
   spec.authors       = ["Michael Gee", "Mark Lorenz"]
   spec.email         = ["mgee@covermymeds.com", "mlorenz@covermymeds.com"]
-  spec.description   = %q{More sass in more structs.}
+  spec.description   = %q(More sass in more structs.)
 
   spec.summary       = <<-HEREDOC
 This gem is a work in progress.  The implementation code is not what's

data/lib/fetching/fetching_array.rb

@@ -26,7 +26,7 @@ class Fetching
       def length
         @table.length
       end
-      alias size length
+      alias_method :size, :length
 
       def reverse
         Fetching.from @table.reverse

data/lib/fetching/fetching_hash.rb

@@ -20,7 +20,7 @@ class Fetching
       end
     end
 
-    def method_missing key, *args, &block
+    def method_missing key, *_args, &_block
       fail NoMethodError, "#{key} not found\nyou have:\n#{@table.inspect}"
     end
 

data/lib/fetching/version.rb

@@ -1,3 +1,3 @@
 class Fetching
-  VERSION = "0.5.0"
+  VERSION = "0.6.0"
 end

data/lib/fetching.rb

@@ -4,7 +4,7 @@ require "fetching/fetching_hash"
 
 module Kernel
 
-  def Fetching(arg)
+  def Fetching(arg) # rubocop:disable MethodName
     Fetching.from(arg)
   end
 
@@ -12,26 +12,25 @@ end
 
 class Fetching
 
-  WHITELIST = %w[ define_singleton_method class object_id
-                  == instance_variables instance_eval
-                  instance_variable_get ]
+  WHITELIST = %w(
+    class object_id == equal?
+    define_singleton_method instance_eval
+    respond_to?
+    instance_variables instance_variable_get
+  )
 
   all_methods = instance_methods.map(&:to_s).grep(/\A[^_]/)
   (all_methods - WHITELIST).each(&method(:undef_method))
 
   def self.from(value)
-    case value
-    when ->(v) { v.respond_to? :to_ary }
-      FetchingArray.new(value.to_ary)
-    when ->(v) { v.respond_to? :to_hash }
-      FetchingHash.new(value.to_hash)
-    else
-      value
-    end
+    return value.to_fetching               if value.respond_to? :to_fetching
+    return FetchingArray.new(value.to_ary) if value.respond_to? :to_ary
+    return FetchingHash.new(value.to_hash) if value.respond_to? :to_hash
+    value
   end
 
-  def self.from_json json, closure
-    from(JSON.parse json).__send__ closure
+  def self.from_json json
+    from(JSON.parse json)
   end
 
   def initialize table
@@ -46,12 +45,22 @@ class Fetching
     self.class.hash ^ @table.hash
   end
 
+  def to_fetching
+    self
+  end
+
   def to_s
     @table.to_s
   end
 
   def inspect
-    "#<#{self.class.name}: @table=#{to_s}>"
+    "#<#{self.class.name}: @table=#{@table}>"
+  end
+
+  private
+
+  def respond_to_missing? _method_name, _include_private = false
+    false
   end
 
 end

data/spec/fetching_array_spec.rb

@@ -2,14 +2,23 @@ require "spec_helper"
 
 describe Fetching::FetchingArray do
 
+  specify "a Fetching object as a value" do
+    ary = Fetching([1, 2])
+    hsh = Fetching(one: 1)
+    [ary, hsh].each do |obj|
+      fetching_ary = Fetching [obj]
+      expect(fetching_ary.first).to equal(obj)
+    end
+  end
+
   specify "#map" do
     ary = [1, 2]
     fetching_ary = Fetching(ary)
-    expect(fetching_ary.map(&:to_s)).to eq(%w[1 2])
+    expect(fetching_ary.map(&:to_s)).to eq(%w(1 2))
   end
 
   specify "Fetching should go deep" do
-    Fetching([{one: 1}]).each do |element|
+    Fetching([{ one: 1 }]).each do |element|
       expect(element.one).to eq(1)
     end
   end
@@ -17,7 +26,7 @@ describe Fetching::FetchingArray do
   specify "#first" do
     ary = []
     sassy_ary = Fetching(ary)
-    expect{ sassy_ary.first }.to raise_error(IndexError)
+    expect { sassy_ary.first }.to raise_error(IndexError)
   end
 
   describe "array methods" do
@@ -25,11 +34,11 @@ describe Fetching::FetchingArray do
     let(:fetching) { Fetching(array) }
 
     describe "#empty?" do
-      it("should be false"){ expect(fetching.empty?).to be_false }
+      it("should be false") { expect(fetching.empty?).to be_false }
 
       context "when empty" do
         let(:array) { [] }
-        it("should be true"){ expect(fetching.empty?).to be_true }
+        it("should be true") { expect(fetching.empty?).to be_true }
       end
     end
 
@@ -50,13 +59,13 @@ describe Fetching::FetchingArray do
     end
 
     specify "#sort" do
-      sorter = ->(x, y){ y <=> x }
+      sorter = ->(x, y) { y <=> x }
       sorted = Fetching(array.sort(&sorter))
       expect(fetching.sort(&sorter)).to eq(sorted)
     end
 
     specify "#sort_by" do
-      sorter = ->(i){ 1/i.to_f }
+      sorter = ->(i) { 1.0 / i }
       sorted = Fetching(array.sort_by(&sorter))
       expect(fetching.sort_by(&sorter)).to eq(sorted)
     end
@@ -70,7 +79,7 @@ describe Fetching::FetchingArray do
       specify "out of bounds" do
         at = 5
         expected_message = "index #{at} outside of array bounds: -3...3"
-        expect{ fetching.values_at(at) }.to raise_error(IndexError, expected_message)
+        expect { fetching.values_at(at) }.to raise_error(IndexError, expected_message)
       end
     end
 

data/spec/fetching_hash_spec.rb

@@ -2,8 +2,17 @@ require "spec_helper"
 
 describe Fetching::FetchingHash do
 
+  specify "a Fetching object as a value" do
+    ary = Fetching([1, 2])
+    hsh = Fetching(one: 1)
+    [ary, hsh].each do |obj|
+      fetching_ary = Fetching key: obj
+      expect(fetching_ary.key).to equal(obj)
+    end
+  end
+
   specify "#to_hash" do
-    hash = {one: 1, two: 2}
+    hash = { one: 1, two: 2 }
     fetching_hash = Fetching(hash)
     expect(fetching_hash.to_hash).to eq(hash)
   end
@@ -16,7 +25,7 @@ describe Fetching::FetchingHash do
   end
 
   specify "#to_hash does a deep copy" do
-    hash = {one: 1, two: {three: 3}}
+    hash = { one: 1, two: { three: 3 } }
     fetching_hash = Fetching(hash)
     expect(fetching_hash.to_hash).to eq(hash)
   end

data/spec/fetching_spec.rb

@@ -3,7 +3,7 @@ require "spec_helper"
 describe Fetching do
 
   let(:input)       { { one: 1, two: two, ary: ary, object_ary: object_ary } }
-  let(:two)         { { "two"=>2 } }
+  let(:two)         { { "two" => 2 } }
   let(:ary)         { [1, 2] }
   let(:object_ary)  { [{}, last_object] }
   let(:last_object) { { three: 3 } }
@@ -18,22 +18,20 @@ describe Fetching do
 
   describe "an unknown hash key" do
     it "raises NoMethodError" do
-      expected_message = "not_a_key not found\nyou have:\n{:one=>1, :two=>{\"two\"=>2}, :ary=>[1, 2], :object_ary=>[{}, {:three=>3}]}"
+      expected_message = <<-EOM.gsub(/^ +/, "").strip
+        not_a_key not found
+        you have:
+        {:one=>1, :two=>{\"two\"=>2}, :ary=>[1, 2], :object_ary=>[{}, {:three=>3}]}
+      EOM
 
-      expect{ subject.not_a_key }.to raise_error(NoMethodError, expected_message)
+      expect { subject.not_a_key }.to raise_error(NoMethodError, expected_message)
     end
   end
 
   describe "an unknown array index" do
     it "raises NoMethodError" do
       expected_message = "index 3 outside of array bounds: -2...2"
-      expect{ subject.ary[ary.size + 1] }.to raise_error(IndexError, expected_message)
-    end
-  end
-
-  describe "a bad closure" do
-    it "raises the expected error" do
-      expect { Fetching.from_json("{}", :not_a_key) }.to raise_error(NoMethodError)
+      expect { subject.ary[ary.size + 1] }.to raise_error(IndexError, expected_message)
     end
   end
 
@@ -43,8 +41,15 @@ describe Fetching do
   end
 
   it "has a nice #inspect" do
-    nice_inspect = "#<Fetching::FetchingHash: @table={:one=>1, :two=>{\"two\"=>2}, :ary=>[1, 2], :object_ary=>[{}, {:three=>3}]}>"
+    table = "{:one=>1, :two=>{\"two\"=>2}, :ary=>[1, 2], :object_ary=>[{}, {:three=>3}]}"
+    nice_inspect = "#<Fetching::FetchingHash: @table=#{table}>"
     expect(subject.inspect).to eq(nice_inspect)
   end
 
+  specify ".from_json" do
+    json     = '{ "some_key": 1 }'
+    expected = Fetching(JSON.parse(json))
+    expect(described_class.from_json(json)).to eq(expected)
+  end
+
 end

data/spec/support/vim_formatter.rb

@@ -1,5 +1,5 @@
 # Adapted from https://github.com/bronson/vim-runtest/blob/master/rspec_formatter.rb.
-require 'rspec/core/formatters/base_text_formatter'
+require "rspec/core/formatters/base_text_formatter"
 
 class VimFormatter < RSpec::Core::Formatters::BaseTextFormatter
 
@@ -9,27 +9,27 @@ class VimFormatter < RSpec::Core::Formatters::BaseTextFormatter
       frame =~ %r{\b(spec/.*_spec\.rb:\d+)(?::|\z)}
     end
     message = format_message exception.message
-    path    = format_caller(path || ' ')
-    output.puts "#{path}: #{example.example_group.description.strip} " +
+    path    = format_caller(path || " ")
+    output.puts "#{path}: #{example.example_group.description.strip} " \
       "#{example.description.strip}: #{message.strip}" if path
   end
 
-  def example_pending *args; end
+  def example_pending *_args; end
 
-  def dump_failures   *args; end
+  def dump_failures   *_args; end
 
-  def dump_pending    *args; end
+  def dump_pending    *_args; end
 
-  def message          msg;  end
+  def message          _msg;  end
 
-  def dump_summary    *args; end
+  def dump_summary    *_args; end
 
-  def seed            *args; end
+  def seed            *_args; end
 
   private
 
   def format_message msg
-    msg.gsub("\n", ' ')[0, 80]
+    msg.gsub("\n", " ")[0, 80]
   end
 
 end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fetching
 version: !ruby/object:Gem::Version
-  version: 0.5.0
-  prerelease: 
+  version: 0.6.0
 platform: ruby
 authors:
 - Michael Gee
@@ -10,12 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-09 00:00:00.000000000 Z
+date: 2014-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -23,7 +21,6 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -31,49 +28,43 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-plus
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: More sass in more structs.
@@ -85,6 +76,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .rubocop.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -102,28 +94,27 @@ files:
 homepage: ''
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.6
 signing_key: 
-specification_version: 3
-summary: ! 'This gem is a work in progress.  The implementation code is not what''s
+specification_version: 4
+summary: 'This gem is a work in progress.  The implementation code is not what''s
   important.  What is important: Don''t de-serialize API responses in to hashes and
   arrays.  Use a "strict" object that inforces key presence, and array bounds.}'
 test_files: