ferrum 0.8 → 0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1fb53f7db2767597ff5d6e7ff08536562edec30f5d68fbb2dcac7bf9943e056d
-  data.tar.gz: 46f9f75de5f4c0a4531dbbeda25c538350c3daa167f5de53c9248dbfc6958e34
+  metadata.gz: 8b4d6dc7aa1827fbf559e6025b82d29d15ed0e36a89793049266d8049fadabb9
+  data.tar.gz: 6fab0202e85a17971d613db12e37a7ef85325eaf23f718b6801812df565ac64c
 SHA512:
-  metadata.gz: 0e15da4027c44cd38e3d4eaf6f3384085fbb85fe5760ade585bbaaf2c4ea4fa79db98c23fee3099b33e1d09ab50e1ce8b979ec8848203a3d0c4b45fbe6208b7f
-  data.tar.gz: 7038d36ca9cca2204d9a489380ae0db7d75f202921a3b31b4bd9cbed3c54fb4bd187d5270052dfcdeba300ba615140b33660982dfaa6f99759a3463c52434fc1
+  metadata.gz: fb109c1b65e73e8d0088734fa004fae3d15650121d01b44dc9086cdb193bb3c7f56c3ad911a2f6de5cd28522231b4e695b67eb515d90afe93b862eb64cfe7050
+  data.tar.gz: a4d5e4c192cbd634c640d86027f3a8faeaf42efcd8fbaa9b0e8c6e81c04aa9921b7f2353eb739c35850363f1ed58f84d5895714f52ecd333d9ebdb50c1de4031

data/README.md

@@ -90,7 +90,7 @@ Interact with a page:
 ```ruby
 browser = Ferrum::Browser.new
 browser.goto("https://google.com")
-input = browser.at_xpath("//div[@id='searchform']/form//input[@type='text']")
+input = browser.at_xpath("//input[@name='q']")
 input.focus.type("Ruby headless driver for Chrome", :Enter)
 browser.at_css("a > h3").text # => "rubycdp/ferrum: Ruby Chrome/Chromium driver - GitHub"
 browser.quit
@@ -147,6 +147,7 @@ Ferrum::Browser.new(options)
 
 * options `Hash`
   * `:headless` (Boolean) - Set browser as headless or not, `true` by default.
+  * `:xvfb` (Boolean) - Run browser in a virtual framebuffer, `false` by default.
   * `:window_size` (Array) - The dimensions of the browser window in which to
       test, expressed as a 2-element array, e.g. [1024, 768]. Default: [1024, 768]
   * `:extensions` (Array[String | Hash]) - An array of paths to files or JS
@@ -166,6 +167,10 @@ Ferrum::Browser.new(options)
   * `:browser_options` (Hash) - Additional command line options,
       [see them all](https://peter.sh/experiments/chromium-command-line-switches/)
       e.g. `{ "ignore-certificate-errors" => nil }`
+  * `:ignore_default_browser_options` (Boolean) - Ferrum has a number of default
+      options it passes to the browser, if you set this to `true` then only
+      options you put in `:browser_options` will be passed to the browser,
+      except required ones of course.
   * `:port` (Integer) - Remote debugging port for headless Chrome
   * `:host` (String) - Remote debugging address for headless Chrome
   * `:url` (String) - URL for a running instance of Chrome. If this is set, a

data/lib/ferrum.rb

@@ -48,6 +48,19 @@ module Ferrum
     end
   end
 
+  class NodeIsMovingError < Error
+    def initialize(node, prev, current)
+      @node, @prev, @current = node, prev, current
+      super(message)
+    end
+
+    def message
+      "#{@node.inspect} that you're trying to click is moving, hence " \
+      "we cannot. Previosuly it was at #{@prev.inspect} but now at " \
+      "#{@current.inspect}."
+    end
+  end
+
   class BrowserError < Error
     attr_reader :response
 

data/lib/ferrum/browser.rb

@@ -4,6 +4,7 @@ require "base64"
 require "forwardable"
 require "ferrum/page"
 require "ferrum/contexts"
+require "ferrum/browser/xvfb"
 require "ferrum/browser/process"
 require "ferrum/browser/client"
 
@@ -16,7 +17,7 @@ module Ferrum
     extend Forwardable
     delegate %i[default_context] => :contexts
     delegate %i[targets create_target create_page page pages windows] => :default_context
-    delegate %i[goto back forward refresh reload stop
+    delegate %i[goto back forward refresh reload stop wait_for_reload
                 at_css at_xpath css xpath current_url current_title url title
                 body doctype set_content
                 headers cookies network

data/lib/ferrum/browser/command.rb

@@ -3,8 +3,6 @@
 module Ferrum
   class Browser
     class Command
-      BROWSER_HOST = "127.0.0.1"
-      BROWSER_PORT = "0"
       NOT_FOUND = "Could not find an executable for the browser. Try to make " \
                   "it available on the PATH or set environment varible for " \
                   "example BROWSER_PATH=\"/usr/bin/chrome\"".freeze
@@ -12,44 +10,47 @@ module Ferrum
       # Currently only these browsers support CDP:
       # https://github.com/cyrus-and/chrome-remote-interface#implementations
       def self.build(options, user_data_dir)
-        case options[:browser_name]
-        when :firefox
-          Firefox
-        when :chrome, :opera, :edge, nil
-          Chrome
-        else
-          raise NotImplementedError, "not supported browser"
-        end.new(options, user_data_dir)
+        defaults = case options[:browser_name]
+                   when :firefox
+                     Options::Firefox.options
+                   when :chrome, :opera, :edge, nil
+                     Options::Chrome.options
+                   else
+                     raise NotImplementedError, "not supported browser"
+                   end
+
+        new(defaults, options, user_data_dir)
       end
 
-      attr_reader :path, :flags, :options
+      attr_reader :defaults, :path, :options
 
-      def initialize(options, user_data_dir)
+      def initialize(defaults, options, user_data_dir)
         @flags = {}
+        @defaults = defaults
         @options, @user_data_dir = options, user_data_dir
-        @path = options[:browser_path] || ENV["BROWSER_PATH"] || detect_path
+        @path = options[:browser_path] || ENV["BROWSER_PATH"] || defaults.detect_path
         raise Cliver::Dependency::NotFound.new(NOT_FOUND) unless @path
+        merge_options
+      end
 
-        combine_flags
+      def xvfb?
+        !!options[:xvfb]
       end
 
       def to_a
-        [path] + flags.map { |k, v| v.nil? ? "--#{k}" : "--#{k}=#{v}" }
+        [path] + @flags.map { |k, v| v.nil? ? "--#{k}" : "--#{k}=#{v}" }
       end
 
       private
 
-      def detect_path
-        if Ferrum.mac?
-          self.class::MAC_BIN_PATH.find { |b| File.exist?(b) }
-        else
-          self.class::LINUX_BIN_PATH
-            .find { |b| p = Cliver.detect(b) and break(p) }
+      def merge_options
+        @flags = defaults.merge_required(@flags, options, @user_data_dir)
+
+        unless options[:ignore_default_browser_options]
+          @flags = defaults.merge_default(@flags, options)
         end
-      end
 
-      def combine_flags
-        raise NotImplementedError
+        @flags.merge!(options.fetch(:browser_options, {}))
       end
     end
   end

data/lib/ferrum/browser/options/base.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+require "singleton"
+
+module Ferrum
+  class Browser
+    module Options
+      class Base
+        BROWSER_HOST = "127.0.0.1"
+        BROWSER_PORT = "0"
+
+        include Singleton
+
+        def self.options
+          instance
+        end
+
+        def to_h
+          self.class::DEFAULT_OPTIONS
+        end
+
+        def except(*keys)
+          to_h.reject { |n, _| keys.include?(n) }
+        end
+
+        def detect_path
+          if Ferrum.mac?
+            self.class::MAC_BIN_PATH.find { |n| File.exist?(n) }
+          else
+            self.class::LINUX_BIN_PATH.find do |name|
+              path = Cliver.detect(name) and break(path)
+            end
+          end
+        end
+
+        def merge_required(flags, options, user_data_dir)
+          raise NotImplementedError
+        end
+
+        def merge_default(flags, options)
+          raise NotImplementedError
+        end
+      end
+    end
+  end
+end

data/lib/ferrum/browser/options/chrome.rb

@@ -0,0 +1,73 @@
+# frozen_string_literal: true
+
+module Ferrum
+  class Browser
+    module Options
+      class Chrome < Base
+        DEFAULT_OPTIONS = {
+          "headless" => nil,
+          "disable-gpu" => nil,
+          "hide-scrollbars" => nil,
+          "mute-audio" => nil,
+          "enable-automation" => nil,
+          "disable-web-security" => nil,
+          "disable-session-crashed-bubble" => nil,
+          "disable-breakpad" => nil,
+          "disable-sync" => nil,
+          "no-first-run" => nil,
+          "use-mock-keychain" => nil,
+          "keep-alive-for-test" => nil,
+          "disable-popup-blocking" => nil,
+          "disable-extensions" => nil,
+          "disable-hang-monitor" => nil,
+          "disable-features" => "site-per-process,TranslateUI",
+          "disable-translate" => nil,
+          "disable-background-networking" => nil,
+          "enable-features" => "NetworkService,NetworkServiceInProcess",
+          "disable-background-timer-throttling" => nil,
+          "disable-backgrounding-occluded-windows" => nil,
+          "disable-client-side-phishing-detection" => nil,
+          "disable-default-apps" => nil,
+          "disable-dev-shm-usage" => nil,
+          "disable-ipc-flooding-protection" => nil,
+          "disable-prompt-on-repost" => nil,
+          "disable-renderer-backgrounding" => nil,
+          "force-color-profile" => "srgb",
+          "metrics-recording-only" => nil,
+          "safebrowsing-disable-auto-update" => nil,
+          "password-store" => "basic",
+          # Note: --no-sandbox is not needed if you properly setup a user in the container.
+          # https://github.com/ebidel/lighthouse-ci/blob/master/builder/Dockerfile#L35-L40
+          # "no-sandbox" => nil,
+        }.freeze
+
+        MAC_BIN_PATH = [
+          "/Applications/Chromium.app/Contents/MacOS/Chromium",
+          "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
+        ].freeze
+        LINUX_BIN_PATH = %w[chromium google-chrome-unstable google-chrome-beta
+                            google-chrome chrome chromium-browser
+                            google-chrome-stable].freeze
+
+        def merge_required(flags, options, user_data_dir)
+          port = options.fetch(:port, BROWSER_PORT)
+          host = options.fetch(:host, BROWSER_HOST)
+          flags.merge("remote-debugging-port" => port,
+                      "remote-debugging-address" => host,
+                      # Doesn't work on MacOS, so we need to set it by CDP
+                      "window-size" => options[:window_size].join(","),
+                      "user-data-dir" => user_data_dir)
+        end
+
+        def merge_default(flags, options)
+          unless options.fetch(:headless, true)
+            defaults = except("headless", "disable-gpu")
+          end
+
+          defaults ||= DEFAULT_OPTIONS
+          defaults.merge(flags)
+        end
+      end
+    end
+  end
+end

data/lib/ferrum/browser/options/firefox.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module Ferrum
+  class Browser
+    module Options
+      class Firefox < Base
+        DEFAULT_OPTIONS = {
+          "headless" => nil,
+        }.freeze
+
+        MAC_BIN_PATH = [
+          "/Applications/Firefox.app/Contents/MacOS/firefox-bin"
+        ].freeze
+        LINUX_BIN_PATH = %w[firefox].freeze
+
+        def merge_required(flags, options, user_data_dir)
+          port = options.fetch(:port, BROWSER_PORT)
+          host = options.fetch(:host, BROWSER_HOST)
+          flags.merge("remote-debugger" => "#{host}:#{port}",
+                      "profile" => user_data_dir)
+        end
+
+        def merge_default(flags, options)
+          unless options.fetch(:headless, true)
+            defaults = except("headless")
+          end
+
+          defaults ||= DEFAULT_OPTIONS
+          defaults.merge(flags)
+        end
+      end
+    end
+  end
+end

data/lib/ferrum/browser/process.rb

@@ -6,9 +6,10 @@ require "json"
 require "addressable"
 require "tmpdir"
 require "forwardable"
+require "ferrum/browser/options/base"
+require "ferrum/browser/options/chrome"
+require "ferrum/browser/options/firefox"
 require "ferrum/browser/command"
-require "ferrum/browser/chrome"
-require "ferrum/browser/firefox"
 
 module Ferrum
   class Browser
@@ -19,7 +20,7 @@ module Ferrum
 
       attr_reader :host, :port, :ws_url, :pid, :command,
                   :default_user_agent, :browser_version, :protocol_version,
-                  :v8_version, :webkit_version
+                  :v8_version, :webkit_version, :xvfb
 
 
       extend Forwardable
@@ -81,7 +82,12 @@ module Ferrum
           process_options[:pgroup] = true unless Ferrum.windows?
           process_options[:out] = process_options[:err] = write_io
 
-          @pid = ::Process.spawn(*@command.to_a, process_options)
+          if @command.xvfb?
+            @xvfb = Xvfb.start(@command.options)
+            ObjectSpace.define_finalizer(self, self.class.process_killer(@xvfb.pid))
+          end
+
+          @pid = ::Process.spawn(Hash(@xvfb&.to_env), *@command.to_a, process_options)
           ObjectSpace.define_finalizer(self, self.class.process_killer(@pid))
 
           parse_ws_url(read_io, @process_timeout)
@@ -92,7 +98,12 @@ module Ferrum
       end
 
       def stop
-        kill if @pid
+        if @pid
+          kill(@pid)
+          kill(@xvfb.pid) if @xvfb&.pid
+          @pid = nil
+        end
+
         remove_user_data_dir if @user_data_dir
         ObjectSpace.undefine_finalizer(self)
       end
@@ -104,9 +115,8 @@ module Ferrum
 
       private
 
-      def kill
-        self.class.process_killer(@pid).call
-        @pid = nil
+      def kill(pid)
+        self.class.process_killer(pid).call
       end
 
       def remove_user_data_dir

data/lib/ferrum/browser/subscriber.rb

@@ -13,7 +13,7 @@ module Ferrum
 
       def initialize
         super
-        @on = Hash.new { |h, k| h[k] = [] }
+        @on = Concurrent::Hash.new { |h, k| h[k] = Concurrent::Array.new }
       end
 
       def on(event, &block)

data/lib/ferrum/browser/web_socket.rb

@@ -8,6 +8,7 @@ module Ferrum
   class Browser
     class WebSocket
       WEBSOCKET_BUG_SLEEP = 0.01
+      SKIP_LOGGING_SCREENSHOTS = !ENV["FERRUM_LOGGING_SCREENSHOTS"]
 
       attr_reader :url, :messages
 
@@ -20,6 +21,10 @@ module Ferrum
         @driver   = ::WebSocket::Driver.client(self, max_length: max_receive_size)
         @messages = Queue.new
 
+        if SKIP_LOGGING_SCREENSHOTS
+          @screenshot_commands = Concurrent::Hash.new
+        end
+
         @driver.on(:open,    &method(:on_open))
         @driver.on(:message, &method(:on_message))
         @driver.on(:close,   &method(:on_close))
@@ -50,7 +55,14 @@ module Ferrum
       def on_message(event)
         data = JSON.parse(event.data)
         @messages.push(data)
-        @logger&.puts("    ◀ #{Ferrum.elapsed_time} #{event.data}\n")
+
+        output = event.data
+        if SKIP_LOGGING_SCREENSHOTS && @screenshot_commands[data["id"]]
+          @screenshot_commands.delete(data["id"])
+          output.sub!(/{"data":"(.*)"}/, %("Set FERRUM_LOGGING_SCREENSHOTS=true to see screenshots in Base64"))
+        end
+
+        @logger&.puts("    ◀ #{Ferrum.elapsed_time} #{output}\n")
       end
 
       def on_close(_event)
@@ -59,6 +71,10 @@ module Ferrum
       end
 
       def send_message(data)
+        if SKIP_LOGGING_SCREENSHOTS
+          @screenshot_commands[data[:id]] = true
+        end
+
         json = data.to_json
         @driver.text(json)
         @logger&.puts("\n\n▶ #{Ferrum.elapsed_time} #{json}")

data/lib/ferrum/browser/xvfb.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module Ferrum
+  class Browser
+    class Xvfb
+      NOT_FOUND = "Could not find an executable for the Xvfb. Try to install " \
+                  "it with your package manager".freeze
+
+      def self.start(*args)
+        new(*args).tap(&:start)
+      end
+
+      def self.xvfb_path
+        Cliver.detect("Xvfb")
+      end
+
+      attr_reader :screen_size, :display_id, :pid
+
+      def initialize(options)
+        @path = self.class.xvfb_path
+        raise Cliver::Dependency::NotFound.new(NOT_FOUND) unless @path
+
+        @screen_size = options.fetch(:window_size, [1024, 768]).join("x") + "x24"
+        @display_id = (Time.now.to_f * 1000).to_i % 100_000_000
+      end
+
+      def start
+        @pid = ::Process.spawn("#{@path} :#{display_id} -screen 0 #{screen_size}")
+        ::Process.detach(@pid)
+      end
+
+      def to_env
+        { "DISPLAY" => ":#{display_id}" }
+      end
+    end
+  end
+end

data/lib/ferrum/frame/runtime.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "singleton"
+
 module Ferrum
   class Frame
     module Runtime
@@ -215,7 +217,7 @@ module Ferrum
 
       def reduce_props(object_id, to)
         if cyclic?(object_id).dig("result", "value")
-          return "(cyclic structure)"
+          return to.is_a?(Array) ? [cyclic_object] : cyclic_object
         else
           props = @page.command("Runtime.getProperties", ownProperties: true, objectId: object_id)
           props["result"].reduce(to) do |memo, prop|
@@ -259,6 +261,18 @@ module Ferrum
           JS
         )
       end
+
+      def cyclic_object
+        CyclicObject.instance
+      end
+    end
+  end
+
+  class CyclicObject
+    include Singleton
+
+    def inspect
+      %(#<#{self.class} JavaScript object that cannot be represented in Ruby>)
     end
   end
 end

data/lib/ferrum/network/intercepted_request.rb

@@ -39,7 +39,7 @@ module Ferrum
           requestId: request_id,
           responseHeaders: header_array(headers),
         })
-        options = options.merge(body: Base64.encode64(options.fetch(:body, "")).strip) if has_body
+        options = options.merge(body: Base64.strict_encode64(options.fetch(:body, ""))) if has_body
 
         @status = :responded
         @page.command("Fetch.fulfillRequest", **options)

data/lib/ferrum/node.rb

@@ -2,6 +2,9 @@
 
 module Ferrum
   class Node
+    MOVING_WAIT = ENV.fetch("FERRUM_NODE_MOVING_WAIT", 0.01).to_f
+    MOVING_ATTEMPTS = ENV.fetch("FERRUM_NODE_MOVING_ATTEMPTS", 50).to_i
+
     attr_reader :page, :target_id, :node_id, :description, :tag_name
 
     def initialize(frame, target_id, node_id, description)
@@ -121,16 +124,42 @@ module Ferrum
     end
 
     def find_position(x: nil, y: nil, position: :top)
-      offset_x, offset_y = x, y
-      quads = get_content_quads
+      prev = get_content_quads
+
+      # FIXME: Case when a few quads returned
+      points = Ferrum.with_attempts(errors: NodeIsMovingError, max: MOVING_ATTEMPTS, wait: 0) do
+        sleep(MOVING_WAIT)
+        current = get_content_quads
+
+        if current != prev
+          error = NodeIsMovingError.new(self, prev, current)
+          prev = current
+          raise(error)
+        end
+
+        current
+      end.map { |q| to_points(q) }.first
+
+      get_position(points, x, y, position)
+    end
+
+    private
+
+    def get_content_quads
+      quads = page.command("DOM.getContentQuads", nodeId: node_id)["quads"]
+      raise "Node is either not visible or not an HTMLElement" if quads.size == 0
+      quads
+    end
+
+    def get_position(points, offset_x, offset_y, position)
       x = y = nil
 
       if offset_x && offset_y && position == :top
-        point = quads.first
+        point = points.first
         x = point[:x] + offset_x.to_i
         y = point[:y] + offset_y.to_i
       else
-        x, y = quads.inject([0, 0]) do |memo, point|
+        x, y = points.inject([0, 0]) do |memo, point|
           [memo[0] + point[:x],
            memo[1] + point[:y]]
         end
@@ -147,19 +176,11 @@ module Ferrum
       [x, y]
     end
 
-    private
-
-    def get_content_quads
-      result = page.command("DOM.getContentQuads", nodeId: node_id)
-      raise "Node is either not visible or not an HTMLElement" if result["quads"].size == 0
-
-      # FIXME: Case when a few quads returned
-      result["quads"].map do |quad|
-        [{x: quad[0], y: quad[1]},
-         {x: quad[2], y: quad[3]},
-         {x: quad[4], y: quad[5]},
-         {x: quad[6], y: quad[7]}]
-      end.first
+    def to_points(quad)
+      [{x: quad[0], y: quad[1]},
+       {x: quad[2], y: quad[3]},
+       {x: quad[4], y: quad[5]},
+       {x: quad[6], y: quad[7]}]
     end
   end
 end

data/lib/ferrum/page.rb

@@ -44,7 +44,7 @@ module Ferrum
 
     def initialize(target_id, browser)
       @frames = {}
-      @main_frame = Frame.new(nil, self) 
+      @main_frame = Frame.new(nil, self)
       @target_id, @browser = target_id, browser
       @event = Event.new.tap(&:set)
 
@@ -125,6 +125,12 @@ module Ferrum
       history_navigate(delta: 1)
     end
 
+    def wait_for_reload(sec = 1)
+      @event.reset if @event.set?
+      @event.wait(sec)
+      @event.set
+    end
+
     def bypass_csp(value = true)
       enabled = !!value
       command("Page.setBypassCSP", enabled: enabled)

data/lib/ferrum/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Ferrum
-  VERSION = "0.8"
+  VERSION = "0.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ferrum
 version: !ruby/object:Gem::Version
-  version: '0.8'
+  version: '0.9'
 platform: ruby
 authors:
 - Dmitry Vorotilin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-04-07 00:00:00.000000000 Z
+date: 2020-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: websocket-driver
@@ -64,14 +64,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '2.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.6'
+        version: '2.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -181,13 +181,15 @@ files:
 - README.md
 - lib/ferrum.rb
 - lib/ferrum/browser.rb
-- lib/ferrum/browser/chrome.rb
 - lib/ferrum/browser/client.rb
 - lib/ferrum/browser/command.rb
-- lib/ferrum/browser/firefox.rb
+- lib/ferrum/browser/options/base.rb
+- lib/ferrum/browser/options/chrome.rb
+- lib/ferrum/browser/options/firefox.rb
 - lib/ferrum/browser/process.rb
 - lib/ferrum/browser/subscriber.rb
 - lib/ferrum/browser/web_socket.rb
+- lib/ferrum/browser/xvfb.rb
 - lib/ferrum/context.rb
 - lib/ferrum/contexts.rb
 - lib/ferrum/cookies.rb

data/lib/ferrum/browser/chrome.rb

@@ -1,76 +0,0 @@
-# frozen_string_literal: true
-
-module Ferrum
-  class Browser
-    class Chrome < Command
-      DEFAULT_OPTIONS = {
-        "headless" => nil,
-        "disable-gpu" => nil,
-        "hide-scrollbars" => nil,
-        "mute-audio" => nil,
-        "enable-automation" => nil,
-        "disable-web-security" => nil,
-        "disable-session-crashed-bubble" => nil,
-        "disable-breakpad" => nil,
-        "disable-sync" => nil,
-        "no-first-run" => nil,
-        "use-mock-keychain" => nil,
-        "keep-alive-for-test" => nil,
-        "disable-popup-blocking" => nil,
-        "disable-extensions" => nil,
-        "disable-hang-monitor" => nil,
-        "disable-features" => "site-per-process,TranslateUI",
-        "disable-translate" => nil,
-        "disable-background-networking" => nil,
-        "enable-features" => "NetworkService,NetworkServiceInProcess",
-        "disable-background-timer-throttling" => nil,
-        "disable-backgrounding-occluded-windows" => nil,
-        "disable-client-side-phishing-detection" => nil,
-        "disable-default-apps" => nil,
-        "disable-dev-shm-usage" => nil,
-        "disable-ipc-flooding-protection" => nil,
-        "disable-prompt-on-repost" => nil,
-        "disable-renderer-backgrounding" => nil,
-        "force-color-profile" => "srgb",
-        "metrics-recording-only" => nil,
-        "safebrowsing-disable-auto-update" => nil,
-        "password-store" => "basic",
-        # Note: --no-sandbox is not needed if you properly setup a user in the container.
-        # https://github.com/ebidel/lighthouse-ci/blob/master/builder/Dockerfile#L35-L40
-        # "no-sandbox" => nil,
-      }.freeze
-
-      MAC_BIN_PATH = [
-        "/Applications/Chromium.app/Contents/MacOS/Chromium",
-        "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome"
-      ].freeze
-      LINUX_BIN_PATH = %w[chromium google-chrome-unstable google-chrome-beta
-                          google-chrome chrome chromium-browser
-                          google-chrome-stable].freeze
-
-      private
-
-      def combine_flags
-        # Doesn't work on MacOS, so we need to set it by CDP as well
-        @flags.merge!("window-size" => options[:window_size].join(","))
-
-        port = options.fetch(:port, BROWSER_PORT)
-        @flags.merge!("remote-debugging-port" => port)
-
-        host = options.fetch(:host, BROWSER_HOST)
-        @flags.merge!("remote-debugging-address" => host)
-
-        @flags.merge!("user-data-dir" => @user_data_dir)
-
-        @flags = DEFAULT_OPTIONS.merge(@flags)
-
-        unless options.fetch(:headless, true)
-          @flags.delete("headless")
-          @flags.delete("disable-gpu")
-        end
-
-        @flags.merge!(options.fetch(:browser_options, {}))
-      end
-    end
-  end
-end

data/lib/ferrum/browser/firefox.rb

@@ -1,34 +0,0 @@
-# frozen_string_literal: true
-
-module Ferrum
-  class Browser
-    class Firefox < Command
-      DEFAULT_OPTIONS = {
-        "headless" => nil,
-      }.freeze
-
-      MAC_BIN_PATH = [
-        "/Applications/Firefox.app/Contents/MacOS/firefox-bin"
-      ].freeze
-      LINUX_BIN_PATH = %w[firefox].freeze
-
-      private
-
-      def combine_flags
-        port = options.fetch(:port, BROWSER_PORT)
-        host = options.fetch(:host, BROWSER_HOST)
-        @flags.merge!("remote-debugger" => "#{host}:#{port}")
-
-        @flags.merge!("profile" => @user_data_dir)
-
-        @flags = DEFAULT_OPTIONS.merge(@flags)
-
-        unless options.fetch(:headless, true)
-          @flags.delete("headless")
-        end
-
-        @flags.merge!(options.fetch(:browser_options, {}))
-      end
-    end
-  end
-end