fera-api 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 340f111ef9ae910374f8b8556b80a4c7cea4a982be22c807e1330b52f5a222a8
-  data.tar.gz: 758fe26ac14a9a4012039d14800e657690d821862eda47ea8e0866ea714a16d1
+  metadata.gz: 5f5fcef6bfad094e9853066b852f6992540e9321015531350e7bc6b02b94d71e
+  data.tar.gz: eff0b267a65ad12bbb8bb42c24c42409224774e1e45a53005e1fecf0b0be5fa2
 SHA512:
-  metadata.gz: db7db0bd5a14e64dce22219b385d21db5675ddc5dc07196756c2a88dc20cb628786a48e911b5ad638b741c2124be96e7008dff341366d4a7ab83e827b767d5b5
-  data.tar.gz: 53ea2d445404901fc1377edd5720f186e3cccad97eafd420f4e13959fedb55d8778ca39847e3eb2622226b06b9261e5fbc38417f3d23a523acfe083701f84303
+  metadata.gz: d0e8f790bdcced7f48af3b8d0f2e59773e3a69ec429b584068ad5d769cdb39835b87c4301f012ed3da06af8b9ffecb1e21e5ce69e94265472473be543996bb46
+  data.tar.gz: 49380fcbb2c591cb0c7c7c730e38bde23a17f3ce1ab59af08c3b6e340700932bc5219af9c11a0bc55e92201ccba8dcd9ada8ee053edae6f3a0faf656967434fe

data/.rubocop.yml

@@ -1,173 +1,10 @@
-# Base was copied from https://github.com/sider/meowcop/blob/master/config/rubocop.yml which is what Sider uses by default
+inherit_from:
+  - 'https://raw.githubusercontent.com/feracommerce/code-standards/master/.rubocop.yml'
+  - 'https://raw.githubusercontent.com/feracommerce/code-standards/master/.rubocop-rspec.yml'
+inherit_mode:
+  merge:
+    - Exclude
 AllCops:
   TargetRubyVersion: 2.3
-  Exclude:
-    - 'vendor/**/*'
-    - 'db/schema.rb'
-    - 'node_modules/**/*'
-    - 'tmp/**/*'
-    - 'lib/tasks/one_offs/**/*' # We don't really care about linting one-off tasks
-    - 'app/migrators/**/*' # Migrators are one-off tasks so there isn't much need to lint them
-  DisplayCopNames: true
-  DisplayStyleGuide: true
-  NewCops: enable
-
-Lint/NonLocalExitFromIterator:
-  Enabled: false # We actually believe that it is more readable with premature returns
-Layout/BeginEndAlignment:
-  Enabled: false # We believe it's more readable to have begin blocks aligned to the end blocks (and also helps with code smells)
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-Lint/AssignmentInCondition:
-  Enabled: false
-Metrics/AbcSize:
-  Max: 60
-# Use the default setting
-Metrics/BlockLength:
-  Max: 200
-  Exclude:
-    # RuboCop's default
-    - 'Rakefile'
-    - '**/*.rake'
-    # In many cases, config/routes.rb has very long block
-    - 'config/routes.rb'
-Metrics/ClassLength:
-  Enabled: false
-Metrics/CyclomaticComplexity:
-  Max: 60
-Metrics/MethodLength:
-  Enabled: false
-Metrics/ModuleLength:
-  Enabled: false
-Metrics/ParameterLists:
-  Max: 5
-Metrics/PerceivedComplexity:
-  Enabled: false
-Layout/ArgumentAlignment:
-  Enabled: false
-Layout/HashAlignment:
-  Enabled: false
-Layout/ParameterAlignment:
-  Enabled: false
-Layout/IndentationWidth:
-  Enabled: false
-Layout/FirstHashElementIndentation:
-  Enabled: false
-Layout/HeredocIndentation:
-  Enabled: false
-Layout/LineLength:
-  Max: 200
-  AllowedPatterns: ['^\s*#', '^\s*([a-zA-Z]*[lL]og[a-zA-Z]*)[ (]', '^\s*[''"]', '.*#.{30,300}', '^\s*[a-z_]:\s*".+",?[}\s]*$']
-Layout/MultilineArrayBraceLayout:
-  Enabled: false
-Layout/MultilineAssignmentLayout:
-  Enabled: false
-Layout/MultilineBlockLayout:
-  Enabled: false
-Layout/MultilineHashBraceLayout:
-  Enabled: false
-Layout/MultilineMethodCallBraceLayout:
-  Enabled: false
-Layout/MultilineMethodCallIndentation:
-  Enabled: false
-Layout/MultilineMethodDefinitionBraceLayout:
-  Enabled: false
-Layout/MultilineOperationIndentation:
-  Enabled: false
-Layout/RescueEnsureAlignment:
-  Enabled: false
-Layout/SpaceAfterNot:
-  Enabled: false
-Layout/SpaceBeforeBlockBraces:
-  Enabled: false
-Layout/SpaceInLambdaLiteral:
-  Enabled: false
-Layout/SpaceInsideStringInterpolation:
-  EnforcedStyle: space
-Naming/PredicateName:
-  Enabled: false # As of February 2022 we now want some methods to have is_ prefix so it is congruent with JavaScript
-Naming/VariableNumber:
-  Enabled: false
-Style/AsciiComments:
-  Enabled: false # It's 2022, emojis are everywhere
-Style/Alias:
-  EnforcedStyle: prefer_alias_method
-Style/CaseLikeIf:
-  Enabled: false
-Style/CommentAnnotation:
-  Enabled: false # Don't really care about being picky on comments like this. Not worth slowing down the developer.
-Style/CommentedKeyword:
-  Enabled: false # We want to allow comments on single-line method definitions like `# @alias`
-Style/ConstantVisibility:
-  Enabled: false
-Style/Copyright:
-  Enabled: false
-Style/DisableCopsWithinSourceCodeDirective:
-  Enabled: false # Allow disabling cops and we will use PRs to determine whether it should be enforced
-Style/Documentation:
-  Enabled: false # We will decide in PR whether public method should be documented or not.
-Style/DocumentationMethod:
-  Enabled: false # We will decide in PR whether public method should be documented or not.
-Style/EmptyElse:
-  AllowComments: true # When a comment is there then it means the programmer thought about the case so we can ignore it.
-  EnforcedStyle: empty  # When a comment or nil is there it means the programmer thought about the case, so there is no need for concern
-Style/FloatDivision:
-  Enabled: false # Sometimes we're trying to force the number to become a float and it could be nil
-Style/FrozenStringLiteralComment:
-  Enabled: false
-Style/GlobalVars:
-  Enabled: false # If we're using global variables, we have a darn good reason or it should be blocked in the PR
-Style/IfUnlessModifier:
-  Enabled: false # This isn't always easier to read. Sometimes you want to put the IF in front of the block of code to make it more clear.
-Style/ImplicitRuntimeError:
-  Enabled: false # These are actually readable as long as we all know that they represent a RuntimeError
-Style/InlineComment:
-  Enabled: false # Trailing inline comments are pretty compact and more readable
-Style/Lambda:
-  Enabled: false
-Style/LambdaCall:
-  Enabled: false
-Style/MethodCallWithArgsParentheses:
-  Enabled: false
-Style/MethodCallWithoutArgsParentheses:
-  Enabled: true # We use whatever is more readable
-Style/MethodCalledOnDoEndBlock:
-  Enabled: false # Actually don't mind these - they look more readable
-Style/MissingElse:
-  Enabled: false # Sometimes it's obvious we don't care about the else case (e.g. if we're prematurely returning from method)
-Style/MultilineBlockChain:
-  Enabled: false # Sometimes these are more readable
-Style/MutableConstant:
-  Enabled: false
-Style/MapToHash:
-  Enabled: false # We believe it's more readable to use map vs hash with block syntax
-Style/NumericPredicate:
-  Enabled: false # .zero? and .positive? are a bit less readable than == 0 IMO
-Style/OptionHash:
-  Enabled: false # It is more intuitive to pass option hashes to other objects in many times
-Style/OpenStructUse:
-  Enabled: false
-Style/RedundantRegexpCharacterClass:
-  Enabled: false # No need to make regexp less readable than they already are by reducing redundancy
-Style/RedundantRegexpEscape:
-  Enabled: false # No need to make regexp less readable than they already are by reducing redundancy
-Style/RedundantSelf:
-  Enabled: false # Sometimes it's actually more readable to explicitly reference self
-Style/RegexpLiteral:
-  Enabled: false
-Style/ReturnNil:
-  Enabled: false # Returning nil is more clear what is happening and can prevent issues with returning mixed types
-Style/Send:
-  Enabled: false
-Style/SingleLineMethods:
-  Enabled: false # Sometimes these are more compact and easier to read. No need to spam our file with simple method definitions.
-Style/StringLiterals:
-  Enabled: false
-Style/SymbolArray:
-  Enabled: false
-Style/TernaryParentheses:
-  Enabled: false
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: consistent_comma # It makes managing arrays much easier when we have commas at the end
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: consistent_comma # It makes managing hashes much easier when we have commas at the end
+require:
+  - rubocop-rspec

data/Gemfile

@@ -13,4 +13,5 @@ group :development, :test do
   gem "pry-rescue"
   gem "pry-stack_explorer"
   gem "rubocop"
+  gem "rubocop-rspec"
 end

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    fera-api (0.1.2)
+    fera-api (0.1.3)
       activemodel (>= 4)
       activeresource (>= 6)
       activesupport (>= 4.0)
@@ -47,7 +47,7 @@ GEM
       concurrent-ruby (~> 1.0)
     interception (0.5)
     json (2.6.2)
-    json-jwt (1.15.2)
+    json-jwt (1.15.3)
       activesupport (>= 4.2)
       aes_key_wrap
       bindata
@@ -104,6 +104,8 @@ GEM
       unicode-display_width (>= 1.4.0, < 3.0)
     rubocop-ast (1.21.0)
       parser (>= 3.1.1.0)
+    rubocop-rspec (2.12.1)
+      rubocop (~> 1.31)
     ruby-progressbar (1.11.0)
     slop (3.6.0)
     to_bool (2.0.0)
@@ -130,6 +132,7 @@ DEPENDENCIES
   pry-stack_explorer
   rspec (>= 3.0)
   rubocop
+  rubocop-rspec
   to_bool
   webmock (>= 3.0)
 

data/lib/fera/api/version.rb

@@ -2,6 +2,6 @@
 
 module Fera
   module API
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

data/lib/fera/api.rb

@@ -18,6 +18,7 @@ module Fera
 
     ##
     # @param api_key [String] Public API key, Secret API key or Auth Token (if app)
+    # @return [Object, ::Fera::API] Result of the block operation if given, otherwise self
     def self.configure(api_key, api_url: nil, strict_mode: false, debug_mode: false)
       previous_base_site = Base.site
       previous_base_headers = Base.headers

data/lib/fera/models/base.rb

@@ -209,7 +209,7 @@ module Fera
           end
         end
 
-        connection.post(collection_path(nil, extra_params), data.to_json, self.class.headers).tap do |response|
+        connection.post(collection_path(nil, extra_params), { data: data }.to_json, self.class.headers).tap do |response|
           self.id = id_from_response(response)
           load_attributes_from_response(response)
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fera-api
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Fera Commerce Inc
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-08-17 00:00:00.000000000 Z
+date: 2022-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel