feedvalidator 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bde10f8cafaa7c9178d757b85928686685531244
-  data.tar.gz: 31a0ef70f2f842b951a143c80a7ea3abe90b499d
+  metadata.gz: edd11b2f4b25f9248aed8ec078e86c957d7c9004
+  data.tar.gz: 8c8c4e13138b80d1646ee6939065939dd52e7a08
 SHA512:
-  metadata.gz: ac20e1b26b07723a310c942f8fbfa9da465e5b54cd002ed9f574b1d792ae479cf8885a170ae547e760f36e9e6c92d949db4b677a8880e2b352761713a10f7ab8
-  data.tar.gz: f971a4c67e56acca285532fd7374e6cec90dd06da40ccc2a479242f88be997983d7421bb6889a15bc3e5a72ba596ab53a51aa5d458fff83cefc43cf90203261c
+  metadata.gz: 5bb7389d9b2b04f6e6f16ffc632380a9c1de7d54c5e10910ccea90bf76b7cf1840325afe4f6101ebee493508808992f2b4ec9f460e632b9b3df3b922b7db643d
+  data.tar.gz: 566bfc63a3baf491d9c534dd2aae215872f03067e0eb4c883047d33fd08c53fb9bc873dab052591ea2b976ccc105c04f06af35dcaeaba90771ea008f9c31c824

data/.travis.yml

@@ -7,4 +7,6 @@ rvm:
   - 2.0.0
   - 2.1.0
   - 2.2.0
-  - ruby-head
+  - 2.3.0
+  - 2.4.0
+  - ruby-head

data/feedvalidator.gemspec

@@ -14,6 +14,7 @@ Gem::Specification.new do |gem|
   gem.authors       = ["Edgar Gonzalez"]
   gem.email         = ["edgargonzalez@gmail.com"]
   gem.description   = %q{Interface to the W3C Feed Validation online service http://validator.w3.org/feed/}
+  gem.homepage      = "http://github.com/edgar/feedvalidator"
 
   gem.add_development_dependency 'rake'
 

data/lib/feed_validator.rb

@@ -1,5 +1,5 @@
 #--
-# Copyright (c) 2006 Edgar Gonzalez <edgar@lacaraoscura.com>
+# Copyright (c) 2006 Edgar Gonzalez <edgargonzalez@gmail.com>
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -21,8 +21,8 @@
 # WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 #++
 #
-# Provide an interface to the {W3C Feed Validation online service}[http://validator.w3.org/feed/], 
-# based on its SOAP 1.2 support. 
+# Provide an interface to the {W3C Feed Validation online service}[http://validator.w3.org/feed/],
+# based on its SOAP 1.2 support.
 #
 require 'net/http'
 require 'cgi'
@@ -31,8 +31,8 @@ require 'rexml/document'
 
 module W3C
 
-  # Implements an interface to the {W3C Feed Validation online service}[http://validator.w3.org/feed/], 
-  # based on its SOAP 1.2 support. 
+  # Implements an interface to the {W3C Feed Validation online service}[http://validator.w3.org/feed/],
+  # based on its SOAP 1.2 support.
   #
   # It helps to find errors in RSS or Atom feeds.
   # ---
@@ -40,52 +40,58 @@ module W3C
   # so do not abuse it: you should make your scripts sleep between requests.
   #
   class FeedValidator
-    VERSION = "0.2.0"
+    VERSION = "0.2.1"
 
     # True if the w3c feed validation service not found errors in the feed.
     #
     attr_reader :valid
-    
+
     # The complete response (as Net::HTTPResponse object) sent it by the w3c feed validation service.
     #
     attr_reader :response
-    
+
     # Collection of _errors_ founded by the w3c feed validation service.
-    # Every error is a hash containing: <tt>:type</tt>, <tt>:line</tt>, 
+    # Every error is a hash containing: <tt>:type</tt>, <tt>:line</tt>,
     # <tt>:column</tt>, <tt>:text</tt>, <tt>:element</tt>
     #
     attr_reader :errors
 
     # Collection of _warnings_ founded by the w3c feed validation service.
-    # Every error is a hash containing: <tt>:type</tt>, <tt>:line</tt>, 
+    # Every error is a hash containing: <tt>:type</tt>, <tt>:line</tt>,
     # <tt>:column</tt>, <tt>:text</tt>, <tt>:element</tt>
     #
     attr_reader :warnings
 
     # Collection of _informations_ founded by the w3c feed validation service.
-    # Every error is a hash containing: <tt>:type</tt>, <tt>:line</tt>, 
+    # Every error is a hash containing: <tt>:type</tt>, <tt>:line</tt>,
     # <tt>:column</tt>, <tt>:text</tt>, <tt>:element</tt>
     #
     attr_reader :informations
-  
+
+    # request_type
+    # :manuel for direct input validation
+    # :url    for url validation
+    attr_reader :request_type
+
     # Initialize the feed validator object
     #
     def initialize
       clear
     end
-    
-    # Validate the data provided. 
+
+    # Validate the data provided.
     # Returns a true value if the validation succeeded (regardless of whether the feed contains errors).
     #
     def validate_data(rawdata)
       clear
       params = "rawdata=#{CGI.escape(rawdata)}&manual=1&output=soap12"
+      @request_type = :manual
       begin
 #        headers = VERSION == "1.8.4" ? {'Content-Type'=>'application/x-www-form-urlencoded'} : {}
         headers = {'Content-Type'=>'application/x-www-form-urlencoded'}
         @response = Net::HTTP.start('validator.w3.org',80) {|http|
           http.post('/feed/check.cgi',params,headers)
-        } 
+        }
       rescue Exception => e
         warn "Exception: #{e.class}: #{e.message}\n\t#{e.backtrace.join("\n\t")}" if $VERBOSE
         return false
@@ -95,12 +101,13 @@ module W3C
       return true
     end
 
-    # Validate the url provided. 
+    # Validate the url provided.
     # Returns a true value if the validation succeeded (regardless of whether the feed contains errors).
     #
     def validate_url(url)
       clear
       params = "url=#{CGI.escape(url)}&output=soap12"
+      @request_type = :url
       begin
         @response = Net::HTTP.get_response('validator.w3.org',"/feed/check.cgi?#{params}",80)
       rescue Exception => e
@@ -116,16 +123,16 @@ module W3C
     def to_s
       msg = "Vailidity: #{@valid}\n"
       msg << "Errors count: #{@errors.size}\n"
-      @errors.each_with_index{ |item, i| msg << "(#{i+1}) type: #{item[:type]} | line: #{item[:line]} | column: #{item[:column]} | text: #{item[:text]},\n"}  
+      @errors.each_with_index{ |item, i| msg << "(#{i+1}) type: #{item[:type]} | line: #{item[:line]} | column: #{item[:column]} | text: #{item[:text]},\n"}
       msg << "Warnings count: #{@warnings.size}\n"
-      @warnings.each_with_index{ |item, i| msg << "(#{i+1}) type: #{item[:type]} | line: #{item[:line]} | column: #{item[:column]} | text: #{item[:text]},\n"}  
+      @warnings.each_with_index{ |item, i| msg << "(#{i+1}) type: #{item[:type]} | line: #{item[:line]} | column: #{item[:column]} | text: #{item[:text]},\n"}
       msg << "Informations count: #{@informations.size}\n"
-      @informations.each_with_index{ |item, i| msg << "(#{i+1}) type: #{item[:type]} | line: #{item[:line]} | column: #{item[:column]} | text: #{item[:text]},\n"}  
+      @informations.each_with_index{ |item, i| msg << "(#{i+1}) type: #{item[:type]} | line: #{item[:line]} | column: #{item[:column]} | text: #{item[:text]},\n"}
       msg
     end
 
     private
-    
+
     def parse_response(response) #nodoc
       xml = REXML::Document.new(response)
       @valid = (/true/.match(xml.root.elements["env:Body/m:feedvalidationresponse/m:validity"].get_text.value))? true : false
@@ -141,6 +148,11 @@ module W3C
         end
       end
       xml.elements.each("env:Envelope/env:Body/m:feedvalidationresponse/m:warnings/m:warninglist/warning") do |warning|
+        next if
+          @request_type == :manual &&
+          warning.elements["type"].get_text.value == "SelfDoesntMatchLocation" &&
+          warning.elements["text"].get_text.value == "Self reference doesn't match document location"
+
         @warnings << {
           :type =>    warning.elements["type"].nil? ? "" : warning.elements["type"].get_text.value,
           :line =>    warning.elements["line"].nil? ? "" : warning.elements["line"].get_text.value,
@@ -162,11 +174,12 @@ module W3C
 
     def clear #nodoc
       @response = nil
+      @request_type = nil
       @valid = false
       @errors = []
       @warnings = []
       @informations = []
     end
-      
+
   end
 end

data/lib/feed_validator/assertions.rb

@@ -36,7 +36,7 @@ module W3C
         parse_response(response.body)
       else
         parse_response(response)
-      end      
+      end
     end
   end
 end
@@ -62,7 +62,7 @@ class Test::Unit::TestCase
     begin
       response = File.open filename do |f| Marshal.load(f) end
       v.parse(response)
-  	rescue   
+  	rescue
       unless v.validate_data(fragment)
         warn("Sorry! could not validate the feed.")
         return assert(true,'')
@@ -71,7 +71,7 @@ class Test::Unit::TestCase
   	end
     assert(v.valid?, v.valid? ? '' : v.to_s)
   end
-  
+
   # Class-level method to quickly create validation tests for a bunch of actions at once in Rails.
   # For example, if you have a FooController with three actions, just add one line to foo_controller_test.rb:
   #
@@ -87,5 +87,5 @@ class Test::Unit::TestCase
       EOF
     end
   end
-  
+
 end

data/test/unit/feed_validator_assertions_test.rb

@@ -1,5 +1,5 @@
 #--
-# Copyright (c) 2006 Edgar Gonzalez <edgar@lacaraoscura.com>
+# Copyright (c) 2006 Edgar Gonzalez <edgargonzalez@gmail.com>
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -27,7 +27,7 @@ require 'feed_validator/assertions'
 require 'digest/md5'
 
 class FeedValidatorAssertionsTest < Test::Unit::TestCase
-  
+
   def test_assert_valid_feed
     # a valid feed
     data = ""
@@ -36,14 +36,14 @@ class FeedValidatorAssertionsTest < Test::Unit::TestCase
     }
     assert_valid_feed(data)
   end
-  
+
   def test_cache
     # testing the cache using an invalid feed with a success response cached
-    fragment_feed = ">--invalid feed--<"    
+    fragment_feed = ">--invalid feed--<"
     response = File.open File.dirname(__FILE__) + "/../responses/success_with_warnings" do |f| Marshal.load(f) end
     filename = File.join Dir::tmpdir, 'feed.' + Digest::MD5.hexdigest(fragment_feed).to_s
     File.open filename, 'w+' do |f| Marshal.dump response, f end
-    assert_valid_feed(fragment_feed)  
+    assert_valid_feed(fragment_feed)
   end
-  
+
 end

data/test/unit/feed_validator_test.rb

@@ -1,5 +1,5 @@
 #--
-# Copyright (c) 2006 Edgar Gonzalez <edgar@lacaraoscura.com>
+# Copyright (c) 2006 Edgar Gonzalez <edgargonzalez@gmail.com>
 #
 # Permission is hereby granted, free of charge, to any person obtaining
 # a copy of this software and associated documentation files (the
@@ -26,7 +26,7 @@ require 'test/unit'
 require 'feed_validator'
 
 class FeedValidatorTest < Test::Unit::TestCase
-  
+
   def test_validate_url
     v = W3C::FeedValidator.new()
     assert v.validate_url('http://www.w3.org/QA/news.rss')
@@ -39,7 +39,7 @@ class FeedValidatorTest < Test::Unit::TestCase
 
   def test_validate_data
     v = W3C::FeedValidator.new()
-    
+
     data = ""
     File.open(File.dirname(__FILE__) + "/../feeds/" + "weblog.rubyonrails.org_rss_2_0_articles.xml").each { |line|
       data << line
@@ -48,7 +48,7 @@ class FeedValidatorTest < Test::Unit::TestCase
     assert v.valid?
 
     assert v.errors.size == 0
-    #assert v.warnings.size == 0
+    assert v.warnings.size == 0
     assert v.informations.size == 0
 
     data = ""
@@ -59,7 +59,7 @@ class FeedValidatorTest < Test::Unit::TestCase
     assert v.valid?
     assert v.errors.size == 0
     assert v.warnings.size >= 1
-    
+
     data = ""
     File.open(File.dirname(__FILE__) + "/../feeds/" + "weblog.rubyonrails.org_rss_2_0_articles_malformed.xml").each { |line|
       data << line
@@ -70,5 +70,5 @@ class FeedValidatorTest < Test::Unit::TestCase
     assert v.errors.first[:line] == "5"
     assert v.errors.first[:column] == "4"
   end
-  
+
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: feedvalidator
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Edgar Gonzalez
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-19 00:00:00.000000000 Z
+date: 2017-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -61,7 +61,7 @@ files:
 - test/responses/success_with_warnings
 - test/unit/feed_validator_assertions_test.rb
 - test/unit/feed_validator_test.rb
-homepage: 
+homepage: http://github.com/edgar/feedvalidator
 licenses:
 - MIT
 metadata: {}
@@ -81,7 +81,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.4
 signing_key: 
 specification_version: 4
 summary: Interface to the W3C Feed Validation online service http://validator.w3.org/feed/