feedjira 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8c0d5191e078e304c8167c6a751183e9fc696180d46197cd27514412a1b19ee7
-  data.tar.gz: 7468bd2d9e312250a8d01410b0934877566ebd924ff50d369d25faa0f9c9c285
+  metadata.gz: e7c43633bb85f7aa16a1930ba863d404bee83de5365676c1df4600df5640d4d6
+  data.tar.gz: e910be45a7e47e55cec3d4d09e219d6d245834da7360d22338c6380e1bad42ac
 SHA512:
-  metadata.gz: 6db87062df76ea36471ae9c39502e7be29ccdbd317aa7fa1f9dd914cab6294a23ff0d154ee3578b101fecf4d6908dc0e800e44a5b7ef986e4af8d4ff320ad941
-  data.tar.gz: 0351de63585571aaac4742d475ae32700f701158a35e6d3f768edf79629c4172d99ec3e30be194dc067d722437fdd9be7b089faf8e6f35b0965c748253ff9aee
+  metadata.gz: a1fbf835d1ae58a7a542fc37362e7c8d1fa9ab5ec435075da34f7a386aac5d0a2acda1e8d24f4138b50ca410582e5fec48409ecf6bcdf93cc2a6f8f6dee55882
+  data.tar.gz: 0ec37861fc3fac82ce93a41df4b84a3800a3a74090f17b5b6322e35c1189e63d83671d0deeca6847bb25803118f9e406c067b1e1363f863edce788b9b985130d

data/.rubocop_todo.yml

@@ -1,14 +1,13 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --auto-gen-only-exclude --exclude-limit 400`
-# on 2025-08-24 01:08:06 UTC using RuboCop version 1.79.1.
+# on 2025-09-02 06:40:19 UTC using RuboCop version 1.80.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 12
-# Configuration parameters: Include, IgnoredGems, OnlyFor.
-# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+# Configuration parameters: IgnoredGems, OnlyFor.
 Bundler/GemComment:
   Exclude:
     - 'Gemfile'
@@ -75,7 +74,7 @@ Layout/SingleLineBlockChain:
     - 'spec/feedjira/feed_utilities_spec.rb'
     - 'spec/feedjira/parser/atom_feed_burner_spec.rb'
 
-# Offense count: 355
+# Offense count: 364
 # Configuration parameters: Only, Ignore.
 Lint/ConstantResolution:
   Exclude:
@@ -154,6 +153,12 @@ Lint/NumberConversion:
   Exclude:
     - 'lib/feedjira/parser/podlove_chapter.rb'
 
+# Offense count: 1
+# Configuration parameters: CountComments, Max, CountAsOne.
+Metrics/ModuleLength:
+  Exclude:
+    - 'spec/feedjira/parser/atom_spec.rb'
+
 # Offense count: 1
 # Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
 # AllowedMethods: call
@@ -285,7 +290,7 @@ Style/InlineComment:
     - 'spec/feedjira/feed_utilities_spec.rb'
     - 'spec/feedjira/preprocessor_spec.rb'
 
-# Offense count: 881
+# Offense count: 890
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: IgnoreMacros, AllowedMethods, AllowedPatterns, IncludedMacros, AllowParenthesesInMultilineCall, AllowParenthesesInChaining, AllowParenthesesInCamelCaseMethod, AllowParenthesesInStringInterpolation, EnforcedStyle.
 # SupportedStyles: require_parentheses, omit_parentheses
@@ -389,9 +394,3 @@ Style/StringHashKeys:
 Style/SuperArguments:
   Exclude:
     - 'lib/feedjira/feed_utilities.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/SuperWithArgsParentheses:
-  Exclude:
-    - 'lib/feedjira/feed_utilities.rb'

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Feedjira Changelog
 
+## 4.0.1
+
+* Amend Atom parser able_to_parse regex to also match the HTTPS variant of the xmlns attribute value (#558)
+
 ## 4.0.0
 
 * Drop support for Ruby 2.7 and 3.0 (#555)

data/Gemfile

@@ -4,10 +4,10 @@ source "https://rubygems.org/"
 
 gemspec
 
-gem "faraday", "~> 2.8.1"
+gem "faraday", "~> 2.13.4"
 gem "pry", "~> 0.15.0"
 gem "rspec", "~> 3.13.0"
-gem "rubocop", "~> 1.79.0"
+gem "rubocop", "~> 1.80.0"
 gem "rubocop-performance", "~> 1.25.0"
 gem "rubocop-rake", "~> 0.7.1"
 gem "rubocop-rspec", "~> 3.6.0"

data/lib/feedjira/parser/atom.rb

@@ -17,7 +17,7 @@ module Feedjira
       element :icon
 
       def self.able_to_parse?(xml)
-        %r{<feed[^>]+xmlns\s?=\s?["'](http://www\.w3\.org/2005/Atom|http://purl\.org/atom/ns\#)["'][^>]*>} =~ xml
+        %r{<feed[^>]+xmlns\s?=\s?["'](https?://www\.w3\.org/2005/Atom|http://purl\.org/atom/ns\#)["'][^>]*>} =~ xml
       end
 
       def url

data/lib/feedjira/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Feedjira
-  VERSION = "4.0.0"
+  VERSION = "4.0.1"
 end

data/spec/feedjira/parser/atom_spec.rb

@@ -4,21 +4,72 @@ require "spec_helper"
 
 module Feedjira
   module Parser
-    describe "#will_parse?" do
-      it "returns true for an atom feed" do
-        expect(Atom).to be_able_to_parse(sample_atom_feed)
+    describe "#able_to_parse?" do
+      it "returns false if the xmlns value is not the expected value" do
+        xml = '<feed xmlns="http://www.example.org/"></feed>'
+        expect(Atom).not_to be_able_to_parse(xml)
       end
 
-      it "returns false for an rdf feed" do
-        expect(Atom).not_to be_able_to_parse(sample_rdf_feed)
+      it "returns false if there is no xmlns value" do
+        xml = "<feed></feed>"
+        expect(Atom).not_to be_able_to_parse(xml)
       end
 
-      it "returns false for an rss feedburner feed" do
-        expect(Atom).not_to be_able_to_parse(sample_rss_feed_burner_feed)
+      describe "with a w3.org URL present" do
+        it "returns true if contains the expected w3.org URL as xmlns value" do
+          xml = '<feed xmlns="http://www.w3.org/2005/Atom"></feed>'
+          expect(Atom).to be_able_to_parse(xml)
+        end
+
+        it "returns true if contains the HTTPS variant of the expected w3.org URL as xmlns value" do
+          xml = '<feed xmlns="https://www.w3.org/2005/Atom"></feed>'
+          expect(Atom).to be_able_to_parse(xml)
+        end
+
+        it "returns true if contains the expected xmlns value with single quotes" do
+          xml = "<feed xmlns='http://www.w3.org/2005/Atom'></feed>"
+          expect(Atom).to be_able_to_parse(xml)
+        end
+
+        it "returns true with whitespace around the equals sign" do
+          xml = '<feed xmlns = "http://www.w3.org/2005/Atom"></feed>'
+          expect(Atom).to be_able_to_parse(xml)
+        end
+      end
+
+      describe "with a purl.org URL present" do
+        it "returns true if contains the expected purl.org URL as xmlns value" do
+          xml = '<feed xmlns="http://purl.org/atom/ns#"></feed>'
+          expect(Atom).to be_able_to_parse(xml)
+        end
+
+        it "returns true if contains the expected xmlns value with single quotes" do
+          xml = "<feed xmlns='http://purl.org/atom/ns#'></feed>"
+          expect(Atom).to be_able_to_parse(xml)
+        end
+
+        it "returns true with whitespace around the equals sign" do
+          xml = '<feed xmlns = "http://purl.org/atom/ns#"></feed>'
+          expect(Atom).to be_able_to_parse(xml)
+        end
       end
 
-      it "returns true for an atom feed that has line breaks in between attributes in the <feed> node" do
-        expect(Atom).to be_able_to_parse(sample_atom_feed_line_breaks)
+      context "with full sample feeds" do
+        it "returns true for an atom feed" do
+          expect(Atom).to be_able_to_parse(sample_atom_feed)
+        end
+
+        it "returns false for an rdf feed" do
+          expect(Atom).not_to be_able_to_parse(sample_rdf_feed)
+        end
+
+        it "returns false for an rss feedburner feed" do
+          expect(Atom).not_to be_able_to_parse(sample_rss_feed_burner_feed)
+        end
+
+        it "returns true for an atom feed that has line breaks in between attributes in the <feed> node" do
+          expect(Atom).to be_able_to_parse(sample_atom_feed_line_breaks)
+        end
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feedjira
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Adam Hess