feed_parser 0.2.0 → 0.2.1

data/lib/feed_parser/feed.rb

@@ -4,7 +4,12 @@ class FeedParser
 
     def initialize(feed_url)
       parsed_url = parse_url(feed_url)
-      @feed = Nokogiri::XML(open(parsed_url[:url], :http_basic_authentication => parsed_url[:basic_auth]))
+      raw_feed = if parsed_url[:basic_auth]
+        open(parsed_url[:url], :http_basic_authentication => parsed_url[:basic_auth])
+      else
+        open(parsed_url[:url])
+      end
+      @feed = Nokogiri::XML(raw_feed)
       @feed.remove_namespaces!
       @type = (@feed.search('rss')[0] && :rss || :atom)
       self

data/lib/feed_parser.rb

@@ -3,7 +3,7 @@ require 'nokogiri'
 
 class FeedParser
 
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 
   def initialize(opts)
     @url = opts[:url]

data/spec/feed_parser_spec.rb

@@ -8,34 +8,23 @@ end
 
 describe FeedParser do
   describe FeedParser::Feed, "#new" do
-    it "should be able to open a feed url" do
-      parser = FeedParser.new(:url => "http://blog.example.com/feed/")
-      lambda {
-        parser.parse
-      }.should_not raise_error(ArgumentError)
-      lambda {
-        parser.parse
-      }.should raise_error(SocketError, /getaddrinfo: nodename nor servname provided, or not known/)
+    def feed_xml
+      File.read(File.join(File.dirname(__FILE__), 'fixtures', 'nodeta.rss.xml'))
     end
 
-    it "should be able to open feed urls with basic auth embedded to the url" do
-      parser = FeedParser.new(:url => "http://user:pass@blog.example.com/feed/")
-      lambda {
-        parser.parse
-      }.should_not raise_error(ArgumentError, /userinfo not supported/)
-      lambda {
-        parser.parse
-      }.should raise_error(SocketError, /getaddrinfo: nodename nor servname provided, or not known/)
+    it "should fetch a feed by url" do
+      FeedParser::Feed.any_instance.should_receive(:open).with("http://blog.example.com/feed/").and_return(feed_xml)
+      FeedParser::Feed.new("http://blog.example.com/feed/")
     end
 
-    it "should be able to open feed urls with only a user name embedded to the url" do
-      parser = FeedParser.new(:url => "http://user@blog.example.com/feed/")
-      lambda {
-        parser.parse
-      }.should_not raise_error(ArgumentError, /userinfo not supported/)
-      lambda {
-        parser.parse
-      }.should raise_error(SocketError, /getaddrinfo: nodename nor servname provided, or not known/)
+    it "should fetch a feed using basic auth if auth embedded to the url" do
+      FeedParser::Feed.any_instance.should_receive(:open).with("http://blog.example.com/feed/", :http_basic_authentication => ["user", "pass"]).and_return(feed_xml)
+      FeedParser::Feed.new("http://user:pass@blog.example.com/feed/")
+    end
+
+    it "should fetch a feed with only a user name embedded to the url" do
+      FeedParser::Feed.any_instance.should_receive(:open).with("http://blog.example.com/feed/", :http_basic_authentication => ["user"]).and_return(feed_xml)
+      FeedParser::Feed.new("http://user@blog.example.com/feed/")
     end
   end
 

metadata

@@ -1,46 +1,62 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: feed_parser
-version: !ruby/object:Gem::Version
-  version: 0.2.0
+version: !ruby/object:Gem::Version 
+  hash: 21
   prerelease: 
+  segments: 
+  - 0
+  - 2
+  - 1
+  version: 0.2.1
 platform: ruby
-authors:
+authors: 
 - Arttu Tervo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-11-28 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: &2156476000 !ruby/object:Gem::Requirement
+
+date: 2011-12-07 00:00:00 +02:00
+default_executable: 
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id001 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  name: nokogiri
   prerelease: false
-  version_requirements: *2156476000
-- !ruby/object:Gem::Dependency
-  name: rspec-rails
-  requirement: &2156475080 !ruby/object:Gem::Requirement
+  type: :runtime
+  requirement: *id001
+- !ruby/object:Gem::Dependency 
+  version_requirements: &id002 !ruby/object:Gem::Requirement 
     none: false
-    requirements:
+    requirements: 
     - - ~>
-      - !ruby/object:Gem::Version
-        version: '2.6'
-  type: :development
+      - !ruby/object:Gem::Version 
+        hash: 15
+        segments: 
+        - 2
+        - 6
+        version: "2.6"
+  name: rspec-rails
   prerelease: false
-  version_requirements: *2156475080
+  type: :development
+  requirement: *id002
 description: Rss and Atom feed parser with sanitizer support built on top of Nokogiri.
-email:
+email: 
 - arttu.tervo@gmail.com
 executables: []
+
 extensions: []
-extra_rdoc_files:
+
+extra_rdoc_files: 
 - README.md
-files:
+files: 
 - .gitignore
 - Gemfile
 - LICENSE
@@ -57,31 +73,41 @@ files:
 - spec/fixtures/nodeta.rss.xml
 - spec/fixtures/sanitize.me.rss.xml
 - spec/fixtures/smashingmagazine.atom.xml
+has_rdoc: true
 homepage: http://github.com/arttu/feed_parser
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.11
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: Rss and Atom feed parser
-test_files:
+test_files: 
 - spec/feed_parser_spec.rb
 - spec/fixtures/TechCrunch.xml
 - spec/fixtures/gcal.atom.xml