feed_cache 0.0.1 → 0.1.0

data/lib/feed_cache.rb

@@ -2,6 +2,8 @@ module FeedCache
   DEFAULT_ENTRIES_LIMIT = 10
   DEFAULT_EXPIRES_IN = 900
 
+  class MissingEntries < StandardError; end
+
   class << self
     attr_accessor :cache
     attr_writer :default_entries_limit, :default_expires_in
@@ -28,8 +30,12 @@ module FeedCache
 
   def self.entries_for(url, options = {})
     limit = options.delete(:limit) || default_entries_limit
-    feed = fetch(url, options)
-    (feed ? feed.entries : []).take(limit)
+    begin
+      feed = fetch(url, options)
+      (feed ? feed.entries : []).take(limit)
+    rescue TypeError
+      raise FeedCache::MissingEntries
+    end
   end
 end
 

data/lib/feed_cache/version.rb

@@ -1,3 +1,3 @@
 module FeedCache
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/spec/feed_cache_spec.rb

@@ -9,14 +9,29 @@ describe FeedCache do
   let(:blog_feed) { YAML.load_file(File.join File.dirname(__FILE__), "./fixtures/blog_feed.yaml") }
   let(:cache) { ActiveSupport::Cache::MemoryStore.new }
 
-  before do
+  def stub_feedzirra
     Feedzirra::Feed.stub(:fetch_and_parse).with(blog_url).and_return(blog_feed)
+  end
+
+  def unstub_feedzirra
+    begin
+      Feedzirra::Feed.unstub(:fetch_and_parse)
+    rescue RSpec::Mocks::MockExpectationError => e
+      $stderr.puts e.message
+    end
+  end
+
+  before do
     FeedCache.configure do |fc|
       fc.cache = cache
     end
   end
 
+  after { unstub_feedzirra }
+
   describe "fetching a feed" do
+    before { stub_feedzirra }
+
     context "for a valid feed grab" do
       it "returns the feed with entries" do
         feed = FeedCache.fetch(blog_url)
@@ -39,6 +54,8 @@ describe FeedCache do
   end
 
   describe "getting just the entries for a feed" do
+    before { stub_feedzirra }
+
     context "for a valid feed grab" do
       it "returns the entries array" do
         FeedCache.entries_for(blog_url).length.should == 10
@@ -60,5 +77,19 @@ describe FeedCache do
         FeedCache.entries_for(blog_url).should == []
       end
     end
+
+    # There's a bug where TypeError is raised, but I can't replicated it
+    # by using FakeWeb, so I want to cover it with an explicit raise for now
+    context "for a feed that raises TypeError when fetching entries" do
+      let(:no_entry_feed_url) { "http://example.com/no_entry_feed.xml" }
+      let(:no_entry_feed) { File.read(File.join(File.dirname(__FILE__), "./fixtures/no_entry_feed.xml")) }
+
+      it "raises FeedCache::MissingEntries" do
+        Feedzirra::Feed.stub(:fetch_and_parse).and_raise(TypeError)
+        lambda {
+          FeedCache.entries_for(no_entry_feed_url)
+        }.should raise_error(FeedCache::MissingEntries)
+      end
+    end
   end
 end

data/spec/fixtures/no_entry_feed.xml

@@ -0,0 +1,11 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<rss xmlns:atom="http://www.w3.org/2005/Atom" version="2.0" xmlns:dc="http://purl.org/dc/elements/1.1/">
+  <channel>
+    <title>Recent posts | Kajabi Support</title>
+    <description>posts</description>
+    <link>http://support.kajabi.com/posts</link>
+    <language>en-us</language>
+    <ttl>60</ttl>
+    <atom:link href="support.kajabi.com/categories/3610-knowledge-base/posts.rss" rel="self" type="application/rss+xml"/>
+  </channel>
+</rss>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: feed_cache
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: false
   segments: 
   - 0
-  - 0
   - 1
-  version: 0.0.1
+  - 0
+  version: 0.1.0
 platform: ruby
 authors: 
 - Brendon Murphy
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-12-06 00:00:00 -08:00
+date: 2012-04-04 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -84,6 +84,7 @@ files:
 - lib/feed_cache/version.rb
 - spec/feed_cache_spec.rb
 - spec/fixtures/blog_feed.yaml
+- spec/fixtures/no_entry_feed.xml
 - spec/spec_helper.rb
 has_rdoc: true
 homepage: ""
@@ -122,4 +123,5 @@ summary: A thin wrapper over Feedzirra with injected caching
 test_files: 
 - spec/feed_cache_spec.rb
 - spec/fixtures/blog_feed.yaml
+- spec/fixtures/no_entry_feed.xml
 - spec/spec_helper.rb