fedex_location_service 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 218e8c66cf2caf2aea9d44a75d13009b9d1671d0fc93d29118ae7eea81940ae2
-  data.tar.gz: b707b292cc9e5da7555921371a09733fa1a509e50398d1e01beb0b2112de120a
+  metadata.gz: c4ef54bf08411e8df537a9c21188188011cbdb5a192e3a38dd633937b853d391
+  data.tar.gz: 733843444d101bf5f49b893fce04b79e7be73f111dd66e4f474c73f9991a4530
 SHA512:
-  metadata.gz: e33c0bf49982055240980f8a96b5c645c80d18c8bcce5f594626c10b5936637ea9d01118f68f40dc13468d538a8234cb4cd42bcd2b238bf6b9d04300f1d93e16
-  data.tar.gz: 906595cdc98eb8924270d52b928e9d3a7de7d194348465ed37477bbe4c5ecd96e7a49c91d9ee83246e4ce697f2b08dca9738dcfbf5327637739b6ffb5ad882ee
+  metadata.gz: 89d0483eb3b12ba9ee42ebf0a18fd7d9c48269a2301b0d66233e33e2065f09dd882665621e9aa95bc770cff7da1a49e4db92b2b28414116b19476af59562a280
+  data.tar.gz: 14d261f96e65f8e46d6ffe02d808a7947208484fa56047a8fde85e9be18c5dc83b05bb108da2217f4e652ab7b740a8893743b583152f22a02e52c1d1d85ab1dc

data/README.md

@@ -60,17 +60,26 @@ The resulting message can then be passed to FedexLocationService::Request.call()
 response = FedexLocationService::Request.call(message)
 ```
 
-This will return a Savon::Response object that you can parse.
+This will return a Savon::Response or Savon::SOAPFault object.
 
-The FedEx Location Service API will return a status of 'SUCCESS' if locations have been found for the address provided in the message.
+This retuned Savon object can then be passed to FedexLocationService::Response.build()
 
-The FedEx Location Service API will return a status of 'ERROR' if no locations have been found for the address provided in the message.
+```ruby
+parsed_response = FedexLocationService::Response.build(response)
+```
+
+Depending on how the request went the parsed_response will have a different status:
 
-The method will rescue from any Savon::SOAPFault exception and return a hash that consists of:
+```ruby
+## The address was correct and there are FedEx locations:
+parsed_response[:search_locations_reply][:highest_severity] == 'SUCCESS'
+
+## The address was correct and there are no FedEx locations:
+parsed_response[:search_locations_reply][:highest_severity] == 'ERROR'
 
-* :cause
-* :code
-* :desc
+## There was a SOAP Fault:
+parsed_response[:search_locations_reply][:highest_severity] == 'FATAL'
+```
 
 Included is a FedexLocationService::Locations.call() method that will extract the first 5 closest locations and return the addresses, distance and a map image.
 

data/Rakefile

@@ -1,6 +1,6 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "fedex_location_service"
+require 'bundler/setup'
+require 'fedex_location_service'
 require 'dotenv/load'
 
 Bundler.require
@@ -9,5 +9,5 @@ Bundler.require
 require_relative '../spec/support/address.rb'
 require_relative '../spec/support/fedex_location_service_config.rb'
 
-require "pry"
+require 'pry'
 Pry.start

data/fedex_location_service.gemspec

@@ -1,40 +1,40 @@
-# coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path('lib', __dir__)
+
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "fedex_location_service/version"
+require 'fedex_location_service/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "fedex_location_service"
+  spec.name          = 'fedex_location_service'
   spec.version       = FedexLocationService::VERSION
-  spec.authors       = ["odin - (Casey Ellett)"]
-  spec.email         = ["casey.ellett@gmail.com"]
+  spec.authors       = ['odin - (Casey Ellett)']
+  spec.email         = ['casey.ellett@gmail.com']
 
   spec.summary       = %q{Interface for FedEx Location Services API.}
   spec.homepage      = 'https://github.com/odin/fedex_location_service'
-  spec.license       = "MIT"
+  spec.license       = 'MIT'
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
-    spec.metadata["allowed_push_host"] = "https://rubygems.org"
+    spec.metadata['allowed_push_host'] = 'https://rubygems.org'
   else
-    raise "RubyGems 2.0 or newer is required to protect against " \
-      "public gem pushes."
+    raise 'RubyGems 2.0 or newer is required to protect against ' \
+      'public gem pushes.'
   end
 
   spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
 
-  spec.bindir        = "exe"
+  spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "awesome_print"
-  spec.add_development_dependency "bundler", "~> 1.15"
-  spec.add_development_dependency "dotenv"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency 'awesome_print'
+  spec.add_development_dependency 'bundler', '~> 1.15'
+  spec.add_development_dependency 'dotenv'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'guard'
   spec.add_development_dependency 'guard-rspec'
   spec.add_development_dependency 'webmock'

data/lib/fedex_location_service.rb

@@ -2,6 +2,7 @@ require 'fedex_location_service/configuration'
 require 'fedex_location_service/locations'
 require 'fedex_location_service/message'
 require 'fedex_location_service/request'
+require 'fedex_location_service/response'
 require 'fedex_location_service/version'
 
 require 'savon'
@@ -24,6 +25,6 @@ module FedexLocationService
   end
 
   def self.root
-    Pathname.new File.expand_path('../..', __FILE__)
+    Pathname.new File.expand_path('..', __dir__)
   end
 end

data/lib/fedex_location_service/message.rb

@@ -30,7 +30,7 @@ module FedexLocationService
           'StreetLines' => [
             address.address_one,
             ## address_two cannot be nil
-            address.address_two ? address.address_two : ''
+            address.address_two || ''
           ],
           'City' => address.city,
           'StateOrProvinceCode' => address.state,
@@ -50,7 +50,7 @@ module FedexLocationService
           'RequiredLocationAttributes' => [
             'WEEKDAY_EXPRESS_HOLD_AT_LOCATION'
           ],
-          'ResultsRequested' => 5,
+          'ResultsRequested' => 5
         ]
       }
     end

data/lib/fedex_location_service/request.rb

@@ -6,10 +6,16 @@ module FedexLocationService
       begin
         @response = client.call(:search_locations, message: message)
       rescue Savon::SOAPFault => error
-        @response = error.to_hash[:fault][:detail]
+        @response = error
+        #@response = {
+        #  message: error.to_hash[:fault][:detail],
+        #  body: {
+        #    search_locations_response: {
+        #      highest_severity: 'ERROR'
+        #    }
+        #  }
+        #}
       end
-
-      return @response
     end
   end
 end

data/lib/fedex_location_service/response.rb

@@ -0,0 +1,19 @@
+module FedexLocationService
+  class Response
+    def self.build(message)
+      if message.class == Savon::Response
+        message.to_hash
+      elsif message.class == Savon::SOAPFault
+        original_message = message.to_hash
+
+        custom_error_message = {
+          search_locations_reply: {
+            highest_severity: 'FATAL'
+          }
+        }
+
+        original_message.merge(custom_error_message)
+      end
+    end
+  end
+end

data/lib/fedex_location_service/version.rb

@@ -1,3 +1,3 @@
 module FedexLocationService
-  VERSION = "0.3.0"
+  VERSION = '0.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fedex_location_service
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - odin - (Casey Ellett)
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-28 00:00:00.000000000 Z
+date: 2018-08-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: awesome_print
@@ -202,6 +202,7 @@ files:
 - lib/fedex_location_service/locations.rb
 - lib/fedex_location_service/message.rb
 - lib/fedex_location_service/request.rb
+- lib/fedex_location_service/response.rb
 - lib/fedex_location_service/version.rb
 homepage: https://github.com/odin/fedex_location_service
 licenses: