fech 1.3.1 → 1.3.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    fech (1.3)
+    fech (1.3.2)
       fastercsv
       people
 

data/README.rdoc

@@ -6,7 +6,7 @@
 
 Fech makes it easy to parse electronic campaign finance filings[http://www.fec.gov/finance/disclosure/efile_search.shtml] by candidates, parties and political action committees from the Federal Election Commission. It lets you access filing attributes the same way regardless of filing version, and works as a framework for cleaning and filing data. Fech is an open source project of The New York Times, but contributions from anyone interested in working with F.E.C. filings are greatly appreciated.
 
-Latest version: 1.3.1
+Latest version: 1.3.2
 
 Fech is tested under Ruby versions 1.8.7, 1.9.2 and 1.9.3.
 
@@ -16,6 +16,7 @@ Can be found at Fech's Github page[http://nytimes.github.com/Fech/].
 
 == News
 
+* March 26, 2013: Version 1.3.2 released. Bugfix for F99 filing encoding issues. Thanks for the patch, @jgillum.
 * Dec. 11, 2012: Versions 1.3, 1.3.1 released. Adds support for F13 filings from inaugural committees and fixes an encoding bug.
 * Dec. 3, 2012: Version 1.2 released. Fixes encoding errors under Ruby 1.9.3 for ASCII-encoded filings. Thanks to Sanjiv for the bug report.
 * Nov. 13, 2012: Version 1.1 released. CSVDoctor skips rows that don't match row type being searched for, which provides a performance boost, and smaller bugfixes for Form 99 handling and date-field conversions. Thanks to Sai for several patches.
@@ -76,6 +77,8 @@ Daniel Pritchett, daniel@sharingatwork.com
 
 Sai, home@saizai.com
 
+Jack Gillum, jgillum@ap.org
+
 == Copyright
 
-Copyright (c) 2012 The New York Times Company. See LICENSE for details.
+Copyright (c) 2013 The New York Times Company. See LICENSE for details.

data/lib/fech/filing.rb

@@ -245,6 +245,15 @@ module Fech
     def fix_f99_contents
       @customized = true
       content = file_contents.read
+      
+      if RUBY_VERSION > "1.9.2"
+        content.encode!('UTF-8', 'UTF-8', :invalid => :replace)
+      else
+        require 'iconv'
+        ic = Iconv.new('UTF-8//IGNORE', 'UTF-8') 
+        content = ic.iconv(content + ' ')[0..-2] # add valid byte before converting, then remove it
+      end
+      
       regex = /\n\[BEGINTEXT\]\n(.*?)\[ENDTEXT\]\n/mi # some use eg [EndText]
       match = content.match(regex)
       if match

data/lib/fech/version.rb

@@ -1,3 +1,3 @@
 module Fech
-  VERSION = "1.3.1"
+  VERSION = "1.3.2"
 end

data/spec/data/862554.fec

@@ -0,0 +1,30 @@
+HDRFEC8.0Vocus PAC Management8.00.58250
+F99C00053553National Rifle Association of America Political Victory Fund11250 Waples Mill RoadFairfaxVA22030AdkinsMary Rose20130321MST
+[BEGINTEXT]
+March 21, 2013
+
+
+Federal Election Commission
+Reports Analysis Division
+Attn:  Paul Stoetzer
+999 E Street, NW
+Washington, DC  20463
+
+ID#	  C00053553
+RE:	  Amended 12 Day Pre-General Report (10/01/2012 - 10/17/2012)
+
+Dear Mr. Stoetzer:
+
+This letter is in response to your letter dated February 15, 2013 regarding the NRA Political Victory Fund�s Amended 12 Day Pre-General Report (10/01/2012 - 10/17/2012) concerning receipts for Line 11(a) that increased from the original report.
+
+When preparing in-house financial statements for the month of October, reconciliations showed that some contributions were not posted to our system by our lockbox service company.  The contributions in question should have been posted with a date of October 16th and 17th but were not deposited into our account until October 19th,  22nd and 23rd.  These deposits in transit were not discovered until a full analysis of our activity for the month of October was performed.  
+
+Once the error was found, corrective action was taken.  The missing items were posted and an amendment showing the additional contributions were reported on Line 11 (a)(iii) of our 12 Day Pre-General Report.
+
+I can be reached at 703-267-1155 should you have any additional questions.
+
+Sincerely,
+
+Mary Rose Adkins
+Treasurer
+[ENDTEXT]

data/spec/filing_spec.rb

@@ -25,6 +25,8 @@ describe Fech::Filing do
     @filing_f13.stubs(:file_path).returns(File.join(File.dirname(__FILE__), 'data', '425925.fec'))
     @filing_special_character = Fech::Filing.new(771694)
     @filing_special_character.stubs(:file_path).returns(File.join(File.dirname(__FILE__), 'data', '771694.fec'))
+    @filing_f99 = Fech::Filing.new(862554)
+    @filing_f99.stubs(:file_path).returns(File.join(File.dirname(__FILE__), 'data', '862554.fec'))
   end
   
   describe "#filing_version" do
@@ -99,6 +101,12 @@ describe Fech::Filing do
     
   end
   
+  describe 'miscelleanous filings' do
+    it "should handle invalid encoding" do
+      @filing_f99.rows_like(/f99/).first.should_not raise_error
+    end
+  end
+  
   describe "#rows_like" do
     
     it "should return only rows matching the specified regex" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: fech
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 31
   prerelease: 
   segments: 
   - 1
   - 3
-  - 1
-  version: 1.3.1
+  - 2
+  version: 1.3.2
 platform: ruby
 authors: 
 - Michael Strickland
@@ -18,7 +18,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-11 00:00:00 Z
+date: 2013-03-26 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: fastercsv
@@ -295,6 +295,7 @@ files:
 - spec/data/767339.fec
 - spec/data/771694.fec
 - spec/data/82094.fec
+- spec/data/862554.fec
 - spec/data/97405.fec
 - spec/default_translations_spec.rb
 - spec/fech_utils_spec.rb