feature_toggle_service 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 871f7203a1058c29fdb1b77f335f06621677ae72
-  data.tar.gz: 273df5f6daf47a89d2dfb24f7f777cf89b3b9882
+  metadata.gz: 94683c6c8febdcbeb9ae8df28ac90e244acf029a
+  data.tar.gz: fc1cb1163743da6089b743f59f69f563806dd5c4
 SHA512:
-  metadata.gz: 4641d20335d2e8947c5b7fb253c4a14854487b49b2782544bcc1e8496b8f3e63a40d8530d3144e6a942910eaad087fc109d9354eaa16f99dacf4d61af6306c58
-  data.tar.gz: 101b517a76ee5e41c7f60ba5cd0bfb49eccdb40dc9d85397f9ee1bd740acbf1c3f90201bb999f5bdd58f9c29f913e57d39d551bd67481da86d311886e5fcd0ad
+  metadata.gz: d074c23443f26130480d02d8a4f3417abe1c3dadb84664ef2a11ef63c2f7838e84e8f869d5eb690ac1e406d2b3286fc0aebe75e0b275ec9be7b287d8d70e51e4
+  data.tar.gz: c25a48c250aab516617b141c37ea4606a87cdcb5d415f29aee48e46988866f7823f39a6017d1646a6da617d4110276dd2dd2080f4f433f69c20ce4ca3fe2ff49

data/README.md

@@ -112,22 +112,96 @@ Or install it yourself as:
 
 ### Setup
 
-Example of configuration in an Rails initializer, using SimpleConfig. We're setting up some config params, and also enabling by default a feature `'my_feature'`
+Example of configuration in an Rails initializer. We're setting up some config params, and also enabling by default a feature `'my_feature'`
+
+
+First, we add common config to the Application config, like where do we have our etcd repository and how to access it.
+
+```ruby
+# config/application.rb
+
+module MyCoolProject
+  class Application < Rails::Application
+
+    #... other stuff
+
+    # FEATURE TOGGLE
+    config.feature_toggle                       = ActiveSupport::OrderedOptions.new
+    config.feature_toggle.enabled               = true
+    config.feature_toggle.cache_toggles         = true
+    config.feature_toggle.app_name              = 'MyCoolProject'
+    config.feature_toggle.etcd_client           = ActiveSupport::OrderedOptions.new
+    config.feature_toggle.etcd_client.host      = 'etcd.example.org'
+    config.feature_toggle.etcd_client.port      = 443
+    config.feature_toggle.etcd_client.use_ssl   = true
+    config.feature_toggle.etcd_client.user_name = 'my-basic-auth-username'
+    config.feature_toggle.etcd_client.password  = 'my-basic-auth-password'
+  end
+end
+```
+
+Then we add environment keys, overrides and defaults on the env config
+
+```ruby
+# config/environments/mcp_int.rb
+
+MyCoolProject::Application.configure do
+
+  # FEATURED TOGGLES
+  config.feature_toggle.key_suffix   = 'int'
+  config.feature_toggle.default_on   = [:feature_1, :another_feature]
+  config.feature_toggle.default_off  = []
+  config.feature_toggle.override_on  = [:feature_3]
+  config.feature_toggle.override_off = []
+end
+
+```
+
+Finally, we load the config into `FeatureToggleService` in the initializer:
 
 ```ruby
+# config/initializers/feature_toggles.rb
+
 require 'feature_toggle_service'
 
 # config
-FeatureToggleService.config_params[:enabled]            = SimpleConfig.for(:site).feature_toggle.enabled
-FeatureToggleService.config_params[:app_name]           = SimpleConfig.for(:site).feature_toggle.app_name
-FeatureToggleService.config_params[:etcd_client][:port] = SimpleConfig.for(:site).feature_toggle.etcd_client.port
-FeatureToggleService.config_params[:logger]             = Rails.logger
-FeatureToggleService.config_params[:key_suffix]         = Rails.env
+ftc = Rails.configuration.feature_toggle
+cp  = FeatureToggleService.config_params
+
+cp[:logger]        = Rails.logger
+cp[:cache_toggles] = ftc.cache_toggles unless ftc.cache_toggles.nil?
+cp[:enabled]       = ftc.enabled unless ftc.enabled.nil?
+cp[:app_name]      = ftc.app_name unless ftc.app_name.nil?
+cp[:key_suffix]    = ftc.key_suffix unless ftc.key_suffix.nil?
+
+etcd_cnf = ftc.etcd_client
+if etcd_cnf
+  cp[:etcd_client][:host]      = etcd_cnf.host unless etcd_cnf.host.nil?
+  cp[:etcd_client][:port]      = etcd_cnf.port unless etcd_cnf.port.nil?
+  cp[:etcd_client][:use_ssl]   = etcd_cnf.use_ssl unless etcd_cnf.use_ssl.nil?
+  cp[:etcd_client][:user_name] = etcd_cnf.user_name unless etcd_cnf.user_name.nil?
+  cp[:etcd_client][:password]  = etcd_cnf.password unless etcd_cnf.password.nil?
+end
 
 # specific defaults on this project
-FeatureToggleService.default_on :my_feature
+Array(ftc.default_on).each do |key|
+  FeatureToggleService.default_on key
+end
+
+Array(ftc.default_off).each do |key|
+  FeatureToggleService.default_off key
+end
+
+Array(ftc.override_on).each do |key|
+  FeatureToggleService.override_on key
+end
+
+Array(ftc.override_off).each do |key|
+  FeatureToggleService.override_off key
+end
 ```
 
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/feature_toggle_service/repository.rb

@@ -55,11 +55,11 @@ module FeatureToggleService
     def retrieve_value(key)
       fk = final_key(key)
       etcd_get_toggle(fk)
-    rescue Etcd::KeyNotFound => e
+    rescue Etcd::KeyNotFound => _e
       logger.error { "Feature Toggle without key #{key.inspect}, final key #{fk.inspect}." }
       default_value_for(key)
-    rescue Errno::ECONNREFUSED => e
-      logger.error { "Cannot connect with Feature Toggle Repository! #{key.inspect}, final key #{fk.inspect}." }
+    rescue Errno::ECONNREFUSED, SocketError => e
+      logger.error { "Cannot connect with Feature Toggle Repository! #{key.inspect}, final key #{fk.inspect}. Error: #{e}" }
       Airbrake.notify(e) if defined?(Airbrake)
       default_value_for(key)
     end

data/lib/feature_toggle_service/version.rb

@@ -1,3 +1,3 @@
 module FeatureToggleService
-  VERSION = '0.4.0'
+  VERSION = '0.4.1'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: feature_toggle_service
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Eduardo Turiño
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-06-08 00:00:00.000000000 Z
+date: 2016-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: etcd
@@ -218,7 +218,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Service for using feature toggles in your ruby code (true/false by a specific