feature_release 0.0.1 → 0.0.2

data/feature_release.gemspec

@@ -21,4 +21,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "mock_redis"
 end

data/lib/feature_release.rb

@@ -1,15 +1,17 @@
 require "feature_release/version"
 require "feature_release/feature"
+require "feature_release/storage"
 
 class FeatureRelease
 
   attr_reader :groups, :features
   
-  def initialize
+  def initialize(storage=nil)
   	@groups = {:all => lambda{|obj| true}}
   	@features = Hash.new do |hash, missing_key|
   	              hash[missing_key] = Feature.new(missing_key)
   	            end
+    set_storage(storage) if storage
   end
 
   def define_group(name, &block)
@@ -29,4 +31,21 @@ class FeatureRelease
   	@features[feature.to_sym].groups.all? {|group| groups[group].call(user)}
   end
 
+  def persisted?(feature)
+    !(@storage.get(@features[feature.to_sym].name).nil?)
+  end
+
+  def save
+    @features.each{|key, value|  @storage.save(value.name, value.to_string)}
+  end
+
+  private
+
+    def set_storage(storage)
+      @storage = storage
+      @storage.get_all.each do |feature_name|
+        @features[feature_name.to_sym] = Feature.new(feature_name, @storage.get(feature_name))
+      end
+    end
+
 end

data/lib/feature_release/feature.rb

@@ -3,10 +3,12 @@ class FeatureRelease
   class Feature
 
   	attr_accessor :groups
+    attr_reader :name
 
-    def initialize(name)
+    def initialize(name, groups_string=nil)
       @name = name
       @groups = []
+      parse_groups(groups_string)
     end  	
 
     def add_group(group)
@@ -17,6 +19,16 @@ class FeatureRelease
       @groups.delete(group.to_sym)
     end
 
+    def to_string
+      @groups.join(",")
+    end
+
+    private
+      def parse_groups(string)
+        return unless string
+        @groups = string.split(",").map(&:to_sym)
+      end
+
   end
 
 end

data/lib/feature_release/storage.rb

@@ -0,0 +1,42 @@
+require 'spec_helper'
+class FeatureRelease
+  class Storage
+
+ 	def initialize(options={})
+ 	  @store = options.fetch(:store)
+ 	end
+
+ 	def save(feature, data)
+ 	  persist(feature, data)
+ 	end
+
+ 	def get(feature)
+ 	  retrieve(feature_key(feature))
+ 	end
+
+ 	def get_all
+ 	  (retrieve(global_key) || "").split(",").map(&:to_sym)
+ 	end
+
+
+ 	private
+
+ 	  def feature_key(feature)
+ 	  	"feature:#{feature}"
+ 	  end
+
+ 	  def global_key
+ 	  	"features:all"
+ 	  end
+
+ 	  def persist(feature, data)
+ 	  	@store.set(feature_key(feature), data)
+ 	  	@store.set(global_key, (get_all | [feature]).join(","))
+ 	  end
+
+ 	  def retrieve(key)
+ 	  	@store.get(key)
+ 	  end
+
+  end
+end

data/lib/feature_release/version.rb

@@ -1,3 +1,3 @@
 class FeatureRelease
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/feature_release_spec.rb

@@ -57,4 +57,38 @@ describe FeatureRelease do
 
   end
 
+  context "persistence" do
+    let(:tester) {double("user", :new? => true, :admin? => false)}
+    let(:admin) {double("user", :admin? => true, :new? => false)}
+
+    before(:each) do
+      @redis = MockRedis.new
+      @storage = FeatureRelease::Storage.new(store:@redis)
+      @fr = FeatureRelease.new(@storage)
+      @fr.define_group(:testers) do |user|
+        user.new?
+      end
+      @fr.activate_feature(:test_feature, :testers)
+      @fr.define_group(:admins) do |user|
+        user.admin?
+      end
+      @fr.activate_feature(:new_feature, :admins)
+    end
+
+    it "commands its storage object to save the features" do
+      @fr.save
+      @fr.persisted?(:test_feature).should be_true
+    end
+
+    it "can build itself from persisted date" do
+      @fr.save
+      @new_fr = FeatureRelease.new(@storage)
+      @new_fr.define_group(:admins) do |user|
+        user.admin?
+      end
+      @new_fr.active?(:new_feature, admin).should be_true
+    end
+
+
+  end
 end

data/spec/feature_spec.rb

@@ -23,5 +23,21 @@ describe FeatureRelease::Feature do
   	f.remove_group(:testers)
   	f.groups.should_not include(:testers)
   end
+
+  it "can be to_string into a string" do
+    f = FeatureRelease::Feature.new(:test_feature)
+    f.add_group(:testers)
+    f.add_group(:admins)
+    f.to_string.should eq("testers,admins")
+  end
+
+  it "can be built from a string" do
+    f = FeatureRelease::Feature.new(:test_feature)
+    f.add_group(:testers)
+    f.add_group(:admins)
+    string = f.to_string
+    from_s = FeatureRelease::Feature.new(:test_feature, string)
+    from_s.groups.should eq([:testers, :admins])
+  end
 	
 end

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 $LOAD_PATH.unshift(File.dirname(__FILE__))
 $LOAD_PATH.unshift(File.join(File.dirname(__FILE__), '..', 'lib'))
 require 'feature_release.rb'
+require 'mock_redis'
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true

data/spec/storage_spec.rb

@@ -0,0 +1,34 @@
+require 'spec_helper'
+
+describe FeatureRelease::Storage do
+
+  before(:each) do
+  	@redis = MockRedis.new
+  end
+
+  it "should initialize with a store" do
+  	expect{FeatureRelease::Storage.new()}.to raise_error
+  	expect{FeatureRelease::Storage.new(store: @redis)}.to_not raise_error
+  end
+
+  context 'saving features' do
+
+  	before(:each) do
+  	  @storage = FeatureRelease::Storage.new(store: @redis)
+  	  @feature = double 'Feature', name: :test_feature, to_string: "test_users, new_users, admin_users"
+  	end
+
+  	it "should save a feature to the store" do
+  	  @storage.save(@feature.name, @feature.to_string)
+  	  @storage.get(@feature.name).should eq(@feature.to_string)
+  	end
+
+  	it "should add a feature to the collection of features" do
+  	  @storage = FeatureRelease::Storage.new(store: @redis)
+  	  @storage.save(@feature.name, @feature.to_string)
+  	  @storage.get_all.should eq([:test_feature])
+  	end
+
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feature_release
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-07 00:00:00.000000000 Z
+date: 2014-05-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -59,6 +59,22 @@ dependencies:
     - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: mock_redis
+  requirement: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Allows you to restrict access of portions of an app to certain users
 email:
 - kavinderd@gmail.com
@@ -75,10 +91,12 @@ files:
 - feature_release.gemspec
 - lib/feature_release.rb
 - lib/feature_release/feature.rb
+- lib/feature_release/storage.rb
 - lib/feature_release/version.rb
 - spec/feature_release_spec.rb
 - spec/feature_spec.rb
 - spec/spec_helper.rb
+- spec/storage_spec.rb
 homepage: ''
 licenses:
 - MIT
@@ -94,7 +112,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4375904973404869369
+      hash: -1008631629134333472
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -103,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 4375904973404869369
+      hash: -1008631629134333472
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.25
@@ -114,3 +132,4 @@ test_files:
 - spec/feature_release_spec.rb
 - spec/feature_spec.rb
 - spec/spec_helper.rb
+- spec/storage_spec.rb