feature_gate 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5acf4b8ccc7c52181ba7d59a41ed67c21b8c1123
-  data.tar.gz: 1c1273f7c50647fa35c95702ddc56ac2bf4b8359
+  metadata.gz: 715612c103f17635e52891cbf81f7514d21e9c3f
+  data.tar.gz: 25dcc5c8bc92d866ef9f9b2cdcacfdd32f8fbf8a
 SHA512:
-  metadata.gz: f230f201f92df9305beb7aa35ddb60ad67ad3f31987b6e032efcd344b7db98c4972fbcf7522ea113d5d779c032aba09f50b8bac19c698e3ab70f627946e0ce86
-  data.tar.gz: 14706e4d0a5b3dae0eb425f5acc09ea5630bd510589e88fe49dc15dfaa5271eafe6f16115d12b34741c2b62c14b4741d0ee1f6c52d1eb85148baf9734116628e
+  metadata.gz: aebdd3dd94eee36f00cfc5df08a0410e728fea4428934c31ae20134a6f58f04ddf3e99b8c38b32d4ce435886a3ee4fea1aa451b586a0ac9fce26a2c63ba95895
+  data.tar.gz: 6f3451d1209a5750f4e75300563fd8e2799f553ff4cce647dd0e84e9fcde1ecc20ec3f7ef0b2d2c39621618a69d78d94da59e8dfb391d9be04b5792a5b5c3d33

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    feature_gate (0.1.8)
+    feature_gate (0.2.2)
       rails (~> 4.0)
 
 GEM

data/lib/feature_gate/version.rb

@@ -1,3 +1,3 @@
 module FeatureGate
-  VERSION = '0.2.2'.freeze
+  VERSION = '0.2.3'.freeze
 end

data/lib/feature_gate.rb

@@ -1,8 +1,6 @@
 module FeatureGate
-  class << self
-    mattr_accessor :time_to_stale
-    self.time_to_stale = 1.month
-  end
+  mattr_accessor :time_to_stale
+  self.time_to_stale = 1.month
 
   def self.setup
     yield self

data/spec/controllers/feature_gate/gated_features_controller_spec.rb

@@ -16,4 +16,26 @@ describe FeatureGate::GatedFeaturesController do
       expect(gate.reload).not_to be_gated
     end
   end
+
+  describe '#destroy' do
+    let!(:gate){ create(:gated_feature) }
+
+    before do
+      allow(FeatureGate::GatedFeature).to receive(:find).and_return(gate)
+    end
+
+    it 'destroys the gate if it is destroyable' do
+      allow(gate).to receive(:destroyable?).and_return true
+      expect do
+        delete :destroy, id: gate.id
+      end.to change{ FeatureGate::GatedFeature.count }.by(-1)
+    end
+
+    it 'does not destory the gate if it is not destroyable' do
+      allow(gate).to receive(:destroyable?).and_return false
+      expect do
+        delete :destroy, id: gate.id
+      end.not_to change{ FeatureGate::GatedFeature.count }
+    end
+  end
 end

data/spec/models/feature_gate/gated_feature_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe FeatureGate::GatedFeature do
+  let!(:gate) { create(:gated_feature) }
+
+  describe '#destroyable?' do
+    it 'returns true if files do not contain any feature gate references' do
+      text = <<-TEXT
+        <div>
+          <% FeatureGate::Manager.gate('test') do %>
+            foo
+          <% end %>
+        </div>
+
+        def index
+          FeatureGate::Manager.gate_page('test')
+        end
+      TEXT
+
+      fake_file = double(read: text)
+      allow(File).to receive(:new).and_return(fake_file)
+      expect(gate).to be_destroyable
+    end
+
+    it 'returns false if files contain feature gate gating a page' do
+      text = <<-TEXT
+        <div>
+          <% FeatureGate::Manager.gate('#{gate.name}') do %>
+            foo
+          <% end %>
+        </div>
+
+        def index
+          FeatureGate::Manager.gate_page('test')
+        end
+      TEXT
+
+      fake_file = double(read: text)
+      allow(File).to receive(:new).and_return(fake_file)
+      expect(gate).not_to be_destroyable
+    end
+
+    it 'return false if files contain feature gate gating part of a page' do
+      text = <<-TEXT
+        <div>
+          <% FeatureGate::Manager.gate('test') do %>
+            foo
+          <% end %>
+        </div>
+
+        def index
+          FeatureGate::Manager.gate_page('#{gate.name}')
+        end
+      TEXT
+
+      fake_file = double(read: text)
+      allow(File).to receive(:new).and_return(fake_file)
+      expect(gate).not_to be_destroyable
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: feature_gate
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Tiffany Huang
@@ -97,6 +97,7 @@ files:
 - spec/controllers/feature_gate/gated_features_controller_spec.rb
 - spec/factories.rb
 - spec/fake_app.rb
+- spec/models/feature_gate/gated_feature_spec.rb
 - spec/models/feature_gate/manager_spec.rb
 - spec/spec_helper.rb
 - spec/support/database.yml