feature 0.7.0 → 1.0.0

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 1.0.0 (2014-03-26)
+
+* drop ruby 1.8 support
+* support Rails 4 generator loading only (mauriciovieira)
+* add Feature.switch method (FlavourSys)
+* minor code and doc fixes and cleanup
+
 ## 0.7.0 (2013-12-07)
 
 * add ActiveRecordRepository and a Rails::Generator (bigzed)

data/Gemfile

@@ -1,9 +1,9 @@
 source 'https://rubygems.org'
 
 gem "rake"
-gem "rspec"
-gem "rspec-mocks"
 
 group :test do
-  gem 'coveralls', :require => false
+  gem "rspec"
+  gem "rspec-mocks"
+  gem 'coveralls', require: false
 end

data/README.md

@@ -5,12 +5,14 @@ Feature is a battle-tested [feature toggle](http://martinfowler.com/bliki/Featur
 The feature toggle functionality has to be configured by feature repositories. A feature repository simply provides lists of active features (symbols!). Unknown features are assumed deactive.
 With this approach Feature is higly configurable and not bound to a specific kind of configuration.
 
+**NOTE:** Ruby 1.8 is only supported until version 0.7.0. Later Versions require at least Ruby 1.9.
+
 ## CI status
 
 [![Gem Version](https://badge.fury.io/rb/feature.png)](https://rubygems.org/gems/feature)
 [![Travis-CI Build Status](https://travis-ci.org/mgsnova/feature.png)](https://travis-ci.org/mgsnova/feature)
 [![Code Climate](https://codeclimate.com/github/mgsnova/feature.png)](https://codeclimate.com/github/mgsnova/feature)
-[![Coverage Status](https://coveralls.io/repos/mgsnova/feature/badge.png)](https://coveralls.io/r/mgsnova/feature)
+[![Coverage Status](https://coveralls.io/repos/mgsnova/feature/badge.png?branch=master)](https://coveralls.io/r/mgsnova/feature)
 
 ## Installation
 
@@ -22,7 +24,7 @@ With this approach Feature is higly configurable and not bound to a specific kin
     * Create a repository (see examples below)
     * set repository to Feature
 
-        Feature.set_repository(your_repository)
+            Feature.set_repository(your_repository)
 
 * Use Feature in your production code
 
@@ -38,6 +40,11 @@ With this approach Feature is higly configurable and not bound to a specific kin
           # code
         end
 
+        Feature.switch(:feature_name, value_true, value_false) # => returns value_true if :feature_name is active, otherwise value_false
+
+        # May also take Procs (here in Ruby 1.9 lambda syntax), returns code evaluation result.
+        Feature.switch(:feature_name, -> { code... }, -> { code... })
+
 * Use Feature in your test code (for reliable testing of feature depending code)
 
         require 'feature/testing'

data/Rakefile

@@ -6,5 +6,5 @@ RSpec::Core::RakeTask.new(:spec) do |spec|
   spec.rspec_opts = ['--colour', '-f documentation', '--backtrace']
 end
 
-task :default => [:spec] do
+task default: [:spec] do
 end

data/lib/feature/generators/install_generator.rb

@@ -5,7 +5,7 @@ require 'rails/generators/active_record'
 module Feature
   class InstallGenerator < Rails::Generators::Base
     include Rails::Generators::Migration
-    extend ActiveRecord::Generators::Migration
+    extend Rails::Generators::Migration
 
     desc 'This generator creates a migration and a model for FeatureToggles.'
     source_root File.expand_path('../templates', __FILE__)

data/lib/feature/generators/templates/feature_toggle.rb

@@ -2,5 +2,5 @@ class FeatureToggle < ActiveRecord::Base
   attr_accessible :name, :active
 
   # Feature name should be present and unique
-  validates :name, :presence => true, :uniqueness => true
+  validates :name, presence: true, uniqueness: true
 end

data/lib/feature/repository/active_record_repository.rb

@@ -21,7 +21,7 @@ module Feature
       # @return [Array<Symbol>] list of active features
       #
       def active_features
-        @model.where(:active => true).map { |f| f.name.to_sym }
+        @model.where(active: true).map { |f| f.name.to_sym }
       end
 
       # Add an active feature to repository
@@ -31,7 +31,7 @@ module Feature
       def add_active_feature(feature)
         check_feature_is_not_symbol(feature)
         check_feature_already_in_list(feature)
-        @model.new(:name => feature.to_s, :active => true).save
+        @model.new(name: feature.to_s, active: true).save
       end
 
       # Checks if the given feature is a not symbol and raises an exception if so

data/lib/feature/testing.rb

@@ -7,8 +7,9 @@ require 'feature'
 # To enable Feature testing capabilities do:
 #   require 'feature/testing'
 module Feature
+
   # Execute the code block with the given feature active
-  # 
+  #
   # Example usage:
   #   Feature.run_with_activated(:feature) do
   #     # your test code here
@@ -22,7 +23,7 @@ module Feature
   end
 
   # Execute the code block with the given feature deactive
-  # 
+  #
   # Example usage:
   #   Feature.run_with_deactivated(:feature) do
   #     # your test code here

data/lib/feature.rb

@@ -5,7 +5,7 @@
 # - to refresh the feature lists (request them from repository)
 #
 # @note all features not active will be handled has inactive
-# 
+#
 # Example usage:
 #   repository = SimpleRepository.new
 #   repository.add_active_feature(:feature_name)
@@ -22,8 +22,8 @@
 #
 module Feature
   require 'feature/repository'
-  # Only load the generator if Rails is defined
-  require 'feature/generators/install_generator' if defined?(Rails)
+  # Only load the generator if Rails is defined and Version is greater than 3
+  require 'feature/generators/install_generator' if defined?(Rails) and Rails::VERSION::STRING > "3"
 
   @repository = nil
   @active_features = nil
@@ -80,9 +80,7 @@ module Feature
       raise ArgumentError, "no block given to #{__method__}"
     end
 
-    if active?(feature)
-      yield
-    end
+    yield if active?(feature)
   end
 
   # Execute the given block if feature is inactive
@@ -94,8 +92,20 @@ module Feature
       raise ArgumentError, "no block given to #{__method__}"
     end
 
-    if inactive?(feature)
-      yield
+    yield if inactive?(feature)
+  end
+
+  # Return value or execute Proc/lambda depending on Feature status.
+  #
+  # @param [Symbol] feature
+  # @param [Object] value to be returned / lambda to be evaluated if feature is active
+  # @param [Object] value to be returned / lambda to be evaluated if feature is inactive
+  #
+  def self.switch(feature, l1, l2)
+    if active?(feature)
+      l1.is_a?(Proc) ? l1.call : l1
+    else
+      l2.is_a?(Proc) ? l2.call : l2
     end
   end
 end

data/spec/feature/active_record_repository_spec.rb

@@ -17,7 +17,7 @@ describe Feature::Repository::ActiveRecordRepository do
 
   it "should add an active feature" do
     @features.should_receive(:exists?).with("feature_a").and_return(false)
-    @features.should_receive(:new).with(:name => "feature_a",:active => true).and_return(stub(:save => true))
+    @features.should_receive(:new).with(name: "feature_a", active: true).and_return(stub(save: true))
 
     @repository.add_active_feature :feature_a
   end
@@ -29,8 +29,8 @@ describe Feature::Repository::ActiveRecordRepository do
   end
 
   it "should raise an exception when adding a active feature already added as active" do
-    @features.should_receive(:new).with(:name => "feature_a",:active => true).and_return(stub(:save => true))
-    @features.stub(:exists?).and_return(false,true)
+    @features.should_receive(:new).with(name: "feature_a", active: true).and_return(stub(save: true))
+    @features.stub(:exists?).and_return(false, true)
 
     @repository.add_active_feature :feature_a
     expect {

data/spec/feature/feature_spec.rb

@@ -41,16 +41,6 @@ describe Feature do
       end.should raise_error(ArgumentError, "given repository does not respond to active_features")
     end
 
-    it "should set a feature repository" do
-      lambda do
-        Feature.active?(:feature_a)
-      end.should_not raise_error
-
-      lambda do
-        Feature.inactive?(:feature_a)
-      end.should_not raise_error
-    end
-
     it "should get active features from repository once" do
       @repository.add_active_feature(:feature_a)
       Feature.active?(:feature_a).should be_false
@@ -145,5 +135,30 @@ describe Feature do
       end.should raise_error(ArgumentError, "no block given to without")
     end
 
+    describe 'switch()' do
+      context 'given a value' do
+        it "should return the first value if the feature is active" do
+          retval = Feature.switch(:feature_active, 1, 2)
+          expect(retval).to eq(1)
+        end
+
+        it "should return the second value if the feature is inactive" do
+          retval = Feature.switch(:feature_inactive, 1, 2)
+          expect(retval).to eq(2)
+        end
+      end
+
+      context 'given a proc/lambda' do
+        it "should call the first proc/lambda if the feature is active" do
+          retval = Feature.switch(:feature_active, lambda { 1 }, lambda { 2 })
+          expect(retval).to eq(1)
+        end
+
+        it "should call the second proc/lambda if the feature is active" do
+          retval = Feature.switch(:feature_inactive, lambda { 1 }, lambda { 2 })
+          expect(retval).to eq(2)
+        end
+      end
+    end
   end
 end

data/spec/spec_helper.rb

@@ -1,5 +1,4 @@
-require "pathname"
-require 'pp'
+require 'pathname'
 require 'coveralls'
 Coveralls.wear!
 

metadata

@@ -1,22 +1,32 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: feature
-version: !ruby/object:Gem::Version
-  version: 0.7.0
+version: !ruby/object:Gem::Version 
+  hash: 23
   prerelease: 
+  segments: 
+  - 1
+  - 0
+  - 0
+  version: 1.0.0
 platform: ruby
-authors:
+authors: 
 - Markus Gerdes
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-07 00:00:00.000000000 Z
+
+date: 2014-03-26 00:00:00 Z
 dependencies: []
+
 description: 
 email: github@mgsnova.de
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - lib/feature.rb
 - lib/feature/generators/install_generator.rb
 - lib/feature/generators/templates/create_feature_toggles.rb
@@ -39,26 +49,36 @@ files:
 - CHANGELOG.md
 homepage: http://github.com/mgsnova/feature
 licenses: []
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
+required_ruby_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
-required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
+required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
-  requirements:
-  - - ! '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
+      version: "0"
 requirements: []
+
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.29
 signing_key: 
 specification_version: 3
 summary: Feature Toggle library for ruby
 test_files: []
+