feature 0.4.0 → 0.4.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.1 (2012-03-20)
+
+* bugfix: occured when having empty feature set using yaml config (benjaminoakes)
+
 ## 0.4.0 (2011-11-28)
 
 * simplify repositories, they only have to respond to method active_features 

data/README.md

@@ -13,7 +13,9 @@ With this approach Feature is higly configurable and not bound to a specific kin
 
         gem install feature
 
-## Example usage
+## Examples
+
+### Vanilla Ruby
 
         require 'feature'
 
@@ -28,3 +30,22 @@ With this approach Feature is higly configurable and not bound to a specific kin
         Feature.with(:be_nice) do
           puts "you can read this"
         end
+
+### Rails
+
+        # File: Gemfile
+        gem 'feature' # Or with version specifier, e.g. '~> 0.4.0'
+
+        # File: config/feature.yml
+        features:
+            an_active_feature: true
+            an_inactive_feature: false
+
+        # File: config/initializers/feature.rb
+        repo = Feature::Repository::YamlRepository.new("#{Rails.root}/config/feature.yml")
+        Feature.set_repository repo
+
+        # File: app/views/example/index.html.erb
+        <% if Feature.active?(:an_active_feature) %>
+          <%# Feature implementation goes here %>
+        <% end %>

data/lib/feature/repository/yaml_repository.rb

@@ -40,12 +40,16 @@ module Feature
           raise ArgumentError, "content of #{@yaml_file_name} does not contain proper config"
         end
 
-        invalid_value = data['features'].values.detect { |value| ![true, false].include?(value) }
-        if invalid_value
-          raise ArgumentError, "#{invalid_value} is not allowed value in config, use true/false"
-        end
+        if data['features']
+          invalid_value = data['features'].values.detect { |value| ![true, false].include?(value) }
+          if invalid_value
+            raise ArgumentError, "#{invalid_value} is not allowed value in config, use true/false"
+          end
 
-        data['features']
+          data['features']
+        else
+          {}
+        end
       end
       private :read_and_parse_file_data
     end

data/spec/feature/yaml_repository_spec.rb

@@ -43,6 +43,21 @@ EOF
         @repo.active_features.should == [:feature_a_active]
       end
     end
+
+    # For example, when all your features are in production and working fine.
+    context "with no features" do
+      before(:each) do
+        fp = File.new(@filename, 'w')
+        fp.write <<"EOF";
+features:
+EOF
+        fp.close
+      end
+
+      it "should read active features new on each request" do
+        @repo.active_features.should == []
+      end
+    end
   end
 
   it "should raise exception on no file found" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: feature
 version: !ruby/object:Gem::Version 
-  hash: 15
+  hash: 13
   prerelease: 
   segments: 
   - 0
   - 4
-  - 0
-  version: 0.4.0
+  - 1
+  version: 0.4.1
 platform: ruby
 authors: 
 - Markus Gerdes
@@ -15,8 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-11-28 00:00:00 +01:00
-default_executable: 
+date: 2012-03-20 00:00:00 Z
 dependencies: []
 
 description: 
@@ -28,19 +27,18 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
+- lib/feature.rb
 - lib/feature/repository/simple_repository.rb
 - lib/feature/repository/yaml_repository.rb
 - lib/feature/repository.rb
-- lib/feature.rb
-- spec/feature/feature_spec.rb
 - spec/feature/simple_repository_spec.rb
 - spec/feature/yaml_repository_spec.rb
+- spec/feature/feature_spec.rb
 - spec/spec_helper.rb
 - Rakefile
 - Gemfile
 - README.md
 - CHANGELOG.md
-has_rdoc: true
 homepage: http://github.com/mgsnova/feature
 licenses: []
 
@@ -70,7 +68,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.15
 signing_key: 
 specification_version: 3
 summary: Feature Toggle library for ruby