feature 0.3.0 → 0.4.0

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.0 (2011-11-28)
+
+* simplify repositories, they only have to respond to method active_features 
+
 ## 0.3.0 (2011-11-23)
 
 * assume all features as inactive that are not active, also unknown ones

data/lib/feature/repository/simple_repository.rb

@@ -3,7 +3,7 @@ module Feature
     # SimpleRepository for active feature list
     # Simply add features to that should be active, no config or data sources required
     #
-    class SimpleRepository < AbstractRepository
+    class SimpleRepository
       # Constructor
       #
       def initialize

data/lib/feature/repository/yaml_repository.rb

@@ -7,7 +7,7 @@ module Feature
     #       an_active_feature: true
     #       an_inactive_feature: false
     #
-    class YamlRepository < AbstractRepository
+    class YamlRepository
       require 'yaml'
 
       # Constructor

data/lib/feature/repository.rb

@@ -1,7 +1,6 @@
 module Feature
   # Module for holding feature repositories
   module Repository
-    require 'feature/repository/abstract_repository'
     require 'feature/repository/simple_repository'
     require 'feature/repository/yaml_repository'
   end

data/lib/feature.rb

@@ -13,12 +13,13 @@ module Feature
   @active_features = nil
 
   # Set the feature repository
+  # The given repository has to respond to method 'active_features' with an array of symbols
   #
-  # @param [Feature::Repository::AbstractRepository] repository the repository to get the features from
+  # @param [Object] repository the repository to get the features from
   #
   def self.set_repository(repository)
-    if !repository.is_a?(Feature::Repository::AbstractRepository)
-      raise ArgumentError, "given argument is not a repository"
+    if !repository.respond_to?(:active_features)
+      raise ArgumentError, "given repository does not respond to active_features"
     end
 
     @repository = repository

data/spec/feature/feature_spec.rb

@@ -38,7 +38,7 @@ describe Feature do
     it "should raise an exception when add repository with wrong class" do
       lambda do
         Feature.set_repository("not a repository")
-      end.should raise_error(ArgumentError, "given argument is not a repository")
+      end.should raise_error(ArgumentError, "given repository does not respond to active_features")
     end
 
     it "should set a feature repository" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: feature
 version: !ruby/object:Gem::Version 
-  hash: 19
-  prerelease: false
+  hash: 15
+  prerelease: 
   segments: 
   - 0
-  - 3
+  - 4
   - 0
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors: 
 - Markus Gerdes
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-11-23 00:00:00 +01:00
+date: 2011-11-28 00:00:00 +01:00
 default_executable: 
 dependencies: []
 
@@ -28,15 +28,13 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
-- lib/feature.rb
 - lib/feature/repository/simple_repository.rb
-- lib/feature/repository/abstract_repository.rb
 - lib/feature/repository/yaml_repository.rb
 - lib/feature/repository.rb
+- lib/feature.rb
+- spec/feature/feature_spec.rb
 - spec/feature/simple_repository_spec.rb
 - spec/feature/yaml_repository_spec.rb
-- spec/feature/abstract_repository_spec.rb
-- spec/feature/feature_spec.rb
 - spec/spec_helper.rb
 - Rakefile
 - Gemfile
@@ -72,7 +70,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.6.2
 signing_key: 
 specification_version: 3
 summary: Feature Toggle library for ruby

data/lib/feature/repository/abstract_repository.rb

@@ -1,24 +0,0 @@
-module Feature
-  module Repository
-    # Abstract class for subclassing and building repository classes which
-    # provide lists of active features
-    #
-    class AbstractRepository
-      # Constructor
-      #
-      # Should be overridden in derived class to initialize repository with all data needed
-      #
-      def initialize
-        raise "abstract class #{self.class.name}!"
-      end
-
-      # Returns list of active features
-      #
-      # @return [Array<Symbol>] list of active features
-      #
-      def active_features
-        raise "#{__method__} has to be overridden in derived class"
-      end
-    end
-  end
-end

data/spec/feature/abstract_repository_spec.rb

@@ -1,9 +0,0 @@
-require 'spec_helper'
-
-describe Feature::Repository::AbstractRepository do
-  it "should raise error on creating a new instance" do
-    lambda do
-      Feature::Repository::AbstractRepository.new
-    end.should raise_error("abstract class Feature::Repository::AbstractRepository!")
-  end
-end