fb_graph 2.4.2 → 2.4.3

data/VERSION

@@ -1 +1 @@
-2.4.2
+2.4.3

data/lib/fb_graph/ad_group.rb

@@ -28,6 +28,9 @@ module FbGraph
         send("#{field}=", attributes[field.to_sym])
       end
 
+      # max_bid is string only when reloaded for some reason..
+      self.max_bid = max_bid.try(:to_i)
+
       %w(start_time end_time updated_time).each do |field|
         if val = attributes[field.to_sym]
           # Handles integer timestamps and ISO8601 strings

data/lib/fb_graph/ad_preview.rb

@@ -4,7 +4,7 @@ module FbGraph
 
     def initialize(attributes = {})
       super
-      self.preview_data = attributes["0"]
+      self.preview_data = Collection.new(attributes).first
     end
   end
 end

data/lib/fb_graph/connections/ad_previews.rb

@@ -2,7 +2,7 @@ module FbGraph
   module Connections
     module AdPreviews
       def ad_previews(options = {})
-        ad_previews = self.post options.merge(:method => 'get', :connection => :adpreviews)
+        ad_previews = self.post options.merge(:method => 'get', :connection => :previews)
         AdPreview.new ad_previews.merge(:access_token => options[:access_token] || self.access_token)
       end
     end

data/spec/fb_graph/ad_group_spec.rb

@@ -82,7 +82,7 @@ describe FbGraph::AdGroup, '.update' do
 
         ad_group.update(:max_bid => 500, :redownload => true)
 
-        ad_group.max_bid.should == "500"
+        ad_group.max_bid.should == 500
 
         # Our test assumes that adgroup_status has changed on Facebook's side and is passed back different
         ad_group.adgroup_status.should == 4

data/spec/fb_graph/connections/ad_groups_spec.rb

@@ -79,8 +79,7 @@ describe FbGraph::Connections::AdGroups, '#ad_group!' do
         ad_group.campaign_id.should == 11223344
         ad_group.name.should == "Test Ad 2"
         ad_group.bid_type.should == 1
-        # Not sure why...but Facebook returns max_bid as a String
-        ad_group.max_bid.should == "100"
+        ad_group.max_bid.should == 100
         ad_group.start_time.should == Time.parse("2012-02-20T00:00:00Z")
         ad_group.end_time.should == Time.parse("2012-02-23T00:00:00Z")
 

data/spec/fb_graph/connections/ad_previews_spec.rb

@@ -4,11 +4,11 @@ describe FbGraph::Connections::AdPreviews, '#ad_previews' do
   context 'when included by FbGraph::AdAccount' do
     context 'when access_token is given' do
       it 'should return ad_preview as FbGraph::AdPreview' do
-        mock_graph :post, 'act_123456789/adpreviews', 'ad_accounts/ad_previews/test_ad_previews'  do
+        mock_graph :post, 'act_123456789/previews', 'ad_accounts/previews/test_ad_previews'  do
           ad_account = FbGraph::AdAccount.new('act_123456789', :access_token => 'access_token')
-          ad_preview = ad_account.ad_previews(:access_token => 'access_token', :preview_spec => {})
+          ad_preview = ad_account.ad_previews(:access_token => 'access_token', :creative => {})
           ad_preview.should be_instance_of(FbGraph::AdPreview)
-          ad_preview.preview_data.should == 'hello world'
+          ad_preview.preview_data[:body].should == '<h1>hello world</h1>'
         end
       end
     end

data/spec/mock_json/ad_accounts/previews/test_ad_previews.json

@@ -0,0 +1,7 @@
+{
+  "data":[
+    {
+      "body":"<h1>hello world</h1>"
+    }
+   ]
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fb_graph
 version: !ruby/object:Gem::Version
-  version: 2.4.2
+  version: 2.4.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-23 00:00:00.000000000Z
+date: 2012-02-25 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
-  requirement: &70278768617680 !ruby/object:Gem::Requirement
+  requirement: &70181998150120 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 2.2.0.2
   type: :runtime
   prerelease: false
-  version_requirements: *70278768617680
+  version_requirements: *70181998150120
 - !ruby/object:Gem::Dependency
   name: rack-oauth2
-  requirement: &70278768615940 !ruby/object:Gem::Requirement
+  requirement: &70181998149180 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +32,10 @@ dependencies:
         version: 0.14.0
   type: :runtime
   prerelease: false
-  version_requirements: *70278768615940
+  version_requirements: *70181998149180
 - !ruby/object:Gem::Dependency
   name: tzinfo
-  requirement: &70278768614800 !ruby/object:Gem::Requirement
+  requirement: &70181998148580 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70278768614800
+  version_requirements: *70181998148580
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &70278768612440 !ruby/object:Gem::Requirement
+  requirement: &70181998146800 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0.8'
   type: :development
   prerelease: false
-  version_requirements: *70278768612440
+  version_requirements: *70181998146800
 - !ruby/object:Gem::Dependency
   name: cover_me
-  requirement: &70278768608100 !ruby/object:Gem::Requirement
+  requirement: &70181998146000 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: 1.2.0
   type: :development
   prerelease: false
-  version_requirements: *70278768608100
+  version_requirements: *70181998146000
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70278768605200 !ruby/object:Gem::Requirement
+  requirement: &70181998144940 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -76,10 +76,10 @@ dependencies:
         version: '2'
   type: :development
   prerelease: false
-  version_requirements: *70278768605200
+  version_requirements: *70181998144940
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &70278768602580 !ruby/object:Gem::Requirement
+  requirement: &70181998143380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +87,10 @@ dependencies:
         version: 1.6.2
   type: :development
   prerelease: false
-  version_requirements: *70278768602580
+  version_requirements: *70181998143380
 - !ruby/object:Gem::Dependency
   name: actionpack
-  requirement: &70278768601400 !ruby/object:Gem::Requirement
+  requirement: &70181998138100 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,7 +98,7 @@ dependencies:
         version: 3.0.6
   type: :development
   prerelease: false
-  version_requirements: *70278768601400
+  version_requirements: *70181998138100
 description: A full-stack Facebook Graph API wrapper in Ruby.
 email: nov@matake.jp
 executables: []
@@ -435,8 +435,8 @@ files:
 - spec/mock_json/ad_accounts/ad_group_stats/test_ad_group_stats.json
 - spec/mock_json/ad_accounts/ad_groups/post_with_redownload.json
 - spec/mock_json/ad_accounts/ad_groups/post_with_valid_access_token.json
-- spec/mock_json/ad_accounts/ad_previews/test_ad_previews.json
 - spec/mock_json/ad_accounts/broad_targeting_categories/test_bct.json
+- spec/mock_json/ad_accounts/previews/test_ad_previews.json
 - spec/mock_json/ad_accounts/reach_estimates/test_reach_estimates.json
 - spec/mock_json/ad_accounts/test_ad_account.json
 - spec/mock_json/ad_campaigns/ad_groups/22334455_ad_groups.json
@@ -799,8 +799,8 @@ test_files:
 - spec/mock_json/ad_accounts/ad_group_stats/test_ad_group_stats.json
 - spec/mock_json/ad_accounts/ad_groups/post_with_redownload.json
 - spec/mock_json/ad_accounts/ad_groups/post_with_valid_access_token.json
-- spec/mock_json/ad_accounts/ad_previews/test_ad_previews.json
 - spec/mock_json/ad_accounts/broad_targeting_categories/test_bct.json
+- spec/mock_json/ad_accounts/previews/test_ad_previews.json
 - spec/mock_json/ad_accounts/reach_estimates/test_reach_estimates.json
 - spec/mock_json/ad_accounts/test_ad_account.json
 - spec/mock_json/ad_campaigns/ad_groups/22334455_ad_groups.json

data/spec/mock_json/ad_accounts/ad_previews/test_ad_previews.json

@@ -1,4 +0,0 @@
-{
-	"0":"hello world",
-	"success":true
-}