faye_tracking 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 59510a6d0b8840e8d1a023e7688cce9e7dcba4b2
-  data.tar.gz: a2eccf51d9d9ae29d31154ac8debffba9368cdc0
+  metadata.gz: 4d25e8f9595db01848dda129c76e4aa15f0ad8e0
+  data.tar.gz: e353842553b1d51dcd1e8b1e0dd49e55b8ebd232
 SHA512:
-  metadata.gz: 98eceda9db22c158a7d46ce1b8998a68b6462304af15ff2a6d61535fee17993666d475d32f16446d97d45680a831c7222cc6023b59556df886addd34a77ffbe3
-  data.tar.gz: be8768b99523474637524d1e24fff8ad4c3e9dd2c05e9dfdf650715d6910db308fe78aa19687b3da910f7ece8055c34194718441eb68f80a5ad2457e3fddedc5
+  metadata.gz: aa8fba78c26b0301ab57ce157cfec9deb9aacb049a70a328dcd9324bef9b9e652b340fb11b76065bb1c935f32ea5a18a32323a57b0670e1f89e3721d256a86c7
+  data.tar.gz: 9ce51c9b99728bcf4d2126a2bf4d0ece75a9af0d8731cd7afa6cf38a4213d170f50f90f2ea65491419718ce959e1d1136c20bdaa7950b2397393584a13f46ad8

data/.gitignore

@@ -13,3 +13,4 @@
 *.a
 mkmf.log
 *.gem
+dump.rdb

data/lib/faye_tracking.rb

@@ -43,6 +43,22 @@ module FayeTracking
     def tracker
       @_tracker = Tracker.new(redis)
     end
+
+    def on_subscribe_callbacks
+      @_on_subscribe_callbacks || reset_on_subscribe_callbacks
+    end
+
+    def on_subscribe(&block)
+      on_subscribe_callbacks << block
+    end
+
+    def run_on_subscribe_callbacks(*args)
+      on_subscribe_callbacks.each { |blk| blk.call(*args) }
+    end
+
+    def reset_on_subscribe_callbacks
+      @_on_subscribe_callbacks = []
+    end
   end
 end
 

data/lib/faye_tracking/faye_extension.rb

@@ -1,13 +1,18 @@
 module FayeTracking
   class FayeExtension
-    MONITORED_CHANNELS = [ '/meta/subscribe', '/meta/unsubscribe', '/meta/disconnect' ]
+    MONITORED_CHANNELS = [
+      '/meta/subscribe',
+      '/meta/unsubscribe',
+      '/meta/disconnect'
+    ]
 
     def initialize(tracker)
       @tracker = tracker
     end
 
     def incoming(message, callback)
-      return callback.call(message) unless MONITORED_CHANNELS.include? message['channel']
+      return callback.call(message) \
+        unless MONITORED_CHANNELS.include? message['channel']
 
       FayeTracking.logger.debug "received incoming message: #{message}"
 
@@ -20,12 +25,17 @@ module FayeTracking
           ext = message['ext']
           if app_client_id = ext['faye_tracking_client_id']
             @tracker.add(subs_channel, client_id, app_client_id)
+            FayeTracking.run_on_subscribe_callbacks(
+              client_id, app_client_id, subs_channel
+            )
           else
             error_message = "missing ext['faye_tracking_client_id']"
-            FayeTracking.logger.debug "error with message: #{error_message}"
+            FayeTracking.logger.error "error with message: #{error_message}"
             message['error'] = error_message
           end
         when '/meta/unsubscribe'
+          # This is not reliable, more robust way to detect unsubscribe event.
+          # see: http://faye.jcoglan.com/ruby/monitoring.html
           @tracker.remove(subs_channel, client_id)
         when '/meta/disconnect'
           @tracker.remove_all(client_id)

data/lib/faye_tracking/store/adapter/namespaced_key_list.rb

@@ -1,8 +1,9 @@
 module FayeTracking
   class NamespacedKeyList < AbstractKeyList
     def initialize(ns, key_list)
-      raise ArgumentError, 'namespace param cannot be blank' if ns.nil? || ns.empty?
-      
+      raise ArgumentError, 'namespace param cannot be blank' \
+        if ns.nil? || ns.empty?
+
       @ns       = ns
       @key_list = key_list
     end

data/lib/faye_tracking/version.rb

@@ -1,3 +1,3 @@
 module FayeTracking
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/faye_tracking_spec.rb

@@ -42,7 +42,19 @@ describe FayeTracking do
 
       it 'returns all users in a channel' do
         faye_subscribe 'room', client_id, 'user_2'
-        expect(described_class.users_in_channel('room')).to match_array(['user_1', 'user_2'])
+        expect(described_class.users_in_channel('room')).to \
+          match_array(['user_1', 'user_2'])
+      end
+    end
+
+    describe 'customize subscribe block' do
+      it 'can set a customize subscribe block' do
+        result = nil
+        FayeTracking.on_subscribe do |client_id, user_id, channel|
+          result = [client_id, user_id, channel]
+        end
+        faye_subscribe 'room', client_id, 'user_1'
+        expect(result).to eq([client_id, 'user_1', 'room'])
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faye_tracking
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Lin He
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-10 00:00:00.000000000 Z
+date: 2015-07-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis