faye-authentication 1.10.0 → 1.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 72258f703034d2918db6f64c09d3a6425723d7b8da3ad1b4d96ae919f115eaf3
-  data.tar.gz: cf7e35e01b7d9c9a1ab23cc5c8ad9ad6d0d389e52f1d8ca111d9aef043d4f217
+  metadata.gz: 23d0511cded90a176f335c918ddd7ac42559d80306818da3505dbc24341b24f8
+  data.tar.gz: 3aaaa3a5e286ee2952b0098b86c6d8d10aeb84c448f606044d406baeec6d074f
 SHA512:
-  metadata.gz: 4c9885e00a0ea3ed9b7f2c032c17295fe085d35b7cc6ee3db64476b1752d5b071ca94637ddecb25b7fe101506b5808b15da74dbca8c04599be22248fdf9e3d59
-  data.tar.gz: 6171172fcf7f70fb42ee65e657cdb4a02a47104ed069a642bf1ad166494a6452204a289b6d16ec203217be12aa4adfa3f0fd9737259457a7b1a235c4c64df4d6
+  metadata.gz: 1e5e77a5ee7df63d0a0c62e813431baa690d16b5532a2f10494e72ca998b4393fa50f5f21adfff356c608892974a1c8b7e0fa0133d502577ef8919922df65511
+  data.tar.gz: d2bcf4df68befe130af88a1e3a94a566374257385e8b737f16c76f22a70f8a042b15d2a205302bbad658e271ad97ce16a3021b25453263ae5f672612038a0375

data/CHANGELOG.md

@@ -1,5 +1,12 @@
+## 1.11.0
+  - Optional authentication for `Faye::Authentication::HTTPClient` (#12)
+
+## 1.10.0
+  - Remove signature from the server response (#11)
+
 ## 1.8.1
   - Fix bad parameter passed to Net::HTTP::Post in HTTP Client (thanks @evserykh)
+
 ## 1.8.0
  - Wait a delay before trying to fetch a signature after an error
 

data/VERSION

@@ -1 +1 @@
-1.10.0
+1.11.0

data/lib/faye/authentication/http_client.rb

@@ -4,16 +4,16 @@ module Faye
   module Authentication
     class HTTPClient
 
-      def self.publish(url, channel, data, key)
+      def self.publish(url, channel, data, key, options = {})
         uri = URI(url)
-        req = prepare_request(uri.request_uri, channel, data, key)
+        req = prepare_request(uri.request_uri, channel, data, key, options)
         Net::HTTP.start(uri.hostname, uri.port, :use_ssl => uri.scheme == 'https') { |http| http.request(req) }
       end
 
-      def self.prepare_request(uri, channel, data, key)
+      def self.prepare_request(uri, channel, data, key, options = {})
         req = Net::HTTP::Post.new(uri)
         message = {'channel' => channel, 'clientId' => 'http'}
-        message['signature'] = Faye::Authentication.sign(message, key)
+        message['signature'] = Faye::Authentication.sign(message, key) if Faye::Authentication.authentication_required?(message, options)
         message['data'] = data
         req.set_form_data(message: JSON.dump(message))
         req

data/spec/lib/faye/authentication/http_client_spec.rb

@@ -9,11 +9,22 @@ describe Faye::Authentication::HTTPClient do
       message = {'channel' => '/foo/bar', 'clientId' => 'http'}
       message['signature'] = Faye::Authentication.sign(message, 'my private key')
       message['data'] = 'hello'
-      request = stub_request(:post, "http://www.example.com").with(:body => {:message => JSON.dump(message)}).to_return(:status => 200, :body => "", :headers => {})
+      request = stub_request(:post, "http://www.example.com").with(body: {message: JSON.dump(message)}).to_return(status: 200, body: "", headers: {})
       Faye::Authentication::HTTPClient.publish('http://www.example.com', '/foo/bar', "hello", 'my private key')
       expect(request).to have_been_made
     end
 
+    it 'should not add a signature if the channel is whitelisted' do
+      message = {'channel' => '/foo/bar', 'clientId' => 'http'}
+      message['data'] = 'hello'
+      request = stub_request(:post, "http://www.example.com").with(body: {message: JSON.dump(message)}).to_return(status: 200, body: "", headers: {})
+      whitelist = lambda do |channel|
+        channel.start_with?('/foo/')
+      end
+      Faye::Authentication::HTTPClient.publish('http://www.example.com', '/foo/bar', "hello", 'my private key', { whitelist: whitelist })
+      expect(request).to have_been_made
+    end
+
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faye-authentication
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.11.0
 platform: ruby
 authors:
 - Adrien Siami
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-12 00:00:00.000000000 Z
+date: 2019-09-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: jwt