faulty 0.8.7 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3148a3eb0ec2e45213ddb40bef524a3b0fa83e83b467101982d7ced65cbac71a
-  data.tar.gz: fd9584532fde4f3409720ca1884f825fc4d6eabb4ebe133c80e969bc0131ab9f
+  metadata.gz: 3c98e42a6c19d8832dc0267abba5498f0203922bd98cb3bb1b9c28643c9a9f3f
+  data.tar.gz: 7b68f35acfa54c10ec411d26eb45319eb47bf6d688d447adaead117f1ec098ab
 SHA512:
-  metadata.gz: 330476d53d625bb22dbd2f5855dd40f4f4849135b1407df72e9ff3849504341f9e67cf6ce5bb0606bd62100a9d11dda2f7d7754be081b40b8c81784d1e25265d
-  data.tar.gz: 9f8023dbd90ea1d9fb55a1a5c7a9c96a9344b0db43e0735113545406734e0f02ea14bcc1550b8d2b335e1b59bd63591812ed2426f66f097789185531f6d2db51
+  metadata.gz: 2677b6450704cbabd6b9c9e3c5d68bad7b762810f27f0b0a9171bca825051c9668aff54aadb58b73884a266f5c0fdfaa46f57d56bc0a6d93824bb1d02c4c08fd
+  data.tar.gz: ef98388e2d161b8995310de758b11ddc960a2b0b4c05605ba9cf7e30334c36bb8590578259c0e0158516254fb56d9bc1bb5cb2f42cea88c8224c176301535898

data/CHANGELOG.md

@@ -9,6 +9,32 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 [Unreleased]
 -------------------
 
+[0.9.0] - 2022-08-18
+---------------------
+
+### Added
+
+* Setup codecov code coverage #57 justinhoward
+
+### Fixed
+
+* Fix a regression where ConnectionPool was required for the redis storage #58 justinhoward
+
+### Changed
+
+* Change current_time to a float #59 justinhoward
+
+### Removed
+
+* Remove features deprecated in 0.8.5 #60 justinhoward
+
+### Breaking
+
+* `Faulty.current_time` is now a float instead of an integer
+* The 3 argument form of `Storage::Interface#entry` deprecated in 0.8.5 is now
+  removed.
+* The `error_module` circuit option deprecated in 0.8.5 is now removed.
+
 [0.8.7] - 2022-08-11
 -------------------
 
@@ -263,11 +289,12 @@ of AutoWire.
 
 Initial public release
 
-[Unreleased]: https://github.com/ParentSquare/faulty/compare/v0.5.0...HEAD
+[Unreleased]: https://github.com/ParentSquare/faulty/compare/v0.9.0...HEAD
+[0.9.0]: https://github.com/ParentSquare/faulty/compare/v0.8.7...v0.9.0
+[0.8.7]: https://github.com/ParentSquare/faulty/compare/v0.8.6...v0.8.7
 [0.8.6]: https://github.com/ParentSquare/faulty/compare/v0.8.5...v0.8.6
 [0.8.5]: https://github.com/ParentSquare/faulty/compare/v0.8.4...v0.8.5
-[0.8.4]: https://github.com/ParentSquare/faulty/compare/v0.8.3...v0.8.4
-[0.8.3]: https://github.com/ParentSquare/faulty/compare/v0.8.2...v0.8.3
+[0.8.4]: https://github.com/ParentSquare/faulty/compare/v0.8.2...v0.8.4
 [0.8.2]: https://github.com/ParentSquare/faulty/compare/v0.8.1...v0.8.2
 [0.8.1]: https://github.com/ParentSquare/faulty/compare/v0.8.0...v0.8.1
 [0.8.0]: https://github.com/ParentSquare/faulty/compare/v0.7.2...v0.8.0

data/README.md

@@ -3,7 +3,7 @@
 [![Gem Version](https://badge.fury.io/rb/faulty.svg)](https://badge.fury.io/rb/faulty)
 [![CI](https://github.com/ParentSquare/faulty/workflows/CI/badge.svg)](https://github.com/ParentSquare/faulty/actions?query=workflow%3ACI+branch%3Amaster)
 [![Code Quality](https://app.codacy.com/project/badge/Grade/16bb1df1569a4ddba893a866673dac2a)](https://www.codacy.com/gh/ParentSquare/faulty/dashboard?utm_source=github.com&utm_medium=referral&utm_content=ParentSquare/faulty&utm_campaign=Badge_Grade)
-[![Code Coverage](https://app.codacy.com/project/badge/Coverage/16bb1df1569a4ddba893a866673dac2a)](https://www.codacy.com/gh/ParentSquare/faulty/dashboard?utm_source=github.com&utm_medium=referral&utm_content=ParentSquare/faulty&utm_campaign=Badge_Coverage)
+[![Code Coverage](https://codecov.io/gh/ParentSquare/faulty/branch/master/graph/badge.svg?token=1NDT4FW1YJ)](https://codecov.io/gh/ParentSquare/faulty)
 [![Inline docs](http://inch-ci.org/github/ParentSquare/faulty.svg?branch=master)](http://inch-ci.org/github/ParentSquare/faulty)
 
 Fault-tolerance tools for ruby based on [circuit-breakers][martin fowler].

data/lib/faulty/circuit.rb

@@ -98,7 +98,6 @@ class Faulty
       :sample_threshold,
       :errors,
       :error_mapper,
-      :error_module,
       :exclude,
       :cache,
       :notifier,
@@ -158,17 +157,6 @@ class Faulty
         unless cache_refreshes_after.nil?
           self.cache_refresh_jitter = 0.2 * cache_refreshes_after
         end
-
-        deprecated_error_module
-      end
-
-      private
-
-      def deprecated_error_module
-        return unless error_module
-
-        Deprecation.method(self.class, :error_module, note: 'See :error_mapper', sunset: '0.9.0')
-        self.error_mapper = error_module
       end
     end
 
@@ -442,11 +430,7 @@ class Faulty
 
     # @return [Boolean] True if the circuit transitioned to closed
     def success!(status)
-      if deprecated_entry?
-        storage.entry(self, Faulty.current_time, true, nil)
-      else
-        storage.entry(self, Faulty.current_time, true)
-      end
+      storage.entry(self, Faulty.current_time, true, nil)
       closed = close! if status.half_open?
 
       options.notifier.notify(:circuit_success, circuit: self)
@@ -455,11 +439,7 @@ class Faulty
 
     # @return [Boolean] True if the circuit transitioned to open
     def failure!(status, error)
-      status = if deprecated_entry?
-        storage.entry(self, Faulty.current_time, false, status)
-      else
-        deprecated_entry(status)
-      end
+      status = storage.entry(self, Faulty.current_time, false, status)
       options.notifier.notify(:circuit_failure, circuit: self, status: status, error: error)
 
       if status.half_open?
@@ -471,23 +451,6 @@ class Faulty
       end
     end
 
-    def deprecated_entry?
-      return @deprecated_entry unless @deprecated_entry.nil?
-
-      @deprecated_entry = storage.method(:entry).arity == 4
-    end
-
-    def deprecated_entry(status)
-      Faulty::Deprecation.deprecate(
-        'Returning entries array from entry',
-        note: 'see Storate::Interface#entry',
-        sunset: '0.9'
-      )
-
-      entries = storage.entry(self, Faulty.current_time, false)
-      Status.from_entries(entries, **status.to_h)
-    end
-
     def skipped!
       options.notifier.notify(:circuit_skipped, circuit: self)
     end

data/lib/faulty/storage/redis.rb

@@ -232,7 +232,7 @@ class Faulty
         end
 
         state = futures[:state].value&.to_sym || :closed
-        opened_at = futures[:opened_at].value ? futures[:opened_at].value.to_i : nil
+        opened_at = futures[:opened_at].value ? Float(futures[:opened_at].value) : nil
         opened_at = Faulty.current_time - options.circuit_ttl if state == :open && opened_at.nil?
 
         Faulty::Status.from_entries(
@@ -356,7 +356,7 @@ class Faulty
       #
       # @return [Integer] The current block number
       def current_list_block
-        (Faulty.current_time.to_f / options.list_granularity).floor
+        (Faulty.current_time / options.list_granularity).floor
       end
 
       # Watch a Redis key and exec commands only if the key matches the expected
@@ -411,7 +411,7 @@ class Faulty
       def map_entries(raw_entries)
         raw_entries.map do |e|
           time, state = e.split(ENTRY_SEPARATOR)
-          [time.to_i, state == '1']
+          [Float(time), state == '1']
         end
       end
 
@@ -449,7 +449,7 @@ class Faulty
       end
 
       def check_pool_options!
-        if options.client.instance_of?(ConnectionPool)
+        if options.client.class.name == 'ConnectionPool'
           timeout = options.client.instance_variable_get(:@timeout)
           warn(<<~MSG) if timeout > 2
             Faulty recommends setting ConnectionPool timeouts <= 2 to prevent

data/lib/faulty/version.rb

@@ -3,6 +3,6 @@
 class Faulty
   # The current Faulty version
   def self.version
-    Gem::Version.new('0.8.7')
+    Gem::Version.new('0.9.0')
   end
 end

data/lib/faulty.rb

@@ -129,7 +129,7 @@ class Faulty
     #
     # @return [Time] The current time
     def current_time
-      Time.now.to_i
+      Time.now.to_f
     end
 
     # Disable Faulty circuits

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: faulty
 version: !ruby/object:Gem::Version
-  version: 0.8.7
+  version: 0.9.0
 platform: ruby
 authors:
 - Justin Howard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-11 00:00:00.000000000 Z
+date: 2022-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -150,7 +150,7 @@ licenses:
 metadata:
   rubygems_mfa_required: 'true'
   changelog_uri: https://github.com/ParentSquare/faulty/blob/master/CHANGELOG.md
-  documentation_uri: https://www.rubydoc.info/gems/faulty/0.8.7
+  documentation_uri: https://www.rubydoc.info/gems/faulty/0.9.0
 post_install_message: 
 rdoc_options: []
 require_paths: