fat_free_crm 0.19.2 → 0.20.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fa077bec8c4e6334e58d1b936d716dd2d81692fe79efc9028b7cafec8ead036
-  data.tar.gz: 3052cb09940c88d9a7ab44f70cb56c9a582e08589ea2052feaf5d6fab0a5f949
+  metadata.gz: a4b6418c618ec04984f8f8261e3121e915b57ce2b55c5787d3393a8acb47adb9
+  data.tar.gz: 362ffdc71d5d01450d0475758f794972ec77dc79755f92196f4f72917e789798
 SHA512:
-  metadata.gz: 8e0ff6fbe7b7e01aa769b85d597aeda05a4dc7b687fb3ce0c80af75e00a519df70d6f60005858b9e2d626b5c62d3130e46d7494db49190a53c2426ea91a6ee67
-  data.tar.gz: dca8bbad437f05b2053ce140beacab67d8d873936bd3510d5ce51434517cb4f8851cbef683bcf1d48e4df7563aa39456d28d468d05d32ce21223b0e8c63914a9
+  metadata.gz: 3a467bdd68e941d5c426a69fd07260ec11631163a8306c2d1b524fdd2c0e0f7f2d48ee78e2ad89e773010e2b0b17f386f90fe67f9388330bb07e53aba02344d0
+  data.tar.gz: 21943a700b302f3eb2f6544ebcba0ae6e70e50ecec337f94531f08ae16522c6d6d3cd49bf315f83963b597997ed7de38c11c17ace76495e346fed0b6a3f3f8a4

data/.github/workflows/brakeman-analysis.yml

@@ -0,0 +1,46 @@
+# This workflow integrates Brakeman with GitHub's Code Scanning feature
+# Brakeman is a static analysis security vulnerability scanner for Ruby on Rails applications
+
+name: Brakeman Scan
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ master ]
+  schedule:
+    - cron: '20 13 * * 6'
+
+jobs:
+  brakeman-scan:
+    name: Brakeman Scan
+    runs-on: ubuntu-latest
+    steps:
+    # Checkout the repository to the GitHub Actions runner
+    - name: Checkout
+      uses: actions/checkout@v2
+
+    # Customize the ruby version depending on your needs
+    - name: Setup Ruby
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: '2.7'
+
+    - name: Setup Brakeman
+      env:
+        BRAKEMAN_VERSION: '4.10' # SARIF support is provided in Brakeman version 4.10+
+      run: |
+        gem install brakeman --version $BRAKEMAN_VERSION
+
+    # Execute Brakeman CLI and generate a SARIF output with the security issues identified during the analysis
+    - name: Scan
+      continue-on-error: true
+      run: |
+        brakeman -f sarif -o output.sarif.json .
+
+    # Upload the SARIF file generated in the previous step
+    - name: Upload SARIF
+      uses: github/codeql-action/upload-sarif@v1
+      with:
+        sarif_file: output.sarif.json

data/.github/workflows/rubocop-analysis.yml

@@ -0,0 +1,40 @@
+# pulled from repo
+name: "Rubocop"
+
+on: push
+
+jobs:
+  rubocop:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v2
+
+    # If running on a self-hosted runner, check it meets the requirements
+    # listed at https://github.com/ruby/setup-ruby#using-self-hosted-runners
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: 2.6
+
+    # This step is not necessary if you add the gem to your Gemfile
+    - name: Install Code Scanning integration
+      run: bundle add code-scanning-rubocop --version 0.3.0 --skip-install
+
+    - name: Install dependencies
+      run: bundle install
+
+    - name: Rubocop run
+      run: |
+        bash -c "
+          bundle exec rubocop --require code_scanning --format CodeScanning::SarifFormatter -o rubocop.sarif
+          [[ $? -ne 2 ]]
+        "
+
+    - name: Upload Sarif output
+      uses: github/codeql-action/upload-sarif@v1
+      with:
+        sarif_file: rubocop.sarif

data/.github/workflows/ruby.yml

@@ -0,0 +1,52 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Rspec
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.7'] # , '2.7', '3.0'
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby
+    # To automatically get bug fixes and new Ruby versions for ruby/setup-ruby,
+    # change this to (see https://github.com/ruby/setup-ruby#versioning):
+    # uses: ruby/setup-ruby@v1
+      uses: ruby/setup-ruby@473e4d8fe5dd94ee328fdfca9f8c9c7afc9dae5e
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        # bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+
+    - name: Install dependencies
+      run: bundle install
+    - name: Prepare DB
+      run: DB=sqlite RAILS_ENV=test bundle exec rake spec:preparedb
+    - name: Run model tests
+      run: DB=sqlite bundle exec rake spec:models
+    - name: Run controller tests
+      run: bundle exec rake spec:controllers
+    - name: Run view tests
+      run: bundle exec rake spec:views
+    - name: Run helper tests
+      run: bundle exec rake spec:helpers
+    - name: Run route tests
+      run: bundle exec rake spec:routing
+    - name: Run mailer tests
+      run: bundle exec rake spec:mailers
+    - name: Run lib tests
+      run: bundle exec rake spec:lib

data/.rubocop_todo.yml

@@ -1,32 +1,32 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-11-08 13:13:48 +1030 using RuboCop version 0.76.0.
+# on 2021-05-09 11:26:41 +0930 using RuboCop version 0.82.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 2
+# Offense count: 3
 # Configuration parameters: Include.
 # Include: **/*.gemfile, **/Gemfile, **/gems.rb
 Bundler/DuplicatedGem:
   Exclude:
     - 'Gemfile'
 
-# Offense count: 88
+# Offense count: 21
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
+# SupportedStylesAlignWith: keyword, variable, start_of_line
+Layout/EndAlignment:
+  Enabled: false
+
+# Offense count: 95
 # Cop supports --auto-correct.
 # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
 # SupportedHashRocketStyles: key, separator, table
 # SupportedColonStyles: key, separator, table
 # SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
-  Enabled: false
-
-# Offense count: 22
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Layout/EndAlignment:
+Layout/HashAlignment:
   Enabled: false
 
 # Offense count: 7
@@ -44,6 +44,7 @@ Lint/AssignmentInCondition:
   Enabled: false
 
 # Offense count: 2
+# Cop supports --auto-correct.
 Lint/BooleanSymbol:
   Exclude:
     - 'config/initializers/ransack.rb'
@@ -53,13 +54,6 @@ Lint/DuplicateMethods:
   Exclude:
     - 'lib/gravatar_image_tag.rb'
 
-# Offense count: 2
-# Configuration parameters: AllowComments.
-Lint/HandleExceptions:
-  Exclude:
-    - 'config/environments/test.rb'
-    - 'lib/fat_free_crm/gem_dependencies.rb'
-
 # Offense count: 4
 Lint/ImplicitStringConcatenation:
   Exclude:
@@ -78,6 +72,13 @@ Lint/ReturnInVoidContext:
     - 'app/models/setting.rb'
     - 'app/models/users/preference.rb'
 
+# Offense count: 2
+# Configuration parameters: AllowComments.
+Lint/SuppressedException:
+  Exclude:
+    - 'config/environments/test.rb'
+    - 'lib/fat_free_crm/gem_dependencies.rb'
+
 # Offense count: 1
 Lint/UriEscapeUnescape:
   Exclude:
@@ -88,11 +89,18 @@ Lint/UselessAssignment:
   Exclude:
     - 'app/views/home/index.atom.builder'
 
-# Offense count: 133
+# Offense count: 134
+# Configuration parameters: IgnoredMethods.
 Metrics/AbcSize:
   Max: 57
 
-# Offense count: 4
+# Offense count: 1
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 298
+
+# Offense count: 3
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 4
@@ -102,11 +110,12 @@ Metrics/BlockNesting:
 Metrics/ClassLength:
   Max: 184
 
-# Offense count: 30
+# Offense count: 29
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 14
 
-# Offense count: 100
+# Offense count: 99
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 36
@@ -114,9 +123,10 @@ Metrics/MethodLength:
 # Offense count: 2
 # Configuration parameters: CountComments.
 Metrics/ModuleLength:
-  Max: 373
+  Max: 371
 
-# Offense count: 26
+# Offense count: 25
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
   Max: 15
 
@@ -136,11 +146,20 @@ Naming/AccessorMethodName:
     - 'spec/controllers/entities/opportunities_controller_spec.rb'
     - 'spec/support/macros.rb'
 
+# Offense count: 3
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
+  Exclude:
+    - 'app/models/fields/field.rb'
+    - 'app/models/polymorphic/comment.rb'
+    - 'lib/missing_translation_detector.rb'
+
 # Offense count: 4
-# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
+# Configuration parameters: NamePrefix, ForbiddenPrefixes, AllowedMethods, MethodDefinitionMacros.
 # NamePrefix: is_, has_, have_
-# NamePrefixBlacklist: is_, has_, have_
-# NameWhitelist: is_a?
+# ForbiddenPrefixes: is_, has_, have_
+# AllowedMethods: is_a?
 # MethodDefinitionMacros: define_method, define_singleton_method
 Naming/PredicateName:
   Exclude:
@@ -157,15 +176,6 @@ Naming/RescuedExceptionsVariableName:
   Exclude:
     - 'spec/support/assert_select.rb'
 
-# Offense count: 3
-# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db, os
-Naming/UncommunicativeMethodParamName:
-  Exclude:
-    - 'app/models/fields/field.rb'
-    - 'app/models/polymorphic/comment.rb'
-    - 'lib/missing_translation_detector.rb'
-
 # Offense count: 12
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: snake_case, normalcase, non_integer
@@ -174,11 +184,7 @@ Naming/VariableNumber:
     - 'spec/controllers/home_controller_spec.rb'
 
 # Offense count: 1
-Security/MarshalLoad:
-  Exclude:
-    - 'app/models/users/preference.rb'
-
-# Offense count: 1
+# Configuration parameters: AllowOnConstant.
 Style/CaseEquality:
   Exclude:
     - 'app/models/fields/field.rb'
@@ -226,7 +232,7 @@ Style/FormatStringToken:
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, never
+# SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Exclude:
     - 'db/schema.rb'
@@ -238,7 +244,7 @@ Style/GlobalVars:
     - 'db/migrate/20100928030598_create_sessions.rb'
     - 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
 
-# Offense count: 28
+# Offense count: 33
 # Configuration parameters: MinBodyLength.
 Style/GuardClause:
   Enabled: false

data/.travis.yml

@@ -1,7 +1,6 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.5.7
   - 2.6.5
   - 2.7.1
 
@@ -11,38 +10,20 @@ env:
   global:
     - BROWSER=chrome
   matrix:
-    - DB=postgres TEST_SUITE=rubocop
     - DB=postgres TEST_SUITE="rake spec:features"
     - DB=postgres TEST_SUITE="rake spec:models"
-    - DB=postgres TEST_SUITE="rake spec:controllers spec:lib spec:routing spec:mailers"
-    - DB=postgres TEST_SUITE="rake spec:views spec:helpers"
     - DB=mysql TEST_SUITE="rake spec:models"
-    - DB=sqlite TEST_SUITE="rake spec:models"
 
 matrix:
   fast_finish: true
-  exclude:
-    - rvm: 2.5.7
-      env: DB=postgres TEST_SUITE=rubocop
-    - rvm: 2.6.5
-      env: DB=postgres TEST_SUITE=rubocop
   allow_failures:
-    - rvm: 2.5.7
-      env: DB=postgres TEST_SUITE="rake spec:features"
     - rvm: 2.6.5
       env: DB=postgres TEST_SUITE="rake spec:features"
     - rvm: 2.7.1
       env: DB=postgres TEST_SUITE="rake spec:features"
-    - rvm: 2.5.7
-      env: DB=mysql TEST_SUITE="rake spec:models"
-    - rvm: 2.5.7
-      env: DB=sqlite TEST_SUITE="rake spec:models"
-    - rvm: 2.6.5
-      env: DB=sqlite TEST_SUITE="rake spec:models"
     - rvm: 2.7.1
       env: DB=mysql TEST_SUITE="rake spec:models"
-    - rvm: 2.7.1
-      env: DB=sqlite TEST_SUITE="rake spec:models"
+
 
 addons:
   chrome: stable

data/CHANGELOG.md

@@ -4,6 +4,18 @@ It does not matter how slowly you go as long as you do not stop.
 First they ignore you, then they laugh at you, then they fight you,
 then you win. –- Mahatma Gandhi
 
+Mon Oct 04, 2021 (0.20.0)
+======
+#905 Swap from Marshal.load. Be sure to run `bundle exec rake ffcrm:preference_update` to migrate your users from old to new format
+
+settings.yml - Background, foreground colors for tasks, accounts, opportunities, and more - these are now defined in CSS by default 
+
+Refactoring to Bootstrap for forms, buttons, layouts.
+
+Drop ruby 2.5 support
+
+Upgrade to rails 6, papertail 12, devise 4.8
+
 Wed May 09, 2021 (0.19.2)
 ======
 CVE-2021-22885
@@ -54,6 +66,7 @@ Ruby 2.4 has reached end of life and is no longer activity tested against.
  * #851 upgrade paper_trail
  * Security fixes CVE-2019-16109, CVE-2019-16676, CVE-2019-5477, CVE-2019-16892
  * Dependency updates
+ * Simple Form upgrades to use HTML5 and browser validations by default
 
 
 Sat Apr 21, 2018 (0.18.0)

data/Gemfile

@@ -7,7 +7,7 @@ source 'https://rubygems.org'
 
 case ENV['CI'] && ENV['DB']
 when 'sqlite'
-  gem 'sqlite3', '~> 1.3.13'
+  gem 'sqlite3', '~> 1.4.0'
 when 'mysql'
   gem 'mysql2'
 when 'postgres'
@@ -66,7 +66,7 @@ group :development, :test do
   gem 'byebug'
   gem 'pry-rails' unless ENV["CI"]
   gem 'factory_bot_rails', '~> 5.0' # Was Pinned due to minor failing view tests to 4.0
-  gem 'rubocop', '~> 0.76.0' # Pinned because upgrades require regenerating rubocop_todo.yml
+  gem 'rubocop', '~> 0.82.0'
   gem 'rainbow'
   gem 'puma' # used by capybara 3
 end
@@ -78,7 +78,7 @@ group :test do
   gem 'database_cleaner'
   gem 'zeus', platform: :ruby unless ENV["CI"]
   gem 'timecop'
-  gem 'sqlite3', '~> 1.3.13'
+  gem 'sqlite3', '~> 1.4.0'
 end
 
 group :heroku do
@@ -86,11 +86,14 @@ group :heroku do
   gem 'puma'
 end
 
+gem 'responds_to_parent', git: 'https://github.com/CloCkWeRX/responds_to_parent.git', branch: 'patch-1' # Temporarily pointed at git until https://github.com/zendesk/responds_to_parent/pull/6 is released
+gem 'acts_as_commentable', git: 'https://github.com/fatfreecrm/acts_as_commentable.git', branch: 'rails-6' # Our fork
 gem 'sass-rails', '~> 5.0.3' # sass-rails 6 requires GCC 4.5+
 gem 'coffee-rails'
 gem 'uglifier'
 gem 'execjs'
-gem 'therubyracer', platform: :ruby unless ENV["CI"]
+# gem 'therubyracer', platform: :ruby unless ENV["CI"]
+gem 'mini_racer'
 gem 'nokogiri', '>= 1.8.1'
 gem 'activemodel-serializers-xml'
 gem 'bootsnap', require: false
@@ -98,5 +101,6 @@ gem 'devise', '~>4.6'
 gem 'devise-i18n'
 gem "devise-encryptable"
 gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby]
-gem 'activejob', '~> 5.2.0'
+gem 'activejob'
 gem 'ransack_ui'
+gem 'bootstrap', '5.0.0'