fat_free_crm 0.15.2 → 0.16.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (91) hide show
  1. checksums.yaml +5 -5
  2. data/.rubocop.yml +20 -1
  3. data/.rubocop_todo.yml +235 -159
  4. data/CHANGELOG.md +5 -9
  5. data/Gemfile +5 -5
  6. data/Gemfile.lock +119 -126
  7. data/app/controllers/authentications_controller.rb +1 -1
  8. data/app/controllers/entities/accounts_controller.rb +1 -1
  9. data/app/controllers/entities/campaigns_controller.rb +1 -1
  10. data/app/controllers/entities/contacts_controller.rb +1 -1
  11. data/app/controllers/entities/leads_controller.rb +1 -1
  12. data/app/controllers/entities/opportunities_controller.rb +1 -1
  13. data/app/helpers/application_helper.rb +10 -10
  14. data/app/helpers/leads_helper.rb +3 -3
  15. data/app/helpers/tags_helper.rb +1 -1
  16. data/app/models/entities/contact.rb +1 -1
  17. data/app/models/entities/lead.rb +1 -1
  18. data/app/models/fields/custom_field_pair.rb +1 -1
  19. data/app/models/fields/field_group.rb +1 -1
  20. data/app/models/observers/entity_observer.rb +1 -1
  21. data/app/models/polymorphic/email.rb +0 -4
  22. data/app/models/polymorphic/task.rb +15 -15
  23. data/app/models/setting.rb +1 -1
  24. data/app/models/users/user.rb +1 -1
  25. data/app/views/application/index.atom.builder +1 -1
  26. data/app/views/application/index.rss.builder +2 -2
  27. data/app/views/application/show.atom.builder +1 -1
  28. data/app/views/application/show.rss.builder +2 -2
  29. data/app/views/home/index.atom.builder +2 -2
  30. data/app/views/home/index.rss.builder +2 -2
  31. data/app/views/leads/index.xls.builder +1 -1
  32. data/config/locales/{cz_fat_free_crm.yml → fat_free_crm.cs.yml} +1 -1
  33. data/config/locales/{de_fat_free_crm.yml → fat_free_crm.de.yml} +0 -0
  34. data/config/locales/{en-GB_fat_free_crm.yml → fat_free_crm.en-GB.yml} +0 -0
  35. data/config/locales/{en-US_fat_free_crm.yml → fat_free_crm.en-US.yml} +0 -0
  36. data/config/locales/{es-CL_fat_free_crm.yml → fat_free_crm.es-CL.yml} +0 -0
  37. data/config/locales/{es_fat_free_crm.yml → fat_free_crm.es.yml} +0 -0
  38. data/config/locales/{et_fat_free_crm.yml → fat_free_crm.et.yml} +0 -0
  39. data/config/locales/{fr-CA_fat_free_crm.yml → fat_free_crm.fr-CA.yml} +0 -0
  40. data/config/locales/{fr_fat_free_crm.yml → fat_free_crm.fr.yml} +0 -0
  41. data/config/locales/{it_fat_free_crm.yml → fat_free_crm.it.yml} +0 -0
  42. data/config/locales/{ja_fat_free_crm.yml → fat_free_crm.ja.yml} +0 -0
  43. data/config/locales/{nl_fat_free_crm.yml → fat_free_crm.nl.yml} +0 -0
  44. data/config/locales/{pl_fat_free_crm.yml → fat_free_crm.pl.yml} +0 -0
  45. data/config/locales/{pt-BR_fat_free_crm.yml → fat_free_crm.pt-BR.yml} +0 -0
  46. data/config/locales/{ru_fat_free_crm.yml → fat_free_crm.ru.yml} +0 -0
  47. data/config/locales/{sv-SE_fat_free_crm.yml → fat_free_crm.sv-SE.yml} +0 -0
  48. data/config/locales/{th_fat_free_crm.yml → fat_free_crm.th.yml} +0 -0
  49. data/config/locales/{zh-CN_fat_free_crm.yml → fat_free_crm.zh-CN.yml} +0 -0
  50. data/config/puma.rb +28 -0
  51. data/db/schema.rb +1 -0
  52. data/fat_free_crm.gemspec +4 -1
  53. data/lib/fat_free_crm.rb +1 -0
  54. data/lib/fat_free_crm/core_ext/alias_method_chain.rb +24 -0
  55. data/lib/fat_free_crm/core_ext/string.rb +1 -1
  56. data/lib/fat_free_crm/mail_processor/base.rb +2 -2
  57. data/lib/fat_free_crm/version.rb +2 -2
  58. data/spec/controllers/tasks_controller_spec.rb +20 -20
  59. data/spec/models/polymorphic/task_spec.rb +1 -0
  60. data/spec/support/auth_macros.rb +2 -2
  61. data/spec/views/leads/_sidebar_show.haml_spec.rb +4 -4
  62. metadata +53 -52
  63. data/config/locales/cz.yml +0 -247
  64. data/config/locales/de.yml +0 -237
  65. data/config/locales/de_ransack.yml +0 -91
  66. data/config/locales/en-GB.yml +0 -219
  67. data/config/locales/en-GB_ransack.yml +0 -91
  68. data/config/locales/en-US.yml +0 -219
  69. data/config/locales/en-US_ransack.yml +0 -91
  70. data/config/locales/en.yml +0 -23
  71. data/config/locales/es-CL.yml +0 -227
  72. data/config/locales/es-CL_ransack.yml +0 -91
  73. data/config/locales/es.yml +0 -219
  74. data/config/locales/es_ransack.yml +0 -91
  75. data/config/locales/et.yml +0 -207
  76. data/config/locales/fr-CA.yml +0 -224
  77. data/config/locales/fr.yml +0 -227
  78. data/config/locales/it.yml +0 -219
  79. data/config/locales/ja.yml +0 -219
  80. data/config/locales/ja_ransack.yml +0 -91
  81. data/config/locales/nl.yml +0 -210
  82. data/config/locales/nl_ransack.yml +0 -91
  83. data/config/locales/pl.yml +0 -230
  84. data/config/locales/pt-BR.yml +0 -232
  85. data/config/locales/pt-BR_ransack.yml +0 -81
  86. data/config/locales/ru.yml +0 -326
  87. data/config/locales/sv-SE.yml +0 -215
  88. data/config/locales/th.rb +0 -204
  89. data/config/locales/zh-CN.yml +0 -241
  90. data/config/locales/zh-CN_ransack.yml +0 -91
  91. data/config/unicorn.rb +0 -32
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA256:
3
- metadata.gz: f278992b3ffb8e57627d828cda9b23973d4eed2a2b4990cf3d2f768ef7c958fd
4
- data.tar.gz: 2fc300e02b9b29f484a8fbeeb75757af152760ab1682ed7aaccc1d71431dc64b
2
+ SHA1:
3
+ metadata.gz: c9ca7af735f0354a0fea14c54f2c91d86a3aacd3
4
+ data.tar.gz: c06e91603c18ee7f5d38e6ce525382d83e9ad68b
5
5
  SHA512:
6
- metadata.gz: 4ef150573319753b25910f2f1e774498f388e79875b2f4ba8d0a926fe3e9731542c38b6241a504b393c95c66f61ecbc0194f334e2125c14d025fd0a187e8e9b6
7
- data.tar.gz: eeb34486ca9e9bcbb7b3faae4807b49b1511da8e1d222c971b1fce86fc059436ac022bfb8d29a2a01ee1a245b9f12c1a9f00b144dbb34f3a90289813bf9558da
6
+ metadata.gz: c9eba700182f9b5044621e1acf9e75730c0dcfd7b3354f301580ae4038087b0ead46623eecafbff75dbf9d17ef1ba7e8f1f744545c45e9dbbb726c508131f233
7
+ data.tar.gz: 0ef94a125840208ae7df9fc88d8bf485b259dd7a897b8ac84e714c32181bc7a8a6273422a9caa6353cbcabab2f365a85d39a0ff58ae676b3da4b79ad7848e3fa
data/.rubocop.yml CHANGED
@@ -1,15 +1,34 @@
1
1
  inherit_from: .rubocop_todo.yml
2
+
2
3
  AllCops:
3
4
  TargetRubyVersion: 2.3
4
5
 
6
+ Lint/ScriptPermission:
7
+ Exclude:
8
+ - 'Rakefile'
9
+
10
+ Bundler/OrderedGems:
11
+ Enabled: false
12
+
5
13
  StringLiterals:
6
14
  Enabled: false
7
15
 
8
16
  Metrics/LineLength:
9
17
  Enabled: false
10
18
 
19
+ Style/EmptyMethod:
20
+ EnforcedStyle: expanded
21
+
11
22
  Style/MutableConstant:
12
23
  Enabled: false
13
24
 
25
+ # See #647
26
+ Style/SafeNavigation:
27
+ Enabled: false
28
+
29
+ Style/WordArray:
30
+ Exclude:
31
+ - 'db/schema.rb'
32
+
14
33
  Style/SymbolArray:
15
- EnforcedStyle: percent
34
+ EnforcedStyle: percent
data/.rubocop_todo.yml CHANGED
@@ -1,38 +1,25 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2017-07-17 11:19:24 +0930 using RuboCop version 0.49.1.
3
+ # on 2017-12-17 21:03:01 +0900 using RuboCop version 0.52.0.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 17
9
+ # Offense count: 16
10
10
  # Cop supports --auto-correct.
11
11
  # Configuration parameters: Include, TreatCommentsAsGroupSeparators.
12
- # Include: **/Gemfile, **/gems.rb
13
- Bundler/OrderedGems:
12
+ # Include: **/*.gemspec
13
+ Gemspec/OrderedDependencies:
14
14
  Exclude:
15
- - 'Gemfile'
16
-
17
- # Offense count: 2
18
- # Cop supports --auto-correct.
19
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
20
- # SupportedStyles: with_first_parameter, with_fixed_indentation
21
- Layout/AlignParameters:
22
- Exclude:
23
- - 'app/views/leads/index.xls.builder'
24
- - 'spec/views/leads/_sidebar_show.haml_spec.rb'
15
+ - 'fat_free_crm.gemspec'
25
16
 
26
- # Offense count: 28
27
- # Cop supports --auto-correct.
28
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentOneStep, IndentationWidth.
29
- # SupportedStyles: case, end
30
- Layout/CaseIndentation:
17
+ # Offense count: 1
18
+ # Configuration parameters: Include.
19
+ # Include: **/*.gemspec
20
+ Gemspec/RequiredRubyVersion:
31
21
  Exclude:
32
- - 'app/helpers/application_helper.rb'
33
- - 'app/helpers/leads_helper.rb'
34
- - 'app/models/polymorphic/task.rb'
35
- - 'spec/controllers/tasks_controller_spec.rb'
22
+ - 'fat_free_crm.gemspec'
36
23
 
37
24
  # Offense count: 27
38
25
  # Cop supports --auto-correct.
@@ -48,13 +35,30 @@ Layout/ClosingParenthesisIndentation:
48
35
  - 'spec/models/polymorphic/version_spec.rb'
49
36
  - 'spec/views/comments/edit.js.haml_spec.rb'
50
37
 
51
- # Offense count: 3
38
+ # Offense count: 21
52
39
  # Cop supports --auto-correct.
53
- Layout/EmptyLineAfterMagicComment:
40
+ Layout/EmptyLinesAroundArguments:
54
41
  Exclude:
55
- - 'db/schema.rb'
56
- - 'fat_free_crm.gemspec'
57
- - 'spec/models/polymorphic/task_spec.rb'
42
+ - 'config/initializers/views.rb'
43
+ - 'db/seeds/fields.rb'
44
+ - 'spec/features/accounts_spec.rb'
45
+ - 'spec/features/admin/groups_spec.rb'
46
+ - 'spec/features/admin/users_spec.rb'
47
+ - 'spec/features/campaigns_spec.rb'
48
+ - 'spec/features/contacts_spec.rb'
49
+ - 'spec/features/dashboard_spec.rb'
50
+ - 'spec/features/leads_spec.rb'
51
+ - 'spec/features/opportunities_overview_spec.rb'
52
+ - 'spec/features/opportunities_spec.rb'
53
+ - 'spec/features/tasks_spec.rb'
54
+
55
+ # Offense count: 1
56
+ # Cop supports --auto-correct.
57
+ # Configuration parameters: EnforcedStyle.
58
+ # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
59
+ Layout/EmptyLinesAroundClassBody:
60
+ Exclude:
61
+ - 'lib/fat_free_crm/core_ext/alias_method_chain.rb'
58
62
 
59
63
  # Offense count: 1
60
64
  # Cop supports --auto-correct.
@@ -62,7 +66,7 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords:
62
66
  Exclude:
63
67
  - 'app/controllers/comments_controller.rb'
64
68
 
65
- # Offense count: 105
69
+ # Offense count: 108
66
70
  # Cop supports --auto-correct.
67
71
  # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
68
72
  Layout/ExtraSpacing:
@@ -70,7 +74,7 @@ Layout/ExtraSpacing:
70
74
 
71
75
  # Offense count: 9
72
76
  # Cop supports --auto-correct.
73
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
77
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
74
78
  # SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
75
79
  Layout/FirstParameterIndentation:
76
80
  Exclude:
@@ -80,7 +84,7 @@ Layout/FirstParameterIndentation:
80
84
 
81
85
  # Offense count: 7
82
86
  # Cop supports --auto-correct.
83
- # Configuration parameters: EnforcedStyle, SupportedStyles.
87
+ # Configuration parameters: EnforcedStyle.
84
88
  # SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
85
89
  Layout/IndentHeredoc:
86
90
  Exclude:
@@ -88,7 +92,7 @@ Layout/IndentHeredoc:
88
92
 
89
93
  # Offense count: 2
90
94
  # Cop supports --auto-correct.
91
- # Configuration parameters: EnforcedStyle, SupportedStyles.
95
+ # Configuration parameters: EnforcedStyle.
92
96
  # SupportedStyles: symmetrical, new_line, same_line
93
97
  Layout/MultilineArrayBraceLayout:
94
98
  Exclude:
@@ -97,7 +101,7 @@ Layout/MultilineArrayBraceLayout:
97
101
 
98
102
  # Offense count: 20
99
103
  # Cop supports --auto-correct.
100
- # Configuration parameters: EnforcedStyle, SupportedStyles.
104
+ # Configuration parameters: EnforcedStyle.
101
105
  # SupportedStyles: symmetrical, new_line, same_line
102
106
  Layout/MultilineMethodCallBraceLayout:
103
107
  Exclude:
@@ -110,13 +114,12 @@ Layout/MultilineMethodCallBraceLayout:
110
114
  - 'spec/models/polymorphic/version_spec.rb'
111
115
  - 'spec/views/comments/edit.js.haml_spec.rb'
112
116
 
113
- # Offense count: 2
117
+ # Offense count: 1
114
118
  # Cop supports --auto-correct.
115
- # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
119
+ # Configuration parameters: EnforcedStyle, IndentationWidth.
116
120
  # SupportedStyles: aligned, indented, indented_relative_to_receiver
117
121
  Layout/MultilineMethodCallIndentation:
118
122
  Exclude:
119
- - 'lib/development_tasks/license.rake'
120
123
  - 'lib/fat_free_crm/gem_ext/rails/engine.rb'
121
124
 
122
125
  # Offense count: 5
@@ -128,6 +131,15 @@ Layout/SpaceAroundOperators:
128
131
  - 'app/views/application/show.rss.builder'
129
132
  - 'app/views/campaigns/index.xls.builder'
130
133
 
134
+ # Offense count: 1
135
+ # Cop supports --auto-correct.
136
+ # Configuration parameters: .
137
+ # SupportedStyles: space, no_space
138
+ # SupportedStylesForEmptyBraces: space, no_space
139
+ Layout/SpaceBeforeBlockBraces:
140
+ EnforcedStyle: space
141
+ EnforcedStyleForEmptyBraces: space
142
+
131
143
  # Offense count: 1
132
144
  # Cop supports --auto-correct.
133
145
  # Configuration parameters: AllowForAlignment.
@@ -135,14 +147,33 @@ Layout/SpaceBeforeFirstArg:
135
147
  Exclude:
136
148
  - 'app/views/home/index.atom.builder'
137
149
 
150
+ # Offense count: 7
151
+ # Cop supports --auto-correct.
152
+ # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
153
+ # SupportedStyles: space, no_space, compact
154
+ # SupportedStylesForEmptyBrackets: space, no_space
155
+ Layout/SpaceInsideArrayLiteralBrackets:
156
+ Exclude:
157
+ - 'db/seeds/fields.rb'
158
+
138
159
  # Offense count: 20
139
160
  # Configuration parameters: AllowSafeAssignment.
140
161
  Lint/AssignmentInCondition:
141
162
  Enabled: false
142
163
 
164
+ # Offense count: 2
165
+ Lint/BooleanSymbol:
166
+ Exclude:
167
+ - 'config/initializers/ransack.rb'
168
+
169
+ # Offense count: 1
170
+ Lint/DuplicateMethods:
171
+ Exclude:
172
+ - 'lib/gravatar_image_tag.rb'
173
+
143
174
  # Offense count: 23
144
175
  # Cop supports --auto-correct.
145
- # Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith, AutoCorrect.
176
+ # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect.
146
177
  # SupportedStylesAlignWith: keyword, variable, start_of_line
147
178
  Lint/EndAlignment:
148
179
  Enabled: false
@@ -165,16 +196,22 @@ Lint/IneffectiveAccessModifier:
165
196
  - 'db/migrate/20100928030620_remove_uuid.rb'
166
197
  - 'lib/gravatar_image_tag.rb'
167
198
 
168
- # Offense count: 3
199
+ # Offense count: 5
169
200
  Lint/RescueException:
170
201
  Exclude:
171
202
  - 'lib/fat_free_crm/mail_processor/base.rb'
172
203
  - 'lib/tasks/ffcrm/update_data.rake'
173
204
 
205
+ # Offense count: 2
206
+ Lint/ReturnInVoidContext:
207
+ Exclude:
208
+ - 'app/models/setting.rb'
209
+ - 'app/models/users/preference.rb'
210
+
174
211
  # Offense count: 1
175
- Lint/ScriptPermission:
212
+ Lint/UriEscapeUnescape:
176
213
  Exclude:
177
- - 'Rakefile'
214
+ - 'lib/gravatar_image_tag.rb'
178
215
 
179
216
  # Offense count: 4
180
217
  # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
@@ -185,22 +222,23 @@ Lint/UselessAccessModifier:
185
222
  - 'db/migrate/20100928030620_remove_uuid.rb'
186
223
  - 'lib/gravatar_image_tag.rb'
187
224
 
188
- # Offense count: 3
225
+ # Offense count: 4
189
226
  Lint/UselessAssignment:
190
227
  Exclude:
191
228
  - 'app/helpers/application_helper.rb'
192
229
  - 'app/views/home/index.atom.builder'
230
+ - 'lib/fat_free_crm/mail_processor/base.rb'
193
231
 
194
- # Offense count: 131
232
+ # Offense count: 130
195
233
  Metrics/AbcSize:
196
234
  Max: 55
197
235
 
198
- # Offense count: 292
236
+ # Offense count: 293
199
237
  # Configuration parameters: CountComments, ExcludedMethods.
200
238
  Metrics/BlockLength:
201
239
  Max: 775
202
240
 
203
- # Offense count: 3
241
+ # Offense count: 4
204
242
  # Configuration parameters: CountBlocks.
205
243
  Metrics/BlockNesting:
206
244
  Max: 4
@@ -210,11 +248,11 @@ Metrics/BlockNesting:
210
248
  Metrics/ClassLength:
211
249
  Max: 195
212
250
 
213
- # Offense count: 29
251
+ # Offense count: 30
214
252
  Metrics/CyclomaticComplexity:
215
253
  Max: 13
216
254
 
217
- # Offense count: 103
255
+ # Offense count: 104
218
256
  # Configuration parameters: CountComments.
219
257
  Metrics/MethodLength:
220
258
  Max: 38
@@ -228,13 +266,59 @@ Metrics/ModuleLength:
228
266
  Metrics/PerceivedComplexity:
229
267
  Max: 15
230
268
 
231
- # Offense count: 3
269
+ # Offense count: 12
270
+ Naming/AccessorMethodName:
271
+ Exclude:
272
+ - 'app/controllers/application_controller.rb'
273
+ - 'app/controllers/entities/accounts_controller.rb'
274
+ - 'app/controllers/entities/campaigns_controller.rb'
275
+ - 'app/controllers/entities/contacts_controller.rb'
276
+ - 'app/controllers/entities/leads_controller.rb'
277
+ - 'app/helpers/application_helper.rb'
278
+ - 'app/inputs/date_pair_input.rb'
279
+ - 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
280
+ - 'spec/controllers/entities/accounts_controller_spec.rb'
281
+ - 'spec/controllers/entities/campaigns_controller_spec.rb'
282
+ - 'spec/controllers/entities/opportunities_controller_spec.rb'
283
+ - 'spec/support/macros.rb'
284
+
285
+ # Offense count: 8
286
+ # Configuration parameters: Blacklist.
287
+ # Blacklist: END, (?-mix:EO[A-Z]{1})
288
+ Naming/HeredocDelimiterNaming:
289
+ Exclude:
290
+ - 'app/controllers/passwords_controller.rb'
291
+ - 'spec/lib/mail_processor/sample_emails/dropbox.rb'
292
+
293
+ # Offense count: 4
294
+ # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
295
+ # NamePrefix: is_, has_, have_
296
+ # NamePrefixBlacklist: is_, has_, have_
297
+ # NameWhitelist: is_a?
298
+ # MethodDefinitionMacros: define_method, define_singleton_method
299
+ Naming/PredicateName:
300
+ Exclude:
301
+ - 'spec/**/*'
302
+ - 'app/inputs/date_time_input.rb'
303
+ - 'app/models/users/user.rb'
304
+ - 'lib/fat_free_crm/fields.rb'
305
+ - 'lib/fat_free_crm/mail_processor/base.rb'
306
+
307
+ # Offense count: 12
308
+ # Configuration parameters: EnforcedStyle.
309
+ # SupportedStyles: snake_case, normalcase, non_integer
310
+ Naming/VariableNumber:
311
+ Exclude:
312
+ - 'spec/controllers/home_controller_spec.rb'
313
+
314
+ # Offense count: 4
232
315
  # Cop supports --auto-correct.
233
- Performance/CompareWithBlock:
316
+ # Configuration parameters: AutoCorrect.
317
+ Performance/HashEachMethods:
234
318
  Exclude:
235
- - 'app/views/application/index.atom.builder'
236
- - 'app/views/application/show.atom.builder'
237
- - 'app/views/home/index.atom.builder'
319
+ - 'app/controllers/entities/opportunities_controller.rb'
320
+ - 'lib/fat_free_crm/errors.rb'
321
+ - 'spec/controllers/tasks_controller_spec.rb'
238
322
 
239
323
  # Offense count: 1
240
324
  # Cop supports --auto-correct.
@@ -262,43 +346,9 @@ Security/YAMLLoad:
262
346
  - 'db/migrate/20120405080742_change_further_subscribed_users_to_set.rb'
263
347
  - 'lib/tasks/ffcrm/config.rake'
264
348
 
265
- # Offense count: 12
266
- Style/AccessorMethodName:
267
- Exclude:
268
- - 'app/controllers/application_controller.rb'
269
- - 'app/controllers/entities/accounts_controller.rb'
270
- - 'app/controllers/entities/campaigns_controller.rb'
271
- - 'app/controllers/entities/contacts_controller.rb'
272
- - 'app/controllers/entities/leads_controller.rb'
273
- - 'app/helpers/application_helper.rb'
274
- - 'app/inputs/date_pair_input.rb'
275
- - 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
276
- - 'spec/controllers/entities/accounts_controller_spec.rb'
277
- - 'spec/controllers/entities/campaigns_controller_spec.rb'
278
- - 'spec/controllers/entities/opportunities_controller_spec.rb'
279
- - 'spec/support/macros.rb'
280
-
281
- # Offense count: 12
282
- # Cop supports --auto-correct.
283
- # Configuration parameters: EnforcedStyle, SupportedStyles.
284
- # SupportedStyles: prefer_alias, prefer_alias_method
285
- Style/Alias:
286
- Exclude:
287
- - 'app/controllers/authentications_controller.rb'
288
- - 'app/controllers/entities/accounts_controller.rb'
289
- - 'app/controllers/entities/campaigns_controller.rb'
290
- - 'app/controllers/entities/contacts_controller.rb'
291
- - 'app/controllers/entities/leads_controller.rb'
292
- - 'app/controllers/entities/opportunities_controller.rb'
293
- - 'app/models/entities/contact.rb'
294
- - 'app/models/entities/lead.rb'
295
- - 'app/models/users/user.rb'
296
- - 'lib/fat_free_crm/core_ext/string.rb'
297
- - 'spec/support/auth_macros.rb'
298
-
299
349
  # Offense count: 4
300
350
  # Cop supports --auto-correct.
301
- # Configuration parameters: EnforcedStyle, SupportedStyles.
351
+ # Configuration parameters: EnforcedStyle.
302
352
  # SupportedStyles: always, conditionals
303
353
  Style/AndOr:
304
354
  Exclude:
@@ -307,7 +357,7 @@ Style/AndOr:
307
357
 
308
358
  # Offense count: 8
309
359
  # Cop supports --auto-correct.
310
- # Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
360
+ # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods.
311
361
  # SupportedStyles: line_count_based, semantic, braces_for_chaining
312
362
  # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
313
363
  # FunctionalMethods: let, let!, subject, watch
@@ -323,7 +373,7 @@ Style/CaseEquality:
323
373
  - 'app/models/fields/field.rb'
324
374
 
325
375
  # Offense count: 18
326
- # Configuration parameters: EnforcedStyle, SupportedStyles.
376
+ # Configuration parameters: EnforcedStyle.
327
377
  # SupportedStyles: nested, compact
328
378
  Style/ClassAndModuleChildren:
329
379
  Enabled: false
@@ -343,9 +393,18 @@ Style/ClassVars:
343
393
  - 'lib/fat_free_crm/tabs.rb'
344
394
  - 'lib/fat_free_crm/view_factory.rb'
345
395
 
396
+ # Offense count: 7
397
+ Style/CommentedKeyword:
398
+ Exclude:
399
+ - 'app/controllers/entities/leads_controller.rb'
400
+ - 'app/helpers/application_helper.rb'
401
+ - 'app/models/users/authentication.rb'
402
+ - 'db/migrate/20100928030617_drop_openid_tables.rb'
403
+ - 'lib/fat_free_crm/mail_processor/dropbox.rb'
404
+
346
405
  # Offense count: 13
347
406
  # Cop supports --auto-correct.
348
- # Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly, IncludeTernaryExpressions.
407
+ # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
349
408
  # SupportedStyles: assign_to_condition, assign_inside_condition
350
409
  Style/ConditionalAssignment:
351
410
  Exclude:
@@ -361,7 +420,12 @@ Style/ConditionalAssignment:
361
420
  - 'spec/spec_helper.rb'
362
421
  - 'spec/support/macros.rb'
363
422
 
364
- # Offense count: 126
423
+ # Offense count: 2
424
+ Style/DateTime:
425
+ Exclude:
426
+ - 'spec/models/fields/field_spec.rb'
427
+
428
+ # Offense count: 128
365
429
  Style/Documentation:
366
430
  Enabled: false
367
431
 
@@ -372,43 +436,48 @@ Style/DoubleNegation:
372
436
  - 'app/models/polymorphic/task.rb'
373
437
  - 'lib/gravatar_image_tag.rb'
374
438
 
375
- # Offense count: 1
439
+ # Offense count: 2
376
440
  # Cop supports --auto-correct.
377
441
  Style/EmptyCaseCondition:
378
442
  Exclude:
379
443
  - 'app/models/polymorphic/task.rb'
444
+ - 'lib/fat_free_crm/core_ext/alias_method_chain.rb'
380
445
 
381
- # Offense count: 10
446
+ # Offense count: 2
382
447
  # Cop supports --auto-correct.
383
- # Configuration parameters: EnforcedStyle, SupportedStyles.
384
- # SupportedStyles: compact, expanded
385
- Style/EmptyMethod:
448
+ Style/Encoding:
386
449
  Exclude:
387
- - 'app/controllers/admin/fields_controller.rb'
388
- - 'app/controllers/admin/settings_controller.rb'
389
- - 'app/controllers/admin/tags_controller.rb'
390
- - 'app/controllers/entities_controller.rb'
391
- - 'db/migrate/20120216042541_is_paranoid_to_paper_trail.rb'
392
- - 'db/migrate/20120316045804_activities_to_versions.rb'
393
- - 'db/migrate/20121221033947_fix_country_mapping.rb'
450
+ - 'db/schema.rb'
451
+ - 'fat_free_crm.gemspec'
452
+
453
+ # Offense count: 1
454
+ Style/EvalWithLocation:
455
+ Exclude:
456
+ - 'lib/fat_free_crm/permissions.rb'
394
457
 
395
458
  # Offense count: 1
396
459
  # Cop supports --auto-correct.
397
- # Configuration parameters: EnforcedStyle, SupportedStyles.
460
+ # Configuration parameters: EnforcedStyle.
398
461
  # SupportedStyles: format, sprintf, percent
399
462
  Style/FormatString:
400
463
  Exclude:
401
464
  - 'spec/factories/shared_factories.rb'
402
465
 
403
- # Offense count: 29
404
- # Configuration parameters: SupportedStyles.
405
- # SupportedStyles: annotated, template
466
+ # Offense count: 52
467
+ # Configuration parameters: EnforcedStyle.
468
+ # SupportedStyles: annotated, template, unannotated
406
469
  Style/FormatStringToken:
407
- EnforcedStyle: template
470
+ Exclude:
471
+ - 'app/inputs/date_pair_input.rb'
472
+ - 'app/inputs/date_time_input.rb'
473
+ - 'app/inputs/datetime_pair_input.rb'
474
+ - 'config/locales/th.rb'
475
+ - 'spec/models/list_spec.rb'
476
+ - 'spec/models/polymorphic/task_spec.rb'
408
477
 
409
478
  # Offense count: 486
410
479
  # Cop supports --auto-correct.
411
- # Configuration parameters: EnforcedStyle, SupportedStyles.
480
+ # Configuration parameters: EnforcedStyle.
412
481
  # SupportedStyles: when_needed, always, never
413
482
  Style/FrozenStringLiteralComment:
414
483
  Enabled: false
@@ -425,22 +494,16 @@ Style/GlobalVars:
425
494
  Style/GuardClause:
426
495
  Enabled: false
427
496
 
428
- # Offense count: 7
429
- # Cop supports --auto-correct.
430
- # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
431
- # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
432
- Style/HashSyntax:
433
- Exclude:
434
- - 'app/views/application/index.rss.builder'
435
- - 'app/views/application/show.rss.builder'
436
- - 'app/views/home/index.atom.builder'
437
- - 'app/views/home/index.rss.builder'
438
-
439
497
  # Offense count: 2
440
498
  Style/IdenticalConditionalBranches:
441
499
  Exclude:
442
500
  - 'app/helpers/application_helper.rb'
443
501
 
502
+ # Offense count: 50
503
+ # Cop supports --auto-correct.
504
+ Style/IfUnlessModifier:
505
+ Enabled: false
506
+
444
507
  # Offense count: 5
445
508
  # Cop supports --auto-correct.
446
509
  # Configuration parameters: InverseMethods, InverseBlocks.
@@ -454,7 +517,7 @@ Style/InverseMethods:
454
517
 
455
518
  # Offense count: 16
456
519
  # Cop supports --auto-correct.
457
- # Configuration parameters: EnforcedStyle, SupportedStyles.
520
+ # Configuration parameters: EnforcedStyle.
458
521
  # SupportedStyles: line_count_dependent, lambda, literal
459
522
  Style/Lambda:
460
523
  Exclude:
@@ -472,6 +535,15 @@ Style/MethodMissing:
472
535
  - 'app/models/setting.rb'
473
536
  - 'lib/fat_free_crm/fields.rb'
474
537
 
538
+ # Offense count: 8
539
+ Style/MixinUsage:
540
+ Exclude:
541
+ - 'lib/fat_free_crm/comment_extensions.rb'
542
+ - 'lib/fat_free_crm/exportable.rb'
543
+ - 'lib/fat_free_crm/fields.rb'
544
+ - 'lib/fat_free_crm/permissions.rb'
545
+ - 'spec/helpers/fields_helper_spec.rb'
546
+
475
547
  # Offense count: 2
476
548
  Style/MultilineBlockChain:
477
549
  Exclude:
@@ -492,7 +564,7 @@ Style/MultilineTernaryOperator:
492
564
 
493
565
  # Offense count: 5
494
566
  # Cop supports --auto-correct.
495
- # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
567
+ # Configuration parameters: EnforcedStyle, MinBodyLength.
496
568
  # SupportedStyles: skip_modifier_ifs, always
497
569
  Style/Next:
498
570
  Exclude:
@@ -509,7 +581,7 @@ Style/NumericLiterals:
509
581
 
510
582
  # Offense count: 10
511
583
  # Cop supports --auto-correct.
512
- # Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
584
+ # Configuration parameters: AutoCorrect, EnforcedStyle.
513
585
  # SupportedStyles: predicate, comparison
514
586
  Style/NumericPredicate:
515
587
  Exclude:
@@ -523,28 +595,44 @@ Style/NumericPredicate:
523
595
  - 'app/models/users/user.rb'
524
596
  - 'lib/tasks/ffcrm/demo.rake'
525
597
 
526
- # Offense count: 190
598
+ # Offense count: 1
599
+ # Cop supports --auto-correct.
600
+ Style/ParallelAssignment:
601
+ Exclude:
602
+ - 'lib/fat_free_crm/core_ext/alias_method_chain.rb'
603
+
604
+ # Offense count: 100
527
605
  # Cop supports --auto-correct.
528
606
  # Configuration parameters: PreferredDelimiters.
529
607
  Style/PercentLiteralDelimiters:
530
- Enabled: false
608
+ Exclude:
609
+ - 'app/views/tasks/index.xls.builder'
610
+ - 'config/locales/th.rb'
611
+ - 'lib/tasks/ffcrm/update_data.rake'
612
+ - 'spec/models/fields/field_spec.rb'
531
613
 
532
- # Offense count: 4
533
- # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
534
- # NamePrefix: is_, has_, have_
535
- # NamePrefixBlacklist: is_, has_, have_
536
- # NameWhitelist: is_a?
537
- Style/PredicateName:
614
+ # Offense count: 1
615
+ # Cop supports --auto-correct.
616
+ Style/PerlBackrefs:
538
617
  Exclude:
539
- - 'spec/**/*'
540
- - 'app/inputs/date_time_input.rb'
541
- - 'app/models/users/user.rb'
542
- - 'lib/fat_free_crm/fields.rb'
543
- - 'lib/fat_free_crm/mail_processor/base.rb'
618
+ - 'lib/fat_free_crm/core_ext/alias_method_chain.rb'
619
+
620
+ # Offense count: 2
621
+ # Cop supports --auto-correct.
622
+ Style/RandomWithOffset:
623
+ Exclude:
624
+ - 'lib/tasks/ffcrm/demo.rake'
625
+ - 'spec/factories/user_factories.rb'
626
+
627
+ # Offense count: 2
628
+ # Cop supports --auto-correct.
629
+ Style/RedundantSelf:
630
+ Exclude:
631
+ - 'app/models/polymorphic/task.rb'
544
632
 
545
633
  # Offense count: 18
546
634
  # Cop supports --auto-correct.
547
- # Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
635
+ # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
548
636
  # SupportedStyles: slashes, percent_r, mixed
549
637
  Style/RegexpLiteral:
550
638
  Exclude:
@@ -561,15 +649,6 @@ Style/RegexpLiteral:
561
649
  - 'spec/views/contacts/update.js.haml_spec.rb'
562
650
  - 'spec/views/opportunities/update.js.haml_spec.rb'
563
651
 
564
- # Offense count: 4
565
- # Cop supports --auto-correct.
566
- # Configuration parameters: ConvertCodeThatCanStartToReturnNil.
567
- Style/SafeNavigation:
568
- Exclude:
569
- - 'app/controllers/tasks_controller.rb'
570
- - 'app/models/observers/opportunity_observer.rb'
571
- - 'db/migrate/20100928030618_add_admin_to_users.rb'
572
-
573
652
  # Offense count: 9
574
653
  # Cop supports --auto-correct.
575
654
  # Configuration parameters: AllowAsExpressionSeparator.
@@ -583,6 +662,12 @@ Style/Semicolon:
583
662
  - 'spec/models/fields/custom_field_spec.rb'
584
663
  - 'spec/support/macros.rb'
585
664
 
665
+ # Offense count: 4
666
+ # Cop supports --auto-correct.
667
+ Style/StderrPuts:
668
+ Exclude:
669
+ - 'lib/fat_free_crm/mail_processor/base.rb'
670
+
586
671
  # Offense count: 2
587
672
  # Cop supports --auto-correct.
588
673
  # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
@@ -602,17 +687,8 @@ Style/UnneededInterpolation:
602
687
  - 'app/views/opportunities/index.xls.builder'
603
688
  - 'app/views/tasks/index.xls.builder'
604
689
 
605
- # Offense count: 12
606
- # Configuration parameters: EnforcedStyle, SupportedStyles.
607
- # SupportedStyles: snake_case, normalcase, non_integer
608
- Style/VariableNumber:
609
- Exclude:
610
- - 'spec/controllers/home_controller_spec.rb'
611
-
612
- # Offense count: 18
613
- # Cop supports --auto-correct.
614
- # Configuration parameters: SupportedStyles, WordRegex.
615
- # SupportedStyles: percent, brackets
616
- Style/WordArray:
617
- EnforcedStyle: percent
618
- MinSize: 5
690
+ # Offense count: 2164
691
+ # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
692
+ # URISchemes: http, https
693
+ Metrics/LineLength:
694
+ Max: 390