fat_free_crm 0.15.0.beta → 0.15.0.beta.2
Sign up to get free protection for your applications and to get access to all the features.
Potentially problematic release.
This version of fat_free_crm might be problematic. Click here for more details.
- checksums.yaml +4 -4
- data/.rubocop.yml +7 -0
- data/.rubocop_todo.yml +517 -0
- data/.travis.yml +1 -1
- data/CHANGELOG.md +145 -9
- data/Gemfile +11 -13
- data/Gemfile.lock +104 -92
- data/README.md +2 -9
- data/app/assets/javascripts/application.js.erb +1 -1
- data/app/assets/javascripts/crm_select2.js.coffee +0 -1
- data/app/controllers/application_controller.rb +6 -6
- data/app/controllers/comments_controller.rb +7 -5
- data/app/controllers/entities/contacts_controller.rb +4 -4
- data/app/controllers/entities/opportunities_controller.rb +3 -3
- data/app/controllers/entities_controller.rb +3 -2
- data/app/controllers/home_controller.rb +21 -14
- data/app/controllers/passwords_controller.rb +1 -1
- data/app/controllers/users_controller.rb +3 -3
- data/app/helpers/accounts_helper.rb +2 -2
- data/app/helpers/application_helper.rb +20 -19
- data/app/helpers/campaigns_helper.rb +1 -1
- data/app/helpers/opportunities_helper.rb +4 -3
- data/app/helpers/tasks_helper.rb +6 -4
- data/app/helpers/users_helper.rb +1 -1
- data/app/helpers/versions_helper.rb +1 -1
- data/app/inputs/date_pair_input.rb +1 -1
- data/app/inputs/date_time_input.rb +1 -1
- data/app/models/entities/contact.rb +1 -0
- data/app/models/entities/lead.rb +4 -9
- data/app/models/entities/opportunity.rb +3 -6
- data/app/models/fields/field.rb +2 -3
- data/app/models/polymorphic/address.rb +1 -1
- data/app/models/polymorphic/comment.rb +1 -1
- data/app/models/polymorphic/task.rb +2 -3
- data/app/models/polymorphic/version.rb +5 -5
- data/app/models/setting.rb +6 -7
- data/app/models/users/user.rb +2 -2
- data/app/views/shared/_tags.html.haml +1 -5
- data/config/environments/test.rb +1 -1
- data/config/initializers/assets.rb +1 -1
- data/config/initializers/paper_trail.rb +1 -1
- data/config/initializers/simple_form.rb +1 -1
- data/config/initializers/views.rb +0 -1
- data/config/locales/th.rb +4 -4
- data/config/unicorn.rb +2 -2
- data/db/migrate/20100928030620_remove_uuid.rb +2 -4
- data/db/migrate/20111201030535_add_field_groups_klass_name.rb +2 -1
- data/db/migrate/20120224073107_remove_default_value_and_clear_settings.rb +1 -1
- data/db/schema.rb +0 -2
- data/fat_free_crm.gemspec +5 -5
- data/lib/fat_free_crm.rb +1 -3
- data/lib/fat_free_crm/callback.rb +2 -1
- data/lib/fat_free_crm/core_ext/string.rb +2 -2
- data/lib/fat_free_crm/engine.rb +1 -1
- data/lib/fat_free_crm/fields.rb +1 -1
- data/lib/fat_free_crm/i18n.rb +1 -1
- data/lib/fat_free_crm/mail_processor/base.rb +8 -2
- data/lib/fat_free_crm/mail_processor/comment_replies.rb +2 -1
- data/lib/fat_free_crm/permissions.rb +1 -1
- data/lib/fat_free_crm/version.rb +1 -1
- data/lib/gravatar_image_tag.rb +2 -2
- data/lib/tasks/ffcrm/comment_replies.rake +2 -2
- data/lib/tasks/ffcrm/config.rake +7 -6
- data/lib/tasks/ffcrm/demo.rake +1 -1
- data/lib/tasks/ffcrm/dropbox.rake +2 -2
- data/lib/tasks/ffcrm/setup.rake +4 -2
- data/lib/tasks/ffcrm/update_data.rake +5 -7
- data/spec/controllers/entities/campaigns_controller_spec.rb +1 -1
- data/spec/controllers/entities/leads_controller_spec.rb +1 -1
- data/spec/controllers/home_controller_spec.rb +5 -5
- data/spec/controllers/tasks_controller_spec.rb +3 -2
- data/spec/factories/sequences.rb +1 -2
- data/spec/factories/shared_factories.rb +5 -5
- data/spec/factories/user_factories.rb +3 -3
- data/spec/models/entities/opportunity_spec.rb +1 -1
- data/spec/models/fields/custom_field_pair_spec.rb +2 -2
- data/spec/models/setting_spec.rb +1 -1
- data/spec/shared/controllers.rb +1 -1
- data/spec/support/auth_macros.rb +6 -5
- data/spec/support/macros.rb +1 -1
- data/spec/views/application/auto_complete.haml_spec.rb +3 -3
- data/spec/views/campaigns/show.haml_spec.rb +2 -2
- data/spec/views/leads/update.js.haml_spec.rb +1 -1
- data/spec/views/tasks/index.haml_spec.rb +1 -1
- data/spec/views/tasks/update.js.haml_spec.rb +7 -7
- metadata +29 -4
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA1:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 3a0daf2ae9f97c0a4589f93b8cb3240f37bd57fe
|
|
4
|
+
data.tar.gz: f3c2f54473fd92552500424d29605b56f59bf235
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: bd15c7c1fd704bc6115d2c46e752fc738367fec631b5692c9b0391dfbf5c42d88d86ddf887f81c095638105c5e81e76ce77ab064467b837eac0289247c8d9aa9
|
|
7
|
+
data.tar.gz: 05beea02b2e41b395f40d198a5035865c672e73cb4a21b28de22679bf219375cfb868c06c0c430cb90b54fa7c4c36342d8228a30e7d1148532dea8ae0cd58e21
|
data/.rubocop.yml
CHANGED
data/.rubocop_todo.yml
ADDED
|
@@ -0,0 +1,517 @@
|
|
|
1
|
+
# This configuration was generated by
|
|
2
|
+
# `rubocop --auto-gen-config`
|
|
3
|
+
# on 2017-02-10 17:37:37 +1030 using RuboCop version 0.47.0.
|
|
4
|
+
# The point is for the user to remove these configuration records
|
|
5
|
+
# one by one as the offenses are removed from the code base.
|
|
6
|
+
# Note that changes in the inspected code, or installation of new
|
|
7
|
+
# versions of RuboCop, may require this file to be generated again.
|
|
8
|
+
|
|
9
|
+
# Offense count: 17
|
|
10
|
+
# Cop supports --auto-correct.
|
|
11
|
+
# Configuration parameters: Include.
|
|
12
|
+
# Include: **/Gemfile, **/gems.rb
|
|
13
|
+
Bundler/OrderedGems:
|
|
14
|
+
Exclude:
|
|
15
|
+
- 'Gemfile'
|
|
16
|
+
|
|
17
|
+
# Offense count: 20
|
|
18
|
+
# Configuration parameters: AllowSafeAssignment.
|
|
19
|
+
Lint/AssignmentInCondition:
|
|
20
|
+
Enabled: false
|
|
21
|
+
|
|
22
|
+
# Offense count: 23
|
|
23
|
+
# Cop supports --auto-correct.
|
|
24
|
+
# Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith, AutoCorrect.
|
|
25
|
+
# SupportedStylesAlignWith: keyword, variable, start_of_line
|
|
26
|
+
Lint/EndAlignment:
|
|
27
|
+
Enabled: false
|
|
28
|
+
|
|
29
|
+
# Offense count: 2
|
|
30
|
+
Lint/HandleExceptions:
|
|
31
|
+
Exclude:
|
|
32
|
+
- 'config/environments/test.rb'
|
|
33
|
+
- 'lib/fat_free_crm/gem_dependencies.rb'
|
|
34
|
+
|
|
35
|
+
# Offense count: 4
|
|
36
|
+
Lint/ImplicitStringConcatenation:
|
|
37
|
+
Exclude:
|
|
38
|
+
- 'db/migrate/20121221033947_fix_country_mapping.rb'
|
|
39
|
+
- 'lib/tasks/ffcrm/update_data.rake'
|
|
40
|
+
|
|
41
|
+
# Offense count: 4
|
|
42
|
+
Lint/IneffectiveAccessModifier:
|
|
43
|
+
Exclude:
|
|
44
|
+
- 'db/migrate/20100928030620_remove_uuid.rb'
|
|
45
|
+
- 'lib/gravatar_image_tag.rb'
|
|
46
|
+
|
|
47
|
+
# Offense count: 3
|
|
48
|
+
Lint/RescueException:
|
|
49
|
+
Exclude:
|
|
50
|
+
- 'lib/fat_free_crm/mail_processor/base.rb'
|
|
51
|
+
- 'lib/tasks/ffcrm/update_data.rake'
|
|
52
|
+
|
|
53
|
+
# Offense count: 4
|
|
54
|
+
# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
|
|
55
|
+
Lint/UselessAccessModifier:
|
|
56
|
+
Exclude:
|
|
57
|
+
- 'app/models/fields/field.rb'
|
|
58
|
+
- 'app/models/users/user.rb'
|
|
59
|
+
- 'db/migrate/20100928030620_remove_uuid.rb'
|
|
60
|
+
- 'lib/gravatar_image_tag.rb'
|
|
61
|
+
|
|
62
|
+
# Offense count: 1
|
|
63
|
+
Lint/UselessAssignment:
|
|
64
|
+
Exclude:
|
|
65
|
+
- 'app/helpers/application_helper.rb'
|
|
66
|
+
|
|
67
|
+
# Offense count: 131
|
|
68
|
+
Metrics/AbcSize:
|
|
69
|
+
Max: 55
|
|
70
|
+
|
|
71
|
+
# Offense count: 267
|
|
72
|
+
# Configuration parameters: CountComments, ExcludedMethods.
|
|
73
|
+
Metrics/BlockLength:
|
|
74
|
+
Max: 775
|
|
75
|
+
|
|
76
|
+
# Offense count: 3
|
|
77
|
+
# Configuration parameters: CountBlocks.
|
|
78
|
+
Metrics/BlockNesting:
|
|
79
|
+
Max: 4
|
|
80
|
+
|
|
81
|
+
# Offense count: 15
|
|
82
|
+
# Configuration parameters: CountComments.
|
|
83
|
+
Metrics/ClassLength:
|
|
84
|
+
Max: 195
|
|
85
|
+
|
|
86
|
+
# Offense count: 29
|
|
87
|
+
Metrics/CyclomaticComplexity:
|
|
88
|
+
Max: 13
|
|
89
|
+
|
|
90
|
+
# Offense count: 103
|
|
91
|
+
# Configuration parameters: CountComments.
|
|
92
|
+
Metrics/MethodLength:
|
|
93
|
+
Max: 38
|
|
94
|
+
|
|
95
|
+
# Offense count: 2
|
|
96
|
+
# Configuration parameters: CountComments.
|
|
97
|
+
Metrics/ModuleLength:
|
|
98
|
+
Max: 391
|
|
99
|
+
|
|
100
|
+
# Offense count: 28
|
|
101
|
+
Metrics/PerceivedComplexity:
|
|
102
|
+
Max: 15
|
|
103
|
+
|
|
104
|
+
# Offense count: 1
|
|
105
|
+
# Cop supports --auto-correct.
|
|
106
|
+
# Configuration parameters: AutoCorrect.
|
|
107
|
+
Performance/StartWith:
|
|
108
|
+
Exclude:
|
|
109
|
+
- 'app/helpers/versions_helper.rb'
|
|
110
|
+
|
|
111
|
+
# Offense count: 1
|
|
112
|
+
Security/Eval:
|
|
113
|
+
Exclude:
|
|
114
|
+
- 'lib/development_tasks/gem.rake'
|
|
115
|
+
|
|
116
|
+
# Offense count: 1
|
|
117
|
+
Security/MarshalLoad:
|
|
118
|
+
Exclude:
|
|
119
|
+
- 'app/models/users/preference.rb'
|
|
120
|
+
|
|
121
|
+
# Offense count: 4
|
|
122
|
+
# Cop supports --auto-correct.
|
|
123
|
+
Security/YAMLLoad:
|
|
124
|
+
Exclude:
|
|
125
|
+
- 'app/models/setting.rb'
|
|
126
|
+
- 'db/migrate/20120405080727_change_subscribed_users_to_set.rb'
|
|
127
|
+
- 'db/migrate/20120405080742_change_further_subscribed_users_to_set.rb'
|
|
128
|
+
- 'lib/tasks/ffcrm/config.rake'
|
|
129
|
+
|
|
130
|
+
# Offense count: 12
|
|
131
|
+
Style/AccessorMethodName:
|
|
132
|
+
Exclude:
|
|
133
|
+
- 'app/controllers/application_controller.rb'
|
|
134
|
+
- 'app/controllers/entities/accounts_controller.rb'
|
|
135
|
+
- 'app/controllers/entities/campaigns_controller.rb'
|
|
136
|
+
- 'app/controllers/entities/contacts_controller.rb'
|
|
137
|
+
- 'app/controllers/entities/leads_controller.rb'
|
|
138
|
+
- 'app/helpers/application_helper.rb'
|
|
139
|
+
- 'app/inputs/date_pair_input.rb'
|
|
140
|
+
- 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
|
|
141
|
+
- 'spec/controllers/entities/accounts_controller_spec.rb'
|
|
142
|
+
- 'spec/controllers/entities/campaigns_controller_spec.rb'
|
|
143
|
+
- 'spec/controllers/entities/opportunities_controller_spec.rb'
|
|
144
|
+
- 'spec/support/macros.rb'
|
|
145
|
+
|
|
146
|
+
# Offense count: 12
|
|
147
|
+
# Cop supports --auto-correct.
|
|
148
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
149
|
+
# SupportedStyles: prefer_alias, prefer_alias_method
|
|
150
|
+
Style/Alias:
|
|
151
|
+
Exclude:
|
|
152
|
+
- 'app/controllers/authentications_controller.rb'
|
|
153
|
+
- 'app/controllers/entities/accounts_controller.rb'
|
|
154
|
+
- 'app/controllers/entities/campaigns_controller.rb'
|
|
155
|
+
- 'app/controllers/entities/contacts_controller.rb'
|
|
156
|
+
- 'app/controllers/entities/leads_controller.rb'
|
|
157
|
+
- 'app/controllers/entities/opportunities_controller.rb'
|
|
158
|
+
- 'app/models/entities/contact.rb'
|
|
159
|
+
- 'app/models/entities/lead.rb'
|
|
160
|
+
- 'app/models/users/user.rb'
|
|
161
|
+
- 'lib/fat_free_crm/core_ext/string.rb'
|
|
162
|
+
- 'spec/support/auth_macros.rb'
|
|
163
|
+
|
|
164
|
+
# Offense count: 1
|
|
165
|
+
# Cop supports --auto-correct.
|
|
166
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
|
167
|
+
# SupportedStyles: with_first_parameter, with_fixed_indentation
|
|
168
|
+
Style/AlignParameters:
|
|
169
|
+
Exclude:
|
|
170
|
+
- 'spec/views/leads/_sidebar_show.haml_spec.rb'
|
|
171
|
+
|
|
172
|
+
# Offense count: 4
|
|
173
|
+
# Cop supports --auto-correct.
|
|
174
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
175
|
+
# SupportedStyles: always, conditionals
|
|
176
|
+
Style/AndOr:
|
|
177
|
+
Exclude:
|
|
178
|
+
- 'config/unicorn.rb'
|
|
179
|
+
- 'lib/fat_free_crm/mail_processor/base.rb'
|
|
180
|
+
|
|
181
|
+
# Offense count: 8
|
|
182
|
+
# Cop supports --auto-correct.
|
|
183
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
|
|
184
|
+
# SupportedStyles: line_count_based, semantic, braces_for_chaining
|
|
185
|
+
# ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
|
|
186
|
+
# FunctionalMethods: let, let!, subject, watch
|
|
187
|
+
# IgnoredMethods: lambda, proc, it
|
|
188
|
+
Style/BlockDelimiters:
|
|
189
|
+
Exclude:
|
|
190
|
+
- 'spec/models/entities/contact_spec.rb'
|
|
191
|
+
- 'spec/models/entities/opportunity_spec.rb'
|
|
192
|
+
|
|
193
|
+
# Offense count: 1
|
|
194
|
+
Style/CaseEquality:
|
|
195
|
+
Exclude:
|
|
196
|
+
- 'app/models/fields/field.rb'
|
|
197
|
+
|
|
198
|
+
# Offense count: 28
|
|
199
|
+
# Cop supports --auto-correct.
|
|
200
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentOneStep, IndentationWidth.
|
|
201
|
+
# SupportedStyles: case, end
|
|
202
|
+
Style/CaseIndentation:
|
|
203
|
+
Exclude:
|
|
204
|
+
- 'app/helpers/application_helper.rb'
|
|
205
|
+
- 'app/helpers/leads_helper.rb'
|
|
206
|
+
- 'app/models/polymorphic/task.rb'
|
|
207
|
+
- 'spec/controllers/tasks_controller_spec.rb'
|
|
208
|
+
|
|
209
|
+
# Offense count: 18
|
|
210
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
211
|
+
# SupportedStyles: nested, compact
|
|
212
|
+
Style/ClassAndModuleChildren:
|
|
213
|
+
Enabled: false
|
|
214
|
+
|
|
215
|
+
# Offense count: 19
|
|
216
|
+
Style/ClassVars:
|
|
217
|
+
Exclude:
|
|
218
|
+
- 'app/models/fields/field.rb'
|
|
219
|
+
- 'app/models/observers/lead_observer.rb'
|
|
220
|
+
- 'app/models/observers/opportunity_observer.rb'
|
|
221
|
+
- 'app/models/observers/task_observer.rb'
|
|
222
|
+
- 'app/models/setting.rb'
|
|
223
|
+
- 'db/migrate/20100928030620_remove_uuid.rb'
|
|
224
|
+
- 'lib/fat_free_crm/callback.rb'
|
|
225
|
+
- 'lib/fat_free_crm/i18n.rb'
|
|
226
|
+
- 'lib/fat_free_crm/mail_processor/dropbox.rb'
|
|
227
|
+
- 'lib/fat_free_crm/tabs.rb'
|
|
228
|
+
- 'lib/fat_free_crm/view_factory.rb'
|
|
229
|
+
|
|
230
|
+
# Offense count: 27
|
|
231
|
+
# Cop supports --auto-correct.
|
|
232
|
+
Style/ClosingParenthesisIndentation:
|
|
233
|
+
Exclude:
|
|
234
|
+
- 'app/helpers/admin/application_helper.rb'
|
|
235
|
+
- 'app/helpers/application_helper.rb'
|
|
236
|
+
- 'app/helpers/leads_helper.rb'
|
|
237
|
+
- 'app/models/fields/custom_field.rb'
|
|
238
|
+
- 'lib/fat_free_crm/gem_ext/rails/engine.rb'
|
|
239
|
+
- 'spec/models/entities/contact_spec.rb'
|
|
240
|
+
- 'spec/models/entities/opportunity_spec.rb'
|
|
241
|
+
- 'spec/models/polymorphic/version_spec.rb'
|
|
242
|
+
- 'spec/views/comments/edit.js.haml_spec.rb'
|
|
243
|
+
|
|
244
|
+
# Offense count: 13
|
|
245
|
+
# Cop supports --auto-correct.
|
|
246
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly, IncludeTernaryExpressions.
|
|
247
|
+
# SupportedStyles: assign_to_condition, assign_inside_condition
|
|
248
|
+
Style/ConditionalAssignment:
|
|
249
|
+
Exclude:
|
|
250
|
+
- 'app/controllers/application_controller.rb'
|
|
251
|
+
- 'app/controllers/entities/contacts_controller.rb'
|
|
252
|
+
- 'app/controllers/entities/opportunities_controller.rb'
|
|
253
|
+
- 'app/controllers/lists_controller.rb'
|
|
254
|
+
- 'app/controllers/tasks_controller.rb'
|
|
255
|
+
- 'app/helpers/application_helper.rb'
|
|
256
|
+
- 'app/helpers/opportunities_helper.rb'
|
|
257
|
+
- 'app/models/entities/contact.rb'
|
|
258
|
+
- 'lib/fat_free_crm/permissions.rb'
|
|
259
|
+
- 'spec/spec_helper.rb'
|
|
260
|
+
- 'spec/support/macros.rb'
|
|
261
|
+
|
|
262
|
+
# Offense count: 126
|
|
263
|
+
Style/Documentation:
|
|
264
|
+
Enabled: false
|
|
265
|
+
|
|
266
|
+
# Offense count: 3
|
|
267
|
+
Style/DoubleNegation:
|
|
268
|
+
Exclude:
|
|
269
|
+
- 'app/helpers/application_helper.rb'
|
|
270
|
+
- 'app/models/polymorphic/task.rb'
|
|
271
|
+
- 'lib/gravatar_image_tag.rb'
|
|
272
|
+
|
|
273
|
+
# Offense count: 1
|
|
274
|
+
# Cop supports --auto-correct.
|
|
275
|
+
Style/EmptyCaseCondition:
|
|
276
|
+
Exclude:
|
|
277
|
+
- 'app/models/polymorphic/task.rb'
|
|
278
|
+
|
|
279
|
+
# Offense count: 10
|
|
280
|
+
# Cop supports --auto-correct.
|
|
281
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
282
|
+
# SupportedStyles: compact, expanded
|
|
283
|
+
Style/EmptyMethod:
|
|
284
|
+
Exclude:
|
|
285
|
+
- 'app/controllers/admin/fields_controller.rb'
|
|
286
|
+
- 'app/controllers/admin/settings_controller.rb'
|
|
287
|
+
- 'app/controllers/admin/tags_controller.rb'
|
|
288
|
+
- 'app/controllers/entities_controller.rb'
|
|
289
|
+
- 'db/migrate/20120216042541_is_paranoid_to_paper_trail.rb'
|
|
290
|
+
- 'db/migrate/20120316045804_activities_to_versions.rb'
|
|
291
|
+
- 'db/migrate/20121221033947_fix_country_mapping.rb'
|
|
292
|
+
|
|
293
|
+
# Offense count: 99
|
|
294
|
+
# Cop supports --auto-correct.
|
|
295
|
+
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
|
|
296
|
+
Style/ExtraSpacing:
|
|
297
|
+
Enabled: false
|
|
298
|
+
|
|
299
|
+
# Offense count: 9
|
|
300
|
+
# Cop supports --auto-correct.
|
|
301
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
|
302
|
+
# SupportedStyles: consistent, special_for_inner_method_call, special_for_inner_method_call_in_parentheses
|
|
303
|
+
Style/FirstParameterIndentation:
|
|
304
|
+
Exclude:
|
|
305
|
+
- 'lib/fat_free_crm/mail_processor/base.rb'
|
|
306
|
+
- 'spec/models/entities/contact_spec.rb'
|
|
307
|
+
- 'spec/models/entities/opportunity_spec.rb'
|
|
308
|
+
|
|
309
|
+
# Offense count: 1
|
|
310
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
311
|
+
# SupportedStyles: format, sprintf, percent
|
|
312
|
+
Style/FormatString:
|
|
313
|
+
Exclude:
|
|
314
|
+
- 'spec/factories/shared_factories.rb'
|
|
315
|
+
|
|
316
|
+
# Offense count: 473
|
|
317
|
+
# Cop supports --auto-correct.
|
|
318
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
319
|
+
# SupportedStyles: when_needed, always, never
|
|
320
|
+
Style/FrozenStringLiteralComment:
|
|
321
|
+
Enabled: false
|
|
322
|
+
|
|
323
|
+
# Offense count: 3
|
|
324
|
+
# Configuration parameters: AllowedVariables.
|
|
325
|
+
Style/GlobalVars:
|
|
326
|
+
Exclude:
|
|
327
|
+
- 'db/migrate/20100928030598_create_sessions.rb'
|
|
328
|
+
- 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
|
|
329
|
+
|
|
330
|
+
# Offense count: 44
|
|
331
|
+
# Configuration parameters: MinBodyLength.
|
|
332
|
+
Style/GuardClause:
|
|
333
|
+
Enabled: false
|
|
334
|
+
|
|
335
|
+
# Offense count: 2
|
|
336
|
+
Style/IdenticalConditionalBranches:
|
|
337
|
+
Exclude:
|
|
338
|
+
- 'app/helpers/application_helper.rb'
|
|
339
|
+
|
|
340
|
+
# Offense count: 16
|
|
341
|
+
# Cop supports --auto-correct.
|
|
342
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
343
|
+
# SupportedStyles: line_count_dependent, lambda, literal
|
|
344
|
+
Style/Lambda:
|
|
345
|
+
Exclude:
|
|
346
|
+
- 'app/models/entities/account.rb'
|
|
347
|
+
- 'app/models/entities/campaign.rb'
|
|
348
|
+
- 'app/models/entities/contact.rb'
|
|
349
|
+
- 'app/models/entities/lead.rb'
|
|
350
|
+
- 'app/models/entities/opportunity.rb'
|
|
351
|
+
- 'app/models/polymorphic/task.rb'
|
|
352
|
+
- 'app/models/users/user.rb'
|
|
353
|
+
|
|
354
|
+
# Offense count: 2
|
|
355
|
+
Style/MethodMissing:
|
|
356
|
+
Exclude:
|
|
357
|
+
- 'app/models/setting.rb'
|
|
358
|
+
- 'lib/fat_free_crm/fields.rb'
|
|
359
|
+
|
|
360
|
+
# Offense count: 2
|
|
361
|
+
# Cop supports --auto-correct.
|
|
362
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
363
|
+
# SupportedStyles: symmetrical, new_line, same_line
|
|
364
|
+
Style/MultilineArrayBraceLayout:
|
|
365
|
+
Exclude:
|
|
366
|
+
- 'app/helpers/accounts_helper.rb'
|
|
367
|
+
- 'config/initializers/views.rb'
|
|
368
|
+
|
|
369
|
+
# Offense count: 2
|
|
370
|
+
Style/MultilineBlockChain:
|
|
371
|
+
Exclude:
|
|
372
|
+
- 'lib/fat_free_crm/core_ext/string.rb'
|
|
373
|
+
- 'lib/tasks/ffcrm/demo.rake'
|
|
374
|
+
|
|
375
|
+
# Offense count: 20
|
|
376
|
+
# Cop supports --auto-correct.
|
|
377
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
378
|
+
# SupportedStyles: symmetrical, new_line, same_line
|
|
379
|
+
Style/MultilineMethodCallBraceLayout:
|
|
380
|
+
Exclude:
|
|
381
|
+
- 'app/helpers/admin/application_helper.rb'
|
|
382
|
+
- 'app/helpers/application_helper.rb'
|
|
383
|
+
- 'app/helpers/leads_helper.rb'
|
|
384
|
+
- 'app/models/fields/custom_field.rb'
|
|
385
|
+
- 'lib/fat_free_crm/gem_ext/rails/engine.rb'
|
|
386
|
+
- 'lib/fat_free_crm/mail_processor/base.rb'
|
|
387
|
+
- 'spec/models/polymorphic/version_spec.rb'
|
|
388
|
+
- 'spec/views/comments/edit.js.haml_spec.rb'
|
|
389
|
+
|
|
390
|
+
# Offense count: 2
|
|
391
|
+
# Cop supports --auto-correct.
|
|
392
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
|
393
|
+
# SupportedStyles: aligned, indented, indented_relative_to_receiver
|
|
394
|
+
Style/MultilineMethodCallIndentation:
|
|
395
|
+
Exclude:
|
|
396
|
+
- 'lib/development_tasks/license.rake'
|
|
397
|
+
- 'lib/fat_free_crm/gem_ext/rails/engine.rb'
|
|
398
|
+
|
|
399
|
+
# Offense count: 2
|
|
400
|
+
Style/MultilineTernaryOperator:
|
|
401
|
+
Exclude:
|
|
402
|
+
- 'app/models/users/authentication.rb'
|
|
403
|
+
|
|
404
|
+
# Offense count: 1
|
|
405
|
+
# Cop supports --auto-correct.
|
|
406
|
+
Style/NegatedIf:
|
|
407
|
+
Exclude:
|
|
408
|
+
- 'app/mailers/user_mailer.rb'
|
|
409
|
+
|
|
410
|
+
# Offense count: 5
|
|
411
|
+
# Cop supports --auto-correct.
|
|
412
|
+
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
|
|
413
|
+
# SupportedStyles: skip_modifier_ifs, always
|
|
414
|
+
Style/Next:
|
|
415
|
+
Exclude:
|
|
416
|
+
- 'app/helpers/application_helper.rb'
|
|
417
|
+
- 'db/migrate/20120316045804_activities_to_versions.rb'
|
|
418
|
+
- 'db/migrate/20120510025219_add_not_null_constraints_for_timestamp_columns.rb'
|
|
419
|
+
- 'lib/tasks/ffcrm/missing_translations.rake'
|
|
420
|
+
|
|
421
|
+
# Offense count: 1
|
|
422
|
+
# Cop supports --auto-correct.
|
|
423
|
+
Style/NumericLiterals:
|
|
424
|
+
MinDigits: 15
|
|
425
|
+
|
|
426
|
+
# Offense count: 10
|
|
427
|
+
# Cop supports --auto-correct.
|
|
428
|
+
# Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
|
|
429
|
+
# SupportedStyles: predicate, comparison
|
|
430
|
+
Style/NumericPredicate:
|
|
431
|
+
Exclude:
|
|
432
|
+
- 'spec/**/*'
|
|
433
|
+
- 'app/helpers/admin/users_helper.rb'
|
|
434
|
+
- 'app/helpers/application_helper.rb'
|
|
435
|
+
- 'app/helpers/campaigns_helper.rb'
|
|
436
|
+
- 'app/helpers/tasks_helper.rb'
|
|
437
|
+
- 'app/models/fields/custom_field.rb'
|
|
438
|
+
- 'app/models/polymorphic/task.rb'
|
|
439
|
+
- 'app/models/users/user.rb'
|
|
440
|
+
- 'lib/tasks/ffcrm/demo.rake'
|
|
441
|
+
|
|
442
|
+
# Offense count: 4
|
|
443
|
+
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
|
|
444
|
+
# NamePrefix: is_, has_, have_
|
|
445
|
+
# NamePrefixBlacklist: is_, has_, have_
|
|
446
|
+
# NameWhitelist: is_a?
|
|
447
|
+
Style/PredicateName:
|
|
448
|
+
Exclude:
|
|
449
|
+
- 'spec/**/*'
|
|
450
|
+
- 'app/inputs/date_time_input.rb'
|
|
451
|
+
- 'app/models/users/user.rb'
|
|
452
|
+
- 'lib/fat_free_crm/fields.rb'
|
|
453
|
+
- 'lib/fat_free_crm/mail_processor/base.rb'
|
|
454
|
+
|
|
455
|
+
# Offense count: 18
|
|
456
|
+
# Cop supports --auto-correct.
|
|
457
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
|
|
458
|
+
# SupportedStyles: slashes, percent_r, mixed
|
|
459
|
+
Style/RegexpLiteral:
|
|
460
|
+
Exclude:
|
|
461
|
+
- 'app/controllers/entities/contacts_controller.rb'
|
|
462
|
+
- 'app/controllers/entities/opportunities_controller.rb'
|
|
463
|
+
- 'app/helpers/application_helper.rb'
|
|
464
|
+
- 'app/models/list.rb'
|
|
465
|
+
- 'lib/development_tasks/license.rake'
|
|
466
|
+
- 'lib/fat_free_crm/core_ext/string.rb'
|
|
467
|
+
- 'lib/fat_free_crm/mail_processor/dropbox.rb'
|
|
468
|
+
- 'spec/helpers/application_helper_spec.rb'
|
|
469
|
+
- 'spec/helpers/users_helper_spec.rb'
|
|
470
|
+
- 'spec/lib/mail_processor/dropbox_spec.rb'
|
|
471
|
+
- 'spec/views/contacts/update.js.haml_spec.rb'
|
|
472
|
+
- 'spec/views/opportunities/update.js.haml_spec.rb'
|
|
473
|
+
|
|
474
|
+
# Offense count: 4
|
|
475
|
+
# Cop supports --auto-correct.
|
|
476
|
+
# Configuration parameters: ConvertCodeThatCanStartToReturnNil.
|
|
477
|
+
Style/SafeNavigation:
|
|
478
|
+
Exclude:
|
|
479
|
+
- 'app/controllers/tasks_controller.rb'
|
|
480
|
+
- 'app/models/observers/opportunity_observer.rb'
|
|
481
|
+
- 'db/migrate/20100928030618_add_admin_to_users.rb'
|
|
482
|
+
|
|
483
|
+
# Offense count: 9
|
|
484
|
+
# Cop supports --auto-correct.
|
|
485
|
+
# Configuration parameters: AllowAsExpressionSeparator.
|
|
486
|
+
Style/Semicolon:
|
|
487
|
+
Exclude:
|
|
488
|
+
- 'app/controllers/application_controller.rb'
|
|
489
|
+
- 'app/controllers/entities/leads_controller.rb'
|
|
490
|
+
- 'lib/fat_free_crm/permissions.rb'
|
|
491
|
+
- 'lib/tasks/ffcrm/setup.rake'
|
|
492
|
+
- 'spec/models/fields/custom_field_date_pair_spec.rb'
|
|
493
|
+
- 'spec/models/fields/custom_field_spec.rb'
|
|
494
|
+
- 'spec/support/macros.rb'
|
|
495
|
+
|
|
496
|
+
# Offense count: 2
|
|
497
|
+
# Cop supports --auto-correct.
|
|
498
|
+
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
|
|
499
|
+
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
|
|
500
|
+
Style/TrivialAccessors:
|
|
501
|
+
Exclude:
|
|
502
|
+
- 'spec/support/auth_macros.rb'
|
|
503
|
+
|
|
504
|
+
# Offense count: 12
|
|
505
|
+
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
|
506
|
+
# SupportedStyles: snake_case, normalcase, non_integer
|
|
507
|
+
Style/VariableNumber:
|
|
508
|
+
Exclude:
|
|
509
|
+
- 'spec/controllers/home_controller_spec.rb'
|
|
510
|
+
|
|
511
|
+
# Offense count: 18
|
|
512
|
+
# Cop supports --auto-correct.
|
|
513
|
+
# Configuration parameters: SupportedStyles, WordRegex.
|
|
514
|
+
# SupportedStyles: percent, brackets
|
|
515
|
+
Style/WordArray:
|
|
516
|
+
EnforcedStyle: percent
|
|
517
|
+
MinSize: 5
|