fat_fingers 0.1.22 → 0.1.23

data/lib/fat_fingers.rb

@@ -22,6 +22,7 @@ class String
     clean_up_funky_nets.
     clean_up_funky_orgs.
     clean_up_gmail.
+    clean_up_googlemail.
     clean_up_hotmail.
     clean_up_yahoo.
     clean_up_other_providers.
@@ -71,8 +72,12 @@ protected
     gsub(/\.o+g*r*g*$/, ".org") # require the o, to not false-positive .gr e-mails
   end
 
+  def clean_up_googlemail
+    gsub(/@(g(o)*)*le(n|m)*(a|i|l)+m*(a|i|k|l)*\./,"@googlemail.")
+  end
+
   def clean_up_gmail
-    gsub(/@g(n|m)*(a|i|l)+m*(a|i|l)*\./,"@gmail.")
+    gsub(/@g(n|m)*(a|i|l)+m*(a|i|k|l)*\./,"@gmail.")
   end
 
   def clean_up_hotmail
@@ -90,7 +95,7 @@ protected
   end
 
   def clean_up_known_coms
-    gsub(/(aol|gmail|hotmail|yahoo).co$/, '\1.com')
+    gsub(/(aol|googlemail|gmail|hotmail|yahoo).co$/, '\1.com')
   end
 
   def add_a_period_if_they_forgot_it

data/test/test_fat_fingers.rb

@@ -8,6 +8,7 @@ class StringTest < MiniTest::Unit::TestCase
     @good_gmail = "test@gmail.com"
     @bad_gmail = [
       "test@gmai.com",
+      "test@gmaii.com",
       "test@gmal.com",
       "test@gmaal.com",
       "test@gmil.com",
@@ -39,6 +40,28 @@ class StringTest < MiniTest::Unit::TestCase
       "test@gmail.couk"
       ]
 
+    @good_googlemail = "test@googlemail.com"
+    @bad_googlemail = [
+      "test@googlemai.com",
+      "test@googlemaii.com",
+      "test@googlemal.com",
+      "test@googlemaal.com",
+      "test@googlemil.com",
+      "test@googlemial.com",
+      "test@googlemali.com",
+      "test@googlemila.com",
+      "test@googlemaill.com",
+      "test@googleamil.com",
+      "test@googlenail.com",
+      "test@googlemailc.om",
+      "test.@googlemail.com",
+      "test.@googlemail.co",
+      "test.@gogglemaii.com",
+      "test.@gogglemail.com",
+      "test.@gogolemail.com",
+      "test.@goooglemail.com"
+      ]
+
     @good_yahoo = "test@yahoo.com"
     @bad_yahoo = [
       "test@aho.com",
@@ -245,10 +268,10 @@ class StringTest < MiniTest::Unit::TestCase
   end
 
   def cases
-    [ "gmail", "intl_gmail", "yahoo", "hotmail", "aol", "com", "net", "org", "comcast", "sbcglobal", "gm", "tld_cn", "tld_co", 
-      "random_co", "tld_gr", "tld_jp", "tld_coop", "gmail_with_dots", "gmail_with_plus", "aol_com", "att_net", "facebook_com",
-      "gmx_com", "googlemail_com", "hotmail_co_uk", "live_com", "mac_com", "mail_com", "me_com", "msn_com", "verizon_net", 
-      "yahoo_co_uk", "ymail_com", "mil"]
+    [ "aol", "aol_com", "att_net", "com", "comcast", "facebook_com", "googlemail", "gm", "gmail", "gmail_with_dots", "gmail_with_plus", 
+      "gmx_com", "googlemail_com", "hotmail", "hotmail_co_uk", "intl_gmail", "live_com", "mac_com", "mail_com", "me_com", 
+      "mil", "msn_com", "net", "org", "random_co", "sbcglobal", "tld_cn", "tld_co", "tld_coop", "tld_gr", "tld_jp", 
+      "verizon_net", "yahoo", "yahoo_co_uk", "ymail_com" ]
   end
 
   def test_that_emails_get_fixed
@@ -276,4 +299,10 @@ class StringTest < MiniTest::Unit::TestCase
     end
   end
 
+  def test_the_four_obscure_tlds_fat_fingers_doesnt_work_with
+    @tlds_fat_fingers_gets_tripped_on.each do |tld|
+      refute_equal "test@something.#{tld}", "test@something.#{tld}".clean_up_typoed_email
+    end
+  end
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fat_fingers
 version: !ruby/object:Gem::Version
-  version: 0.1.22
+  version: 0.1.23
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-12 00:00:00.000000000 Z
+date: 2014-02-16 00:00:00.000000000 Z
 dependencies: []
 description: Makes sure users don't accidentally create an account for the wrong e-mail
   address. Because 'gmial' isn't actually what they meant to type. Similarly, 'yaho.com',