fastly 2.5.2 → 2.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b75dc13044604bb40449d7fb5211800bc012b44b43ac51ea1fd443a3bd882e86
-  data.tar.gz: 540582acde735caf0786d3060b2f907bf772bac1a359165c41f8cf53244fd5f1
+  metadata.gz: ff6374dedf0a4320acb1bb370b700f31dffbb841ad039e717c9b6bd713a6cb5a
+  data.tar.gz: f53667b8fa95b6e9cf013ec23c94feee19b860c28de60aba3fee4ddd17ffaa4c
 SHA512:
-  metadata.gz: 0a6ec0d7a43e57a7e87c9489bc0d53801c03d56115dbe849b9a8a7d1a591dac3597a2d01bb511f8d6d21f1c5b2897b60addbcd91ffec99a74b736d914ca66b0c
-  data.tar.gz: 5298847912ac68c9b7a2a92323c7e8a35f0b84c4e823fec14a12f99b3bae1ae4548efb59d137887a59ef1cb60adb249aa094a56a0bc9190306ff3862e62411b2
+  metadata.gz: f3115a7e69149466f180e3d823c13ef9d4a895178a6e33e02522afa1b5551df59da7655dd3c316eba9cb0be0df2494b2b2f4a6803a2ec6b04cb8f4f1b06be11f
+  data.tar.gz: c7a1a39686da60e1986b24d7ef7d94cdba247e29117a99bed51924e23716da3dc72cc44869e1b711f75745309ff71597c165d2048fb5b43ed38fa6d0d2fc4e88

data/.env.example

@@ -0,0 +1,3 @@
+FASTLY_TEST_USER=
+FASTLY_TEST_PASSWORD=
+FASTLY_TEST_API_KEY=

data/Gemfile

@@ -11,3 +11,7 @@ group :development, :test do
   gem 'rubocop', '~> 0.57.2', require: false
   gem 'webmock'
 end
+
+group :test do
+  gem 'dotenv'
+end

data/README.md

@@ -202,15 +202,19 @@ This option should not be used in a production setting as all HTTP headers, requ
 
 ### Notes for testing
 
-The test suite requires the following `ENV` variables to be set:
+The test suite tests create and delete three services in sequence, so you may want to create an account just for these tests.
 
-* `FASTLY_TEST_USER` - Your user email
-* `FASTLY_TEST_PASSWORD` - Your account password
-* `FASTLY_TEST_API_KEY` - Your API key (found at https://app.fastly.com/#account)
+To run the test suite:
 
-While the test suite is safe to be run on all accounts and isn't harmful to your
-data, the tests will create and delete 3 services in sequence so you may want
-to create an account just for tests.
+1. Generate a personal token for these tests: https://manage.fastly.com/account/personal/tokens
+
+2. Copy `.env.example` to `.env` and add the values for the variables:
+
+  * `FASTLY_TEST_USER` - Your user email
+  * `FASTLY_TEST_PASSWORD` - Your account password
+  * `FASTLY_TEST_API_KEY` - Your personal token
+
+3. Run the tests via `bundle exec rake test:unit`
 
 ## Copyright
 

data/lib/fastly/belongs_to_service_and_version.rb

@@ -16,9 +16,9 @@ class Fastly
     end
 
     # Get the number of the Version this belongs to
-    def version_number # rubocop:disable all
-      @version
-    end # rubocop:enable all
+    def version_number
+      @version ||= nil
+    end
 
     # :nodoc:
     def as_hash

data/lib/fastly/client.rb

@@ -27,6 +27,10 @@ class Fastly
 
       return self unless fully_authed?
 
+      warn("DEPRECATION WARNING: Username/password authentication is deprecated
+      and will not be available starting September 2020;
+      please migrate to API tokens as soon as possible.")
+
       # If full auth creds (user/pass) then log in and set a cookie
       resp = http.post(
         '/login', 

data/lib/fastly/gem_version.rb

@@ -1,4 +1,4 @@
 # The current version of the library
 class Fastly
-  VERSION = "2.5.2"
+  VERSION = "2.5.3"
 end

data/lib/fastly/service.rb

@@ -2,7 +2,8 @@
 class Fastly
   # Represents something you want to serve - this can be, for example, a whole web site, a Wordpress site, or just your image servers
   class Service < Base
-    attr_accessor :id, :customer_id, :name, :comment, :versions
+    attr_accessor :id, :customer_id, :name, :comment
+    attr_writer :versions
 
     @versions = []
 

data/test/fastly/client_test.rb

@@ -12,7 +12,7 @@ describe Fastly::Client do
       }
     end
 
-    it 'does not log in if user/pass are not provided' do
+    it 'does not set the user/pass if they are not provided' do
       client = Fastly::Client.new(api_key: api_key)
 
       assert_equal api_key, client.api_key
@@ -29,6 +29,13 @@ describe Fastly::Client do
       assert_equal "Invalid auth credentials. Check username/password.", e.message
     end
 
+    it 'surfaces a deprecation message when a username or password is provided' do
+      stub_request(:any, /api.fastly.com/).
+        to_return(body: JSON.generate(i: "dont care"), status: 200)
+
+      assert_output('', /DEPRECATION WARNING:/) { Fastly::Client.new(user: user, password: pass) }
+    end
+
     it 'initializes an http client' do
       client = Fastly::Client.new(api_key: api_key)
 

data/test/helper.rb

@@ -2,6 +2,7 @@ require 'common'
 require 'fastly'
 require 'minitest/autorun'
 require 'pry'
+require 'dotenv/load'
 
 class Fastly
   class TestCase < Minitest::Test; end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastly
 version: !ruby/object:Gem::Version
-  version: 2.5.2
+  version: 2.5.3
 platform: ruby
 authors:
 - Fastly
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-10 00:00:00.000000000 Z
+date: 2020-06-09 00:00:00.000000000 Z
 dependencies: []
 description: Client library for the Fastly acceleration system
 email:
@@ -21,6 +21,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".env.example"
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
@@ -109,8 +110,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Client library for the Fastly acceleration system