fastlane_core 0.5.2 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c7558dcc162c851329311ec25d8157718a58487
-  data.tar.gz: 4bb9549d6060d3518f835955b0f725b6bdc581be
+  metadata.gz: 06327f198e2394586d0a6dd85ea74c828e9a75e0
+  data.tar.gz: a6d15a06e21bd123ce34a704f294fa8b1bbb28e7
 SHA512:
-  metadata.gz: ee70b2aac81876ea582d9ede3ac183267c077d46c20dc4710b0e6b66e3631d28501377ae1a3072f58f193dcc20a8b3a13e96d77c48471aa2216da18733d6e1fe
-  data.tar.gz: c9f8d64c2c2bd22a687611a5113d0ff389523cdd11b8e863b6834200c1caac6ef8d16ee52c2835ba077c50b6df252939ff3edcefe859c2eb43285de91c032780
+  metadata.gz: 233efb9872b290d7e26d954aa8ba617693c30e3a082842fdcc3aaf4071191feb151780c475ac81fdd313e120faad316538f98ba58a01c1d1967da74688b59051
+  data.tar.gz: 59b492002c6ad95ba8619bd13bb6d80f221e1d38fe7ecb03dca6993299c73fc4638c2b89f59efd661c1f4968bc0d4654829ce445da0b3897e3e02881612c0322

data/lib/fastlane_core/configuration.rb

@@ -9,8 +9,12 @@ module FastlaneCore
 
     # Setting up
 
+    def values
+      @values
+    end
+
     def initialize(available_options, values)
-      @available_options = available_options
+      @available_options = available_options || []
       @values = values || {}
 
       verify_input_types      
@@ -19,9 +23,9 @@ module FastlaneCore
     end
 
     def verify_input_types
-      raise "available_options parameter must be an array of ConfigItems".red unless @available_options.kind_of?Array
+      raise "available_options parameter must be an array of ConfigItems but is #{@available_options.class}".red unless @available_options.kind_of?Array
       @available_options.each do |item|
-        raise "available_options parameter must be an array of ConfigItems".red unless item.kind_of?ConfigItem
+        raise "available_options parameter must be an array of ConfigItems. Found #{item.class}.".red unless item.kind_of?ConfigItem
       end
       raise "values parameter must be a hash".red unless @values.kind_of?Hash
     end
@@ -33,7 +37,7 @@ module FastlaneCore
         if option
           option.verify!(value) # Call the verify block for it too
         else
-          raise "Could not find available option '#{key}' in the list of available options #{@available_options.collect { |a| a.key }}".red
+          raise "Could not find available option '#{key}' in the list of available options: #{@available_options.collect { |a| a.key }.join(', ')}".red
         end
       end
     end
@@ -58,11 +62,11 @@ module FastlaneCore
       raise "Key '#{key}' must be a symbol. Example :app_id.".red unless key.kind_of?Symbol
 
       option = option_for_key(key)
-      raise "Could not find option for key :#{key}. Available keys: #{@available_options.collect { |a| a.key }}".red unless option
+      raise "Could not find option for key :#{key}. Available keys: #{@available_options.collect { |a| a.key }.join(', ')}".red unless option
 
       # `if value == nil` instead of ||= because false is also a valid value
 
-      value ||= @values[key]
+      value = @values[key]
       # TODO: configuration files
 
       if value == nil
@@ -71,9 +75,22 @@ module FastlaneCore
       end
 
       value = option.default_value if value == nil
-      value = false if (value == nil and not option.is_string) # by default boolean flags are false
+      value = nil if (value == nil and not option.is_string) # by default boolean flags are false
+
+      return value unless value.nil? # we already have a value
+      return value if option.optional # as this value is not required, just return what we have
+      
 
-      while value == nil and !option.optional
+      if Helper.is_test?
+        # Since we don't want to be asked on tests, we'll just call the verify block with no value
+        # to raise the exception that is shown when the user passes an invalid value
+        set(key, '')
+        # If this didn't raise an exception, just raise a default one
+        raise "No value found for '#{key}'"
+      end
+
+      while value == nil
+        Helper.log.info "To not be asked about this value, you can specify it using '#{option.key}'".yellow
         value = ask("#{option.description}: ")
         # Also store this value to use it from now on
         begin
@@ -89,11 +106,11 @@ module FastlaneCore
 
     # Overwrites or sets a new value for a given key
     def set(key, value)
-      raise "Key '#{key}' must be a symbol. Example :app_id.".red unless key.kind_of?Symbol
+      raise "Key '#{key}' must be a symbol. Example :#{key}.".red unless key.kind_of?Symbol
       option = option_for_key(key)
       
       unless option
-        raise "Could not find available option '#{key}' in the list of !available options #{@available_options.collect { |a| a.key }}".red
+        raise "Could not find available option '#{key}' in the list of available options #{@available_options.collect { |a| a.key }.join(', ')}".red
       end
 
       option.verify!(value)
@@ -109,5 +126,6 @@ module FastlaneCore
 
     # Aliases `[key]` to `fetch(key)` because Ruby can do it.
     alias_method :[], :fetch
+    alias_method :[]=, :set
   end
 end

data/lib/fastlane_core/configuration/config_item.rb

@@ -11,7 +11,7 @@ module FastlaneCore
     # @param verify_block an optional block which is called when a new value is set. 
     #   Check value is valid. This could be type checks or if a folder/file exists
     #   You have to raise a specific exception if something goes wrong. Append .red after the string
-    # @param is_string (String) is that parameter a string?
+    # @param is_string (String) is that parameter a string? Defaults to true. If it's true, the type string will be verified.
     # @param optional (Boolean) is false by default. If set to true, also string values will not be asked to the user
     def initialize(key: nil, env_name: nil, description: nil, short_option: nil, default_value: nil, verify_block: nil, is_string: true, optional: false)
       raise "key must be a symbol" unless key.kind_of?Symbol
@@ -46,7 +46,7 @@ module FastlaneCore
       # we also allow nil values, which do not have to be verified. 
       if value
         if @is_string
-          raise "Please pass a path as String".red unless value.kind_of?String
+          raise "'#{self.key}' value must be a String!".red unless value.kind_of?String
         end
         
         if @verify_block

data/lib/fastlane_core/developer_center/developer_center_login.rb

@@ -54,7 +54,7 @@ module FastlaneCore
           if page.has_content?"Getting Started"
             raise "There was no valid signing certificate found. Please log in and follow the 'Getting Started guide' on '#{current_url}'".red
           else
-            raise DeveloperCenterLoginError.new("Error logging in user #{user} with the given password. Make sure you entered them correctly.")
+            raise DeveloperCenterLoginError.new("Error logging in user #{user} with the given password. Make sure you entered them correctly.".red)
           end
         end
 

data/lib/fastlane_core/itunes_connect/itunes_connect_login.rb

@@ -44,11 +44,11 @@ module FastlaneCore
         if page.has_content?"My Apps"
           # Everything looks good
         else
-          raise ItunesConnectLoginError.new("Looks like your login data was correct, but you do not have access to the apps.")
+          raise ItunesConnectLoginError.new("Looks like your login data was correct, but you do not have access to the apps.".red)
         end
       rescue => ex
         Helper.log.debug(ex)
-        raise ItunesConnectLoginError.new("Error logging in user #{user} with the given password. Make sure you entered them correctly.")
+        raise ItunesConnectLoginError.new("Error logging in user #{user} with the given password. Make sure you entered them correctly.".red)
       end
 
       Helper.log.info "Successfully logged into iTunesConnect"

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.5.2"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.6.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-12 00:00:00.000000000 Z
+date: 2015-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -249,7 +249,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.19.0
 - !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '>='