fastlane_core 0.43.5 → 0.44.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d2cd4f07e96bad3ee1da04c0e795fd56096f11c6
-  data.tar.gz: 6361ce6d0c84c064053eadca611d8ee03283d65c
+  metadata.gz: 6b3c9145a7514244cbfa62bb7e5bd0e847cad507
+  data.tar.gz: e3ae44d5d71b41e1b5a22fbaf7c89314e3b96e8d
 SHA512:
-  metadata.gz: 4d982e332e6ab720791ad26a9c84bac4d103949b30620e5aaa83f0d880380fb88e07214ee2a006debcc73639f0c1f89d337c9c34c267383bf7998e0b1203041f
-  data.tar.gz: 9f5f0f5a43cd5710200fdd79ff61aa9ac7f76cf87407caaf851ce8ae6a6f11fbff9c6c7bd7e31954f2d468ee0d114dfc4afad237c75aacdc775e3481f36da552
+  metadata.gz: f504183fcc913e355b1677b5c62503d4418a92ccf5d763e9abee082f491cd4c9ac8acd56447f8b6c49d5b9e99b1c18ef5d7dc897915a87bd586c7d7964876cde
+  data.tar.gz: 2c13bc156f3872ae92ed8c998009f09cd7fc437e2d93654ceb260b487435d56711fcd60928ccae3fc243dc0fbebd5a7d1a784c0ad0567f9c9e85de49fd3680b4

data/lib/fastlane_core.rb

@@ -21,7 +21,6 @@ require 'fastlane_core/ipa_upload_package_builder'
 require 'fastlane_core/print_table'
 require 'fastlane_core/project'
 require 'fastlane_core/device_manager'
-require 'fastlane_core/crash_reporting/crash_reporting'
 require 'fastlane_core/ui/ui'
 require 'fastlane_core/tool_collector'
 

data/lib/fastlane_core/cert_checker.rb

@@ -49,7 +49,7 @@ module FastlaneCore
     def self.wwdr_certificate_installed?
       certificate_name = "Apple Worldwide Developer Relations Certification Authority"
       keychain = wwdr_keychain
-      response = Helper.backticks("security find-certificate -c '#{certificate_name}' #{keychain}", print: $verbose)
+      response = Helper.backticks("security find-certificate -c '#{certificate_name}' #{keychain.shellescape}", print: $verbose)
       return response.include?("attributes:")
     end
 
@@ -59,7 +59,7 @@ module FastlaneCore
         filename = File.basename(url)
         keychain = wwdr_keychain
         keychain.prepend("-k ") unless keychain.empty?
-        `curl -O #{url} && security import #{filename} #{keychain}`
+        Helper.backticks("curl -O #{url} && security import #{filename} #{keychain.shellescape}", print: $verbose)
         UI.user_error!("Could not install WWDR certificate") unless $?.success?
       end
     end

data/lib/fastlane_core/configuration/configuration_file.rb

@@ -13,10 +13,10 @@ module FastlaneCore
 
       # From https://github.com/orta/danger/blob/master/lib/danger/Dangerfile.rb
       if content.tr!('“”‘’‛', %(""'''))
-        Helper.log.error "Your #{File.basename(path)} has had smart quotes sanitised. " \
-                    'To avoid issues in the future, you should not use ' \
-                    'TextEdit for editing it. If you are not using TextEdit, ' \
-                    'you should turn off smart quotes in your editor of choice.'.red
+        UI.error("Your #{File.basename(path)} has had smart quotes sanitised. " \
+                  'To avoid issues in the future, you should not use ' \
+                  'TextEdit for editing it. If you are not using TextEdit, ' \
+                  'you should turn off smart quotes in your editor of choice.')
       end
 
       begin

data/lib/fastlane_core/device_manager.rb

@@ -9,7 +9,7 @@ module FastlaneCore
       end
 
       def simulators(requested_os_type = "")
-        UI.message("Fetching available simulator devices") if $verbose
+        UI.verbose("Fetching available simulator devices")
 
         @devices = []
         os_type = 'unknown'
@@ -42,7 +42,7 @@ module FastlaneCore
       end
 
       def connected_devices(requested_os_type)
-        Helper.log.info "Fetching available connected devices" if $verbose
+        UI.verbose("Fetching available connected devices")
 
         device_types = if requested_os_type == "tvOS"
                          ["AppleTV"]
@@ -84,7 +84,7 @@ module FastlaneCore
               match = instruments_device.match(/(.+) \(([0-9.]+)\) \[([0-9a-f]+)\]?/)
               if match && match[3] == device_uuid
                 devices << Device.new(name: match[1], udid: match[3], os_version: match[2], state: "Booted", is_simulator: false)
-                Helper.log.info "USB Device Found - \"" + match[1] + "\" (" + match[2] + ") UUID:" + match[3] if $verbose
+                UI.verbose("USB Device Found - \"" + match[1] + "\" (" + match[2] + ") UUID:" + match[3])
               end
             end
           end
@@ -95,7 +95,7 @@ module FastlaneCore
 
       # The code below works from Xcode 7 on
       # def all
-      #   UI.message("Fetching available devices") if $verbose
+      #   UI.verbose("Fetching available devices")
 
       #   @devices = []
       #   output = ''

data/lib/fastlane_core/helper.rb

@@ -2,48 +2,7 @@ require 'logger'
 require 'colored'
 
 module FastlaneCore
-  # rubocop:disable Metrics/ModuleLength
   module Helper
-    # Logging happens using this method
-    def self.log
-      $stdout.sync = true
-
-      if is_test?
-        @log ||= Logger.new(nil) # don't show any logs when running tests
-      else
-        @log ||= Logger.new($stdout)
-      end
-
-      @log.formatter = proc do |severity, datetime, progname, msg|
-        string = "#{severity} [#{datetime.strftime('%Y-%m-%d %H:%M:%S.%2N')}]: " if $verbose
-        string = "[#{datetime.strftime('%H:%M:%S')}]: " unless $verbose
-        second = "#{msg}\n"
-
-        if severity == "DEBUG"
-          string = string.magenta
-        elsif severity == "INFO"
-          string = string.white
-        elsif severity == "WARN"
-          string = string.yellow
-        elsif severity == "ERROR"
-          string = string.red
-        elsif severity == "FATAL"
-          string = string.red.bold
-        end
-
-        [string, second].join("")
-      end
-
-      @log
-    end
-
-    # This method can be used to add nice lines around the actual log
-    # Use this to log more important things
-    # The logs will be green automatically
-    def self.log_alert(text)
-      UI.header(text)
-    end
-
     # Runs a given command using backticks (`)
     # and prints them out using the UI.command method
     def self.backticks(command, print: true)
@@ -178,5 +137,4 @@ module FastlaneCore
       end
     end
   end
-  # rubocop:enable Metrics/ModuleLength
 end

data/lib/fastlane_core/tool_collector.rb

@@ -25,34 +25,33 @@ module FastlaneCore
     end
 
     def did_launch_action(name)
-      name = name.to_sym
+      name = name_to_track(name.to_sym)
+      return unless name
 
-      if is_official?(name)
-        launches[name] += 1
-        versions[name] ||= determine_version(name)
-      end
+      launches[name] += 1
+      versions[name] ||= determine_version(name)
     end
 
     # Call when the problem is a caught/controlled exception (e.g. via UI.user_error!)
     def did_raise_error(name)
-      name = name.to_sym
-      if is_official?(name)
-        @error = name
-        # Don't write to the @crash field so that we can distinguish this exception later
-        # as being controlled
-      end
+      name = name_to_track(name.to_sym)
+      return unless name
+
+      @error = name
+      # Don't write to the @crash field so that we can distinguish this exception later
+      # as being controlled
     end
 
     # Call when the problem is an uncaught/uncontrolled exception (e.g. via UI.crash!)
     def did_crash(name)
-      name = name.to_sym
-      if is_official?(name)
-        # Write to the @error field to maintain the historical behavior of the field, so
-        # that the server gets the same data in that field from old and new clients
-        @error = name
-        # Also specifically note that this exception was uncontrolled in the @crash field
-        @crash = true
-      end
+      name = name_to_track(name.to_sym)
+      return unless name
+
+      # Write to the @error field to maintain the historical behavior of the field, so
+      # that the server gets the same data in that field from old and new clients
+      @error = name
+      # Also specifically note that this exception was uncontrolled in the @crash field
+      @crash = true
     end
 
     def did_finish
@@ -113,10 +112,19 @@ module FastlaneCore
       @versions ||= {}
     end
 
+    # Override this in subclasses
     def is_official?(name)
       return true
     end
 
+    # Returns nil if we shouldn't track this action
+    # Returns a (maybe modified) name that should be sent to the enhancer web service
+    # Modificiation is used to prefix the action name with the name of the plugin
+    def name_to_track(name)
+      return nil unless is_official?(name)
+      name
+    end
+
     def did_show_message?
       path = File.join(File.expand_path('~'), '.did_show_opt_info')
       did_show = File.exist?(path)

data/lib/fastlane_core/ui/fastlane_runner.rb

@@ -61,7 +61,6 @@ module Commander
         error_info = error_info.join("\n\t") if error_info.kind_of?(Array)
         display_user_error!(e, error_info)
       else
-        FastlaneCore::CrashReporting.handle_crash(e)
         # From https://stackoverflow.com/a/4789702/445598
         # We do this to make the actual error message red and therefore more visible
         reraise_formatted!(e, e.message)

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.43.5".freeze
+  VERSION = "0.44.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.43.5
+  version: 0.44.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-13 00:00:00.000000000 Z
+date: 2016-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -150,20 +150,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.4.5
-- !ruby/object:Gem::Dependency
-  name: sentry-raven
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.15'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.15'
 - !ruby/object:Gem::Dependency
   name: credentials_manager
   requirement: !ruby/object:Gem::Requirement
@@ -356,8 +342,6 @@ files:
 - lib/fastlane_core/configuration/configuration.rb
 - lib/fastlane_core/configuration/configuration_file.rb
 - lib/fastlane_core/core_ext/string.rb
-- lib/fastlane_core/crash_reporting/clean_stack_trace.rb
-- lib/fastlane_core/crash_reporting/crash_reporting.rb
 - lib/fastlane_core/device_manager.rb
 - lib/fastlane_core/helper.rb
 - lib/fastlane_core/ipa_file_analyser.rb
@@ -401,7 +385,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.2
+rubygems_version: 2.4.0
 signing_key: 
 specification_version: 4
 summary: Contains all shared code/dependencies of the fastlane.tools

data/lib/fastlane_core/crash_reporting/clean_stack_trace.rb

@@ -1,18 +0,0 @@
-module Raven
-  # This class gets rid of the user folder, as we don't want to share the username
-  class Processor
-    class CleanStackTrace < Processor
-      def process(value)
-        if value[:exception]
-          value[:exception][:values].each do |single_exception|
-            single_exception[:stacktrace][:frames].each do |current|
-              current[:abs_path].gsub!(Dir.home, "~")
-            end
-          end
-        end
-
-        return value
-      end
-    end
-  end
-end

data/lib/fastlane_core/crash_reporting/crash_reporting.rb

@@ -1,85 +0,0 @@
-module FastlaneCore
-  class CrashReporting
-    URL = 'https://02c6a8be5bd4425389706655f3657f5c:de62aa2bffe643948ea6f81354adb8d6@app.getsentry.com/55281'
-    class << self
-      def file_path
-        File.expand_path(File.join('~/.fastlane_crash_reporting'))
-      end
-
-      def enable
-        File.write(file_path, "1")
-        puts "Successfully enabled crash reporting.".green
-        puts "This will only send a stack trace for installed gems to Sentry.".green
-        puts "Thanks for improving fastlane!".green
-      end
-
-      def disable
-        File.delete(file_path) if File.exist?(file_path)
-        puts "Disabled crash reporting :("
-      end
-
-      def enabled?
-        File.exist?(file_path)
-      end
-
-      def show_message
-        puts "-------------------------------------------------------------------------------------------".yellow
-        puts "😨  An error occured. Please enable crash reports using `fastlane enable_crash_reporting`.".yellow
-        puts "👍  This makes resolving issues much easier and helps improve fastlane.".yellow
-        puts "🔒  The reports will be stored securely on getsentry.com.".yellow
-        puts "🙊  More information about privacy: https://github.com/fastlane/fastlane/releases/tag/1.33.3".yellow
-        puts "-------------------------------------------------------------------------------------------".yellow
-      end
-
-      # Ask the user politely if they want to send crash reports
-      def ask_during_setup
-        return if enabled?
-
-        puts "-------------------------------------------------------------------------------------------".yellow
-        puts "😃  Enable crash reporting when fastlane experiences a problem?".yellow
-        puts "👍  This makes resolving issues much easier and helps improve fastlane.".yellow
-        puts "🔒  The reports will be stored securely on getsentry.com".yellow
-        puts "🙊  More information about privacy: https://github.com/fastlane/fastlane/releases/tag/1.33.3".yellow
-        puts "🌴  You can always disable crash reports at anytime `fastlane disable_crash_reporting`".yellow
-        puts "-------------------------------------------------------------------------------------------".yellow
-        if agree("Do you want to enable crash reporting? (y/n) ", true)
-          enable
-        end
-      end
-
-      def handle_crash(ex)
-        unless enabled?
-          show_message
-          return
-        end
-
-        raise ex if Helper.test?
-        send_crash(ex)
-      end
-
-      def send_crash(ex)
-        # https://github.com/getsentry/raven-ruby/wiki/Advanced-Configuration
-        require 'raven'
-        require 'json'
-        require 'fastlane_core/crash_reporting/clean_stack_trace'
-
-        Raven.configure do |config|
-          config.dsn = URL
-          config.logger = Logger.new('/dev/null') # we couldn't care less
-          config.sanitize_fields = %w(server_name)
-          config.processors << Raven::Processor::CleanStackTrace
-        end
-
-        Raven::Context.clear! # we don't want to transfer things like the host name
-        crash = Raven.capture_exception(ex)
-        path = "/tmp/sentry_#{crash.id}.json"
-        File.write(path, JSON.pretty_generate(crash.to_hash))
-        puts "Successfully submitted a crash report. If this is a problem with one of the tools specifically,".yellow
-        puts "please submit an issue on GitHub and attach the following number to it: '#{crash.id}'".yellow
-        puts "The crash report has been stored locally '#{path}'".yellow
-      rescue => e
-        UI.verbose(e) # We don't want crash reporting to cause crash
-      end
-    end
-  end
-end