fastlane_core 0.36.3 → 0.36.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b86515eea2d9c5c11d0985eb367f21be0af8b131
-  data.tar.gz: b077eea2066f2518c8c22a797cba3b9a25b4644e
+  metadata.gz: 4e2c535c84cb619841394b78023c7cc4121bd03b
+  data.tar.gz: 3985ca325cde24611e05c0213e88ff7ace61c7a5
 SHA512:
-  metadata.gz: f343c86830f6cec3ae0a49e411ec28f143c5006858ddf3a11bd40b903ec4ba2950b27afc008db7b1cca7d7037b79fdad4177e30c368c93f0b3bde822f02166a2
-  data.tar.gz: 77a6b3c0150984e82dc73c7910518a86aec5705f8df4a46cc6652069f87530164a5f9c0a5069865f85b4b941dd1c22ffc0129ce5aabcc93802ded9da3b66c7b2
+  metadata.gz: ddb2912bdc782cb80a30d5d74371bf7f0097326b61f9ebe234eec04439c8e050819bbdd8d9742c1551bf8a7641691c08c8227604ff96551c2d2341003d336718
+  data.tar.gz: 79cb6475c69d1d75aeadb0f8eeaa399a19a215513dfcefaf0496b1cd6d571f1c6725e3f54667a43226d5223f114ef7558d59db4e441c7a8f2481d1e9c5718eea

data/lib/fastlane_core/itunes_transporter.rb

@@ -193,7 +193,7 @@ module FastlaneCore
         '"' + Helper.transporter_path + '"',
         "-m lookupMetadata",
         "-u \"#{username}\"",
-        "-p '#{escaped_password(password)}'",
+        "-p #{shell_escaped_password(password)}",
         "-apple_id #{apple_id}",
         "-destination '#{destination}'"
       ].join(' ')
@@ -204,7 +204,7 @@ module FastlaneCore
         '"' + Helper.transporter_path + '"',
         "-m upload",
         "-u \"#{username}\"",
-        "-p '#{escaped_password(password)}'",
+        "-p #{shell_escaped_password(password)}",
         "-f '#{source}'",
         ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"], # that's here, because the user might overwrite the -t option
         "-t 'Signiant'",
@@ -212,8 +212,19 @@ module FastlaneCore
       ].join(' ')
     end
 
-    def escaped_password(password)
-      Shellwords.escape(password)
+    def shell_escaped_password(password)
+      # because the shell handles passwords with single-quotes incorrectly, use gsub to replace ShellEscape'd single-quotes of this form:
+      #    \'
+      # with a sequence that wraps the escaped single-quote in double-quotes:
+      #    '"\'"'
+      # this allows us to properly handle passwords with single-quotes in them
+      # we use the 'do' version of gsub, because two-param version interprets the replace text as a pattern and does the wrong thing
+      password = Shellwords.escape(password).gsub("\\'") do
+        "'\"\\'\"'"
+      end
+
+      # wrap the fully-escaped password in single quotes, since the transporter expects a escaped password string (which must be single-quoted for the shell's benefit)
+      "'" + password + "'"
     end
   end
 end

data/lib/fastlane_core/update_checker/update_checker.rb

@@ -68,7 +68,10 @@ module FastlaneCore
       url = UPDATE_URL + gem_name
       params = {}
       params["ci"] = "1" if Helper.is_ci?
-      params["p_hash"] = p_hash if p_hash
+
+      project_hash = p_hash
+      params["p_hash"] = project_hash if project_hash
+
       url += "?" + URI.encode_www_form(params) if params.count > 0
       return url
     end
@@ -94,7 +97,15 @@ module FastlaneCore
       return nil if ENV["FASTLANE_OPT_OUT_USAGE"]
       require 'credentials_manager'
       value = CredentialsManager::AppfileConfig.try_fetch_value(:app_identifier)
-      return Digest::SHA256.hexdigest("p" + value + "fastlan3_SAlt") if value # hashed + salted the bundle identifier
+      unless value
+        value = CredentialsManager::AppfileConfig.try_fetch_value(:package_name)
+        value = "android_project_#{value}" if value # if the iOS and Android app share the same app identifier
+      end
+
+      if value
+        return Digest::SHA256.hexdigest("p#{value}fastlan3_SAlt") # hashed + salted the bundle identifier
+      end
+
       return nil
     rescue
       return nil

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.36.3"
+  VERSION = "0.36.4"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.36.3
+  version: 0.36.4
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-11 00:00:00.000000000 Z
+date: 2016-02-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -384,7 +384,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.0
 signing_key: 
 specification_version: 4
 summary: Contains all shared code/dependencies of the fastlane.tools