fastlane_core 0.9.2 → 0.10.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a48aa42d30f71cc7c58d5d68c67490a38bfb8de
-  data.tar.gz: 3eee24f17bccfa4027c22789a43cb6fa5acd4463
+  metadata.gz: f8b0ac651f60fbd9ab9eda7a9842a524de056726
+  data.tar.gz: 25b61598ef0442e59fb1f3356f1ef9935dd8a780
 SHA512:
-  metadata.gz: 070d7472451929a304fd66af537435af89245197529ebc258d76ecbcf26df9653d7e61baca02af94b7e025f3b8ae205f5413d6e1143852271c8c8628c393fd79
-  data.tar.gz: c444b6ceab4590c0b53d962cf411126247560fdc863d8852b5afdb8df0380df506590b470d1751611efd3e39dd410c877cbc3c0f407c8e522757fb6e56c3528f
+  metadata.gz: 12022fab57b9c45321648fbe1493e59ed605829af2bd75eb3067f32ad5b37e834cd3f74baef12c95164f9f8cccf39ffe58c83df9f955ce33c9a524f30e8ec6b4
+  data.tar.gz: a53ebc857fead387a86b07385772121d705f77ce929513bcfc74a2c9df9bec5ceee30b052f622507520c144b8ed37b6b3cdb79493c2def2f7ed0bac8ff778e17

data/lib/fastlane_core.rb

@@ -6,6 +6,8 @@ require 'fastlane_core/update_checker'
 require 'fastlane_core/languages'
 require 'fastlane_core/itunes_search_api'
 require 'fastlane_core/cert_checker'
+require 'fastlane_core/ipa_file_analyser'
+require 'fastlane_core/itunes_transporter'
 
 # Third Party code
 require 'colored'

data/lib/fastlane_core/ipa_file_analyser.rb

@@ -0,0 +1,46 @@
+require 'zip'
+
+module FastlaneCore
+  class IpaFileAnalyser
+
+    # Fetches the app identifier (e.g. com.facebook.Facebook) from the given ipa file.
+    def self.fetch_app_identifier(path)
+      plist = IpaFileAnalyser.fetch_info_plist_file(path)
+      return plist['CFBundleIdentifier'] if plist
+      return nil
+    end
+
+    # Fetches the app version from the given ipa file.
+    def self.fetch_app_version(path)
+      plist = IpaFileAnalyser.fetch_info_plist_file(path)
+      return plist['CFBundleShortVersionString'] if plist
+      return nil
+    end
+
+    def self.fetch_info_plist_file(path)
+      Zip::File.open(path) do |zipfile|
+        zipfile.each do |file|
+          if file.name.include?'.plist' and not ['.bundle', '.framework'].any? { |a| file.name.include?a }
+            # We can not be completely sure, that's the correct plist file, so we have to try
+            begin
+              # The XML file has to be properly unpacked first
+              tmp_path = "/tmp/deploytmp.plist"
+              File.write(tmp_path, zipfile.read(file))
+              system("plutil -convert xml1 #{tmp_path}")
+              result = Plist::parse_xml(tmp_path)
+              File.delete(tmp_path)
+
+              if result['CFBundleIdentifier'] or result['CFBundleVersion']
+                return result
+              end
+            rescue
+              # We don't really care, look for another XML file
+            end
+          end
+        end
+      end
+
+      nil
+    end
+  end
+end

data/lib/fastlane_core/itunes_transporter.rb

@@ -0,0 +1,208 @@
+require 'pty'
+require 'shellwords'
+require 'credentials_manager/password_manager'
+
+
+module FastlaneCore
+  # The TransporterInputError occurs when you passed wrong inputs to the {Deliver::ItunesTransporter}
+  class TransporterInputError < StandardError
+  end
+  # The TransporterTransferError occurs when some error happens
+  # while uploading or downloading something from/to iTC
+  class TransporterTransferError < StandardError
+  end
+
+  class ItunesTransporter
+    ERROR_REGEX = />\s*ERROR:\s+(.+)/
+    WARNING_REGEX = />\s*WARN:\s+(.+)/
+    OUTPUT_REGEX = />\s+(.+)/
+    RETURN_VALUE_REGEX = />\sDBG-X:\sReturning\s+(\d+)/
+
+    SKIP_ERRORS = [ "ERROR: An exception has occurred: Scheduling automatic restart in 1 minute" ]
+
+    private_constant :ERROR_REGEX, :WARNING_REGEX, :OUTPUT_REGEX, :RETURN_VALUE_REGEX, :SKIP_ERRORS
+
+    # This will be called from the Deliverfile, and disables the logging of the transporter output
+    def self.hide_transporter_output
+      @@hide_transporter_output = true
+
+      @@hide_transporter_output = false if $verbose
+    end
+
+    # Returns a new instance of the iTunesTransporter.
+    # If no username or password given, it will be taken from
+    # the #{CredentialsManager::PasswordManager}
+    def initialize(user = nil, password = nil)
+      @user = (user || CredentialsManager::PasswordManager.shared_manager.username)
+      @password = (password || CredentialsManager::PasswordManager.shared_manager.password)
+    end
+
+    # Downloads the latest version of the app metadata package from iTC.
+    # @param app_id [Integer] The unique App ID
+    # @param dir [String] the path in which the package file should be stored
+    # @return (Bool) True if everything worked fine
+    # @raise [Deliver::TransporterTransferError] when something went wrong
+    #   when transfering
+    def download(app_id, dir = nil)
+      dir ||= "/tmp"
+
+      Helper.log.info "Going to download app metadata from iTunesConnect"
+      command = build_download_command(@user, @password, app_id, dir)
+      Helper.log.debug build_download_command(@user, 'YourPassword', app_id, dir) if $verbose
+
+      result = execute_transporter(command)
+
+      itmsp_path = File.join(dir, "#{app_id}.itmsp")
+      if result and File.directory?itmsp_path
+        Helper.log.info "Successfully downloaded the latest package from iTunesConnect.".green
+      else
+        unless /^[0-9a-zA-Z\.\$\_]*$/ === @password
+          Helper.log.error "Password contains special characters, which may not be handled properly by iTMSTransporter. If you experience problems uploading to iTunes Connect, please consider changing your password to something with only alphanumeric characters."
+        end
+        Helper.log.fatal "Could not download metadata from iTunes Connect! It's probably related to your password or your internet connection."
+      end
+
+      result
+    end
+
+    # Uploads the modified package back to iTunesConnect
+    # @param app_id [Integer] The unique App ID
+    # @param dir [String] the path in which the package file is located
+    # @return (Bool) True if everything worked fine
+    # @raise [Deliver::TransporterTransferError] when something went wrong
+    #   when transfering
+    def upload(app_id, dir)
+      dir = File.join(dir, "#{app_id}.itmsp")
+
+      Helper.log.info "Going to upload updated app to iTunesConnect"
+      Helper.log.info "This might take a few minutes, please don't interrupt the script".green
+
+      command = build_upload_command(@user, @password, dir)
+      Helper.log.debug build_upload_command(@user, 'YourPassword', dir) if $verbose
+
+      result = execute_transporter(command)
+
+      if result
+        Helper.log.info(("-" * 102).green)
+        Helper.log.info("Successfully uploaded package to iTunesConnect. It might take a few minutes until it's visible online.".green)
+        Helper.log.info(("-" * 102).green)
+
+        FileUtils.rm_rf(dir) unless Helper.is_test? # we don't need the package any more, since the upload was successful
+      end
+
+      result
+    end
+
+    private
+      def execute_transporter(command)
+        @errors = []
+        @warnings = []
+
+        if defined?@@hide_transporter_output
+          # Show a one time message instead
+          Helper.log.info "Waiting for iTunes Connect transporter to be finished.".green
+          Helper.log.info "iTunes Transporter progress... this might take a few minutes...".green
+        end
+
+        begin
+          PTY.spawn(command) do |stdin, stdout, pid|
+            stdin.each do |line|
+              parse_line(line) # this is where the parsing happens
+            end
+          end
+        rescue => ex
+          Helper.log.fatal(ex.to_s)
+          @errors << ex.to_s
+        end
+
+        if @warnings.count > 0
+          Helper.log.warn(@warnings.join("\n"))
+        end
+
+        if @errors.count > 0
+          Helper.log.error(@errors.join("\n"))
+          return false
+        end
+
+        true
+      end
+
+      def parse_line(line)
+        # Taken from https://github.com/sshaw/itunes_store_transporter/blob/master/lib/itunes/store/transporter/output_parser.rb
+
+        output_done = false
+
+        re = Regexp.union(SKIP_ERRORS)
+        if line.match(re)
+          # Those lines will not be handle like errors or warnings
+
+        elsif line =~ ERROR_REGEX
+          @errors << $1
+          Helper.log.error "[Transporter Error Output]: #{$1}".red
+
+          # Check if it's a login error
+          if $1.include?"Your Apple ID or password was entered incorrectly" or
+             $1.include?"This Apple ID has been locked for security reasons"
+
+            CredentialsManager::PasswordManager.shared_manager.password_seems_wrong unless Helper.is_test?
+          elsif $1.include?"Redundant Binary Upload. There already exists a binary upload with build"
+            Helper.log.fatal $1
+            Helper.log.fatal "You have to change the build number of your app to upload your ipa file"
+          end
+
+          output_done = true
+        elsif line =~ WARNING_REGEX
+          @warnings << $1
+          Helper.log.warn "[Transporter Warning Output]: #{$1}".yellow
+          output_done = true
+        end
+
+        if line =~ RETURN_VALUE_REGEX
+          if $1.to_i != 0
+            Helper.log.fatal "Transporter transfer failed.".red
+            Helper.log.warn(@warnings.join("\n").yellow)
+            Helper.log.error(@errors.join("\n").red)
+            raise "Return status of iTunes Transporter was #{$1}: #{@errors.join('\n')}".red
+          else
+            Helper.log.info "iTunes Transporter successfully finished its job".green
+          end
+        end
+
+        if not defined?@@hide_transporter_output and line =~ OUTPUT_REGEX
+          # General logging for debug purposes
+          unless output_done
+            Helper.log.debug "[Transporter]: #{$1}"
+          end
+        end
+      end
+
+      def build_download_command(username, password, apple_id, destination = "/tmp")
+        [
+          '"' + Helper.transporter_path + '"',
+          "-m lookupMetadata",
+          "-u \"#{username}\"",
+          "-p '#{escaped_password(password)}'",
+          "-apple_id #{apple_id}",
+          "-destination '#{destination}'"
+        ].join(' ')
+      end
+
+      def build_upload_command(username, password, source = "/tmp")
+        [
+          '"' + Helper.transporter_path + '"',
+          "-m upload",
+          "-u \"#{username}\"",
+          "-p '#{escaped_password(password)}'",
+          "-f '#{source}'",
+          ENV["DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS"], # that's here, because the user might overwrite the -t option
+          "-t 'Signiant'",
+          "-k 100000"
+        ].join(' ')
+      end
+
+      def escaped_password(password)
+        Shellwords.escape(password)
+      end
+
+  end
+end

data/lib/fastlane_core/update_checker.rb

@@ -1,15 +1,16 @@
-require 'open-uri'
+require 'excon'
 
 module FastlaneCore
   # Verifies, the user runs the latest version of this gem
   class UpdateChecker
-
     # This web service is fully open source: https://github.com/fastlane/refresher
     UPDATE_URL = "https://fastlane-refresher.herokuapp.com/"
 
     def self.start_looking_for_update(gem_name)
       return if Helper.is_test?
       return if ENV["FASTLANE_SKIP_UPDATE_CHECK"]
+
+      @start_time = Time.now
       
       Thread.new do
         begin
@@ -19,15 +20,32 @@ module FastlaneCore
       end
     end
 
-    def self.show_update_status(gem_name, current_version)
+    def self.server_results
+      @@results ||= {}
+    end
+
+    def self.update_available?(gem_name, current_version)
       latest = server_results[gem_name]
-      if latest and Gem::Version.new(latest) > Gem::Version.new(current_version)
-        show_update_message(gem_name, latest, current_version)
+      return (latest and Gem::Version.new(latest) > Gem::Version.new(current_version))
+    end
+
+    def self.show_update_status(gem_name, current_version)
+      t = Thread.new do
+        begin
+          finished_running(gem_name)
+        rescue
+        end
       end
+
+      if update_available?(gem_name, current_version)
+        show_update_message(gem_name, current_version)
+      end
+
+      t.join(3)
     end
 
-    def self.show_update_message(gem_name, available, current_version)
-      v = fetch_latest(gem_name)
+    def self.show_update_message(gem_name, current_version)
+      available = server_results[gem_name]
       puts ""
       puts '#######################################################################'.green
       puts "# #{gem_name} #{available} is available. You are on #{current_version}.".green
@@ -37,30 +55,19 @@ module FastlaneCore
       puts '#######################################################################'.green
     end
 
-    def self.server_results
-      @@results ||= {}
-    end
-
-    # Legacy Code:
-    # 
-    # Is a new official release available (this does not include pre-releases)
-    def self.update_available?(gem_name, current_version)
-      begin
-        latest = fetch_latest(gem_name)
-        if latest and Gem::Version.new(latest) > Gem::Version.new(current_version)
-          return true
-        end
-      rescue => ex
-        Helper.log.error("Could not check if '#{gem_name}' is up to date.")
-      end
-      return false
-    end
-
-    # Relevant code
     def self.fetch_latest(gem_name)
       url = UPDATE_URL + gem_name
       url += "?ci=1" if Helper.is_ci?
-      JSON.parse(open(url).read)["version"]
+      JSON.parse(Excon.post(url).body).fetch("version", nil)
+    end
+
+    def self.finished_running(gem_name)
+      time = (Time.now - @start_time).to_i
+
+      url = UPDATE_URL + "time/#{gem_name}"
+      url += "?time=#{time}"
+      url += "&ci=1" if Helper.is_ci?
+      output = Excon.post(url)
     end
   end
 end

data/lib/fastlane_core/version.rb

@@ -1,3 +1,3 @@
 module FastlaneCore
-  VERSION = "0.9.2"
+  VERSION = "0.10.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fastlane_core
 version: !ruby/object:Gem::Version
-  version: 0.9.2
+  version: 0.10.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-06 00:00:00.000000000 Z
+date: 2015-07-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -108,6 +108,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.45.0
+- !ruby/object:Gem::Dependency
+  name: rubyzip
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.6
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.1.6
 - !ruby/object:Gem::Dependency
   name: credentials_manager
   requirement: !ruby/object:Gem::Requirement
@@ -280,11 +294,13 @@ files:
 - lib/fastlane_core/developer_center/developer_center_helper.rb
 - lib/fastlane_core/developer_center/developer_center_login.rb
 - lib/fastlane_core/helper.rb
+- lib/fastlane_core/ipa_file_analyser.rb
 - lib/fastlane_core/itunes_connect/itunes_connect.rb
 - lib/fastlane_core/itunes_connect/itunes_connect_apple_id.rb
 - lib/fastlane_core/itunes_connect/itunes_connect_helper.rb
 - lib/fastlane_core/itunes_connect/itunes_connect_login.rb
 - lib/fastlane_core/itunes_search_api.rb
+- lib/fastlane_core/itunes_transporter.rb
 - lib/fastlane_core/languages.rb
 - lib/fastlane_core/update_checker.rb
 - lib/fastlane_core/version.rb