fastlane 2.82.0.beta.20180215010002 → 2.82.0.beta.20180216010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 935452664f9757cf2e835362cf9f9aede76db394
-  data.tar.gz: c794c55221115b462996398dcbcccf898f0a4fc1
+  metadata.gz: adcbd0fcd5fd347e6a34b599a342db0a0dc875c3
+  data.tar.gz: 7139f25facd65a9c1b381dd721700bd9b044d3a4
 SHA512:
-  metadata.gz: 1a738d9f17cd8fc989de3d6320a6122ecd95291107e34dc57aa6fc86fb5616844e22f3663c05693083f2087b8461257097a63aaafd6d172fad8485dc7670fa60
-  data.tar.gz: 48f77ca59d14eb9d6b49dadc02769db54459a3361187494f9f4d27e809c67da32b415a59d841ebb3b931f345fbc697366cb93183bb23b83ca67f21fab4eaf02e
+  metadata.gz: eacebd6e8fc0e6f99b855899155583d7b9bf648b742739986fb78843b448d5b1e9c3578b5fb176d79f08de5086aef200ac7b1917d4d2e7b591175f05ee11d812
+  data.tar.gz: a975048e6a5f957b6b9f56ecd6c7596ed0c23f2c95b9d5bb706492b8b517e21230db9b0899723e5d31d4e82740bb0b101f2efbd7c8ddc7739a2678769e240527

data/fastlane/lib/fastlane/actions/add_git_tag.rb

@@ -6,7 +6,7 @@ module Fastlane
         # lane name in lane_context could be nil because you can just call $fastlane add_git_tag which has no context
         lane_name = Actions.lane_context[Actions::SharedValues::LANE_NAME].to_s.delete(' ') # no spaces allowed
 
-        tag = options[:tag] || "#{options[:grouping]}/#{lane_name}/#{options[:prefix]}#{options[:build_number]}"
+        tag = options[:tag] || "#{options[:grouping]}/#{lane_name}/#{options[:prefix]}#{options[:build_number]}#{options[:postfix]}"
         message = options[:message] || "#{tag} (fastlane)"
 
         cmd = ['git tag']
@@ -31,6 +31,7 @@ module Fastlane
           "- `grouping` is just to keep your tags organised under one 'folder', defaults to 'builds'",
           "- `lane` is the name of the current fastlane lane",
           "- `prefix` is anything you want to stick in front of the version number, e.g. 'v'",
+          "- `postfix` is anything you want to stick at the end of the version number, e.g. '-RC1'",
           "- `build_number` is the build number, which defaults to the value emitted by the `increment_build_number` action",
           "",
           "For example for build 1234 in the 'appstore' lane it will tag the commit with `builds/appstore/1234`"
@@ -51,6 +52,10 @@ module Fastlane
                                        env_name: "FL_GIT_TAG_PREFIX",
                                        description: "Anything you want to put in front of the version number (e.g. 'v')",
                                        default_value: ''),
+          FastlaneCore::ConfigItem.new(key: :postfix,
+                                       env_name: "FL_GIT_TAG_POSTFIX",
+                                       description: "Anything you want to put at the end of the version number (e.g. '-RC1')",
+                                       default_value: ''),
           FastlaneCore::ConfigItem.new(key: :build_number,
                                        env_name: "FL_GIT_TAG_BUILD_NUMBER",
                                        description: "The build number. Defaults to the result of increment_build_number if you\'re using it",
@@ -85,6 +90,7 @@ module Fastlane
           'add_git_tag(
             grouping: "fastlane-builds",
             prefix: "v",
+            postfix: "-RC1",
             build_number: 123
           )',
           '# Alternatively, you can specify your own tag. Note that if you do specify a tag, all other arguments are ignored.

data/fastlane/lib/fastlane/actions/automatic_code_signing.rb

@@ -35,6 +35,7 @@ module Fastlane
 
           if params[:team_id]
             sett["DevelopmentTeam"] = params[:team_id]
+            build_configuration_list.set_setting("DEVELOPMENT_TEAM", params[:team_id])
             UI.important("Set Team id to: #{params[:team_id]} for target: #{found_target[:name]}")
           end
           if params[:code_sign_identity]

data/fastlane/lib/fastlane/actions/update_app_identifier.rb

@@ -23,7 +23,7 @@ module Fastlane
           configs = project.objects.select { |obj| obj.isa == 'XCBuildConfiguration' && !obj.build_settings[identifier_key].nil? }
           UI.user_error!("Info plist uses $(#{identifier_key}), but xcodeproj does not") unless configs.count > 0
 
-          configs = configs.select { |obj| obj.build_settings[info_plist_key] == params[:plist_path] }
+          configs = configs.select { |obj| resolve_path(obj.build_settings[info_plist_key], params[:xcodeproj]) == info_plist_path }
           UI.user_error!("Xcodeproj doesn't have configuration with info plist #{params[:plist_path]}.") unless configs.count > 0
 
           # For each of the build configurations, set app identifier
@@ -48,6 +48,7 @@ module Fastlane
       end
 
       def self.resolve_path(path, xcodeproj_path)
+        return nil unless path
         project_dir = File.dirname(xcodeproj_path)
         # SRCROOT, SOURCE_ROOT and PROJECT_DIR are the same
         %w{SRCROOT SOURCE_ROOT PROJECT_DIR}.each do |variable_name|

data/fastlane/lib/fastlane/plugins/plugin_manager.rb

@@ -116,9 +116,10 @@ module Fastlane
       selection_git_url = "Git URL"
       selection_path = "Local Path"
       selection_rubygems = "RubyGems.org ('#{plugin_name}' seems to not be available there)"
+      selection_gem_server = "Other Gem Server"
       selection = UI.select(
         "Seems like the plugin is not available on RubyGems, what do you want to do?",
-        [selection_git_url, selection_path, selection_rubygems]
+        [selection_git_url, selection_path, selection_rubygems, selection_gem_server]
       )
 
       if selection == selection_git_url
@@ -129,6 +130,9 @@ module Fastlane
         return ", path: '#{path}'"
       elsif selection == selection_rubygems
         return ""
+      elsif selection == selection_gem_server
+        source_url = UI.input('Please enter the gem source URL which hosts the plugin you want to use, including the protocol (e.g. https:// or git://)')
+        return ", source: '#{source_url}'"
       else
         UI.user_error!("Unknown input #{selection}")
       end

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.82.0.beta.20180215010002'.freeze
+  VERSION = '2.82.0.beta.20180216010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/spaceship/lib/spaceship/test_flight/build.rb

@@ -90,7 +90,8 @@ module Spaceship
         ready_to_submit: 'testflight.build.state.submit.ready',
         ready_to_test: 'testflight.build.state.testing.ready',
         export_compliance_missing: 'testflight.build.state.export.compliance.missing',
-        review_rejected: 'testflight.build.state.review.rejected'
+        review_rejected: 'testflight.build.state.review.rejected',
+        approved: 'testflight.build.state.review.approved'
       }
 
       # Find a Build by `build_id`.
@@ -155,6 +156,10 @@ module Spaceship
         external_state == BUILD_STATES[:review_rejected]
       end
 
+      def approved?
+        external_state == BUILD_STATES[:approved]
+      end
+
       def processed?
         active? || ready_to_submit? || export_compliance_missing? || review_rejected?
       end
@@ -201,6 +206,7 @@ module Spaceship
 
       def submit_for_testflight_review!
         return if ready_to_test?
+        return if approved?
         client.post_for_testflight_review(app_id: app_id, build_id: id, build: self)
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.82.0.beta.20180215010002
+  version: 2.82.0.beta.20180216010003
 platform: ruby
 authors:
 - Olivier Halligon
@@ -25,7 +25,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-15 00:00:00.000000000 Z
+date: 2018-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -309,7 +309,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.4.5
+        version: 4.4.6
     - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0
@@ -319,7 +319,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.4.5
+        version: 4.4.6
     - - "<"
       - !ruby/object:Gem::Version
         version: 5.0.0