fastlane 2.81.0.beta.20180212010003 → 2.81.0.beta.20180213010002

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d4cd5a8f568bbc996e0ad18bfa85810022de1cc
-  data.tar.gz: b34a2848d80f4e4a13634b315bc269278e91a116
+  metadata.gz: 4d0136deaf66f641e5a8365826952403010abaaf
+  data.tar.gz: f01438a9bf35fe931ad048a700f94db478854d37
 SHA512:
-  metadata.gz: 1a394bcdd8fd7d60c8c6db1415971aea2b97edd1d4b7e578110aac752fa327113aa0728702a574472a1d76805fe7cb4ef71aabe10417ff0351ad27122da4b862
-  data.tar.gz: 44cc248e17de7830ab61e365ba18ecd09e83eb0b3cf30cd2ec83fee49cae00e80935f2adf2d4716c4d472dfbf61f03829fa2c07e348d1e9d695b8b71b6e96a78
+  metadata.gz: 9b830c49e31d324038a04b8c152c7e6c7c3b748826dd7b6d54a16b4cb1baa86436dd216e365a05cd957b25900fee8ff4d664993f0d6fb62850265e55a2bcd421
+  data.tar.gz: 6c786ef59adae93eca22b89a5ef4b0b8980839cc8a752d00685e8d0f459c9eed8bd8796415c91fb5b98691b5d04bf6f4e126d211569df6718e39863d9b8455b6

data/fastlane/lib/fastlane/actions/download_dsyms.rb

@@ -53,18 +53,24 @@ module Fastlane
 
         # Loop through all app versions and download their dSYM
         app.all_build_train_numbers(platform: platform).each do |train_number|
+          UI.verbose("Found train: #{train_number}, comparing to supplied version: #{version}")
           if version && version != train_number
+            UI.verbose("Version #{version} doesn't match: #{train_number}")
             next
           end
           app.all_builds_for_train(train: train_number, platform: platform).each do |build|
+            UI.verbose("Found build version: #{build.build_version}, comparing to supplied build_number: #{build_number}")
             if build_number && build.build_version != build_number
+              UI.verbose("build_version: #{build.build_version} doesn't match: #{build_number}")
               next
             end
 
             begin
               # need to call reload here or dsym_url is nil
+              UI.verbose("Build_version: #{build.build_version} matches #{build_number}, grabbing dsym_url")
               build.reload
               download_url = build.dsym_url
+              UI.verbose("dsym_url: #{download_url}")
             rescue Spaceship::TunesClient::ITunesConnectError => ex
               UI.error("Error accessing dSYM file for build\n\n#{build}\n\nException: #{ex}")
             end

data/fastlane/lib/fastlane/lane.rb

@@ -47,8 +47,10 @@ module Fastlane
         end
 
         if self.gray_list.include?(name.to_sym)
+          UI.error("------------------------------------------------")
           UI.error("Lane name '#{name}' should not be used because it is the name of a fastlane tool")
           UI.error("It is recommended to not use '#{name}' as the name of your lane")
+          UI.error("------------------------------------------------")
           # We still allow it, because we're nice
           # Otherwise we might break existing setups
           return
@@ -86,7 +88,9 @@ module Fastlane
       def ensure_name_not_conflicts(name)
         # First, check if there is a predefined method in the actions folder
         return unless Actions.action_class_ref(name)
-        UI.important("Name of the lane '#{name}' is already taken by the action named '#{name}'")
+        UI.error("------------------------------------------------")
+        UI.error("Name of the lane '#{name}' is already taken by the action named '#{name}'")
+        UI.error("------------------------------------------------")
       end
     end
   end

data/fastlane/lib/fastlane/runner.rb

@@ -142,6 +142,15 @@ module Fastlane
       # It's important to *not* have this code inside the rescue block
       # otherwise all NameErrors will be caught and the error message is
       # confusing
+      begin
+        return self.try_switch_to_lane(method_sym, arguments)
+      rescue LaneNotAvailableError
+        # We don't actually handle this here yet
+        # We just try to use a user configured lane first
+        # and only if there is none, we're gonna check for the
+        # built-in actions
+      end
+
       if class_ref
         if class_ref.respond_to?(:run)
           # Action is available, now execute it
@@ -149,26 +158,20 @@ module Fastlane
         else
           UI.user_error!("Action '#{method_sym}' of class '#{class_name}' was found, but has no `run` method.")
         end
+      end
+
+      # No lane, no action, let's at least show the correct error message
+      if Fastlane.plugin_manager.plugin_is_added_as_dependency?(PluginManager.plugin_prefix + method_sym.to_s)
+        # That's a plugin, but for some reason we can't find it
+        UI.user_error!("Plugin '#{method_sym}' was not properly loaded, make sure to follow the plugin docs for troubleshooting: #{PluginManager::TROUBLESHOOTING_URL}")
+      elsif Fastlane::Actions.formerly_bundled_actions.include?(method_sym.to_s)
+        # This was a formerly bundled action which is now a plugin.
+        UI.verbose(caller.join("\n"))
+        UI.user_error!("The action '#{method_sym}' is no longer bundled with fastlane. You can install it using `fastlane add_plugin #{method_sym}`")
       else
-        # Action was not found
-        # Is there a lane under this name?
-        begin
-          return self.try_switch_to_lane(method_sym, arguments)
-        rescue LaneNotAvailableError
-          # No lane, no action, let's at least show the correct error message
-          if Fastlane.plugin_manager.plugin_is_added_as_dependency?(PluginManager.plugin_prefix + method_sym.to_s)
-            # That's a plugin, but for some reason we can't find it
-            UI.user_error!("Plugin '#{method_sym}' was not properly loaded, make sure to follow the plugin docs for troubleshooting: #{PluginManager::TROUBLESHOOTING_URL}")
-          elsif Fastlane::Actions.formerly_bundled_actions.include?(method_sym.to_s)
-            # This was a formerly bundled action which is now a plugin.
-            UI.verbose(caller.join("\n"))
-            UI.user_error!("The action '#{method_sym}' is no longer bundled with fastlane. You can install it using `fastlane add_plugin #{method_sym}`")
-          else
-            # So there is no plugin under that name, so just show the error message generated by the lane switch
-            UI.verbose(caller.join("\n"))
-            UI.user_error!("Could not find action, lane or variable '#{method_sym}'. Check out the documentation for more details: https://docs.fastlane.tools/actions")
-          end
-        end
+        # So there is no plugin under that name, so just show the error message generated by the lane switch
+        UI.verbose(caller.join("\n"))
+        UI.user_error!("Could not find action, lane or variable '#{method_sym}'. Check out the documentation for more details: https://docs.fastlane.tools/actions")
       end
     end
 
@@ -227,6 +230,7 @@ module Fastlane
         Dir.chdir(custom_dir) do # go up from the fastlane folder, to the project folder
           # If another action is calling this action, we shouldn't show it in the summary
           # (see https://github.com/fastlane/fastlane/issues/4546)
+
           action_name = from_action ? nil : class_ref.step_text
           Actions.execute_action(action_name) do
             # arguments is an array by default, containing an hash with the actual parameters
@@ -248,7 +252,6 @@ module Fastlane
               puts(class_ref.deprecated_notes.to_s.deprecated) if class_ref.deprecated_notes
               puts("==========================================\n".deprecated)
             end
-
             class_ref.runner = self # needed to call another action form an action
             return_value = class_ref.run(arguments)
 

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.81.0.beta.20180212010003'.freeze
+  VERSION = '2.81.0.beta.20180213010002'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/screengrab/lib/screengrab/page.html.erb

@@ -64,117 +64,99 @@
       }
     </style>
   </head>
-  <body>
-    <% divide_size_by = 5.0 %>
-    <% max_width = 180 %>
-    <% image_counter = 0 %>
+  <body><% image_counter = 0 %><% @data.each do |language, content| %>
+    <h1 class="language"><%= language %></h1>
+    <hr>
+    <table><% content.each do |device_name, screens| %>
+      <tr>
+        <th colspan="<%= screens.count %>">
+          <span class="deviceName"><%= device_name %></span>
+        </th>
+      </tr>
+      <tr><% screens.each do |screen_path| %><% next if screen_path.include?"_framed.png" %>
+        <td><% image_counter += 1 %>
+          <a href="<%= screen_path %>" target="_blank" class="screenshotLink">
+            <img class="screenshot" src="<%= screen_path %>" style="width: 100%;" alt="<%= language %> <%= device_name %>" data-counter="<%= image_counter %>">
+          </a>
+        </td><% end %>
+      </tr><% end %>
+    </table><% end %>
+    <div id="overlay">
+      <img id="imageDisplay" src="" alt="" />
+      <div id="imageInfo"></div>
+    </div>
+    <script type="text/javascript">
+      var overlay        = document.getElementById('overlay');
+      var imageDisplay   = document.getElementById('imageDisplay');
+      var imageInfo      = document.getElementById('imageInfo');
+      var screenshotLink = document.getElementsByClassName('screenshotLink');
 
-
-    <% @data.each do |language, content| %>
-      <h1 class="language"><%= language %></h1>
-      <hr>
-      <table>
-        <% content.each do |device_name, screens| %>
-          <tr>
-            <th colspan="<%= screens.count %>">
-              <span class="deviceName"><%= device_name %></span>
-            </th>
-          </tr>
-          <tr>
-            <% screens.each do |screen_path| %>
-              <% next if screen_path.include?"_framed.png" %>
-              <td>
-                <% style = "width: 100%;" %>
-                <% image_counter += 1 %>
-                <a href="<%= screen_path %>" target="_blank" class="screenshotLink">
-                  <img class="screenshot"
-                         src="<%= screen_path %>"
-                       style="<%= style %>"
-                         alt="<%= language %> <%= device_name %>"
-                data-counter="<%= image_counter %>" />
-                </a>
-              </td>
-            <% end %>
-          </tr>
-        <% end %>
-      </table>
-    <% end %>
-      <div id="overlay">
-        <img id="imageDisplay" src="" alt="" />
-        <div id="imageInfo"></div>
-      </div>
-      <script type="text/javascript">
-        var overlay        = document.getElementById('overlay');
-        var imageDisplay   = document.getElementById('imageDisplay');
-        var imageInfo      = document.getElementById('imageInfo');
-        var screenshotLink = document.getElementsByClassName('screenshotLink');
-
-        function doClick(el) {
-          if (document.createEvent) {
-            var evObj = document.createEvent('MouseEvents', true);
-            evObj.initMouseEvent("click", false, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
-            el.dispatchEvent(evObj);
-          } else if (document.createEventObject) { //IE
-            var evObj = document.createEventObject();
-            el.fireEvent('onclick', evObj);
-          }
+      function doClick(el) {
+        if (document.createEvent) {
+          var evObj = document.createEvent('MouseEvents', true);
+          evObj.initMouseEvent("click", false, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
+          el.dispatchEvent(evObj);
+        } else if (document.createEventObject) { //IE
+          var evObj = document.createEventObject();
+          el.fireEvent('onclick', evObj);
         }
+      }
 
-        for (index = 0; index < screenshotLink.length; ++index) {
-          screenshotLink[index].addEventListener('click', function(e) {
-            e.preventDefault();
+      for (index = 0; index < screenshotLink.length; ++index) {
+        screenshotLink[index].addEventListener('click', function(e) {
+          e.preventDefault();
 
-            var img = e.target;
-            if (e.target.tagName == 'A') {
-              img = e.target.children[0];
-            }
+          var img = e.target;
+          if (e.target.tagName == 'A') {
+            img = e.target.children[0];
+          }
 
-            // beautify
-            var tmpImg = new Image();
-            tmpImg.src = img.src;
-            imageDisplay.style.height     = 'auto';
-            imageDisplay.style.width     = 'auto';
-            if (window.innerHeight < tmpImg.height) {
-              imageDisplay.style.height = document.documentElement.clientHeight+'px';
-            } else if (window.innerWidth < tmpImg.width) {
-              imageDisplay.style.width = document.documentElement.clientWidth;+'px';
-            } else {
-              imageDisplay.style.paddingTop = parseInt((window.innerHeight - tmpImg.height) / 2)+'px';
-            }
+          // beautify
+          var tmpImg = new Image();
+          tmpImg.src = img.src;
+          imageDisplay.style.height     = 'auto';
+          imageDisplay.style.width     = 'auto';
+          if (window.innerHeight < tmpImg.height) {
+            imageDisplay.style.height = document.documentElement.clientHeight+'px';
+          } else if (window.innerWidth < tmpImg.width) {
+            imageDisplay.style.width = document.documentElement.clientWidth;+'px';
+          } else {
+            imageDisplay.style.paddingTop = parseInt((window.innerHeight - tmpImg.height) / 2)+'px';
+          }
 
-            imageDisplay.src             = img.src;
-            imageDisplay.alt             = img.alt;
-            imageDisplay.dataset.counter = img.dataset.counter;
+          imageDisplay.src             = img.src;
+          imageDisplay.alt             = img.alt;
+          imageDisplay.dataset.counter = img.dataset.counter;
 
-            imageInfo.innerHTML          = '<h3>'+img.alt+'</h3>';
-            imageInfo.innerHTML         += img.src.split("/").pop();
-            imageInfo.innerHTML         += '<br />'+tmpImg.height+'&times;'+tmpImg.width+'px';
+          imageInfo.innerHTML          = '<h3>'+img.alt+'</h3>';
+          imageInfo.innerHTML         += decodeURI(img.src.split("/").pop());
+          imageInfo.innerHTML         += '<br />'+tmpImg.height+'&times;'+tmpImg.width+'px';
 
-            overlay.style.display        = "block";
-          });
-        }
+          overlay.style.display        = "block";
+        });
+      }
 
-        imageDisplay.addEventListener('click', function(e) {
-          e.stopPropagation(); // !
+      imageDisplay.addEventListener('click', function(e) {
+        e.stopPropagation(); // !
 
-          overlay.style.display = "none";
+        overlay.style.display = "none";
 
-          img_counter = parseInt(e.target.dataset.counter) + 1;
+        img_counter = parseInt(e.target.dataset.counter) + 1;
+        try {
+          link = document.body.querySelector('img[data-counter="'+img_counter+'"]').parentNode;
+        } catch (e) {
           try {
-            link = document.body.querySelector('img[data-counter="'+img_counter+'"]').parentNode;
+            link = document.body.querySelector('img[data-counter="0"]').parentNode;
           } catch (e) {
-            try {
-              link = document.body.querySelector('img[data-counter="0"]').parentNode;
-            } catch (e) {
-              return false;
-            }
+            return false;
           }
-          doClick(link);
-        });
+        }
+        doClick(link);
+      });
 
-        overlay.addEventListener('click', function(e) {
-          overlay.style.display = "none";
-        })
+      overlay.addEventListener('click', function(e) {
+        overlay.style.display = "none";
+      })
 
       function keyPressed(e) {
         e = e || window.event;
@@ -203,6 +185,6 @@
          }
       };
       document.body.addEventListener('keydown', keyPressed);
-      </script>
+    </script>
   </body>
 </html>

data/snapshot/lib/snapshot/page.html.erb

@@ -64,118 +64,100 @@
       }
     </style>
   </head>
-  <body>
-    <% divide_size_by = 5.0 %>
-    <% max_width = 180 %>
-    <% image_counter = 0 %>
+  <body><% image_counter = 0 %><% @data.each do |language, content| %>
+    <h1 class="language"><%= language %></h1>
+    <hr>
+    <table><% content.each do |device_name, screens| %>
+      <tr>
+        <th colspan="<%= screens.count %>">
+          <span class="deviceName"><%= device_name %></span>
+        </th>
+      </tr>
+      <tr><% screens.each do |screen_path| %><% next if screen_path.include?"_framed.png" %>
+        <td><% image_counter += 1 %>
+          <a href="<%= screen_path %>" target="_blank" class="screenshotLink">
+            <img class="screenshot" src="<%= screen_path %>" style="width: 100%;" alt="<%= language %> <%= device_name %>" data-counter="<%= image_counter %>">
+          </a>
+        </td><% end %>
+      </tr><% end %>
+    </table><% end %>
+    <div id="overlay">
+      <img id="imageDisplay" src="" alt="" />
+      <div id="imageInfo"></div>
+    </div>
+    <script type="text/javascript">
+      var overlay        = document.getElementById('overlay');
+      var imageDisplay   = document.getElementById('imageDisplay');
+      var imageInfo      = document.getElementById('imageInfo');
+      var screenshotLink = document.getElementsByClassName('screenshotLink');
 
+      function doClick(el) {
+        if (document.createEvent) {
+          var evObj = document.createEvent('MouseEvents', true);
+          evObj.initMouseEvent("click", false, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
+          el.dispatchEvent(evObj);
+        } else if (document.createEventObject) { //IE
+          var evObj = document.createEventObject();
+          el.fireEvent('onclick', evObj);
+        }
+      }
 
-    <% @data.each do |language, content| %>
-      <h1 class="language"><%= language %></h1>
-      <hr>
-      <table>
-        <% content.each do |device_name, screens| %>
-          <tr>
-            <th colspan="<%= screens.count %>">
-              <span class="deviceName"><%= device_name %></span>
-            </th>
-          </tr>
-          <tr>
-            <% screens.each do |screen_path| %>
-              <% next if screen_path.include?"_framed.png" %>
-              <td>
-                <% style = "width: 100%;" %>
-                <% image_counter += 1 %>
-                <a href="<%= screen_path %>" target="_blank" class="screenshotLink">
-                  <img class="screenshot"
-                         src="<%= screen_path %>"
-                       style="<%= style %>"
-                         alt="<%= language %> <%= device_name %>"
-                data-counter="<%= image_counter %>" />
-                </a>
-              </td>
-            <% end %>
-          </tr>
-        <% end %>
-      </table>
-    <% end %>
-      <div id="overlay">
-        <img id="imageDisplay" src="" alt="" />
-        <div id="imageInfo"></div>
-      </div>
-      <script type="text/javascript">
-        var overlay        = document.getElementById('overlay');
-        var imageDisplay   = document.getElementById('imageDisplay');
-        var imageInfo      = document.getElementById('imageInfo');
-        var screenshotLink = document.getElementsByClassName('screenshotLink');
+      for (index = 0; index < screenshotLink.length; ++index) {
+        screenshotLink[index].addEventListener('click', function(e) {
+          e.preventDefault();
 
-        function doClick(el) {
-          if (document.createEvent) {
-            var evObj = document.createEvent('MouseEvents', true);
-            evObj.initMouseEvent("click", false, true, window, 0, 0, 0, 0, 0, false, false, false, false, 0, null);
-            el.dispatchEvent(evObj);
-          } else if (document.createEventObject) { //IE
-            var evObj = document.createEventObject();
-            el.fireEvent('onclick', evObj);
+          var img = e.target;
+          if (e.target.tagName == 'A') {
+            img = e.target.children[0];
           }
-        }
 
-        for (index = 0; index < screenshotLink.length; ++index) {
-          screenshotLink[index].addEventListener('click', function(e) {
-            e.preventDefault();
-            
-            var img = e.target;
-            if (e.target.tagName == 'A') {
-              img = e.target.children[0];
-            }
-            
-            // beautify
-            var tmpImg = new Image();
-            tmpImg.src = img.src;
-            imageDisplay.style.height     = 'auto';
-            imageDisplay.style.width     = 'auto';
-            if (window.innerHeight < tmpImg.height) {
-              imageDisplay.style.height = document.documentElement.clientHeight+'px';
-            } else if (window.innerWidth < tmpImg.width) {
-              imageDisplay.style.width = document.documentElement.clientWidth;+'px';
-            } else {
-              imageDisplay.style.paddingTop = parseInt((window.innerHeight - tmpImg.height) / 2)+'px';
-            }
+          // beautify
+          var tmpImg = new Image();
+          tmpImg.src = img.src;
+          imageDisplay.style.height     = 'auto';
+          imageDisplay.style.width     = 'auto';
+          if (window.innerHeight < tmpImg.height) {
+            imageDisplay.style.height = document.documentElement.clientHeight+'px';
+          } else if (window.innerWidth < tmpImg.width) {
+            imageDisplay.style.width = document.documentElement.clientWidth;+'px';
+          } else {
+            imageDisplay.style.paddingTop = parseInt((window.innerHeight - tmpImg.height) / 2)+'px';
+          }
 
-            imageDisplay.src             = img.src;
-            imageDisplay.alt             = img.alt;
-            imageDisplay.dataset.counter = img.dataset.counter;
-            
-            imageInfo.innerHTML          = '<h3>'+img.alt+'</h3>';
-            imageInfo.innerHTML         += decodeURI(img.src.split("/").pop());
-            imageInfo.innerHTML         += '<br />'+tmpImg.height+'&times;'+tmpImg.width+'px';
-                    
-            overlay.style.display        = "block";
-          });
-        }
-        
-        imageDisplay.addEventListener('click', function(e) {
-          e.stopPropagation(); // !
-          
-          overlay.style.display = "none";
-          
-          img_counter = parseInt(e.target.dataset.counter) + 1;
+          imageDisplay.src             = img.src;
+          imageDisplay.alt             = img.alt;
+          imageDisplay.dataset.counter = img.dataset.counter;
+
+          imageInfo.innerHTML          = '<h3>'+img.alt+'</h3>';
+          imageInfo.innerHTML         += decodeURI(img.src.split("/").pop());
+          imageInfo.innerHTML         += '<br />'+tmpImg.height+'&times;'+tmpImg.width+'px';
+
+          overlay.style.display        = "block";
+        });
+      }
+
+      imageDisplay.addEventListener('click', function(e) {
+        e.stopPropagation(); // !
+
+        overlay.style.display = "none";
+
+        img_counter = parseInt(e.target.dataset.counter) + 1;
+        try {
+          link = document.body.querySelector('img[data-counter="'+img_counter+'"]').parentNode;
+        } catch (e) {
           try {
-            link = document.body.querySelector('img[data-counter="'+img_counter+'"]').parentNode;
+            link = document.body.querySelector('img[data-counter="0"]').parentNode;
           } catch (e) {
-            try {
-              link = document.body.querySelector('img[data-counter="0"]').parentNode;
-            } catch (e) {
-              return false;
-            }
+            return false;
           }
-          doClick(link);
-        });
+        }
+        doClick(link);
+      });
+
+      overlay.addEventListener('click', function(e) {
+        overlay.style.display = "none";
+      })
 
-        overlay.addEventListener('click', function(e) {
-          overlay.style.display = "none";
-        })
-        
       function keyPressed(e) {
         e = e || window.event;
         var charCode = e.keyCode || e.which;
@@ -203,6 +185,6 @@
          }
       };
       document.body.addEventListener('keydown', keyPressed);
-      </script>
+    </script>
   </body>
 </html>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.81.0.beta.20180212010003
+  version: 2.81.0.beta.20180213010002
 platform: ruby
 authors:
 - Fumiya Nakamura
@@ -25,7 +25,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-12 00:00:00.000000000 Z
+date: 2018-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier