fastlane 2.75.1 → 2.76.0.beta.20180110010004

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f338936293c5d07951e36822d6fc311be2e6983c
-  data.tar.gz: ae280a88555a7c50902397aadb6d98048bcb06bb
+  metadata.gz: 30c22daaa7ac36879e3d6f5b17809a0944c7b73a
+  data.tar.gz: 0db4bcebf71912f485ab5f7c56c3fa364200e203
 SHA512:
-  metadata.gz: 5a7b8bcb682bc77acbf1e7c556eebf53e62bf24e9ee14f5711446c87903deeee0b5d28f754dc5872a570f4f2bbe95974d854956bb21b97dc4a890d3c692b08f5
-  data.tar.gz: 4e8af52bb4bf45f3dfffb9835e0cb42f3d58d46e5040516a40347e07be61476c0730dfd46b9528bcde5cdca95d5f73570d7ed6d23ac31c8d1e60365e1613112e
+  metadata.gz: e53f8c9828ff0128baa84f200f40e331ea1dcd6f08838da30243883ee4c2ebb741cc79a22f6695ed86e5ffbeb33e7ee20e5c61b6e8ce085d1fabc9e0c386525a
+  data.tar.gz: 5fef039c28cb018ff3cd6f975092751cade7bb4cd201fc2b8f33aed1144c069db0dfdf0f5bc12430f6e01257f48b6001d2965f01ff43124b0c6234c4af2916d5

data/fastlane/lib/fastlane/actions/appium.rb

@@ -37,9 +37,7 @@ module Fastlane
 
       def self.invoke_appium_server(params)
         appium = detect_appium(params)
-        fork do
-          Process.exec("#{appium} -a #{params[:host]} -p #{params[:port]}")
-        end
+        Process.spawn("#{appium} -a #{params[:host]} -p #{params[:port]}")
       end
 
       def self.detect_appium(params)

data/fastlane/lib/fastlane/actions/docs/{scan.md → run_tests.md}

@@ -111,7 +111,9 @@ scan(
 
 For a list of all available parameters use
 
-    fastlane action scan
+```no-highlight
+fastlane action scan
+```
 
 To access the raw `xcodebuild` output open `~/Library/Logs/scan`
 

data/fastlane/lib/fastlane/documentation/markdown_docs_generator.rb

@@ -43,11 +43,24 @@ module Fastlane
       @_launches ||= JSON.parse(File.read(File.join(Fastlane::ROOT, "assets/action_ranking.json"))) # root because we're in a temporary directory here
     end
 
+    def custom_action_docs_path
+      "lib/fastlane/actions/docs/"
+    end
+
+    def load_custom_action_md(action)
+      # check if there is a custom detail view in markdown available in the fastlane code base
+      custom_file_location = File.join(Fastlane::ROOT, custom_action_docs_path, "#{action.action_name}.md")
+      if File.exist?(custom_file_location)
+        UI.verbose("Using custom md file for action #{action.action_name}")
+        return File.read(custom_file_location)
+      end
+      return nil
+    end
+
     def generate!(target_path: nil)
       require 'yaml'
       FileUtils.mkdir_p(target_path)
       docs_dir = File.join(target_path, "docs")
-      custom_action_docs = "lib/fastlane/actions/docs/"
 
       # Generate actions.md
       template = File.join(Fastlane::ROOT, "lib/assets/Actions.md.erb")
@@ -58,12 +71,15 @@ module Fastlane
       all_actions_ref_yml = []
       FileUtils.mkdir_p(File.join(docs_dir, "actions"))
       ActionsList.all_actions do |action|
-        # check if there is a custom detail view in markdown available in the fastlane code base
-        custom_file_location = File.join(Fastlane::ROOT, custom_action_docs, "#{action.action_name}.md")
-        @custom_content = nil # important, as we're in a loop and using @ variables
-        if File.exist?(custom_file_location)
-          UI.verbose("Using custom md file for action #{action.action_name}")
-          @custom_content = File.read(custom_file_location)
+        # Make sure to always assign `@custom_content`, as we're in a loop and `@` is needed for the `erb`
+        @custom_content = load_custom_action_md(action)
+
+        if action.superclass != Fastlane::Action
+          # This means, the current method is an alias
+          # meaning we're gonna look if the parent class
+          # as a custom md file.
+          # e.g. `deliver.rb` super class is `upload_to_app_store.rb`
+          @custom_content ||= load_custom_action_md(action.superclass)
         end
 
         template = File.join(Fastlane::ROOT, "lib/assets/ActionDetails.md.erb")
@@ -85,7 +101,7 @@ module Fastlane
       File.write(mkdocs_yml_path, mkdocs_yml.to_yaml)
 
       # Copy over the assets from the `actions/docs/assets` directory
-      Dir[File.join(custom_action_docs, "assets", "*")].each do |current_asset_path|
+      Dir[File.join(custom_action_docs_path, "assets", "*")].each do |current_asset_path|
         UI.message("Copying asset #{current_asset_path}")
         FileUtils.cp(current_asset_path, File.join(docs_dir, "img", "actions", File.basename(current_asset_path)))
       end

data/fastlane/lib/fastlane/fastlane_require.rb

@@ -39,21 +39,22 @@ module Fastlane
       end
 
       def gem_installed?(name, req = Gem::Requirement.default)
-        # We fork and try to load a gem with that name in the child process so we
-        # don't actually load anything we don't want to load
-        # This is just to test if the gem is already preinstalled, e.g. YAML
+        installed = Gem::Specification.any? { |s| s.name == name and req =~ s.version }
+        return true if installed
+
+        # In special cases a gem is already preinstalled, e.g. YAML.
+        # To find out we try to load a gem with that name in a child process
+        # (so we don't actually load anything we don't want to load)
         # See https://github.com/fastlane/fastlane/issues/6951
-        fork do
+        require_tester = <<-RB.gsub(/^ */, '')
           begin
-            require name
+            require ARGV.first
           rescue LoadError
             exit(1)
           end
-        end
-        _, status = Process.wait2
-        return true if status.exitstatus == 0
-
-        Gem::Specification.any? { |s| s.name == name and req =~ s.version }
+        RB
+        system(RbConfig.ruby, "-e", require_tester.lines.map(&:chomp).join("; "), name)
+        return $?.success?
       end
 
       def find_gem_name(user_supplied_name)

data/fastlane/lib/fastlane/plugins/template/.rubocop.yml

@@ -1,301 +1,170 @@
-require: 
-  - rubocop/require_tools
-
+---
 Style/MultipleComparison:
   Enabled: false
-
 Style/PercentLiteralDelimiters:
   Enabled: false
-
-# kind_of? is a good way to check a type
 Style/ClassCheck:
   EnforcedStyle: kind_of?
-
 Style/FrozenStringLiteralComment:
   Enabled: false
-
-# This doesn't work with older versions of Ruby (pre 2.4.0)
 Style/SafeNavigation:
   Enabled: false
-
-# This doesn't work with older versions of Ruby (pre 2.4.0)
 Performance/RegexpMatch:
   Enabled: false
-
-# This suggests use of `tr` instead of `gsub`. While this might be more performant,
-# these methods are not at all interchangable, and behave very differently. This can
-# lead to people making the substitution without considering the differences.
 Performance/StringReplacement:
   Enabled: false
-
-# .length == 0 is also good, we don't always want .zero?
 Style/NumericPredicate:
   Enabled: false
-
-# this would cause errors with long lanes
 Metrics/BlockLength:
   Enabled: false
-
-# this is a bit buggy
 Metrics/ModuleLength:
   Enabled: false
-
-# certificate_1 is an okay variable name
 Style/VariableNumber:
   Enabled: false
-
-# This is used a lot across the fastlane code base for config files
 Style/MethodMissing:
   Enabled: false
-
-# This rule isn't useful, lots of discussion happening around it also
-# e.g. https://github.com/bbatsov/rubocop/issues/2338
 MultilineBlockChain:
   Enabled: false
-
-#
-#   File.chmod(0777, f)
-#
-# is easier to read than
-#
-#   File.chmod(0o777, f)
-#
 Style/NumericLiteralPrefix:
   Enabled: false
-
-#
-# command = (!clean_expired.nil? || !clean_pattern.nil?) ? CLEANUP : LIST
-#
-# is easier to read than
-#
-# command = !clean_expired.nil? || !clean_pattern.nil? ? CLEANUP : LIST
-#
 Style/TernaryParentheses:
   Enabled: false
-
-# sometimes it is useful to have those empty methods
 Style/EmptyMethod:
   Enabled: false
-
-# It's better to be more explicit about the type
 Style/BracesAroundHashParameters:
   Enabled: false
-
-# specs sometimes have useless assignments, which is fine
 Lint/UselessAssignment:
   Exclude:
-    - '**/spec/**/*'
-
-# In specs requires are done automatically
+  - "**/spec/**/*"
 Require/MissingRequireStatement:
   Exclude:
-    - '**/spec/**/*.rb'
-    - '**/spec_helper.rb'
-    - 'spaceship/lib/spaceship/babosa_fix.rb'
-    - '**/Fastfile'
-    - '**/*.gemspec'
-    - 'rakelib/**/*'
-    - '**/*.rake'
-    - '**/Rakefile'
-    - 'fastlane/**/*' # TODO: remove
-    - 'supply/**/*' # TODO: remove
-
-# We could potentially enable the 2 below:
+  - "**/spec/**/*.rb"
+  - "**/spec_helper.rb"
+  - spaceship/lib/spaceship/babosa_fix.rb
+  - "**/Fastfile"
+  - "**/*.gemspec"
+  - rakelib/**/*
+  - "**/*.rake"
+  - "**/Rakefile"
+  - fastlane/**/*
+  - supply/**/*
 Layout/IndentHash:
   Enabled: false
-
 Layout/AlignHash:
   Enabled: false
-
-# HoundCI doesn't like this rule
 Layout/DotPosition:
   Enabled: false
-
-# We allow !! as it's an easy way to convert ot boolean
 Style/DoubleNegation:
   Enabled: false
-
-# Prevent to replace [] into %i
 Style/SymbolArray:
   Enabled: false
-
-# We still support Ruby 2.0.0
 Layout/IndentHeredoc:
   Enabled: false
-
-# This cop would not work fine with rspec
 Style/MixinGrouping:
   Exclude:
-    - '**/spec/**/*'
-
-# Sometimes we allow a rescue block that doesn't contain code
+  - "**/spec/**/*"
 Lint/HandleExceptions:
   Enabled: false
-
-# Cop supports --auto-correct.
 Lint/UnusedBlockArgument:
   Enabled: false
-
 Lint/AmbiguousBlockAssociation:
   Enabled: false
-
-# Needed for $verbose
 Style/GlobalVars:
   Enabled: false
-
-# We want to allow class Fastlane::Class
 Style/ClassAndModuleChildren:
   Enabled: false
-
-# $? Exit
 Style/SpecialGlobalVars:
   Enabled: false
-
 Metrics/AbcSize:
   Enabled: false
-
 Metrics/MethodLength:
   Enabled: false
-
 Metrics/CyclomaticComplexity:
   Enabled: false
-
-# The %w might be confusing for new users
 Style/WordArray:
   MinSize: 19
-
-# raise and fail are both okay
 Style/SignalException:
   Enabled: false
-
-# Better too much 'return' than one missing
 Style/RedundantReturn:
   Enabled: false
-
-# Having if in the same line might not always be good
 Style/IfUnlessModifier:
   Enabled: false
-
-# and and or is okay
 Style/AndOr:
   Enabled: false
-
-# Configuration parameters: CountComments.
 Metrics/ClassLength:
   Max: 320
-
-
-# Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 370
-
-# Configuration parameters: CountKeywordArgs.
 Metrics/ParameterLists:
   Max: 17
-
 Metrics/PerceivedComplexity:
   Max: 18
-
-# Sometimes it's easier to read without guards
 Style/GuardClause:
   Enabled: false
-
-# We allow both " and '
 Style/StringLiterals:
   Enabled: false
-
-# something = if something_else
-# that's confusing
 Style/ConditionalAssignment:
   Enabled: false
-
-# Better to have too much self than missing a self
 Style/RedundantSelf:
   Enabled: false
-
-# e.g.
-# def self.is_supported?(platform)
-# we may never use `platform`
 Lint/UnusedMethodArgument:
   Enabled: false
-
-# the let(:key) { ... }
 Lint/ParenthesesAsGroupedExpression:
   Exclude:
-    - '**/spec/**/*'
-
-# This would reject is_ in front of methods
-# We use `is_supported?` everywhere already
+  - "**/spec/**/*"
 Style/PredicateName:
   Enabled: false
-
-# We allow the $
 Style/PerlBackrefs:
   Enabled: false
-
-# Disable '+ should be surrounded with a single space' for xcodebuild_spec.rb
 Layout/SpaceAroundOperators:
   Exclude:
-    - '**/spec/actions_specs/xcodebuild_spec.rb'
-
+  - "**/spec/actions_specs/xcodebuild_spec.rb"
 AllCops:
   TargetRubyVersion: 2.0
   Include:
-    - '**/fastlane/Fastfile'
+  - "**/fastlane/Fastfile"
   Exclude:
-    - '**/lib/assets/custom_action_template.rb'
-    - './vendor/**/*'
-
-# They have not to be snake_case
+  - "**/lib/assets/custom_action_template.rb"
+  - "./vendor/**/*"
 Style/FileName:
   Exclude:
-    - '**/Dangerfile'
-    - '**/Brewfile'
-    - '**/Gemfile'
-    - '**/Podfile'
-    - '**/Rakefile'
-    - '**/Fastfile'
-    - '**/Deliverfile'
-    - '**/Snapfile'
-    - '**/*.gemspec'
-
-# We're not there yet
+  - "**/Dangerfile"
+  - "**/Brewfile"
+  - "**/Gemfile"
+  - "**/Podfile"
+  - "**/Rakefile"
+  - "**/Fastfile"
+  - "**/Deliverfile"
+  - "**/Snapfile"
+  - "**/*.gemspec"
 Style/Documentation:
   Enabled: false
-
-# Added after upgrade to 0.38.0
 Style/MutableConstant:
   Enabled: false
-
-# length > 0 is good
 Style/ZeroLengthPredicate:
   Enabled: false
-
-# Adds complexity
 Style/IfInsideElse:
   Enabled: false
-
-# Sometimes we just want to 'collect'
 Style/CollectionMethods:
   Enabled: false
-
-# ( ) for method calls
+CrossPlatform/ForkUsage:
+  Exclude:
+  - "**/plugins/template/**/*"
 Style/MethodCallWithArgsParentheses:
   Enabled: true
   IgnoredMethods:
-    - 'require'
-    - 'require_relative'
-    - 'gem'
-    - 'program'
-    - 'command'
-    - 'raise'
-    - 'attr_accessor'
-    - 'attr_reader'
-    - 'lane'
-    # rspec tests code below
-    - 'to'
-    - 'describe'
-    - 'it'
-    - 'context'
-    - 'before'
-    - 'after'
+  - require
+  - require_relative
+  - gem
+  - program
+  - command
+  - raise
+  - attr_accessor
+  - attr_reader
+  - lane
+  - to
+  - describe
+  - it
+  - context
+  - before
+  - after

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.75.1'.freeze
+  VERSION = '2.76.0.beta.20180110010004'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/fastlane_core/lib/fastlane_core/analytics/analytics_ingester_client.rb

@@ -6,7 +6,7 @@ module FastlaneCore
   class AnalyticsIngesterClient
     def post_events(events)
       unless Helper.test?
-        fork do
+        Thread.new do
           send_request(json: { analytics: events }.to_json)
         end
       end

data/fastlane_core/lib/fastlane_core/helper.rb

@@ -278,21 +278,27 @@ module FastlaneCore
       end
     end
 
+    def self.should_show_loading_indicator?
+      return false if FastlaneCore::Env.truthy?("FASTLANE_DISABLE_ANIMATION")
+      return false if Helper.ci?
+      return true
+    end
+
     # Show/Hide loading indicator
     def self.show_loading_indicator(text = nil)
-      if FastlaneCore::Env.truthy?("FASTLANE_DISABLE_ANIMATION")
-        UI.message(text) if text
-      else
+      if self.should_show_loading_indicator?
         # we set the default here, instead of at the parameters
         # as we don't want to `UI.message` a rocket that's just there for the loading indicator
         text ||= "🚀"
         @require_fastlane_spinner = TTY::Spinner.new("[:spinner] #{text} ", format: :dots)
         @require_fastlane_spinner.auto_spin
+      else
+        UI.message(text) if text
       end
     end
 
     def self.hide_loading_indicator
-      if !FastlaneCore::Env.truthy?("FASTLANE_DISABLE_ANIMATION") && @require_fastlane_spinner
+      if self.should_show_loading_indicator? && @require_fastlane_spinner
         @require_fastlane_spinner.success
       end
     end

data/fastlane_core/lib/fastlane_core/tool_collector.rb

@@ -70,7 +70,7 @@ module FastlaneCore
 
       # Never generate web requests during tests
       unless Helper.test?
-        fork do
+        Thread.new do
           begin
             Excon.post(url,
                        body: analytic_event_body,

data/fastlane_core/lib/fastlane_core/update_checker/update_checker.rb

@@ -46,7 +46,7 @@ module FastlaneCore
     end
 
     def self.show_update_status(gem_name, current_version)
-      fork do
+      Thread.new do
         begin
           send_completion_events_for(gem_name)
         rescue

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.75.1
+  version: 2.76.0.beta.20180110010004
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-09 00:00:00.000000000 Z
+date: 2018-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier
@@ -871,8 +871,6 @@ files:
 - deliver/lib/deliver/upload_price_tier.rb
 - deliver/lib/deliver/upload_screenshots.rb
 - fastlane/README.md
-- fastlane/lib/.DS_Store
-- fastlane/lib/assets/.DS_Store
 - fastlane/lib/assets/ActionDetails.md.erb
 - fastlane/lib/assets/Actions.md.erb
 - fastlane/lib/assets/AppfileTemplate
@@ -891,10 +889,8 @@ files:
 - fastlane/lib/assets/s3_plist_template.erb
 - fastlane/lib/assets/s3_version_template.erb
 - fastlane/lib/fastlane.rb
-- fastlane/lib/fastlane/.DS_Store
 - fastlane/lib/fastlane/action.rb
 - fastlane/lib/fastlane/action_collector.rb
-- fastlane/lib/fastlane/actions/.DS_Store
 - fastlane/lib/fastlane/actions/README.md
 - fastlane/lib/fastlane/actions/actions_helper.rb
 - fastlane/lib/fastlane/actions/adb.rb
@@ -947,21 +943,20 @@ files:
 - fastlane/lib/fastlane/actions/deliver.rb
 - fastlane/lib/fastlane/actions/deploygate.rb
 - fastlane/lib/fastlane/actions/device_grid/README.md
-- fastlane/lib/fastlane/actions/docs/.DS_Store
-- fastlane/lib/fastlane/actions/docs/cert.md
-- fastlane/lib/fastlane/actions/docs/deliver.md
-- fastlane/lib/fastlane/actions/docs/frameit.md
-- fastlane/lib/fastlane/actions/docs/gym.md
-- fastlane/lib/fastlane/actions/docs/match.md
-- fastlane/lib/fastlane/actions/docs/pem.md
-- fastlane/lib/fastlane/actions/docs/pilot.md
-- fastlane/lib/fastlane/actions/docs/precheck.md
-- fastlane/lib/fastlane/actions/docs/produce.md
-- fastlane/lib/fastlane/actions/docs/scan.md
-- fastlane/lib/fastlane/actions/docs/screengrab.md
-- fastlane/lib/fastlane/actions/docs/sigh.md
-- fastlane/lib/fastlane/actions/docs/snapshot.md
-- fastlane/lib/fastlane/actions/docs/supply.md
+- fastlane/lib/fastlane/actions/docs/build_ios_app.md
+- fastlane/lib/fastlane/actions/docs/capture_android_screenshots.md
+- fastlane/lib/fastlane/actions/docs/capture_ios_screenshots.md
+- fastlane/lib/fastlane/actions/docs/check_app_store_metadata.md
+- fastlane/lib/fastlane/actions/docs/create_app_online.md
+- fastlane/lib/fastlane/actions/docs/frame_screenshots.md
+- fastlane/lib/fastlane/actions/docs/get_certificates.md
+- fastlane/lib/fastlane/actions/docs/get_provisioning_profile.md
+- fastlane/lib/fastlane/actions/docs/get_push_certificate.md
+- fastlane/lib/fastlane/actions/docs/run_tests.md
+- fastlane/lib/fastlane/actions/docs/sync_code_signing.md
+- fastlane/lib/fastlane/actions/docs/upload_to_app_store.md
+- fastlane/lib/fastlane/actions/docs/upload_to_play_store.md
+- fastlane/lib/fastlane/actions/docs/upload_to_testflight.md
 - fastlane/lib/fastlane/actions/dotgpg_environment.rb
 - fastlane/lib/fastlane/actions/download.rb
 - fastlane/lib/fastlane/actions/download_dsyms.rb
@@ -1187,7 +1182,6 @@ files:
 - fastlane/lib/fastlane/server/json_return_value_processor.rb
 - fastlane/lib/fastlane/server/socket_server.rb
 - fastlane/lib/fastlane/server/socket_server_action_command_executor.rb
-- fastlane/lib/fastlane/setup/.DS_Store
 - fastlane/lib/fastlane/setup/crashlytics_beta.rb
 - fastlane/lib/fastlane/setup/crashlytics_beta_command_line_handler.rb
 - fastlane/lib/fastlane/setup/crashlytics_beta_info.rb
@@ -1237,10 +1231,8 @@ files:
 - fastlane/swift/SocketResponse.swift
 - fastlane/swift/main.swift
 - fastlane_core/README.md
-- fastlane_core/lib/.DS_Store
 - fastlane_core/lib/assets/XMLTemplate.xml.erb
 - fastlane_core/lib/fastlane_core.rb
-- fastlane_core/lib/fastlane_core/.DS_Store
 - fastlane_core/lib/fastlane_core/analytics/action_completion_context.rb
 - fastlane_core/lib/fastlane_core/analytics/action_launch_context.rb
 - fastlane_core/lib/fastlane_core/analytics/analytics_event_builder.rb
@@ -1606,24 +1598,24 @@ metadata:
 post_install_message: 
 rdoc_options: []
 require_paths:
-- cert/lib
-- credentials_manager/lib
-- deliver/lib
-- fastlane/lib
-- fastlane_core/lib
-- frameit/lib
-- gym/lib
+- supply/lib
+- screengrab/lib
 - match/lib
-- pem/lib
-- pilot/lib
 - precheck/lib
+- sigh/lib
 - produce/lib
 - scan/lib
-- screengrab/lib
-- sigh/lib
+- gym/lib
 - snapshot/lib
+- frameit/lib
+- fastlane/lib
+- cert/lib
+- pilot/lib
 - spaceship/lib
-- supply/lib
+- credentials_manager/lib
+- deliver/lib
+- fastlane_core/lib
+- pem/lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -1631,12 +1623,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: The easiest way to automate beta deployments and releases for your iOS and