fastlane 2.69.0.beta.20171205010003 → 2.69.0.beta.20171206010003

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b03e2f9c11fdcde5531d97cf0083fe1b01aab953
-  data.tar.gz: 948146daac281de6b6f315e1d4b81e0a7ecadd6e
+  metadata.gz: ea5a73fe4ecd48f828a975d2de5c8fa5d3c0d430
+  data.tar.gz: aefbffc7401c80cf217105f54e3fb54d595170fd
 SHA512:
-  metadata.gz: 3322e536ea10336b9c7d8809ca94d9597a2003093a17b62d494d6161fae6f3847f9355cd767da0eba32f04d58061482bb006387b0d15c1d7d4461ac19975db67
-  data.tar.gz: 8766855b6161e939bb1e06c6d1d9b3676b71e30c61cf6840a719e6e076443ed32a01a4eb632424e94f96db210af9b6e6f047746399179269da9e3f99cecbac49
+  metadata.gz: 29812f72c4d3108681fa774f5f6555784cbcfe445d5a7ee116f862192f6a197e6b6b0354f64971961a013cc298addde10dc2ef641d6140cac16ffa7b215c28bf
+  data.tar.gz: a1ebc40e736d82160e77bb7210d9c2bc3b4ad78f590e0b18e19efaad3a1f3699288b408463cc8952c4b44c62f840ae88823a2e8277d3d5718030fe71d3fecd77

data/fastlane/lib/fastlane/setup/crashlytics_beta.rb

@@ -61,7 +61,7 @@ module Fastlane
   lane :beta do |values|
     # Fabric generated this lane for deployment to Crashlytics Beta
     # set 'export_method' to 'ad-hoc' if your Crashlytics Beta distribution uses ad-hoc provisioning
-    gym(scheme: '#{@beta_info.schemes.first}', export_method: '#{@beta_info.export_method}')
+    build_app(scheme: '#{@beta_info.schemes.first}', export_method: '#{@beta_info.export_method}')
 
     emails = values[:test_email] ? values[:test_email] : #{beta_info_emails} # You can list more emails here
     groups = values[:test_email] ? nil : #{beta_info_groups} # You can define groups on the web and reference them here

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.69.0.beta.20171205010003'.freeze
+  VERSION = '2.69.0.beta.20171206010003'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/spaceship/lib/spaceship/client.rb

@@ -417,11 +417,32 @@ module Spaceship
     # This method is used for both the Apple Dev Portal and iTunes Connect
     # This will also handle 2 step verification
     def send_shared_login_request(user, password)
-      # First we see if we have a stored cookie for 2 step enabled accounts
-      # this is needed as it stores the information on if this computer is a
-      # trusted one. In general I think spaceship clients should be trusted
-      load_session_from_file
+      # Check if we have a cached/valid session here
+      # Fixes
+      #   - https://github.com/fastlane/fastlane/issues/10812
+      #   - https://github.com/fastlane/fastlane/issues/10793
+      #
+      # Before 4th December 2017 we didn't load existing session from the disk
+      # but changed it, because Apple introduced a rate limit, which is fine by itself
+      # but unfortunately it also rate limits successful logins, meaning if you call multiple
+      # tools in a lane (e.g. call match 5 times), this would mean it locks you out of the account
+      # for a while.
+      # By loading existing sessions and checking if they're valid, we're sending less login requests
+      # More context on why this change was necessary https://github.com/fastlane/fastlane/pull/11108
+      #
+      if load_session_from_file
+        # Check if the session is still valid here
+        begin
+          # We use the olympus session to determine if the old session is still valid
+          # As this will raise an exception if the old session has expired
+          # If the old session is still valid, we don't have to do anything else in this method
+          return true if fetch_olympus_session.count > 0
+        rescue
+        end
+      end
+
       # If this is a CI, the user can pass the session via environment variable
+      # This is used for 2FA related sessions
       load_session_from_env
 
       data = {

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -109,7 +109,11 @@ module Spaceship
 
     def send_login_request(user, password)
       clear_user_cached_data
-      send_shared_login_request(user, password)
+      result = send_shared_login_request(user, password)
+
+      store_cookie
+
+      return result
     end
 
     # Sometimes we get errors or info nested in our data

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.69.0.beta.20171205010003
+  version: 2.69.0.beta.20171206010003
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-05 00:00:00.000000000 Z
+date: 2017-12-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier