fastlane 2.68.1 → 2.68.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 572a013cd15bc30801de30f0fe654ac9f04199f4
-  data.tar.gz: ffcc2c9e252d116243010af5c523fb400af9be76
+  metadata.gz: 8964dde63cba5a4b1698b0bac40dbe8f18c2213e
+  data.tar.gz: 623c111554aa9940a85c76fd4216fc91c9786283
 SHA512:
-  metadata.gz: e40d6207de613550a4b4a76aefa92e26ff877c631be4ee464f84692a0ed23a8a6bd85640d2119615004a04bf77a1da654260375e9a14d8d1a612f379c888c49b
-  data.tar.gz: f95e163db65895bf33dd5f01cc5dbc7727f69cc3fd7b1996222c233852f3785a038ef491ec87618bdb48078e4816721b29acdb4e4cde2b2cd614dd9e736aa7fe
+  metadata.gz: 65d60acb15635c58d2a1b630cada88efa1cf17c4e90060f628ac394037af364be08417aa28d65f0decb2f75f9715db934cc57fc85b7294799b267a0e16b742d0
+  data.tar.gz: f397c43b76d932a8e1d2143cae0f6f24a1cb881d0a46c440235ab7003c2a1d143b741357b0f02587a0274372aa485a5c058a661a8958319dfd8b886bbcaeef50

data/fastlane/lib/fastlane/actions/appium.rb

@@ -195,7 +195,7 @@ module Fastlane
               versionNumber: "9.1",
               deviceName:    "iPhone 6"
             },
-            appium_lib {
+            appium_lib: {
               wait: 10
             }
           )'

data/fastlane/lib/fastlane/setup/crashlytics_beta.rb

@@ -61,7 +61,7 @@ module Fastlane
   lane :beta do |values|
     # Fabric generated this lane for deployment to Crashlytics Beta
     # set 'export_method' to 'ad-hoc' if your Crashlytics Beta distribution uses ad-hoc provisioning
-    gym(scheme: '#{@beta_info.schemes.first}', export_method: '#{@beta_info.export_method}')
+    build_app(scheme: '#{@beta_info.schemes.first}', export_method: '#{@beta_info.export_method}')
 
     emails = values[:test_email] ? values[:test_email] : #{beta_info_emails} # You can list more emails here
     groups = values[:test_email] ? nil : #{beta_info_groups} # You can define groups on the web and reference them here

data/fastlane/lib/fastlane/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
-  VERSION = '2.68.1'.freeze
+  VERSION = '2.68.2'.freeze
   DESCRIPTION = "The easiest way to automate beta deployments and releases for your iOS and Android apps".freeze
   MINIMUM_XCODE_RELEASE = "7.0".freeze
   RUBOCOP_REQUIREMENT = '0.49.1'.freeze

data/gym/lib/gym/generators/package_command_generator_xcode7.rb

@@ -135,7 +135,10 @@ module Gym
             hash = normalize_export_options(Gym.config[:export_options])
           else
             # Reads options from file
-            hash = Plist.parse_xml(Gym.config[:export_options])
+            plist_file_path = Gym.config[:export_options]
+            UI.user_error!("Couldn't find plist file at path #{File.expand_path(plist_file_path)}") unless File.exist?(plist_file_path)
+            hash = Plist.parse_xml(plist_file_path)
+            UI.user_error!("Couldn't read provided plist at path #{File.expand_path(plist_file_path)}") if hash.nil?
             # Convert keys to symbols
             hash = keys_to_symbols(hash)
           end

data/spaceship/lib/spaceship/base.rb

@@ -191,8 +191,8 @@ module Spaceship
       #   Certificate.factory(attrs)
       #   #=> #<PushCertificate ... >
       #
-      def factory(attrs)
-        self.new(attrs)
+      def factory(attrs, existing_client = nil)
+        self.new(attrs, existing_client)
       end
     end
 
@@ -210,12 +210,12 @@ module Spaceship
     # attributes that are defined by `attr_mapping`
     #
     # Do not override `initialize` in your own models.
-    def initialize(attrs = {})
+    def initialize(attrs = {}, existing_client = nil)
       attrs.each do |key, val|
         self.send("#{key}=", val) if respond_to?("#{key}=")
       end
       self.raw_data = DataHash.new(attrs)
-      @client = self.class.client
+      @client = existing_client || self.class.client
       self.setup
     end
 

data/spaceship/lib/spaceship/client.rb

@@ -417,11 +417,32 @@ module Spaceship
     # This method is used for both the Apple Dev Portal and iTunes Connect
     # This will also handle 2 step verification
     def send_shared_login_request(user, password)
-      # First we see if we have a stored cookie for 2 step enabled accounts
-      # this is needed as it stores the information on if this computer is a
-      # trusted one. In general I think spaceship clients should be trusted
-      load_session_from_file
+      # Check if we have a cached/valid session here
+      # Fixes
+      #   - https://github.com/fastlane/fastlane/issues/10812
+      #   - https://github.com/fastlane/fastlane/issues/10793
+      #
+      # Before 4th December 2017 we didn't load existing session from the disk
+      # but changed it, because Apple introduced a rate limit, which is fine by itself
+      # but unfortunately it also rate limits successful logins, meaning if you call multiple
+      # tools in a lane (e.g. call match 5 times), this would mean it locks you out of the account
+      # for a while.
+      # By loading existing sessions and checking if they're valid, we're sending less login requests
+      # More context on why this change was necessary https://github.com/fastlane/fastlane/pull/11108
+      #
+      if load_session_from_file
+        # Check if the session is still valid here
+        begin
+          # We use the olympus session to determine if the old session is still valid
+          # As this will raise an exception if the old session has expired
+          # If the old session is still valid, we don't have to do anything else in this method
+          return true if fetch_olympus_session.count > 0
+        rescue
+        end
+      end
+
       # If this is a CI, the user can pass the session via environment variable
+      # This is used for 2FA related sessions
       load_session_from_env
 
       data = {

data/spaceship/lib/spaceship/tunes/tunes_client.rb

@@ -109,7 +109,11 @@ module Spaceship
 
     def send_login_request(user, password)
       clear_user_cached_data
-      send_shared_login_request(user, password)
+      result = send_shared_login_request(user, password)
+
+      store_cookie
+
+      return result
     end
 
     # Sometimes we get errors or info nested in our data
@@ -753,7 +757,7 @@ module Spaceship
     # so we cache it
     # @return [UserDetail] the response
     def user_detail_data
-      @_cached_user_detail_data ||= Spaceship::Tunes::UserDetail.factory(user_details_data)
+      @_cached_user_detail_data ||= Spaceship::Tunes::UserDetail.factory(user_details_data, self)
     end
 
     #####################################################

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fastlane
 version: !ruby/object:Gem::Version
-  version: 2.68.1
+  version: 2.68.2
 platform: ruby
 authors:
 - Felix Krause
@@ -15,7 +15,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-04 00:00:00.000000000 Z
+date: 2017-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: slack-notifier